Page overview: fix order by column mismatch

This commit is contained in:
Christian Guenter 2019-10-09 18:42:31 +00:00 committed by Lars Hvam
parent ef0d149fa3
commit 8bf4b5df4c

View File

@ -42,7 +42,8 @@ CLASS zcl_abapgit_gui_view_repo DEFINITION
mv_order_by TYPE string, mv_order_by TYPE string,
mv_order_descending TYPE abap_bool, mv_order_descending TYPE abap_bool,
mv_diff_first TYPE abap_bool, mv_diff_first TYPE abap_bool,
mv_key TYPE zif_abapgit_persistence=>ty_value. mv_key TYPE zif_abapgit_persistence=>ty_value,
mv_are_changes_recorded_in_tr TYPE abap_bool.
METHODS: METHODS:
render_head_line render_head_line
@ -168,8 +169,7 @@ CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION.
iv_act = |{ zif_abapgit_definitions=>c_action-repo_remote_attach }?{ mv_key }| ). iv_act = |{ zif_abapgit_definitions=>c_action-repo_remote_attach }?{ mv_key }| ).
ENDIF. ENDIF.
lv_package = mo_repo->get_package( ). IF mv_are_changes_recorded_in_tr = abap_true.
IF zcl_abapgit_factory=>get_sap_package( lv_package )->are_changes_recorded_in_tr_req( ) = abap_true.
ro_advanced_dropdown->add( ro_advanced_dropdown->add(
iv_txt = 'Add all objects to transport request' iv_txt = 'Add all objects to transport request'
iv_act = |{ zif_abapgit_definitions=>c_action-repo_add_all_obj_to_trans_req }?{ mv_key }| ). iv_act = |{ zif_abapgit_definitions=>c_action-repo_add_all_obj_to_trans_req }?{ mv_key }| ).
@ -423,7 +423,8 @@ CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION.
METHOD constructor. METHOD constructor.
DATA lo_settings TYPE REF TO zcl_abapgit_settings. DATA: lo_settings TYPE REF TO zcl_abapgit_settings,
lv_package TYPE devclass.
super->constructor( ). super->constructor( ).
@ -440,6 +441,11 @@ CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION.
mv_max_lines = lo_settings->get_max_lines( ). mv_max_lines = lo_settings->get_max_lines( ).
mv_max_setting = mv_max_lines. mv_max_setting = mv_max_lines.
lv_package = mo_repo->get_package( ).
mv_are_changes_recorded_in_tr = zcl_abapgit_factory=>get_sap_package( lv_package
)->are_changes_recorded_in_tr_req( ).
ENDMETHOD. ENDMETHOD.
@ -943,6 +949,9 @@ CLASS zcl_abapgit_gui_view_repo IMPLEMENTATION.
" technical name display name css class add timezone title " technical name display name css class add timezone title
_add_col '' '' '' '' ''. _add_col '' '' '' '' ''.
IF mv_are_changes_recorded_in_tr = abap_true.
_add_col '' '' '' '' ''.
ENDIF.
_add_col 'OBJ_TYPE' 'Type' '' '' ''. _add_col 'OBJ_TYPE' 'Type' '' '' ''.
_add_col 'OBJ_NAME' 'Name' '' '' ''. _add_col 'OBJ_NAME' 'Name' '' '' ''.
_add_col 'PATH' 'Path' '' '' ''. _add_col 'PATH' 'Path' '' '' ''.