Merge branch 'main' into HTTP

src/cts/zif_abapgit_default_transport.intf.xml

@@ -5,7 +5,7 @@
    <VSEOINTERF>
     <CLSNAME>ZIF_ABAPGIT_DEFAULT_TRANSPORT</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>ZIF_ABAPGIT_DEFAULT_TRANSPORT</DESCRIPT>
+    <DESCRIPT>abapGit - Default Transport</DESCRIPT>
     <EXPOSURE>2</EXPOSURE>
     <STATE>1</STATE>
     <UNICODE>X</UNICODE>

src/env/zcl_abapgit_environment.clas.abap

@@ -233,7 +233,7 @@ CLASS zcl_abapgit_environment IMPLEMENTATION.
         currently_no_resources_avail   = 4
         no_pbt_resources_found         = 5
         cant_init_different_pbt_groups = 6
-        OTHERS                         = 7.
+        OTHERS                         = 7 ##FM_SUBRC_OK.
     " If SPBT_INITIALIZE fails, check transactions RZ12, SM50, SM21, SARFC
 
   ENDMETHOD.

src/exits/zif_abapgit_exit.intf.abap

@@ -7,7 +7,7 @@ INTERFACE zif_abapgit_exit PUBLIC.
       clone_url TYPE string,
     END OF ty_ci_repo.
   TYPES:
-    ty_ci_repos TYPE TABLE OF ty_ci_repo.
+    ty_ci_repos TYPE STANDARD TABLE OF ty_ci_repo WITH DEFAULT KEY.
   TYPES:
     ty_object_types TYPE STANDARD TABLE OF tadir-object WITH DEFAULT KEY.
   TYPES:

src/inspect/zcl_abapgit_where_used_tools.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>ZCL_ABAPGIT_WHERE_USED_TOOLS</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>abapGit where used utilities</DESCRIPT>
+    <DESCRIPT>abapGit - Where-used Utilities</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/objects/aff/zcl_abapgit_json_handler.clas.abap

@@ -18,7 +18,7 @@ CLASS zcl_abapgit_json_handler DEFINITION
         mappings TYPE ty_json_abap_mappings,
       END OF ty_enum_mapping .
     TYPES:
-      ty_enum_mappings TYPE TABLE OF ty_enum_mapping WITH DEFAULT KEY .
+      ty_enum_mappings TYPE STANDARD TABLE OF ty_enum_mapping WITH DEFAULT KEY .
     TYPES:
       BEGIN OF ty_path_value_pair,
         path  TYPE string,

src/objects/core/zcl_abapgit_dependencies.clas.abap

@@ -61,7 +61,7 @@ CLASS zcl_abapgit_dependencies IMPLEMENTATION.
     INSERT ls_ddls_name INTO TABLE lt_ddls_name.
 
     PERFORM ('DDLS_GET_DEP') IN PROGRAM ('RADMASDL')
-                             TABLES lt_ddls_name rt_dependency.
+                             TABLES lt_ddls_name rt_dependency ##PERF_NO_FORM.
 
   ENDMETHOD.
 

src/objects/core/zcl_abapgit_file_deserialize.clas.abap

@@ -214,6 +214,9 @@ CLASS zcl_abapgit_file_deserialize IMPLEMENTATION.
           DELETE lt_requires WHERE obj_type <> 'IASP'
             AND obj_type <> 'PROG'
             AND obj_type <> 'IARP'.
+        WHEN 'IDOC' OR 'IEXT'.
+          lt_requires = lt_items.
+          DELETE lt_requires WHERE obj_type <> 'TABL'.
         WHEN 'DCLS'.
           lt_requires = lt_items.
           DELETE lt_requires WHERE obj_type <> 'DDLS'.

src/objects/core/zcl_abapgit_objects_activation.clas.abap

@@ -310,7 +310,7 @@ CLASS zcl_abapgit_objects_activation IMPLEMENTATION.
               excecution_error       = 1
               cancelled              = 2
               insert_into_corr_error = 3
-              OTHERS                 = 4 ##SUBRC_OK.
+              OTHERS                 = 4 ##FM_SUBRC_OK.
         CATCH cx_sy_dyn_call_param_not_found.
           CALL FUNCTION 'RS_WORKING_OBJECTS_ACTIVATE'
             EXPORTING
@@ -324,7 +324,7 @@ CLASS zcl_abapgit_objects_activation IMPLEMENTATION.
               excecution_error       = 1
               cancelled              = 2
               insert_into_corr_error = 3
-              OTHERS                 = 4 ##SUBRC_OK.
+              OTHERS                 = 4 ##FM_SUBRC_OK.
       ENDTRY.
       CASE sy-subrc.
         WHEN 1 OR 3 OR 4.
@@ -398,9 +398,18 @@ CLASS zcl_abapgit_objects_activation IMPLEMENTATION.
           WHERE type = <ls_message>-show_req->object_type.
       ENDIF.
       LOOP AT <ls_message>-mtext ASSIGNING <lv_msg>.
+        IF sy-tabix = 1.
+          ii_log->add(
+            iv_type   = 'E'
+            iv_msg    = <lv_msg>
+            iv_class  = <ls_message>-message-msgid
+            iv_number = <ls_message>-message-msgno
+            is_item   = ls_item ).
+        ELSE.
           ii_log->add_error(
             iv_msg  = <lv_msg>
             is_item = ls_item ).
+        ENDIF.
       ENDLOOP.
     ENDLOOP.
 
@@ -440,7 +449,9 @@ CLASS zcl_abapgit_objects_activation IMPLEMENTATION.
 
     LOOP AT lt_lines ASSIGNING <ls_line>.
       ii_log->add( iv_msg    = <ls_line>-line
-                   iv_type = <ls_line>-severity ).
+                   iv_type   = <ls_line>-severity
+                   iv_class  = <ls_line>-class
+                   iv_number = |{ <ls_line>-number }| ).
     ENDLOOP.
 
     ii_log->add_info( |View complete activation log in program RSPUTPRT (type D, log name { iv_logname })| ).

src/objects/core/zcl_abapgit_serialize.clas.abap

@@ -432,7 +432,7 @@ CLASS zcl_abapgit_serialize IMPLEMENTATION.
   METHOD filter_unsupported_objects.
 
     DATA: ls_unsupported_count TYPE ty_unsupported_count,
-          lt_supported_types   TYPE zcl_abapgit_objects=>ty_types_tt,
+          lt_supported_types   TYPE zif_abapgit_objects=>ty_types_tt,
           lt_unsupported_count TYPE ty_unsupported_count_tt.
 
     FIELD-SYMBOLS: <ls_tadir>             LIKE LINE OF ct_tadir,

src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap

@@ -66,7 +66,7 @@ CLASS zcl_abapgit_ecatt_helper IMPLEMENTATION.
         lv_text = lx_ecatt->get_text( ).
         zcx_abapgit_exception=>raise( lv_text ).
         " note, exception cx_ecatt_ui_attachment doesn't exist in 702
-      CATCH cx_ecatt.
+      CATCH cx_ecatt ##NO_HANDLER.
         "will never be raised from download, when called with mv_generate_xml_no_download = 'X'.
     ENDTRY.
 

src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap

@@ -25,7 +25,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION.
+CLASS zcl_abapgit_ecatt_sp_download IMPLEMENTATION.
 
 
   METHOD download.
@@ -93,7 +93,7 @@ CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION.
         CALL METHOD lo_ecatt_sp->('GET_SP_ATTRIBUTES')
           IMPORTING
             e_sp_xml = lv_sp_xml.
-      CATCH cx_ecatt_apl.
+      CATCH cx_ecatt_apl ##NO_HANDLER.
     ENDTRY.
 
     CALL FUNCTION 'SDIXML_XML_TO_DOM'

src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap

@@ -27,7 +27,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION.
+CLASS zcl_abapgit_ecatt_sp_upload IMPLEMENTATION.
 
 
   METHOD get_ecatt_sp.
@@ -129,7 +129,6 @@ CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION.
     ENDTRY.
 
     ASSIGN ecatt_object TO <lg_ecatt_sp>.
-    ASSERT sy-subrc = 0.
 
     lo_ecatt_sp = <lg_ecatt_sp>.
 
@@ -162,13 +161,12 @@ CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION.
       CATCH cx_ecatt_apl INTO lx_ecatt.
         lv_exc_occ = 'X'.
     ENDTRY.
-* Devesh,C5129871  18.07.2011  Releasing enqueue after uploading
+    " Releasing enqueue after uploading
-*begin
     TRY.
         ecatt_object->close_object( im_suppress_events = 'X' ).
-      CATCH cx_ecatt_apl INTO lx_ecatt.
+      CATCH cx_ecatt_apl INTO lx_ecatt ##NO_HANDLER.
     ENDTRY.
-*end
+
 *     get devclass from existing object
     TRY.
         cl_apl_ecatt_object=>get_tadir_entry(

src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap

@@ -62,7 +62,7 @@ CLASS zcl_abapgit_object_enho_clif IMPLEMENTATION.
       TRY.
           io_clif->add_change_enha_type( type_line = ls_type_line ).
         CATCH cx_enh_mod_not_allowed
-        cx_enh_is_not_enhanceable.
+        cx_enh_is_not_enhanceable ##NO_HANDLER.
           " TODO
       ENDTRY.
     ENDLOOP.

src/objects/jump/zcl_abapgit_gui_jumper.clas.abap

@@ -253,7 +253,8 @@ CLASS zcl_abapgit_gui_jumper IMPLEMENTATION.
       EXCEPTIONS
         communication_failure = 1 MESSAGE lv_msg
         system_failure        = 2 MESSAGE lv_msg
-        OTHERS                = 3.
+        resource_failure      = 3
+        OTHERS                = 4.
 
     lv_subrc = sy-subrc.
 

src/objects/oo/zcl_abapgit_oo_class.clas.abap

@@ -611,7 +611,7 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION.
             component_error = 4
             no_access       = 5
             other           = 6
-            OTHERS          = 7.
+            OTHERS          = 7 ##FM_SUBRC_OK.
       CATCH cx_sy_dyn_call_param_not_found.
         CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'
           EXPORTING
@@ -628,7 +628,7 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION.
             component_error = 4
             no_access       = 5
             other           = 6
-            OTHERS          = 7.
+            OTHERS          = 7 ##FM_SUBRC_OK.
     ENDTRY.
     IF sy-subrc <> 0.
       zcx_abapgit_exception=>raise_t100( ).
@@ -998,5 +998,4 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION.
       zcx_abapgit_exception=>raise( |Class { ls_clskey-clsname } has syntax errors | ).
     ENDIF.
   ENDMETHOD.
-
 ENDCLASS.

src/objects/oo/zcl_abapgit_oo_interface.clas.abap

@@ -212,7 +212,7 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION.
             component_error = 4
             no_access       = 5
             other           = 6
-            OTHERS          = 7.
+            OTHERS          = 7 ##FM_SUBRC_OK.
       CATCH cx_sy_dyn_call_param_not_found.
         CALL FUNCTION 'SEO_INTERFACE_CREATE_COMPLETE'
           EXPORTING
@@ -229,7 +229,7 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION.
             component_error = 4
             no_access       = 5
             other           = 6
-            OTHERS          = 7.
+            OTHERS          = 7 ##FM_SUBRC_OK.
     ENDTRY.
     IF sy-subrc <> 0.
       zcx_abapgit_exception=>raise_t100( ).
@@ -368,5 +368,4 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION.
       zcx_abapgit_exception=>raise( |Interface { ls_intkey-clsname } has syntax errors | ).
     ENDIF.
   ENDMETHOD.
-
 ENDCLASS.

src/objects/oo/zcl_abapgit_oo_serializer.clas.abap

@@ -151,7 +151,7 @@ CLASS zcl_abapgit_oo_serializer IMPLEMENTATION.
     lv_program = ls_include.
     TRY.
         lt_source = zcl_abapgit_factory=>get_sap_report( )->read_report( lv_program ).
-      CATCH zcx_abapgit_exception.
+      CATCH zcx_abapgit_exception ##NO_HANDLER.
 * ignore if the report is not found, sometimes the CCDEF include does not exist
     ENDTRY.
     rt_source = lt_source.

src/objects/sap/zcl_abapgit_sap_report.clas.abap

@@ -47,7 +47,7 @@ CLASS zcl_abapgit_sap_report IMPLEMENTATION.
               no_show_permission             = 7
               permission_failure             = 8
               request_language_denied        = 9
-              OTHERS                         = 10.
+              OTHERS                         = 10 ##FM_SUBRC_OK.
         CATCH cx_sy_dyn_call_param_not_found.
           CALL FUNCTION 'RS_ACCESS_PERMISSION'
             EXPORTING
@@ -67,7 +67,7 @@ CLASS zcl_abapgit_sap_report IMPLEMENTATION.
               no_show_permission       = 7
               permission_failure       = 8
               request_language_denied  = 9
-              OTHERS                   = 10.
+              OTHERS                   = 10 ##FM_SUBRC_OK.
       ENDTRY.
       IF sy-subrc <> 0.
         zcx_abapgit_exception=>raise_t100( ).

src/objects/tabl/zcl_abapgit_object_tabl_ddl.clas.abap

@@ -103,7 +103,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_OBJECT_TABL_DDL IMPLEMENTATION.
+CLASS zcl_abapgit_object_tabl_ddl IMPLEMENTATION.
 
 
   METHOD deserialize.
@@ -158,9 +158,9 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL_DDL IMPLEMENTATION.
                  start     TYPE i VALUE 0,
                  colon     TYPE i VALUE 1,
                  type      TYPE i VALUE 2,
-                 aftertype TYPE i VALUE 2,
+                 aftertype TYPE i VALUE 3,
-                 null      TYPE i VALUE 2,
+                 null      TYPE i VALUE 4,
-                 afternull TYPE i VALUE 2,
+                 afternull TYPE i VALUE 5,
                END OF lc_mode.
 
     DATA lv_field  TYPE string.

src/objects/texts/zcl_abapgit_longtexts.clas.abap

@@ -64,6 +64,10 @@ CLASS zcl_abapgit_longtexts IMPLEMENTATION.
 
     FIELD-SYMBOLS: <ls_dokil> LIKE LINE OF lt_dokil.
 
+    IF iv_object_name CA '#'.
+      zcx_abapgit_exception=>raise( |Invalid name for longtext: { iv_longtext_id } { iv_object_name }| ).
+    ENDIF.
+
     lv_object = escape_name(
       iv_longtext_id = iv_longtext_id
       iv_object_name = iv_object_name ).
@@ -77,7 +81,6 @@ CLASS zcl_abapgit_longtexts IMPLEMENTATION.
       ENDIF.
 
     ELSEIF iv_longtext_id IS NOT INITIAL.
-      IF lv_object NA '#'.
       IF iv_main_lang_only = abap_true.
         SELECT * FROM dokil
                  INTO TABLE lt_dokil
@@ -92,7 +95,6 @@ CLASS zcl_abapgit_longtexts IMPLEMENTATION.
                  AND object LIKE lv_object ESCAPE '#'
                  ORDER BY PRIMARY KEY.
       ENDIF.
-      ENDIF.
     ELSE.
 
       zcx_abapgit_exception=>raise( |serialize_longtexts parameter error| ).

src/objects/zcl_abapgit_object_doma.clas.abap

@@ -43,7 +43,7 @@ CLASS zcl_abapgit_object_doma DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
 
     METHODS handle_dependencies
       IMPORTING
-        !iv_step TYPE zif_abapgit_definitions=>ty_deserialization_step
+        !iv_step TYPE zif_abapgit_objects=>ty_deserialization_step
       CHANGING
         !cv_exit TYPE dd01v-convexit
         !cv_done TYPE abap_bool.

src/objects/zcl_abapgit_object_fugs.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>ZCL_ABAPGIT_OBJECT_FUGS</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>abapGit - FUGS</DESCRIPT>
+    <DESCRIPT>abapGit - FUGS - Function Group (SAP)</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/objects/zcl_abapgit_object_idoc.clas.abap

@@ -163,6 +163,9 @@ CLASS zcl_abapgit_object_idoc IMPLEMENTATION.
     MOVE-CORRESPONDING ls_idoc-attributes TO ls_attributes.
 
     IF zif_abapgit_object~exists( ) = abap_false.
+      " Avoid popup asking for package
+      tadir_insert( iv_package ).
+
       CALL FUNCTION 'IDOCTYPE_CREATE'
         EXPORTING
           pi_idoctyp       = mv_idoctyp

src/objects/zcl_abapgit_object_iext.clas.abap

@@ -97,6 +97,9 @@ CLASS zcl_abapgit_object_iext IMPLEMENTATION.
         EXCEPTIONS
           OTHERS        = 1.
     ELSE.
+      " Avoid popup asking for package
+      tadir_insert( iv_package ).
+
       CALL FUNCTION 'EXTTYPE_CREATE'
         EXPORTING
           pi_cimtyp     = mv_extension

src/objects/zcl_abapgit_object_iobj.clas.abap

@@ -61,7 +61,7 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION.
         iobj_not_found   = 1
         illegal_input    = 2
         bct_comp_invalid = 3
-        not_authorized   = 4
+*        not_authorized   = 4 " not in lower releases
         OTHERS           = 5.
     IF sy-subrc = 0.
       ASSIGN COMPONENT 'TSTPNM' OF STRUCTURE <lg_viobj> TO <lg_tstpnm>.
@@ -200,6 +200,7 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION.
         ASSERT sy-subrc = 0.
 
         IF zif_abapgit_object~exists( ) = abap_false.
+          TRY.
               CALL FUNCTION 'BAPI_IOBJ_CREATE'
                 EXPORTING
                   details                  = <lg_details>
@@ -213,8 +214,23 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION.
                   hierarchycharacteristics = <lt_hierarchycharacteristics>
                   elimination              = <lt_elimination>
                   hanafieldsmapping        = <lt_hanafieldsmapping>
-              xxlattributes            = <lt_xxlattributes>.
+                  xxlattributes            = <lt_xxlattributes> ##ARG_OK.
+            CATCH cx_sy_dyn_call_param_not_found.
+              CALL FUNCTION 'BAPI_IOBJ_CREATE'
+                EXPORTING
+                  details                  = <lg_details>
+                IMPORTING
+                  return                   = ls_return
+                TABLES
+                  compounds                = <lt_compounds>
+                  attributes               = <lt_attributes>
+                  navigationattributes     = <lt_navigationattributes>
+                  atrnavinfoprovider       = <lt_atrnavinfoprovider>
+                  hierarchycharacteristics = <lt_hierarchycharacteristics>
+                  elimination              = <lt_elimination>.
+          ENDTRY.
         ELSE.
+          TRY.
               CALL FUNCTION 'BAPI_IOBJ_CHANGE'
                 EXPORTING
                   infoobject               = <lg_infoobject>
@@ -229,7 +245,22 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION.
                   hierarchycharacteristics = <lt_hierarchycharacteristics>
                   elimination              = <lt_elimination>
                   hanafieldsmapping        = <lt_hanafieldsmapping>
-              xxlattributes            = <lt_xxlattributes>.
+                  xxlattributes            = <lt_xxlattributes> ##ARG_OK.
+            CATCH cx_sy_dyn_call_param_not_found.
+              CALL FUNCTION 'BAPI_IOBJ_CHANGE'
+                EXPORTING
+                  infoobject               = <lg_infoobject>
+                  details                  = <lg_details>
+                IMPORTING
+                  return                   = ls_return
+                TABLES
+                  compounds                = <lt_compounds>
+                  attributes               = <lt_attributes>
+                  navigationattributes     = <lt_navigationattributes>
+                  atrnavinfoprovider       = <lt_atrnavinfoprovider>
+                  hierarchycharacteristics = <lt_hierarchycharacteristics>
+                  elimination              = <lt_elimination>.
+          ENDTRY.
         ENDIF.
 
         IF ls_return-type = 'E'.
@@ -409,6 +440,7 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION.
 
     lv_iobjnam = ms_item-obj_name.
 
+    TRY.
         CALL FUNCTION 'BAPI_IOBJ_GETDETAIL'
           EXPORTING
             infoobject               = lv_iobjnam
@@ -423,7 +455,22 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION.
             hierarchycharacteristics = <lt_hierarchycharacteristics>
             elimination              = <lt_elimination>
             hanafieldsmapping        = <lt_hanafieldsmapping>
-        xxlattributes            = <lt_xxlattributes>.
+            xxlattributes            = <lt_xxlattributes> ##ARG_OK.
+      CATCH cx_sy_dyn_call_param_not_found.
+        CALL FUNCTION 'BAPI_IOBJ_GETDETAIL'
+          EXPORTING
+            infoobject               = lv_iobjnam
+          IMPORTING
+            details                  = <lg_details>
+            return                   = ls_return
+          TABLES
+            compounds                = <lt_compounds>
+            attributes               = <lt_attributes>
+            navigationattributes     = <lt_navigationattributes>
+            atrnavinfoprovider       = <lt_atrnavinfoprovider>
+            hierarchycharacteristics = <lt_hierarchycharacteristics>
+            elimination              = <lt_elimination>.
+    ENDTRY.
 
     IF ls_return-type = 'E'.
       zcx_abapgit_exception=>raise( |Error getting details of InfoObject: { ls_return-message }| ).

src/objects/zcl_abapgit_object_iwpr.clas.abap

@@ -124,7 +124,11 @@ CLASS zcl_abapgit_object_iwpr IMPLEMENTATION.
 
   METHOD zif_abapgit_object~jump.
 
-    SUBMIT /iwbep/r_sbui_service_builder
+    DATA lv_prog TYPE progname.
+
+    lv_prog = '/IWBEP/R_SBUI_SERVICE_BUILDER'.
+
+    SUBMIT (lv_prog)
       WITH i_prname = ms_item-obj_name
       AND RETURN.
 

src/objects/zcl_abapgit_object_iwvb.clas.abap

@@ -131,7 +131,11 @@ CLASS zcl_abapgit_object_iwvb IMPLEMENTATION.
 
   METHOD zif_abapgit_object~jump.
 
-    SUBMIT /iwbep/r_dst_vocan_register
+    DATA lv_prog TYPE progname.
+
+    lv_prog = '/IWBEP/R_DST_VOCAN_REGISTER'.
+
+    SUBMIT (lv_prog)
       WITH ip_aname = ms_item-obj_name
       WITH ip_avers = ms_item-obj_name+32(4)
       AND RETURN.

src/objects/zcl_abapgit_object_msag.clas.abap

@@ -84,7 +84,7 @@ CLASS zcl_abapgit_object_msag IMPLEMENTATION.
         object_is_enqueued_by_corr     = 6
         user_break                     = 7
         OTHERS                         = 8.
-    IF sy-subrc <> 0.
+    IF sy-subrc <> 0 AND sy-subrc <> 4.
       zcx_abapgit_exception=>raise( 'Error deleting longtext for message' ).
     ENDIF.
 

src/objects/zcl_abapgit_object_shlp.clas.abap

@@ -7,7 +7,7 @@ CLASS zcl_abapgit_object_shlp DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
 
     METHODS handle_dependencies
       IMPORTING
-        !iv_step TYPE zif_abapgit_definitions=>ty_deserialization_step
+        !iv_step TYPE zif_abapgit_objects=>ty_deserialization_step
       CHANGING
         !cv_exit TYPE dd30v-selmexit
         !cv_done TYPE abap_bool.

src/objects/zcl_abapgit_object_sush.clas.abap

@@ -23,10 +23,10 @@ CLASS zcl_abapgit_object_sush DEFINITION
     METHODS clear_metadata
       CHANGING
         cs_data_head TYPE any
-        ct_usobx     TYPE table
+        ct_usobx     TYPE STANDARD TABLE
-        ct_usobt     TYPE table
+        ct_usobt     TYPE STANDARD TABLE
-        ct_usobx_ext TYPE table
+        ct_usobx_ext TYPE STANDARD TABLE
-        ct_usobt_ext TYPE table.
+        ct_usobt_ext TYPE STANDARD TABLE.
 
 ENDCLASS.
 

src/objects/zcl_abapgit_object_ucsa.clas.abap

@@ -158,6 +158,8 @@ CLASS zcl_abapgit_object_ucsa IMPLEMENTATION.
 
     tadir_delete( ).
 
+    corr_insert( iv_package ).
+
   ENDMETHOD.
 
 
@@ -195,6 +197,8 @@ CLASS zcl_abapgit_object_ucsa IMPLEMENTATION.
 
         tadir_insert( iv_package ).
 
+        corr_insert( iv_package ).
+
       CATCH cx_root INTO lx_root.
         lv_text = lx_root->get_text( ).
         zcx_abapgit_exception=>raise( lv_text ).

src/objects/zcl_abapgit_objects.clas.abap

@@ -4,9 +4,6 @@ CLASS zcl_abapgit_objects DEFINITION
 
   PUBLIC SECTION.
 
-    TYPES:
-      ty_types_tt TYPE SORTED TABLE OF tadir-object WITH UNIQUE KEY table_line .
-
     CLASS-METHODS serialize
       IMPORTING
         !is_item                 TYPE zif_abapgit_definitions=>ty_item
@@ -71,7 +68,7 @@ CLASS zcl_abapgit_objects DEFINITION
         VALUE(rv_bool) TYPE abap_bool .
     CLASS-METHODS supported_list
       RETURNING
-        VALUE(rt_types) TYPE ty_types_tt .
+        VALUE(rt_types) TYPE zif_abapgit_objects=>ty_types_tt.
     CLASS-METHODS is_active
       IMPORTING
         !is_item         TYPE zif_abapgit_definitions=>ty_item
@@ -663,7 +660,7 @@ CLASS zcl_abapgit_objects IMPLEMENTATION.
           li_progress TYPE REF TO zif_abapgit_progress,
           lv_path     TYPE string,
           lt_items    TYPE zif_abapgit_definitions=>ty_items_tt,
-          lt_steps_id TYPE zif_abapgit_definitions=>ty_deserialization_step_tt,
+          lt_steps_id TYPE zif_abapgit_objects=>ty_deserialization_step_tt,
           lt_steps    TYPE zif_abapgit_objects=>ty_step_data_tt,
           lx_exc      TYPE REF TO zcx_abapgit_exception.
     DATA lo_folder_logic TYPE REF TO zcl_abapgit_folder_logic.
@@ -672,7 +669,7 @@ CLASS zcl_abapgit_objects IMPLEMENTATION.
     DATA lo_abap_language_vers TYPE REF TO zcl_abapgit_abap_language_vers.
 
     FIELD-SYMBOLS: <ls_result>  TYPE zif_abapgit_definitions=>ty_result,
-                   <lv_step_id> TYPE LINE OF zif_abapgit_definitions=>ty_deserialization_step_tt,
+                   <lv_step_id> TYPE LINE OF zif_abapgit_objects=>ty_deserialization_step_tt,
                    <ls_step>    TYPE LINE OF zif_abapgit_objects=>ty_step_data_tt,
                    <ls_deser>   TYPE LINE OF zif_abapgit_objects=>ty_deserialization_tt.
 

src/objects/zcl_abapgit_objects.clas.testclasses.abap

@@ -29,7 +29,7 @@ CLASS ltcl_object_types IMPLEMENTATION.
 
     DATA: ls_item   TYPE zif_abapgit_definitions=>ty_item,
           lv_exists TYPE abap_bool,
-          lt_types  TYPE zcl_abapgit_objects=>ty_types_tt.
+          lt_types  TYPE zif_abapgit_objects=>ty_types_tt.
 
     FIELD-SYMBOLS: <lv_type> LIKE LINE OF lt_types.
 

src/objects/zif_abapgit_object.intf.abap

@@ -1,12 +1,11 @@
-INTERFACE zif_abapgit_object
+INTERFACE zif_abapgit_object PUBLIC.
-  PUBLIC .
 
   CONSTANTS:
     BEGIN OF gc_step_id,
-      early TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `EARLY`,
+      early TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'EARLY',
-      abap  TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `ABAP`,
+      abap  TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'ABAP',
-      ddic  TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `DDIC`,
+      ddic  TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'DDIC',
-      late  TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `LATE`,
+      late  TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'LATE',
     END OF gc_step_id.
 
   METHODS serialize
@@ -19,7 +18,7 @@ INTERFACE zif_abapgit_object
     IMPORTING
       !iv_package   TYPE devclass
       !io_xml       TYPE REF TO zif_abapgit_xml_input
-      !iv_step      TYPE zif_abapgit_definitions=>ty_deserialization_step
+      !iv_step      TYPE zif_abapgit_objects=>ty_deserialization_step
       !ii_log       TYPE REF TO zif_abapgit_log
       !iv_transport TYPE trkorr
     RAISING
@@ -78,7 +77,7 @@ INTERFACE zif_abapgit_object
 
   METHODS get_deserialize_steps
     RETURNING
-      VALUE(rt_steps) TYPE zif_abapgit_definitions=>ty_deserialization_step_tt .
+      VALUE(rt_steps) TYPE zif_abapgit_objects=>ty_deserialization_step_tt.
 
   METHODS get_deserialize_order
     IMPORTING

src/objects/zif_abapgit_objects.intf.abap

@@ -1,5 +1,4 @@
-INTERFACE zif_abapgit_objects
+INTERFACE zif_abapgit_objects PUBLIC.
-  PUBLIC.
 
   TYPES:
     BEGIN OF ty_serialization,
@@ -15,9 +14,15 @@ INTERFACE zif_abapgit_objects
     END OF ty_deserialization .
   TYPES:
     ty_deserialization_tt TYPE STANDARD TABLE OF ty_deserialization WITH DEFAULT KEY .
+  TYPES:
+    ty_types_tt TYPE SORTED TABLE OF tadir-object WITH UNIQUE KEY table_line.
+  TYPES:
+    ty_deserialization_step TYPE string.
+  TYPES:
+    ty_deserialization_step_tt TYPE STANDARD TABLE OF ty_deserialization_step WITH DEFAULT KEY.
   TYPES:
     BEGIN OF ty_step_data,
-      step_id      TYPE zif_abapgit_definitions=>ty_deserialization_step,
+      step_id      TYPE ty_deserialization_step,
       order        TYPE i,
       descr        TYPE string,
       syntax_check TYPE abap_bool,

src/repo/zcl_abapgit_repo.clas.abap

@@ -192,7 +192,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
+CLASS zcl_abapgit_repo IMPLEMENTATION.
 
 
   METHOD bind_listener.
@@ -402,7 +402,7 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
   METHOD get_unsupported_objects_local.
 
     DATA: lt_tadir           TYPE zif_abapgit_definitions=>ty_tadir_tt,
-          lt_supported_types TYPE zcl_abapgit_objects=>ty_types_tt.
+          lt_supported_types TYPE zif_abapgit_objects=>ty_types_tt.
 
     FIELD-SYMBOLS: <ls_tadir>  LIKE LINE OF lt_tadir,
                    <ls_object> LIKE LINE OF rt_objects.

src/ui/core/zcl_abapgit_gui.clas.abap

@@ -115,7 +115,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_GUI IMPLEMENTATION.
+CLASS zcl_abapgit_gui IMPLEMENTATION.
 
 
   METHOD back.
@@ -373,7 +373,7 @@ CLASS ZCL_ABAPGIT_GUI IMPLEMENTATION.
           li_modal ?= ii_page.
           rv_yes = li_modal->is_modal( ).
         ENDIF.
-      CATCH cx_sy_move_cast_error.
+      CATCH cx_sy_move_cast_error ##NO_HANDLER.
     ENDTRY.
 
   ENDMETHOD.

src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap

@@ -243,7 +243,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION.
+CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
 
 
   METHOD class_constructor.
@@ -261,7 +261,7 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION.
             timezone            = gv_time_zone
           EXCEPTIONS
             customizing_missing = 1
-            OTHERS              = 2.
+            OTHERS              = 2 ##FM_SUBRC_OK.
     ENDTRY.
 
   ENDMETHOD.

src/ui/lib/zcl_abapgit_gui_page_hoc.clas.abap

@@ -54,7 +54,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_GUI_PAGE_HOC IMPLEMENTATION.
+CLASS zcl_abapgit_gui_page_hoc IMPLEMENTATION.
 
 
   METHOD constructor.
@@ -96,14 +96,14 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_HOC IMPLEMENTATION.
     IF ls_control-page_menu_provider IS NOT BOUND. " try component itself
       TRY.
           ls_control-page_menu_provider ?= ii_child_component.
-        CATCH cx_sy_move_cast_error.
+        CATCH cx_sy_move_cast_error ##NO_HANDLER.
       ENDTRY.
     ENDIF.
 
     IF ls_control-page_title_provider IS NOT BOUND. " try component itself
       TRY.
           ls_control-page_title_provider ?= ii_child_component.
-        CATCH cx_sy_move_cast_error.
+        CATCH cx_sy_move_cast_error ##NO_HANDLER.
       ENDTRY.
     ENDIF.
 
@@ -132,7 +132,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_HOC IMPLEMENTATION.
     TRY.
         li_modal ?= mi_child.
         rv_is_modal = li_modal->is_modal( ).
-      CATCH cx_sy_move_cast_error.
+      CATCH cx_sy_move_cast_error ##NO_HANDLER.
     ENDTRY.
 
   ENDMETHOD.
@@ -141,7 +141,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_HOC IMPLEMENTATION.
   METHOD detect_title_provider.
     TRY.
         ri_ref ?= mi_child.
-      CATCH cx_sy_move_cast_error.
+      CATCH cx_sy_move_cast_error ##NO_HANDLER.
     ENDTRY.
   ENDMETHOD.
 

src/ui/lib/zcl_abapgit_gui_picklist.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>ZCL_ABAPGIT_GUI_PICKLIST</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>abapGit - Pick from list</DESCRIPT>
+    <DESCRIPT>abapGit - GUI Pick List</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/ui/lib/zcl_abapgit_log_viewer.clas.abap

@@ -30,6 +30,8 @@ CLASS zcl_abapgit_log_viewer DEFINITION
         source    TYPE icon_d,
         callstack TYPE icon_d,
         cell_type TYPE salv_t_int4_column,
+        id        TYPE sy-msgid,
+        number    TYPE sy-msgno,
       END OF ty_log_out.
     TYPES:
       ty_log_outs TYPE STANDARD TABLE OF ty_log_out
@@ -91,7 +93,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_LOG_VIEWER IMPLEMENTATION.
+CLASS zcl_abapgit_log_viewer IMPLEMENTATION.
 
 
   METHOD calculate_cell_type.
@@ -268,6 +270,10 @@ CLASS ZCL_ABAPGIT_LOG_VIEWER IMPLEMENTATION.
           CATCH cx_sy_move_cast_error ##NO_HANDLER.
         ENDTRY.
 
+      ELSEIF lr_message->id IS NOT INITIAL AND lr_message->number IS NOT INITIAL.
+        ls_log-id       = lr_message->id.
+        ls_log-number   = lr_message->number.
+        ls_log-longtext = icon_system_help.
       ENDIF.
 
       ls_log-obj_type = lr_message->obj_type.
@@ -387,6 +393,16 @@ CLASS ZCL_ABAPGIT_LOG_VIEWER IMPLEMENTATION.
           lo_column->set_technical( abap_true ).
         ENDIF.
 
+        LOOP AT gt_log TRANSPORTING NO FIELDS WHERE id IS NOT INITIAL.
+          EXIT.
+        ENDLOOP.
+        IF sy-subrc <> 0.
+          lo_column = lo_columns->get_column( |ID| ).
+          lo_column->set_technical( abap_true ).
+          lo_column = lo_columns->get_column( |NUMBER| ).
+          lo_column->set_technical( abap_true ).
+        ENDIF.
+
         ls_position = zcl_abapgit_popups=>center(
           iv_width  = 125
           iv_height = 20 ).
@@ -424,31 +440,34 @@ CLASS ZCL_ABAPGIT_LOG_VIEWER IMPLEMENTATION.
           lt_dummy2      TYPE TABLE OF dval,
           ls_help_info   TYPE help_info.
 
-    IF is_log-exception IS NOT BOUND.
+    IF is_log-exception IS BOUND.
-      RETURN.
-    ENDIF.
-
       TRY.
           lx_abapgit ?= is_log-exception.
         CATCH cx_sy_move_cast_error.
           RETURN.
       ENDTRY.
 
-    lv_docu_object   = lx_abapgit->if_t100_message~t100key-msgid.
+      lv_docu_object = lx_abapgit->if_t100_message~t100key-msgid && lx_abapgit->if_t100_message~t100key-msgno.
-    lv_docu_object+2 = lx_abapgit->if_t100_message~t100key-msgno.
-
-    ls_help_info-call       = 'D'.
-    ls_help_info-spras      = sy-langu.
       ls_help_info-messageid  = lx_abapgit->if_t100_message~t100key-msgid.
       ls_help_info-messagenr  = lx_abapgit->if_t100_message~t100key-msgno.
-    ls_help_info-message    = is_log-msg.
-    ls_help_info-title      = 'Longtext'.
-    ls_help_info-docuid     = 'NA'.
-    ls_help_info-docuobject = lv_docu_object.
       ls_help_info-msgv1      = lx_abapgit->msgv1.
       ls_help_info-msgv2      = lx_abapgit->msgv2.
       ls_help_info-msgv3      = lx_abapgit->msgv3.
       ls_help_info-msgv4      = lx_abapgit->msgv4.
+    ELSEIF is_log-id IS NOT INITIAL AND is_log-number IS NOT INITIAL.
+      lv_docu_object          = is_log-id && is_log-number.
+      ls_help_info-messageid  = is_log-id.
+      ls_help_info-messagenr  = is_log-number.
+    ELSE.
+      RETURN.
+    ENDIF.
+
+    ls_help_info-call       = 'D'.
+    ls_help_info-spras      = sy-langu.
+    ls_help_info-message    = is_log-msg.
+    ls_help_info-title      = 'Longtext'.
+    ls_help_info-docuid     = 'NA'.
+    ls_help_info-docuobject = condense( lv_docu_object ).
 
     CALL FUNCTION 'HELP_START'
       EXPORTING

src/ui/pages/codi/zcl_abapgit_gui_page_codi_base.clas.abap

@@ -127,7 +127,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION.
+CLASS zcl_abapgit_gui_page_codi_base IMPLEMENTATION.
 
 
   METHOD apply_filter_kind.
@@ -256,7 +256,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION.
             ENDIF.
 
         ENDCASE.
-      CATCH cx_root.
+      CATCH cx_root ##NO_HANDLER.
         " leave empty, fallback to default, defined elsewhere
     ENDTRY.
 
@@ -340,7 +340,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION.
           RETURN.
 
         ENDIF.
-      CATCH zcx_abapgit_exception.
+      CATCH zcx_abapgit_exception ##NO_HANDLER.
     ENDTRY.
 
     TRY.

src/ui/pages/codi/zcl_abapgit_gui_page_whereused.clas.xml

@@ -5,7 +5,7 @@
    <VSEOCLASS>
     <CLSNAME>ZCL_ABAPGIT_GUI_PAGE_WHEREUSED</CLSNAME>
     <LANGU>E</LANGU>
-    <DESCRIPT>abapGit where-used page</DESCRIPT>
+    <DESCRIPT>abapGit - GUI Where-used</DESCRIPT>
     <STATE>1</STATE>
     <CLSCCINCL>X</CLSCCINCL>
     <FIXPT>X</FIXPT>

src/ui/pages/sett/zcl_abapgit_gui_page_sett_info.clas.abap

@@ -422,7 +422,7 @@ CLASS zcl_abapgit_gui_page_sett_info IMPLEMENTATION.
     DATA:
       ls_stats           TYPE ty_stats,
       ls_item            TYPE zif_abapgit_definitions=>ty_item,
-      lt_supported_types TYPE zcl_abapgit_objects=>ty_types_tt.
+      lt_supported_types TYPE zif_abapgit_objects=>ty_types_tt.
 
     ls_stats-measure = 'Number of Objects'.
 

src/ui/pages/sett/zcl_abapgit_gui_page_sett_pers.clas.abap

@@ -317,7 +317,7 @@ CLASS zcl_abapgit_gui_page_sett_pers IMPLEMENTATION.
           lo_colors->set(
             iv_key = lv_l
             iv_val = lv_l ).
-        CATCH zcx_abapgit_exception.
+        CATCH zcx_abapgit_exception ##NO_HANDLER.
       ENDTRY.
     ENDLOOP.
 

src/ui/pages/zcl_abapgit_gui_page_debuginfo.clas.abap

@@ -298,15 +298,15 @@ CLASS zcl_abapgit_gui_page_debuginfo IMPLEMENTATION.
 
     DATA: lv_list     TYPE string,
           li_html     TYPE REF TO zif_abapgit_html,
-          lt_types    TYPE zcl_abapgit_objects=>ty_types_tt,
+          lt_types    TYPE zif_abapgit_objects=>ty_types_tt,
           lv_type     LIKE LINE OF lt_types,
           lt_obj      TYPE STANDARD TABLE OF ko100 WITH DEFAULT KEY,
           lv_class    TYPE seoclsname,
           li_object   TYPE REF TO zif_abapgit_object,
           ls_item     TYPE zif_abapgit_definitions=>ty_item,
           ls_metadata TYPE zif_abapgit_definitions=>ty_metadata,
-          lv_step     TYPE zif_abapgit_definitions=>ty_deserialization_step,
+          lv_step     TYPE zif_abapgit_objects=>ty_deserialization_step,
-          lt_steps    TYPE zif_abapgit_definitions=>ty_deserialization_step_tt.
+          lt_steps    TYPE zif_abapgit_objects=>ty_deserialization_step_tt.
 
     FIELD-SYMBOLS: <ls_obj> TYPE ko100.
 

src/ui/pages/zcl_abapgit_gui_page_stage.clas.abap

@@ -137,7 +137,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION.
+CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION.
 
 
   METHOD check_selected.
@@ -281,7 +281,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION.
               es_item     = ls_item ).
           ls_changed_by-item = ls_item.
           INSERT ls_changed_by INTO TABLE lt_changed_by_remote.
-        CATCH zcx_abapgit_exception.
+        CATCH zcx_abapgit_exception ##NO_HANDLER.
       ENDTRY.
     ENDLOOP.
 
@@ -348,7 +348,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_STAGE IMPLEMENTATION.
 
         rt_transports = li_cts_api->get_transports_for_list( lt_items ).
 
-      CATCH zcx_abapgit_exception.
+      CATCH zcx_abapgit_exception ##NO_HANDLER.
     ENDTRY.
 
   ENDMETHOD.

src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap

@@ -22,6 +22,7 @@ CLASS zcl_abapgit_popup_branch_list DEFINITION
         !iv_default_branch  TYPE string OPTIONAL
         !iv_show_new_option TYPE abap_bool DEFAULT abap_false.
 
+  PROTECTED SECTION.
   PRIVATE SECTION.
 
     DATA mv_repo_url TYPE string.
@@ -41,15 +42,6 @@ ENDCLASS.
 CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
 
 
-  METHOD create.
-    CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_branch_list
-      EXPORTING
-        iv_url             = iv_url
-        iv_default_branch  = iv_default_branch
-        iv_show_new_option = iv_show_new_option.
-  ENDMETHOD.
-
-
   METHOD constructor.
     mv_repo_url        = iv_url.
     mv_default_branch  = zif_abapgit_git_definitions=>c_git_branch-heads_prefix && iv_default_branch.
@@ -57,14 +49,12 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
   ENDMETHOD.
 
 
-  METHOD zif_abapgit_html_popup~create_picklist.
+  METHOD create.
-
+    CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_branch_list
-    CREATE OBJECT ro_picklist
       EXPORTING
-        iv_title         = 'Choose Branch'
+        iv_url             = iv_url
-        it_list          = fetch_branch_list( )
+        iv_default_branch  = iv_default_branch
-        ii_item_renderer = me.
+        iv_show_new_option = iv_show_new_option.
-
   ENDMETHOD.
 
 
@@ -109,7 +99,6 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
     FIELD-SYMBOLS <ls_b> TYPE zif_abapgit_git_definitions=>ty_git_branch.
 
     ASSIGN iv_item TO <ls_b>.
-    ASSERT sy-subrc = 0.
 
     " TODO render mv_default_branch properly, needs respecting support from the picklist components
 
@@ -120,4 +109,15 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
     ri_html = zcl_abapgit_html=>create( |{ <ls_b>-display_name }{ lv_head_marker }| ).
 
   ENDMETHOD.
+
+
+  METHOD zif_abapgit_html_popup~create_picklist.
+
+    CREATE OBJECT ro_picklist
+      EXPORTING
+        iv_title         = 'Choose Branch'
+        it_list          = fetch_branch_list( )
+        ii_item_renderer = me.
+
+  ENDMETHOD.
 ENDCLASS.

src/ui/popups/zcl_abapgit_popup_code_insp.clas.abap

@@ -24,7 +24,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_POPUP_CODE_INSP IMPLEMENTATION.
+CLASS zcl_abapgit_popup_code_insp IMPLEMENTATION.
 
 
   METHOD create.
@@ -44,7 +44,6 @@ CLASS ZCL_ABAPGIT_POPUP_CODE_INSP IMPLEMENTATION.
     FIELD-SYMBOLS <ls_item> TYPE LINE OF zif_abapgit_code_inspector=>ty_variants.
 
     ASSIGN iv_item TO <ls_item>.
-    ASSERT sy-subrc = 0.
 
     ri_html = zcl_abapgit_html=>create( |<b>{ <ls_item>-name }</b> - { <ls_item>-description }| ).
 

src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap

@@ -67,7 +67,6 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
     FIELD-SYMBOLS <ls_pr> TYPE zif_abapgit_pr_enum_provider=>ty_pull_request.
 
     ASSIGN iv_item TO <ls_pr>.
-    ASSERT sy-subrc = 0.
 
     ri_html = zcl_abapgit_html=>create( |<b>{ <ls_pr>-number }</b> - { <ls_pr>-title } @{ <ls_pr>-user }| ).
 

src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap

@@ -18,6 +18,7 @@ CLASS zcl_abapgit_popup_tag_list DEFINITION
       IMPORTING
         iv_url TYPE string.
 
+  PROTECTED SECTION.
   PRIVATE SECTION.
 
     DATA mv_repo_url TYPE string.
@@ -34,26 +35,15 @@ ENDCLASS.
 CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION.
 
 
-  METHOD create.
-    CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_tag_list
-      EXPORTING
-        iv_url = iv_url.
-  ENDMETHOD.
-
-
   METHOD constructor.
     mv_repo_url = iv_url.
   ENDMETHOD.
 
 
-  METHOD zif_abapgit_html_popup~create_picklist.
+  METHOD create.
-
+    CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_tag_list
-    CREATE OBJECT ro_picklist
       EXPORTING
-        iv_title         = 'Choose Tag'
+        iv_url = iv_url.
-        it_list          = fetch_tag_list( )
-        ii_item_renderer = me.
-
   ENDMETHOD.
 
 
@@ -80,9 +70,19 @@ CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION.
     FIELD-SYMBOLS <ls_tag> TYPE zif_abapgit_git_definitions=>ty_git_branch.
 
     ASSIGN iv_item TO <ls_tag>.
-    ASSERT sy-subrc = 0.
 
     ri_html = zcl_abapgit_html=>create( |{ <ls_tag>-display_name }| ).
 
   ENDMETHOD.
+
+
+  METHOD zif_abapgit_html_popup~create_picklist.
+
+    CREATE OBJECT ro_picklist
+      EXPORTING
+        iv_title         = 'Choose Tag'
+        it_list          = fetch_tag_list( )
+        ii_item_renderer = me.
+
+  ENDMETHOD.
 ENDCLASS.

src/ui/routing/zcl_abapgit_gui_router.clas.abap

@@ -186,7 +186,8 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
       EXCEPTIONS
         communication_failure = 1 MESSAGE lv_msg
         system_failure        = 2 MESSAGE lv_msg
-        OTHERS                = 3.
+        resource_failure      = 3
+        OTHERS                = 4.
     IF sy-subrc <> 0.
       lv_msg = |Error starting transaction { iv_tcode }: { lv_msg }|.
       MESSAGE lv_msg TYPE 'I'.
@@ -478,6 +479,22 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
   ENDMETHOD.
 
 
+  METHOD go_stage_transport.
+
+    DATA lt_r_trkorr TYPE zif_abapgit_definitions=>ty_trrngtrkor_tt.
+    DATA lo_repo TYPE REF TO zcl_abapgit_repo.
+
+    lt_r_trkorr = zcl_abapgit_ui_factory=>get_popups( )->popup_select_wb_tc_tr_and_tsk( ).
+
+    lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ).
+
+    CREATE OBJECT ro_filter.
+    ro_filter->set_filter_values( iv_package  = lo_repo->get_package( )
+                                  it_r_trkorr = lt_r_trkorr ).
+
+  ENDMETHOD.
+
+
   METHOD jump_display_transport.
 
     DATA:
@@ -762,6 +779,28 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
   ENDMETHOD.
 
 
+  METHOD zip_export_transport.
+
+    DATA lo_obj_filter_trans TYPE REF TO zcl_abapgit_object_filter_tran.
+    DATA lt_r_trkorr         TYPE zif_abapgit_definitions=>ty_trrngtrkor_tt.
+    DATA lo_repo             TYPE REF TO zcl_abapgit_repo.
+    DATA lv_xstr             TYPE xstring.
+
+    lt_r_trkorr = zcl_abapgit_ui_factory=>get_popups( )->popup_select_wb_tc_tr_and_tsk( ).
+    lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ).
+    lo_repo->refresh( ).
+    CREATE OBJECT lo_obj_filter_trans.
+    lo_obj_filter_trans->set_filter_values( iv_package  = lo_repo->get_package( )
+                                            it_r_trkorr = lt_r_trkorr ).
+
+    lv_xstr = zcl_abapgit_zip=>encode_files( lo_repo->get_files_local_filtered( lo_obj_filter_trans ) ).
+    lo_repo->refresh( ).
+    file_download( iv_package = lo_repo->get_package( )
+                   iv_xstr    = lv_xstr ).
+
+  ENDMETHOD.
+
+
   METHOD zip_services.
 
     DATA: lv_key            TYPE zif_abapgit_persistence=>ty_repo-key,
@@ -860,40 +899,4 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
     ENDCASE.
 
   ENDMETHOD.
-
-  METHOD zip_export_transport.
-
-    DATA lo_obj_filter_trans TYPE REF TO zcl_abapgit_object_filter_tran.
-    DATA lt_r_trkorr         TYPE zif_abapgit_definitions=>ty_trrngtrkor_tt.
-    DATA lo_repo             TYPE REF TO zcl_abapgit_repo.
-    DATA lv_xstr             TYPE xstring.
-
-    lt_r_trkorr = zcl_abapgit_ui_factory=>get_popups( )->popup_select_wb_tc_tr_and_tsk( ).
-    lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ).
-    lo_repo->refresh( ).
-    CREATE OBJECT lo_obj_filter_trans.
-    lo_obj_filter_trans->set_filter_values( iv_package  = lo_repo->get_package( )
-                                            it_r_trkorr = lt_r_trkorr ).
-
-    lv_xstr = zcl_abapgit_zip=>encode_files( lo_repo->get_files_local_filtered( lo_obj_filter_trans ) ).
-    lo_repo->refresh( ).
-    file_download( iv_package = lo_repo->get_package( )
-                   iv_xstr    = lv_xstr ).
-
-  ENDMETHOD.
-
-  METHOD go_stage_transport.
-
-    DATA lt_r_trkorr TYPE zif_abapgit_definitions=>ty_trrngtrkor_tt.
-    DATA lo_repo TYPE REF TO zcl_abapgit_repo.
-
-    lt_r_trkorr = zcl_abapgit_ui_factory=>get_popups( )->popup_select_wb_tc_tr_and_tsk( ).
-
-    lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( iv_key ).
-
-    CREATE OBJECT ro_filter.
-    ro_filter->set_filter_values( iv_package  = lo_repo->get_package( )
-                                  it_r_trkorr = lt_r_trkorr ).
-
-  ENDMETHOD.
 ENDCLASS.

src/ui/zabapgit_css_theme_dark.w3mi.data.css

@@ -263,4 +263,4 @@ div.log { color: var(--theme-greyscale-dark); }
 .dialog input[readonly] {
   background-color: var(--theme-greyscale-dark);
   color: var(--theme-greyscale-medium);
-}
+}

src/ui/zcl_abapgit_popups.clas.locals_imp.abap

@@ -248,7 +248,7 @@ CLASS lcl_object_decision_list IMPLEMENTATION.
         TRY.
             lo_columns->get_column( |{ c_fieldname_obj_type }| ).
             lv_object_list = abap_true.
-          CATCH cx_salv_not_found.
+          CATCH cx_salv_not_found ##NO_HANDLER.
         ENDTRY.
 
         setup_columns(

src/ui/zif_abapgit_popups.intf.abap

@@ -12,7 +12,7 @@ INTERFACE zif_abapgit_popups
       show_icon TYPE abap_bool,
       center    TYPE abap_bool,
     END OF ty_alv_column,
-    ty_alv_column_tt TYPE TABLE OF ty_alv_column WITH DEFAULT KEY.
+    ty_alv_column_tt TYPE STANDARD TABLE OF ty_alv_column WITH DEFAULT KEY.
 
   TYPES:
     BEGIN OF ty_popup_position,

src/utils/zcl_abapgit_log.clas.abap

@@ -92,6 +92,8 @@ CLASS zcl_abapgit_log IMPLEMENTATION.
     APPEND INITIAL LINE TO mt_log ASSIGNING <ls_log>.
     <ls_log>-msg-text   = iv_msg.
     <ls_log>-msg-type   = iv_type.
+    <ls_log>-msg-id     = iv_class.
+    <ls_log>-msg-number = iv_number.
     <ls_log>-item       = is_item.
     <ls_log>-exception  = ix_exc.
 
@@ -252,6 +254,8 @@ CLASS zcl_abapgit_log IMPLEMENTATION.
     FIELD-SYMBOLS <ls_log> TYPE ty_log.
     LOOP AT mt_log ASSIGNING <ls_log>.
       ls_msg-type      = <ls_log>-msg-type.
+      ls_msg-id        = <ls_log>-msg-id.
+      ls_msg-number    = <ls_log>-msg-number.
       ls_msg-text      = <ls_log>-msg-text.
       ls_msg-obj_type  = <ls_log>-item-obj_type.
       ls_msg-obj_name  = <ls_log>-item-obj_name.

src/utils/zcl_abapgit_log.clas.testclasses.abap

@@ -14,7 +14,8 @@ CLASS ltcl_test DEFINITION FOR TESTING DURATION SHORT RISK LEVEL HARMLESS FINAL.
       merge_with_min_level FOR TESTING,
       empty FOR TESTING,
       clone FOR TESTING,
-      add FOR TESTING.
+      add FOR TESTING,
+      add_with_id_number FOR TESTING.
 ENDCLASS.
 
 
@@ -64,6 +65,44 @@ CLASS ltcl_test IMPLEMENTATION.
 
   ENDMETHOD.
 
+  METHOD add_with_id_number.
+
+    DATA lv_message TYPE string.
+    DATA lt_messages TYPE zif_abapgit_log=>ty_log_outs.
+    DATA ls_message LIKE LINE OF lt_messages.
+
+    lv_message = 'abracadabra'.
+
+    mi_cut->add(
+      iv_msg    = lv_message
+      iv_type   = 'W'
+      iv_class  = 'SL'
+      iv_number = '123' ).
+
+    cl_abap_unit_assert=>assert_equals(
+      act = mi_cut->count( )
+      exp = 1 ).
+
+    cl_abap_unit_assert=>assert_equals(
+      act = mi_cut->get_status( )
+      exp = 'W' ).
+
+    lt_messages = mi_cut->get_messages( ).
+    READ TABLE lt_messages INDEX 1 INTO ls_message.
+    cl_abap_unit_assert=>assert_subrc( ).
+
+    cl_abap_unit_assert=>assert_equals(
+      act = ls_message-text
+      exp = lv_message ).
+    cl_abap_unit_assert=>assert_equals(
+      act = ls_message-id
+      exp = 'SL' ).
+    cl_abap_unit_assert=>assert_equals(
+      act = ls_message-number
+      exp = '123' ).
+
+  ENDMETHOD.
+
   METHOD get_status.
 
     DATA lo_x TYPE REF TO zcx_abapgit_exception.

src/utils/zif_abapgit_log.intf.abap

@@ -19,6 +19,8 @@ INTERFACE zif_abapgit_log
   TYPES:
     BEGIN OF ty_log_out,
       type      TYPE sy-msgty,
+      id        TYPE sy-msgid,
+      number    TYPE sy-msgno,
       text      TYPE string,
       obj_type  TYPE tadir-object,
       obj_name  TYPE tadir-obj_name,
@@ -31,6 +33,8 @@ INTERFACE zif_abapgit_log
     BEGIN OF ty_msg,
       text   TYPE string,
       type   TYPE sy-msgty,
+      id     TYPE sy-msgid,
+      number TYPE sy-msgno,
       level  TYPE i,
     END OF ty_msg .
   TYPES:
@@ -50,6 +54,8 @@ INTERFACE zif_abapgit_log
     IMPORTING
       !iv_msg    TYPE csequence
       !iv_type   TYPE sy-msgty DEFAULT 'E'
+      !iv_class  TYPE sy-msgid OPTIONAL
+      !iv_number TYPE sy-msgno OPTIONAL
       !is_item   TYPE zif_abapgit_definitions=>ty_item OPTIONAL
       !ix_exc    TYPE REF TO cx_root OPTIONAL .
   METHODS add_error

src/zif_abapgit_definitions.intf.abap

@@ -268,11 +268,6 @@ INTERFACE zif_abapgit_definitions
       prerelase       TYPE string,
       prerelase_patch TYPE i,
     END OF ty_version.
-  TYPES:
-    ty_deserialization_step TYPE string.
-  TYPES:
-    ty_deserialization_step_tt TYPE STANDARD TABLE OF ty_deserialization_step
-                                          WITH DEFAULT KEY .
   TYPES ty_sci_result TYPE c LENGTH 1.
   CONSTANTS:
     BEGIN OF c_sci_result,