From 8d839aee236bf34111ed7d87f53283bf61f5251f Mon Sep 17 00:00:00 2001
From: Lars Hvam <larshp@hotmail.com>
Date: Mon, 17 Jul 2023 10:13:32 +0200
Subject: [PATCH] cleanup, delete unused popup choose_pr_popup() (#6349)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
---
 ...pgit_html_form_utils.clas.testclasses.abap |  3 --
 ...apgit_services_basis.clas.testclasses.abap |  4 --
 src/ui/zcl_abapgit_popups.clas.abap           | 49 -------------------
 ..._abapgit_ui_injector.clas.testclasses.abap |  4 --
 src/ui/zif_abapgit_popups.intf.abap           |  7 ---
 5 files changed, 67 deletions(-)

diff --git a/src/ui/lib/zcl_abapgit_html_form_utils.clas.testclasses.abap b/src/ui/lib/zcl_abapgit_html_form_utils.clas.testclasses.abap
index 0e02b7781..98f077a98 100644
--- a/src/ui/lib/zcl_abapgit_html_form_utils.clas.testclasses.abap
+++ b/src/ui/lib/zcl_abapgit_html_form_utils.clas.testclasses.abap
@@ -38,9 +38,6 @@ CLASS ltcl_popups_mock IMPLEMENTATION.
   METHOD zif_abapgit_popups~branch_list_popup.
   ENDMETHOD.
 
-  METHOD zif_abapgit_popups~choose_pr_popup.
-  ENDMETHOD.
-
   METHOD zif_abapgit_popups~commit_list_popup.
   ENDMETHOD.
 
diff --git a/src/ui/routing/zcl_abapgit_services_basis.clas.testclasses.abap b/src/ui/routing/zcl_abapgit_services_basis.clas.testclasses.abap
index a8c89a49e..8bf91b5ad 100644
--- a/src/ui/routing/zcl_abapgit_services_basis.clas.testclasses.abap
+++ b/src/ui/routing/zcl_abapgit_services_basis.clas.testclasses.abap
@@ -346,10 +346,6 @@ CLASS ltcl_popups_mock IMPLEMENTATION.
 
   ENDMETHOD.
 
-  METHOD zif_abapgit_popups~choose_pr_popup.
-
-  ENDMETHOD.
-
   METHOD zif_abapgit_popups~commit_list_popup.
 
   ENDMETHOD.
diff --git a/src/ui/zcl_abapgit_popups.clas.abap b/src/ui/zcl_abapgit_popups.clas.abap
index 2c0696ace..2682bf3fa 100644
--- a/src/ui/zcl_abapgit_popups.clas.abap
+++ b/src/ui/zcl_abapgit_popups.clas.abap
@@ -336,55 +336,6 @@ CLASS zcl_abapgit_popups IMPLEMENTATION.
   ENDMETHOD.
 
 
-  METHOD zif_abapgit_popups~choose_pr_popup.
-
-    DATA lv_answer    TYPE c LENGTH 1.
-    DATA lt_selection TYPE TABLE OF spopli.
-    FIELD-SYMBOLS <ls_sel>  LIKE LINE OF lt_selection.
-    FIELD-SYMBOLS <ls_pull> LIKE LINE OF it_pulls.
-
-    IF lines( it_pulls ) = 0.
-      zcx_abapgit_exception=>raise( 'No pull requests to select from' ).
-    ENDIF.
-
-    LOOP AT it_pulls ASSIGNING <ls_pull>.
-      APPEND INITIAL LINE TO lt_selection ASSIGNING <ls_sel>.
-      <ls_sel>-varoption = |{ <ls_pull>-number } - { <ls_pull>-title } @{ <ls_pull>-user }|.
-    ENDLOOP.
-
-    ms_position = center(
-      iv_width  = 74
-      iv_height = lines( lt_selection ) ).
-
-    CALL FUNCTION 'POPUP_TO_DECIDE_LIST'
-      EXPORTING
-        textline1 = 'Select pull request'
-        titel     = 'Select pull request'
-        start_col = ms_position-start_column
-        start_row = ms_position-start_row
-      IMPORTING
-        answer    = lv_answer
-      TABLES
-        t_spopli  = lt_selection
-      EXCEPTIONS
-        OTHERS    = 1.
-    IF sy-subrc <> 0.
-      zcx_abapgit_exception=>raise( 'Error from POPUP_TO_DECIDE_LIST' ).
-    ENDIF.
-
-    IF lv_answer = c_answer_cancel.
-      RETURN.
-    ENDIF.
-
-    READ TABLE lt_selection ASSIGNING <ls_sel> WITH KEY selflag = abap_true.
-    ASSERT sy-subrc = 0.
-
-    READ TABLE it_pulls INTO rs_pull INDEX sy-tabix.
-    ASSERT sy-subrc = 0.
-
-  ENDMETHOD.
-
-
   METHOD zif_abapgit_popups~commit_list_popup.
 
     DATA:
diff --git a/src/ui/zcl_abapgit_ui_injector.clas.testclasses.abap b/src/ui/zcl_abapgit_ui_injector.clas.testclasses.abap
index aa1d0c264..2ed52c92e 100644
--- a/src/ui/zcl_abapgit_ui_injector.clas.testclasses.abap
+++ b/src/ui/zcl_abapgit_ui_injector.clas.testclasses.abap
@@ -72,10 +72,6 @@ CLASS ltcl_abapgit_popups_mock IMPLEMENTATION.
 
   ENDMETHOD.
 
-  METHOD zif_abapgit_popups~choose_pr_popup.
-
-  ENDMETHOD.
-
   METHOD zif_abapgit_popups~popup_select_tr_requests.
 
   ENDMETHOD.
diff --git a/src/ui/zif_abapgit_popups.intf.abap b/src/ui/zif_abapgit_popups.intf.abap
index d0d96fd96..632f4fc97 100644
--- a/src/ui/zif_abapgit_popups.intf.abap
+++ b/src/ui/zif_abapgit_popups.intf.abap
@@ -132,13 +132,6 @@ INTERFACE zif_abapgit_popups
       VALUE(rv_transport)       TYPE trkorr
     RAISING
       zcx_abapgit_exception .
-  METHODS choose_pr_popup
-    IMPORTING
-      !it_pulls      TYPE zif_abapgit_pr_enum_provider=>ty_pull_requests
-    RETURNING
-      VALUE(rs_pull) TYPE zif_abapgit_pr_enum_provider=>ty_pull_request
-    RAISING
-      zcx_abapgit_exception .
   METHODS popup_select_tr_requests
     IMPORTING is_selection        TYPE trwbo_selection
               iv_title            TYPE trwbo_title