SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 04:08:27 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

cleanup, delete unused popup choose_pr_popup() (#6349)

Browse Source 
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
This commit is contained in:
Lars Hvam 2023-07-17 10:13:32 +02:00 committed by GitHub
parent ac854ff684
commit 8d839aee23
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 0 additions and 67 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ui/lib/zcl_abapgit_html_form_utils.clas.testclasses.abap
View File

@ -38,9 +38,6 @@ CLASS ltcl_popups_mock IMPLEMENTATION.
METHOD zif_abapgit_popups~branch_list_popup. METHOD zif_abapgit_popups~branch_list_popup.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_popups~choose_pr_popup.
ENDMETHOD.
METHOD zif_abapgit_popups~commit_list_popup. METHOD zif_abapgit_popups~commit_list_popup.
ENDMETHOD. ENDMETHOD.

4
src/ui/routing/zcl_abapgit_services_basis.clas.testclasses.abap
View File

@ -346,10 +346,6 @@ CLASS ltcl_popups_mock IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_popups~choose_pr_popup.
ENDMETHOD.
METHOD zif_abapgit_popups~commit_list_popup. METHOD zif_abapgit_popups~commit_list_popup.
ENDMETHOD. ENDMETHOD.

49
src/ui/zcl_abapgit_popups.clas.abap
View File

@ -336,55 +336,6 @@ CLASS zcl_abapgit_popups IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_popups~choose_pr_popup.
DATA lv_answer TYPE c LENGTH 1.
DATA lt_selection TYPE TABLE OF spopli.
FIELD-SYMBOLS <ls_sel> LIKE LINE OF lt_selection.
FIELD-SYMBOLS <ls_pull> LIKE LINE OF it_pulls.
IF lines( it_pulls ) = 0.
zcx_abapgit_exception=>raise( 'No pull requests to select from' ).
ENDIF.
LOOP AT it_pulls ASSIGNING <ls_pull>.
APPEND INITIAL LINE TO lt_selection ASSIGNING <ls_sel>.
<ls_sel>-varoption = |{ <ls_pull>-number } - { <ls_pull>-title } @{ <ls_pull>-user }|.
ENDLOOP.
ms_position = center(
iv_width = 74
iv_height = lines( lt_selection ) ).
CALL FUNCTION 'POPUP_TO_DECIDE_LIST'
EXPORTING
textline1 = 'Select pull request'
titel = 'Select pull request'
start_col = ms_position-start_column
start_row = ms_position-start_row
IMPORTING
answer = lv_answer
TABLES
t_spopli = lt_selection
EXCEPTIONS
OTHERS = 1.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error from POPUP_TO_DECIDE_LIST' ).
ENDIF.
IF lv_answer = c_answer_cancel.
RETURN.
ENDIF.
READ TABLE lt_selection ASSIGNING <ls_sel> WITH KEY selflag = abap_true.
ASSERT sy-subrc = 0.
READ TABLE it_pulls INTO rs_pull INDEX sy-tabix.
ASSERT sy-subrc = 0.
ENDMETHOD.
METHOD zif_abapgit_popups~commit_list_popup. METHOD zif_abapgit_popups~commit_list_popup.
DATA: DATA:

4
src/ui/zcl_abapgit_ui_injector.clas.testclasses.abap
View File

@ -72,10 +72,6 @@ CLASS ltcl_abapgit_popups_mock IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_popups~choose_pr_popup.
ENDMETHOD.
METHOD zif_abapgit_popups~popup_select_tr_requests. METHOD zif_abapgit_popups~popup_select_tr_requests.
ENDMETHOD. ENDMETHOD.

7
src/ui/zif_abapgit_popups.intf.abap
View File

@ -132,13 +132,6 @@ INTERFACE zif_abapgit_popups
VALUE(rv_transport) TYPE trkorr VALUE(rv_transport) TYPE trkorr
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS choose_pr_popup
IMPORTING
!it_pulls TYPE zif_abapgit_pr_enum_provider=>ty_pull_requests
RETURNING
VALUE(rs_pull) TYPE zif_abapgit_pr_enum_provider=>ty_pull_request
RAISING
zcx_abapgit_exception .
METHODS popup_select_tr_requests METHODS popup_select_tr_requests
IMPORTING is_selection TYPE trwbo_selection IMPORTING is_selection TYPE trwbo_selection
iv_title TYPE trwbo_title iv_title TYPE trwbo_title