From 8d87beea6012669cb56f4ab6f0f44b81ec4b2e59 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Thu, 1 Aug 2019 03:17:59 -0700 Subject: [PATCH] tutorial is just a view, no need to implement intf (#2823) --- src/ui/zcl_abapgit_gui_page_main.clas.abap | 6 ++--- .../zcl_abapgit_gui_view_tutorial.clas.abap | 22 +++++-------------- 2 files changed, 8 insertions(+), 20 deletions(-) diff --git a/src/ui/zcl_abapgit_gui_page_main.clas.abap b/src/ui/zcl_abapgit_gui_page_main.clas.abap index ca8ca7ea4..964b1485d 100644 --- a/src/ui/zcl_abapgit_gui_page_main.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_main.clas.abap @@ -106,7 +106,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION. DATA: lt_repos TYPE zif_abapgit_definitions=>ty_repo_ref_tt, lx_error TYPE REF TO zcx_abapgit_exception, - lo_tutorial TYPE REF TO zcl_abapgit_gui_view_tutorial, + li_tutorial TYPE REF TO zif_abapgit_gui_renderable, lo_repo LIKE LINE OF lt_repos. retrieve_active_repo( ). " Get and validate key of user default repo @@ -123,8 +123,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION. ro_html->add( render_toc( lt_repos ) ). IF mv_show IS INITIAL OR lines( lt_repos ) = 0. - CREATE OBJECT lo_tutorial. - ro_html->add( lo_tutorial->render( ) ). + CREATE OBJECT li_tutorial TYPE zcl_abapgit_gui_view_tutorial. + ro_html->add( li_tutorial->render( ) ). ELSE. lo_repo = zcl_abapgit_repo_srv=>get_instance( )->get( mv_show ). ro_html->add( render_repo( lo_repo ) ). diff --git a/src/ui/zcl_abapgit_gui_view_tutorial.clas.abap b/src/ui/zcl_abapgit_gui_view_tutorial.clas.abap index b9a7774af..1bf5183f0 100644 --- a/src/ui/zcl_abapgit_gui_view_tutorial.clas.abap +++ b/src/ui/zcl_abapgit_gui_view_tutorial.clas.abap @@ -1,11 +1,11 @@ -CLASS zcl_abapgit_gui_view_tutorial DEFINITION PUBLIC FINAL CREATE PUBLIC. +CLASS zcl_abapgit_gui_view_tutorial DEFINITION + PUBLIC + FINAL + CREATE PUBLIC . PUBLIC SECTION. - INTERFACES zif_abapgit_gui_renderable. - INTERFACES zif_abapgit_gui_event_handler. - INTERFACES zif_abapgit_gui_page_hotkey. - ALIASES render FOR zif_abapgit_gui_renderable~render. + INTERFACES zif_abapgit_gui_renderable . PROTECTED SECTION. PRIVATE SECTION. METHODS render_content @@ -74,16 +74,6 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_TUTORIAL IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_gui_event_handler~on_event. - ev_state = zcl_abapgit_gui=>c_event_state-not_handled. - ENDMETHOD. - - - METHOD zif_abapgit_gui_page_hotkey~get_hotkey_actions. - - ENDMETHOD. - - METHOD zif_abapgit_gui_renderable~render. CREATE OBJECT ro_html TYPE zcl_abapgit_html. @@ -93,6 +83,4 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_TUTORIAL IMPLEMENTATION. ro_html->add( '' ). ENDMETHOD. - - ENDCLASS.