From 8e07d46f4b1f78234c323b86581be37ef447d35d Mon Sep 17 00:00:00 2001
From: Lars Hvam <larshp@hotmail.com>
Date: Tue, 9 Feb 2021 15:50:27 +0100
Subject: [PATCH] jump_se11, remove unused parameters (#4498)

---
 abaplint.json                                   | 1 +
 src/objects/zcl_abapgit_object_doma.clas.abap   | 3 +--
 src/objects/zcl_abapgit_object_dtel.clas.abap   | 3 +--
 src/objects/zcl_abapgit_object_enqu.clas.abap   | 3 +--
 src/objects/zcl_abapgit_object_nspc.clas.abap   | 6 +-----
 src/objects/zcl_abapgit_object_shlp.clas.abap   | 3 +--
 src/objects/zcl_abapgit_object_tabl.clas.abap   | 3 +--
 src/objects/zcl_abapgit_object_ttyp.clas.abap   | 3 +--
 src/objects/zcl_abapgit_object_type.clas.abap   | 3 +--
 src/objects/zcl_abapgit_object_view.clas.abap   | 3 +--
 src/objects/zcl_abapgit_objects_super.clas.abap | 3 ---
 src/ui/zcl_abapgit_html_form.clas.abap          | 2 ++
 12 files changed, 12 insertions(+), 24 deletions(-)

diff --git a/abaplint.json b/abaplint.json
index 02e1a30f2..d685d53a5 100644
--- a/abaplint.json
+++ b/abaplint.json
@@ -74,6 +74,7 @@
     "globalMacros": []
   },
   "rules": {
+    "prefer_raise_exception_new": true,
     "use_class_based_exceptions": true,
     "uncaught_exception": true,
     "intf_referencing_clas": false,
diff --git a/src/objects/zcl_abapgit_object_doma.clas.abap b/src/objects/zcl_abapgit_object_doma.clas.abap
index e2240051c..d06ea1359 100644
--- a/src/objects/zcl_abapgit_object_doma.clas.abap
+++ b/src/objects/zcl_abapgit_object_doma.clas.abap
@@ -336,8 +336,7 @@ CLASS zcl_abapgit_object_doma IMPLEMENTATION.
 
   METHOD zif_abapgit_object~jump.
 
-    jump_se11( iv_radio = 'RSRD1-DOMA'
-               iv_field = 'RSRD1-DOMA_VAL' ).
+    jump_se11( ).
 
   ENDMETHOD.
 
diff --git a/src/objects/zcl_abapgit_object_dtel.clas.abap b/src/objects/zcl_abapgit_object_dtel.clas.abap
index 3153d74d8..a9d1af148 100644
--- a/src/objects/zcl_abapgit_object_dtel.clas.abap
+++ b/src/objects/zcl_abapgit_object_dtel.clas.abap
@@ -272,8 +272,7 @@ CLASS zcl_abapgit_object_dtel IMPLEMENTATION.
 
   METHOD zif_abapgit_object~jump.
 
-    jump_se11( iv_radio = 'RSRD1-DDTYPE'
-               iv_field = 'RSRD1-DDTYPE_VAL' ).
+    jump_se11( ).
 
   ENDMETHOD.
 
diff --git a/src/objects/zcl_abapgit_object_enqu.clas.abap b/src/objects/zcl_abapgit_object_enqu.clas.abap
index 3735d4921..d80b0b7b3 100644
--- a/src/objects/zcl_abapgit_object_enqu.clas.abap
+++ b/src/objects/zcl_abapgit_object_enqu.clas.abap
@@ -131,8 +131,7 @@ CLASS zcl_abapgit_object_enqu IMPLEMENTATION.
 
   METHOD zif_abapgit_object~jump.
 
-    jump_se11( iv_radio = 'RSRD1-ENQU'
-               iv_field = 'RSRD1-ENQU_VAL' ).
+    jump_se11( ).
 
   ENDMETHOD.
 
diff --git a/src/objects/zcl_abapgit_object_nspc.clas.abap b/src/objects/zcl_abapgit_object_nspc.clas.abap
index e8b14de99..b14d4153c 100644
--- a/src/objects/zcl_abapgit_object_nspc.clas.abap
+++ b/src/objects/zcl_abapgit_object_nspc.clas.abap
@@ -105,8 +105,6 @@ CLASS zcl_abapgit_object_nspc IMPLEMENTATION.
   METHOD serialize_texts.
 
     DATA:
-      lv_name       TYPE ddobjname,
-      lv_index      TYPE i,
       ls_trnspacett TYPE trnspacett,
       lt_nspc_texts TYPE ty_nspc_texts,
       lt_i18n_langs TYPE TABLE OF langu.
@@ -315,9 +313,7 @@ CLASS zcl_abapgit_object_nspc IMPLEMENTATION.
 
     DATA:
       ls_nspc       TYPE ty_nspc,
-      ls_nspc_text  TYPE ty_nspc_text,
-      ls_trnspacet  TYPE trnspacet,
-      ls_trnspacett TYPE trnspacett.
+      ls_nspc_text  TYPE ty_nspc_text.
 
     SELECT SINGLE * FROM trnspacet INTO CORRESPONDING FIELDS OF ls_nspc
       WHERE namespace = ms_item-obj_name.
diff --git a/src/objects/zcl_abapgit_object_shlp.clas.abap b/src/objects/zcl_abapgit_object_shlp.clas.abap
index f72c4faeb..0c7f3ccb4 100644
--- a/src/objects/zcl_abapgit_object_shlp.clas.abap
+++ b/src/objects/zcl_abapgit_object_shlp.clas.abap
@@ -130,8 +130,7 @@ CLASS zcl_abapgit_object_shlp IMPLEMENTATION.
 
   METHOD zif_abapgit_object~jump.
 
-    jump_se11( iv_radio = 'RSRD1-SHMA'
-               iv_field = 'RSRD1-SHMA_VAL' ).
+    jump_se11( ).
 
   ENDMETHOD.
 
diff --git a/src/objects/zcl_abapgit_object_tabl.clas.abap b/src/objects/zcl_abapgit_object_tabl.clas.abap
index 1b4f22527..bbe611419 100644
--- a/src/objects/zcl_abapgit_object_tabl.clas.abap
+++ b/src/objects/zcl_abapgit_object_tabl.clas.abap
@@ -868,8 +868,7 @@ CLASS zcl_abapgit_object_tabl IMPLEMENTATION.
 
   METHOD zif_abapgit_object~jump.
 
-    jump_se11( iv_radio = 'RSRD1-DDTYPE'
-               iv_field = 'RSRD1-DDTYPE_VAL' ).
+    jump_se11( ).
 
   ENDMETHOD.
 
diff --git a/src/objects/zcl_abapgit_object_ttyp.clas.abap b/src/objects/zcl_abapgit_object_ttyp.clas.abap
index e8e133efd..f2bf526ce 100644
--- a/src/objects/zcl_abapgit_object_ttyp.clas.abap
+++ b/src/objects/zcl_abapgit_object_ttyp.clas.abap
@@ -147,8 +147,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TTYP IMPLEMENTATION.
 
   METHOD zif_abapgit_object~jump.
 
-    jump_se11( iv_radio = 'RSRD1-DDTYPE'
-               iv_field = 'RSRD1-DDTYPE_VAL' ).
+    jump_se11( ).
 
   ENDMETHOD.
 
diff --git a/src/objects/zcl_abapgit_object_type.clas.abap b/src/objects/zcl_abapgit_object_type.clas.abap
index ae2d36007..7e86658d4 100644
--- a/src/objects/zcl_abapgit_object_type.clas.abap
+++ b/src/objects/zcl_abapgit_object_type.clas.abap
@@ -199,8 +199,7 @@ CLASS zcl_abapgit_object_type IMPLEMENTATION.
 
 
   METHOD zif_abapgit_object~jump.
-    jump_se11( iv_radio = 'RSRD1-TYMA'
-               iv_field = 'RSRD1-TYMA_VAL' ).
+    jump_se11( ).
   ENDMETHOD.
 
 
diff --git a/src/objects/zcl_abapgit_object_view.clas.abap b/src/objects/zcl_abapgit_object_view.clas.abap
index 2c3e00c45..bb32c104c 100644
--- a/src/objects/zcl_abapgit_object_view.clas.abap
+++ b/src/objects/zcl_abapgit_object_view.clas.abap
@@ -254,8 +254,7 @@ CLASS zcl_abapgit_object_view IMPLEMENTATION.
 
       WHEN OTHERS.
 
-        jump_se11( iv_radio = 'RSRD1-VIMA'
-                   iv_field = 'RSRD1-VIMA_VAL' ).
+        jump_se11( ).
 
     ENDCASE.
 
diff --git a/src/objects/zcl_abapgit_objects_super.clas.abap b/src/objects/zcl_abapgit_objects_super.clas.abap
index 31549a9c1..987f224c0 100644
--- a/src/objects/zcl_abapgit_objects_super.clas.abap
+++ b/src/objects/zcl_abapgit_objects_super.clas.abap
@@ -40,9 +40,6 @@ CLASS zcl_abapgit_objects_super DEFINITION
       RAISING
         zcx_abapgit_exception .
     METHODS jump_se11
-      IMPORTING
-        !iv_radio TYPE string
-        !iv_field TYPE string
       RAISING
         zcx_abapgit_exception .
     METHODS exists_a_lock_entry_for
diff --git a/src/ui/zcl_abapgit_html_form.clas.abap b/src/ui/zcl_abapgit_html_form.clas.abap
index 8700c915c..c9554bf8b 100644
--- a/src/ui/zcl_abapgit_html_form.clas.abap
+++ b/src/ui/zcl_abapgit_html_form.clas.abap
@@ -267,6 +267,8 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION.
     ls_field-name  = iv_name.
     APPEND ls_field TO mt_fields.
 
+    ro_self = me.
+
   ENDMETHOD.