SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DOCT: consider all versions (#3161)

Browse Source 
* DOCT: consider version - use ZCL_ABAPGIT_LONGTEXTS

* fix linter

* switch to factory

* fix linter
This commit is contained in:
Christian Günter 2020-01-19 08:34:48 +01:00 committed by Lars Hvam
parent f02ae98504
commit 92f8ee0d62
4 changed files with 178 additions and 108 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
src/objects/zcl_abapgit_longtexts.clas.abap
View File

@ -1,15 +1,29 @@
CLASS zcl_abapgit_longtexts DEFINITION CLASS zcl_abapgit_longtexts DEFINITION
PUBLIC PUBLIC
FINAL CREATE PRIVATE
CREATE PUBLIC. GLOBAL FRIENDS zcl_abapgit_factory.
PUBLIC SECTION. PUBLIC SECTION.
CLASS-METHODS: METHODS:
constructor
IMPORTING
iv_longtexts_name TYPE string OPTIONAL,
changed_by
IMPORTING
iv_object_name TYPE sobj_name
iv_longtext_id TYPE dokil-id
it_dokil TYPE zif_abapgit_definitions=>tty_dokil OPTIONAL
RETURNING
VALUE(rv_user) TYPE xubname
RAISING
zcx_abapgit_exception,
serialize serialize
IMPORTING IMPORTING
iv_object_name TYPE sobj_name iv_object_name TYPE sobj_name
iv_longtext_id TYPE dokil-id iv_longtext_id TYPE dokil-id
it_dokil TYPE zif_abapgit_definitions=>tty_dokil it_dokil TYPE zif_abapgit_definitions=>tty_dokil OPTIONAL
io_xml TYPE REF TO zcl_abapgit_xml_output io_xml TYPE REF TO zcl_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception, zcx_abapgit_exception,
@ -37,15 +51,41 @@ CLASS zcl_abapgit_longtexts DEFINITION
END OF ty_longtext, END OF ty_longtext,
tty_longtexts TYPE STANDARD TABLE OF ty_longtext tty_longtexts TYPE STANDARD TABLE OF ty_longtext
WITH NON-UNIQUE DEFAULT KEY. WITH NON-UNIQUE DEFAULT KEY.
CONSTANTS: CONSTANTS:
c_longtexts_name TYPE string VALUE 'LONGTEXTS' ##NO_TEXT, c_longtexts_name TYPE string VALUE 'LONGTEXTS' ##NO_TEXT,
c_docu_state_active TYPE dokstate VALUE 'A' ##NO_TEXT. c_docu_state_active TYPE dokstate VALUE 'A' ##NO_TEXT.
DATA:
mv_longtexts_name TYPE string.
METHODS:
read
IMPORTING
iv_object_name TYPE sobj_name
iv_longtext_id TYPE dokil-id
it_dokil TYPE zif_abapgit_definitions=>tty_dokil
RETURNING
VALUE(rt_longtexts) TYPE tty_longtexts
RAISING
zcx_abapgit_exception.
ENDCLASS. ENDCLASS.
CLASS ZCL_ABAPGIT_LONGTEXTS IMPLEMENTATION. CLASS zcl_abapgit_longtexts IMPLEMENTATION.
METHOD constructor.
IF iv_longtexts_name IS NOT INITIAL.
mv_longtexts_name = iv_longtexts_name.
ELSE.
mv_longtexts_name = c_longtexts_name.
ENDIF.
ENDMETHOD.
METHOD delete. METHOD delete.
@ -56,7 +96,7 @@ CLASS ZCL_ABAPGIT_LONGTEXTS IMPLEMENTATION.
SELECT * FROM dokil SELECT * FROM dokil
INTO TABLE lt_dokil INTO TABLE lt_dokil
WHERE id = iv_longtext_id WHERE id = iv_longtext_id
AND object = iv_longtext_id. AND object = iv_object_name.
LOOP AT lt_dokil ASSIGNING <ls_dokil>. LOOP AT lt_dokil ASSIGNING <ls_dokil>.
@ -87,7 +127,7 @@ CLASS ZCL_ABAPGIT_LONGTEXTS IMPLEMENTATION.
io_xml->read( io_xml->read(
EXPORTING EXPORTING
iv_name = c_longtexts_name iv_name = mv_longtexts_name
CHANGING CHANGING
cg_data = lt_longtexts ). cg_data = lt_longtexts ).
@ -112,13 +152,42 @@ CLASS ZCL_ABAPGIT_LONGTEXTS IMPLEMENTATION.
METHOD serialize. METHOD serialize.
DATA: lt_longtexts TYPE tty_longtexts.
lt_longtexts = read( iv_object_name = iv_object_name
iv_longtext_id = iv_longtext_id
it_dokil = it_dokil ).
io_xml->add( iv_name = mv_longtexts_name
ig_data = lt_longtexts ).
ENDMETHOD.
METHOD changed_by.
DATA: lt_longtexts TYPE tty_longtexts.
FIELD-SYMBOLS: <ls_longtext> TYPE ty_longtext.
lt_longtexts = read( iv_object_name = iv_object_name
iv_longtext_id = iv_longtext_id
it_dokil = it_dokil ).
READ TABLE lt_longtexts INDEX 1 ASSIGNING <ls_longtext>.
IF sy-subrc = 0.
rv_user = <ls_longtext>-head-tdluser.
ENDIF.
ENDMETHOD.
METHOD read.
DATA: ls_longtext TYPE ty_longtext, DATA: ls_longtext TYPE ty_longtext,
lt_longtexts TYPE tty_longtexts,
lt_dokil TYPE zif_abapgit_definitions=>tty_dokil. lt_dokil TYPE zif_abapgit_definitions=>tty_dokil.
FIELD-SYMBOLS: <ls_dokil> LIKE LINE OF lt_dokil. FIELD-SYMBOLS: <ls_dokil> LIKE LINE OF lt_dokil.
IF lines( it_dokil ) > 0. IF lines( it_dokil ) > 0.
lt_dokil = it_dokil. lt_dokil = it_dokil.
@ -128,7 +197,8 @@ CLASS ZCL_ABAPGIT_LONGTEXTS IMPLEMENTATION.
SELECT * FROM dokil SELECT * FROM dokil
INTO TABLE lt_dokil INTO TABLE lt_dokil
WHERE id = iv_longtext_id WHERE id = iv_longtext_id
AND object = iv_object_name. AND object = iv_object_name
ORDER BY PRIMARY KEY.
ELSE. ELSE.
@ -164,12 +234,10 @@ CLASS ZCL_ABAPGIT_LONGTEXTS IMPLEMENTATION.
ls_longtext-head-tdldate, ls_longtext-head-tdldate,
ls_longtext-head-tdltime. ls_longtext-head-tdltime.
INSERT ls_longtext INTO TABLE lt_longtexts. INSERT ls_longtext INTO TABLE rt_longtexts.
ENDLOOP. ENDLOOP.
io_xml->add( iv_name = c_longtexts_name
ig_data = lt_longtexts ).
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

108
src/objects/zcl_abapgit_object_doct.clas.abap
View File

@ -3,100 +3,72 @@ CLASS zcl_abapgit_object_doct DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
PUBLIC SECTION. PUBLIC SECTION.
INTERFACES zif_abapgit_object. INTERFACES zif_abapgit_object.
ALIASES mo_files FOR zif_abapgit_object~mo_files. ALIASES mo_files FOR zif_abapgit_object~mo_files.
METHODS:
constructor
IMPORTING
is_item TYPE zif_abapgit_definitions=>ty_item
iv_language TYPE spras.
PROTECTED SECTION. PROTECTED SECTION.
PRIVATE SECTION. PRIVATE SECTION.
CONSTANTS: c_id TYPE dokhl-id VALUE 'TX', CONSTANTS:
c_typ TYPE dokhl-typ VALUE 'E', c_id TYPE dokhl-id VALUE 'TX',
c_version TYPE dokhl-dokversion VALUE '0001',
c_name TYPE string VALUE 'DOC'. c_name TYPE string VALUE 'DOC'.
TYPES: BEGIN OF ty_data, DATA:
mo_longtexts TYPE REF TO zcl_abapgit_longtexts.
TYPES:
BEGIN OF ty_data,
doctitle TYPE dsyst-doktitle, doctitle TYPE dsyst-doktitle,
head TYPE thead, head TYPE thead,
lines TYPE tline_tab, lines TYPE tline_tab,
END OF ty_data. END OF ty_data.
METHODS: read
RETURNING VALUE(rs_data) TYPE ty_data.
ENDCLASS. ENDCLASS.
CLASS ZCL_ABAPGIT_OBJECT_DOCT IMPLEMENTATION. CLASS zcl_abapgit_object_doct IMPLEMENTATION.
METHOD constructor.
METHOD read. super->constructor(
is_item = is_item
iv_language = iv_language ).
DATA: lv_object TYPE dokhl-object. mo_longtexts = zcl_abapgit_factory=>get_longtexts( c_name ).
lv_object = ms_item-obj_name.
CALL FUNCTION 'DOCU_READ'
EXPORTING
id = c_id
langu = mv_language
object = lv_object
typ = c_typ
version = c_version
IMPORTING
doktitle = rs_data-doctitle
head = rs_data-head
TABLES
line = rs_data-lines.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_object~changed_by. METHOD zif_abapgit_object~changed_by.
rv_user = read( )-head-tdluser.
rv_user = mo_longtexts->changed_by(
iv_object_name = ms_item-obj_name
iv_longtext_id = c_id ).
IF rv_user IS INITIAL. IF rv_user IS INITIAL.
rv_user = c_user_unknown. rv_user = c_user_unknown.
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_object~delete. METHOD zif_abapgit_object~delete.
DATA: lv_object TYPE dokhl-object. mo_longtexts->delete(
iv_object_name = ms_item-obj_name
iv_longtext_id = c_id ).
lv_object = ms_item-obj_name.
CALL FUNCTION 'DOCU_DEL'
EXPORTING
id = c_id
langu = mv_language
object = lv_object
typ = c_typ
EXCEPTIONS
ret_code = 1
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'error from DOCU_DEL' ).
ENDIF.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_object~deserialize. METHOD zif_abapgit_object~deserialize.
DATA: ls_data TYPE ty_data. mo_longtexts->deserialize(
io_xml = io_xml
iv_master_language = mv_language ).
io_xml->read( EXPORTING iv_name = c_name
CHANGING cg_data = ls_data ).
CALL FUNCTION 'DOCU_UPDATE'
EXPORTING
head = ls_data-head
state = 'A'
typ = c_typ
version = c_version
TABLES
line = ls_data-lines.
tadir_insert( iv_package ). tadir_insert( iv_package ).
@ -195,22 +167,10 @@ CLASS ZCL_ABAPGIT_OBJECT_DOCT IMPLEMENTATION.
METHOD zif_abapgit_object~serialize. METHOD zif_abapgit_object~serialize.
DATA: ls_data TYPE ty_data. mo_longtexts->serialize(
iv_object_name = ms_item-obj_name
iv_longtext_id = c_id
ls_data = read( ). io_xml = io_xml ).
CLEAR: ls_data-head-tdfuser,
ls_data-head-tdfreles,
ls_data-head-tdfdate,
ls_data-head-tdftime,
ls_data-head-tdluser,
ls_data-head-tdlreles,
ls_data-head-tdldate,
ls_data-head-tdltime.
io_xml->add( iv_name = c_name
ig_data = ls_data ).
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

11
src/objects/zcl_abapgit_objects_super.clas.abap
View File

@ -84,8 +84,6 @@ CLASS zcl_abapgit_objects_super DEFINITION PUBLIC ABSTRACT.
VALUE(rv_active) TYPE abap_bool VALUE(rv_active) TYPE abap_bool
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PRIVATE SECTION.
ENDCLASS. ENDCLASS.
@ -163,7 +161,8 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
METHOD delete_longtexts. METHOD delete_longtexts.
zcl_abapgit_longtexts=>delete( iv_longtext_id = iv_longtext_id zcl_abapgit_factory=>get_longtexts( )->delete(
iv_longtext_id = iv_longtext_id
iv_object_name = ms_item-obj_name ). iv_object_name = ms_item-obj_name ).
ENDMETHOD. ENDMETHOD.
@ -171,7 +170,8 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
METHOD deserialize_longtexts. METHOD deserialize_longtexts.
zcl_abapgit_longtexts=>deserialize( io_xml = io_xml zcl_abapgit_factory=>get_longtexts( )->deserialize(
io_xml = io_xml
iv_master_language = mv_language ). iv_master_language = mv_language ).
ENDMETHOD. ENDMETHOD.
@ -301,7 +301,8 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
METHOD serialize_longtexts. METHOD serialize_longtexts.
zcl_abapgit_longtexts=>serialize( iv_object_name = ms_item-obj_name zcl_abapgit_factory=>get_longtexts( )->serialize(
iv_object_name = ms_item-obj_name
iv_longtext_id = iv_longtext_id iv_longtext_id = iv_longtext_id
it_dokil = it_dokil it_dokil = it_dokil
io_xml = io_xml ). io_xml = io_xml ).

43
src/zcl_abapgit_factory.clas.abap
View File

@ -34,6 +34,12 @@ CLASS zcl_abapgit_factory DEFINITION
CLASS-METHODS get_environment CLASS-METHODS get_environment
RETURNING RETURNING
VALUE(ro_environment) TYPE REF TO zif_abapgit_environment . VALUE(ro_environment) TYPE REF TO zif_abapgit_environment .
CLASS-METHODS get_longtexts
IMPORTING
iv_longtexts_name TYPE string OPTIONAL
RETURNING
VALUE(ro_longtexts) TYPE REF TO zcl_abapgit_longtexts.
PROTECTED SECTION. PROTECTED SECTION.
PRIVATE SECTION. PRIVATE SECTION.
@ -54,17 +60,26 @@ CLASS zcl_abapgit_factory DEFINITION
tty_code_inspector TYPE HASHED TABLE OF ty_code_inspector tty_code_inspector TYPE HASHED TABLE OF ty_code_inspector
WITH UNIQUE KEY package . WITH UNIQUE KEY package .
TYPES:
BEGIN OF ty_longtexts,
longtexts_name TYPE string,
instance TYPE REF TO zcl_abapgit_longtexts,
END OF ty_longtexts .
TYPES:
tty_longtexts TYPE HASHED TABLE OF ty_longtexts
WITH UNIQUE KEY longtexts_name .
CLASS-DATA gi_tadir TYPE REF TO zif_abapgit_tadir . CLASS-DATA gi_tadir TYPE REF TO zif_abapgit_tadir .
CLASS-DATA gt_sap_package TYPE tty_sap_package . CLASS-DATA gt_sap_package TYPE tty_sap_package .
CLASS-DATA gt_code_inspector TYPE tty_code_inspector . CLASS-DATA gt_code_inspector TYPE tty_code_inspector .
CLASS-DATA gi_stage_logic TYPE REF TO zif_abapgit_stage_logic . CLASS-DATA gi_stage_logic TYPE REF TO zif_abapgit_stage_logic .
CLASS-DATA gi_cts_api TYPE REF TO zif_abapgit_cts_api . CLASS-DATA gi_cts_api TYPE REF TO zif_abapgit_cts_api .
CLASS-DATA go_environment TYPE REF TO zif_abapgit_environment . CLASS-DATA go_environment TYPE REF TO zif_abapgit_environment .
CLASS-DATA gt_longtexts TYPE tty_longtexts.
ENDCLASS. ENDCLASS.
CLASS ZCL_ABAPGIT_FACTORY IMPLEMENTATION. CLASS zcl_abapgit_factory IMPLEMENTATION.
METHOD get_branch_overview. METHOD get_branch_overview.
@ -165,4 +180,30 @@ CLASS ZCL_ABAPGIT_FACTORY IMPLEMENTATION.
ri_tadir = gi_tadir. ri_tadir = gi_tadir.
ENDMETHOD. ENDMETHOD.
METHOD get_longtexts.
DATA: ls_longtext TYPE ty_longtexts.
FIELD-SYMBOLS: <ls_longtext> TYPE ty_longtexts.
READ TABLE gt_longtexts ASSIGNING <ls_longtext>
WITH TABLE KEY longtexts_name = iv_longtexts_name.
IF sy-subrc <> 0.
ls_longtext-longtexts_name = iv_longtexts_name.
CREATE OBJECT ls_longtext-instance
EXPORTING
iv_longtexts_name = iv_longtexts_name.
INSERT ls_longtext
INTO TABLE gt_longtexts
ASSIGNING <ls_longtext>.
ENDIF.
ro_longtexts = <ls_longtext>-instance.
ENDMETHOD.
ENDCLASS. ENDCLASS.