Refactoring of CORR_INSERT and adjustment for object types (#2392)

* Refactoring of CORR_INSERT and adjustment for object types

* CORR_INSERT without CORR_CHECK

* Z exception

src/objects/zcl_abapgit_object_doma.clas.abap

@@ -265,7 +265,7 @@ CLASS ZCL_ABAPGIT_OBJECT_DOMA IMPLEMENTATION.
     io_xml->read( EXPORTING iv_name = 'DD07V_TAB'
                   CHANGING cg_data = lt_dd07v ).
 
-    corr_insert( iv_package ).
+    corr_insert( iv_package = iv_package iv_object_class = 'DICT' ).
 
     lv_name = ms_item-obj_name. " type conversion
 

src/objects/zcl_abapgit_object_dtel.clas.abap

@@ -194,7 +194,7 @@ CLASS zcl_abapgit_object_dtel IMPLEMENTATION.
     io_xml->read( EXPORTING iv_name = 'TPARA'
                   CHANGING cg_data = ls_tpara ).
 
-    corr_insert( iv_package ).
+    corr_insert( iv_package = iv_package iv_object_class = 'DICT' ).
 
     lv_name = ms_item-obj_name. " type conversion
 

src/objects/zcl_abapgit_object_enqu.clas.abap

@@ -72,7 +72,7 @@ CLASS zcl_abapgit_object_enqu IMPLEMENTATION.
     io_xml->read( EXPORTING iv_name = 'DD27P_TABLE'
                   CHANGING cg_data = lt_dd27p ).
 
-    corr_insert( iv_package ).
+    corr_insert( iv_package = iv_package iv_object_class = 'DICT' ).
 
     lv_name = ms_item-obj_name.
 

src/objects/zcl_abapgit_object_msag.clas.abap

@@ -335,20 +335,7 @@ CLASS ZCL_ABAPGIT_OBJECT_MSAG IMPLEMENTATION.
     io_xml->read( EXPORTING iv_name = 'T100'
                   CHANGING cg_data = lt_t100 ).
 
-    CALL FUNCTION 'RS_CORR_INSERT'
+    corr_insert( iv_package ).
-      EXPORTING
-        global_lock         = abap_true
-        devclass            = iv_package
-        object              = ls_t100a-arbgb
-        object_class        = 'T100'
-        mode                = 'INSERT'
-      EXCEPTIONS
-        cancelled           = 01
-        permission_failure  = 02
-        unknown_objectclass = 03.
-    IF sy-subrc <> 0.
-      zcx_abapgit_exception=>raise( 'Error from RS_CORR_INSERT' ).
-    ENDIF.
 
     SELECT * FROM t100u INTO TABLE lt_before
       WHERE arbgb = ls_t100a-arbgb ORDER BY msgnr. "#EC CI_GENBUFF "#EC CI_BYPASS

src/objects/zcl_abapgit_object_shlp.clas.abap

@@ -165,7 +165,7 @@ CLASS zcl_abapgit_object_shlp IMPLEMENTATION.
     io_xml->read( EXPORTING iv_name = 'DD33V_TABLE'
                   CHANGING cg_data = lt_dd33v ).
 
-    corr_insert( iv_package ).
+    corr_insert( iv_package = iv_package iv_object_class = 'DICT' ).
 
     lv_name = ms_item-obj_name.
 

src/objects/zcl_abapgit_object_tabl.clas.abap

@@ -524,7 +524,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL IMPLEMENTATION.
       io_xml->read( EXPORTING iv_name = 'DD36M'
                     CHANGING cg_data = lt_dd36m ).
 
-      corr_insert( iv_package ).
+      corr_insert( iv_package = iv_package iv_object_class = 'DICT' ).
 
       lv_name = ms_item-obj_name. " type conversion
 

src/objects/zcl_abapgit_object_ttyp.clas.abap

@@ -150,7 +150,7 @@ CLASS zcl_abapgit_object_ttyp IMPLEMENTATION.
     io_xml->read( EXPORTING iv_name = 'DD43V'
                   CHANGING cg_data = lt_dd43v ).
 
-    corr_insert( iv_package ).
+    corr_insert( iv_package = iv_package iv_object_class = 'DICT' ).
 
     lv_name = ms_item-obj_name. " type conversion
 

src/objects/zcl_abapgit_object_view.clas.abap

@@ -77,7 +77,7 @@ CLASS zcl_abapgit_object_view IMPLEMENTATION.
     io_xml->read( EXPORTING iv_name = 'DD28V_TABLE'
                   CHANGING cg_data = lt_dd28v ).
 
-    corr_insert( iv_package ).
+    corr_insert( iv_package = iv_package iv_object_class = 'DICT' ).
 
     lv_name = ms_item-obj_name. " type conversion
 

src/objects/zcl_abapgit_objects_super.clas.abap

@@ -37,6 +37,7 @@ CLASS zcl_abapgit_objects_super DEFINITION PUBLIC ABSTRACT.
     METHODS corr_insert
       IMPORTING
         !iv_package TYPE devclass
+        !iv_object_class TYPE any OPTIONAL
       RAISING
         zcx_abapgit_exception .
     METHODS tadir_insert
@@ -141,28 +142,38 @@ CLASS ZCL_ABAPGIT_OBJECTS_SUPER IMPLEMENTATION.
 
   METHOD corr_insert.
 
-    DATA: ls_object TYPE ddenqs.
+    DATA: lv_object       TYPE string,
+          lv_object_class TYPE string.
 
-
+    IF iv_object_class IS NOT INITIAL.
-    ls_object-objtype = ms_item-obj_type.
+      lv_object_class = iv_object_class.
-    ls_object-objname = ms_item-obj_name.
+      IF iv_object_class = 'DICT'.
+        CONCATENATE ms_item-obj_type ms_item-obj_name INTO lv_object.
+      ELSE.
+        lv_object = ms_item-obj_name.
+      ENDIF.
+    ELSE.
+      lv_object_class = ms_item-obj_type.
+      lv_object       = ms_item-obj_name.
+    ENDIF.
 
     CALL FUNCTION 'RS_CORR_INSERT'
       EXPORTING
-        object              = ls_object
+        object              = lv_object
-        object_class        = 'DICT'
+        object_class        = lv_object_class
         devclass            = iv_package
         master_language     = mv_language
-        mode                = 'INSERT'
+        global_lock         = abap_true
+        author              = sy-uname
+        mode                = 'I'
+        suppress_dialog     = abap_true
       EXCEPTIONS
         cancelled           = 1
         permission_failure  = 2
         unknown_objectclass = 3
         OTHERS              = 4.
-    IF sy-subrc = 1.
+    IF sy-subrc <> 0.
-      zcx_abapgit_exception=>raise( 'Cancelled' ).
+      zcx_abapgit_exception=>raise_t100( ).
-    ELSEIF sy-subrc <> 0.
-      zcx_abapgit_exception=>raise( 'error from RS_CORR_INSERT' ).
     ENDIF.
 
   ENDMETHOD.