Terminology: Inclusive Language - Part 4 (#4432)

* Terminology: Inclusive Language - Part 4

Continue change of terminology (#4043)

* Service

* Language

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2021-01-21 11:18:03 -05:00 committed by GitHub
parent 4c07c33c21
commit 978b7a4a57
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 56 additions and 55 deletions

View File

@ -19,7 +19,7 @@ CLASS zcl_abapgit_performance_test DEFINITION
METHODS:
constructor IMPORTING iv_package TYPE devclass
iv_include_sub_packages TYPE abap_bool DEFAULT abap_true
iv_serialize_master_lang_only TYPE abap_bool DEFAULT abap_true,
iv_main_language_only TYPE abap_bool DEFAULT abap_true,
set_object_type_filter IMPORTING it_object_type_range TYPE zif_abapgit_definitions=>ty_object_type_range,
set_object_name_filter IMPORTING it_object_name_range TYPE zif_abapgit_definitions=>ty_object_name_range,
get_object_type_filter RETURNING VALUE(rt_object_type_range) TYPE zif_abapgit_definitions=>ty_object_type_range,
@ -34,7 +34,7 @@ CLASS zcl_abapgit_performance_test DEFINITION
DATA:
mv_package TYPE devclass,
mv_include_sub_packages TYPE abap_bool,
mv_serialize_master_lang_only TYPE abap_bool,
mv_main_language_only TYPE abap_bool,
BEGIN OF ms_filter_parameters,
object_type_range TYPE zif_abapgit_definitions=>ty_object_type_range,
object_name_range TYPE zif_abapgit_definitions=>ty_object_name_range,
@ -44,13 +44,13 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_PERFORMANCE_TEST IMPLEMENTATION.
CLASS zcl_abapgit_performance_test IMPLEMENTATION.
METHOD constructor.
mv_package = iv_package.
mv_include_sub_packages = iv_include_sub_packages.
mv_serialize_master_lang_only = iv_serialize_master_lang_only.
mv_main_language_only = iv_main_language_only.
ENDMETHOD.
@ -92,7 +92,7 @@ CLASS ZCL_ABAPGIT_PERFORMANCE_TEST IMPLEMENTATION.
CREATE OBJECT lo_serializer
EXPORTING
iv_serialize_master_lang_only = mv_serialize_master_lang_only.
iv_serialize_master_lang_only = mv_main_language_only.
LOOP AT lt_tadir ASSIGNING <ls_tadir>.
INSERT <ls_tadir> INTO TABLE lt_tadir_single.

View File

@ -24,10 +24,10 @@ CLASS zcl_abapgit_gui_page_addofflin DEFINITION
CONSTANTS:
BEGIN OF c_id,
url TYPE string VALUE 'url',
package TYPE string VALUE 'package',
folder_logic TYPE string VALUE 'folder_logic',
master_lang_only TYPE string VALUE 'master_lang_only',
url TYPE string VALUE 'url',
package TYPE string VALUE 'package',
folder_logic TYPE string VALUE 'folder_logic',
main_lang_only TYPE string VALUE 'main_lang_only',
END OF c_id .
CONSTANTS:
@ -114,7 +114,7 @@ CLASS zcl_abapgit_gui_page_addofflin IMPLEMENTATION.
iv_label = 'Full'
iv_value = zif_abapgit_dot_abapgit=>c_folder_logic-full
)->checkbox(
iv_name = c_id-master_lang_only
iv_name = c_id-main_lang_only
iv_label = 'Serialize Main Language Only'
iv_hint = 'Ignore translations, serialize just main language'
)->command(

View File

@ -30,7 +30,7 @@ CLASS zcl_abapgit_gui_page_addonline DEFINITION
display_name TYPE string VALUE 'display_name',
folder_logic TYPE string VALUE 'folder_logic',
ignore_subpackages TYPE string VALUE 'ignore_subpackages',
master_lang_only TYPE string VALUE 'master_lang_only',
main_lang_only TYPE string VALUE 'main_lang_only',
END OF c_id.
CONSTANTS:
@ -133,7 +133,7 @@ CLASS zcl_abapgit_gui_page_addonline IMPLEMENTATION.
iv_label = 'Ignore Subpackages'
iv_hint = 'Synchronize root package only'
)->checkbox(
iv_name = c_id-master_lang_only
iv_name = c_id-main_lang_only
iv_label = 'Serialize Main Language Only'
iv_hint = 'Ignore translations, serialize just main language'
)->command(

View File

@ -28,7 +28,7 @@ CLASS zcl_abapgit_gui_page_sett_repo DEFINITION
CONSTANTS:
BEGIN OF c_id,
dot TYPE string VALUE 'dot',
master_language TYPE string VALUE 'master_language',
main_language TYPE string VALUE 'main_language',
i18n_langs TYPE string VALUE 'i18n_langs',
starting_folder TYPE string VALUE 'starting_folder',
folder_logic TYPE string VALUE 'folder_logic',
@ -72,7 +72,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_GUI_PAGE_SETT_REPO IMPLEMENTATION.
CLASS zcl_abapgit_gui_page_sett_repo IMPLEMENTATION.
METHOD constructor.
@ -118,14 +118,14 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SETT_REPO IMPLEMENTATION.
iv_label = 'Repository Settings (.abapgit.xml)'
iv_hint = 'Settings stored in root folder in .abapgit.xml file'
)->text(
iv_name = c_id-master_language
iv_name = c_id-main_language
iv_label = 'Main Language'
iv_hint = 'Main language of repository (cannot be changed)'
iv_readonly = abap_true
)->text(
iv_name = c_id-i18n_langs
iv_label = 'Serialize translations (experimental LXE approach)'
iv_hint = 'Comma separate 2-letter iso lang codes e.g. "de,es,..." - should not include main language'
iv_label = 'Serialize Translations (experimental LXE approach)'
iv_hint = 'Comma-separate 2-letter ISO language codes e.g. "DE,ES,..." - should not include main language'
)->radio(
iv_name = c_id-folder_logic
iv_default_value = zif_abapgit_dot_abapgit=>c_folder_logic-prefix
@ -195,7 +195,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SETT_REPO IMPLEMENTATION.
ENDIF.
mo_form_data->set(
iv_key = c_id-master_language
iv_key = c_id-main_language
iv_val = |{ ls_dot-master_language } ({ lv_language })| ).
mo_form_data->set(
iv_key = c_id-i18n_langs

View File

@ -89,7 +89,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
CLASS zcl_abapgit_popups IMPLEMENTATION.
METHOD add_field.
@ -833,12 +833,12 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
<ls_field>-value = cv_include_sub_packages.
APPEND INITIAL LINE TO lt_fields ASSIGNING <ls_field>.
<ls_field>-name = 'MASTER_LANG_ONLY'.
<ls_field>-name = 'MAIN_LANG_ONLY'.
<ls_field>-only_parameter = abap_true.
<ls_field>-ddic_tabname = 'TVDIR'.
<ls_field>-ddic_fieldname = 'FLAG'.
<ls_field>-text = 'Main language only'.
<ls_field>-value = cv_serialize_master_lang_only.
<ls_field>-value = cv_main_language_only.
popup_get_from_free_selections(
EXPORTING
@ -857,8 +857,8 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
et_object_name_filter = <ls_field>-value_range.
WHEN 'INCLUDE_SUB_PACKAGES'.
cv_include_sub_packages = boolc( <ls_field>-value IS NOT INITIAL ).
WHEN 'MASTER_LANG_ONLY'.
cv_serialize_master_lang_only = boolc( <ls_field>-value IS NOT INITIAL ).
WHEN 'MAIN_LANG_ONLY'.
cv_main_language_only = boolc( <ls_field>-value IS NOT INITIAL ).
ENDCASE.
ENDLOOP.
ENDMETHOD.

View File

@ -32,7 +32,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_SERVICES_BASIS IMPLEMENTATION.
CLASS zcl_abapgit_services_basis IMPLEMENTATION.
METHOD create_package.
@ -122,19 +122,19 @@ CLASS ZCL_ABAPGIT_SERVICES_BASIS IMPLEMENTATION.
METHOD run_performance_test.
DATA: lo_performance TYPE REF TO zcl_abapgit_performance_test,
lv_package TYPE devclass,
lv_include_sub_packages TYPE abap_bool VALUE abap_true,
lv_serialize_master_lang_only TYPE abap_bool VALUE abap_true,
lt_object_type_filter TYPE zif_abapgit_definitions=>ty_object_type_range,
lt_object_name_filter TYPE zif_abapgit_definitions=>ty_object_name_range,
lt_result TYPE zcl_abapgit_performance_test=>ty_results,
lo_alv TYPE REF TO cl_salv_table,
lx_salv_error TYPE REF TO cx_salv_error,
lv_current_repo TYPE zif_abapgit_persistence=>ty_value,
lo_runtime_column TYPE REF TO cl_salv_column,
lo_seconds_column TYPE REF TO cl_salv_column,
li_popups TYPE REF TO zif_abapgit_popups.
DATA: lo_performance TYPE REF TO zcl_abapgit_performance_test,
lv_package TYPE devclass,
lv_include_sub_packages TYPE abap_bool VALUE abap_true,
lv_main_language_only TYPE abap_bool VALUE abap_true,
lt_object_type_filter TYPE zif_abapgit_definitions=>ty_object_type_range,
lt_object_name_filter TYPE zif_abapgit_definitions=>ty_object_name_range,
lt_result TYPE zcl_abapgit_performance_test=>ty_results,
lo_alv TYPE REF TO cl_salv_table,
lx_salv_error TYPE REF TO cx_salv_error,
lv_current_repo TYPE zif_abapgit_persistence=>ty_value,
lo_runtime_column TYPE REF TO cl_salv_column,
lo_seconds_column TYPE REF TO cl_salv_column,
li_popups TYPE REF TO zif_abapgit_popups.
TRY.
lv_current_repo = zcl_abapgit_persistence_user=>get_instance( )->get_repo_show( ).
@ -147,18 +147,18 @@ CLASS ZCL_ABAPGIT_SERVICES_BASIS IMPLEMENTATION.
li_popups = zcl_abapgit_ui_factory=>get_popups( ).
li_popups->popup_perf_test_parameters(
IMPORTING
et_object_type_filter = lt_object_type_filter
et_object_name_filter = lt_object_name_filter
et_object_type_filter = lt_object_type_filter
et_object_name_filter = lt_object_name_filter
CHANGING
cv_package = lv_package
cv_include_sub_packages = lv_include_sub_packages
cv_serialize_master_lang_only = lv_serialize_master_lang_only ).
cv_package = lv_package
cv_include_sub_packages = lv_include_sub_packages
cv_main_language_only = lv_main_language_only ).
CREATE OBJECT lo_performance
EXPORTING
iv_package = lv_package
iv_include_sub_packages = lv_include_sub_packages
iv_serialize_master_lang_only = lv_serialize_master_lang_only.
iv_package = lv_package
iv_include_sub_packages = lv_include_sub_packages
iv_main_language_only = lv_main_language_only.
lo_performance->set_object_type_filter( lt_object_type_filter ).

View File

@ -1,9 +1,9 @@
INTERFACE zif_abapgit_popups
PUBLIC .
TYPES:
ty_sval_tt TYPE STANDARD TABLE OF sval WITH DEFAULT KEY.
TYPES:
ty_sval_tt TYPE STANDARD TABLE OF sval WITH DEFAULT KEY .
TYPES:
BEGIN OF ty_popup, " TODO remove, use zif_abapgit_services_repo=>ty_repo_params instead
url TYPE string,
@ -73,7 +73,7 @@ INTERFACE zif_abapgit_popups
RETURNING
VALUE(rs_popup) TYPE ty_popup
RAISING
zcx_abapgit_exception ##NO_TEXT.
zcx_abapgit_exception ##NO_TEXT.
METHODS popup_to_confirm
IMPORTING
!iv_titlebar TYPE clike
@ -160,12 +160,12 @@ INTERFACE zif_abapgit_popups
zcx_abapgit_exception .
METHODS popup_perf_test_parameters
EXPORTING
!et_object_type_filter TYPE zif_abapgit_definitions=>ty_object_type_range
!et_object_name_filter TYPE zif_abapgit_definitions=>ty_object_name_range
!et_object_type_filter TYPE zif_abapgit_definitions=>ty_object_type_range
!et_object_name_filter TYPE zif_abapgit_definitions=>ty_object_name_range
CHANGING
!cv_package TYPE devclass
!cv_include_sub_packages TYPE abap_bool
!cv_serialize_master_lang_only TYPE abap_bool
!cv_package TYPE devclass
!cv_include_sub_packages TYPE abap_bool
!cv_main_language_only TYPE abap_bool
RAISING
zcx_abapgit_exception .
ENDINTERFACE.

View File

@ -1,7 +1,7 @@
*----------------------------------------------------------------------*
* This helper class is used to set and restore the current language.
* As some of the SAP functions used rely on SY-LANGU containing the
* master language, this class is used to temporarily change and then
* main language, this class is used to temporarily change and then
* restore the value of SY-LANGU.
*----------------------------------------------------------------------*
CLASS zcl_abapgit_language DEFINITION
@ -15,6 +15,7 @@ CLASS zcl_abapgit_language DEFINITION
CLASS-METHODS set_current_language
IMPORTING
!iv_language TYPE langu .
PROTECTED SECTION.
PRIVATE SECTION.
CLASS-DATA gv_login_language TYPE langu .
@ -22,7 +23,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_LANGUAGE IMPLEMENTATION.
CLASS zcl_abapgit_language IMPLEMENTATION.
METHOD class_constructor.