SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

code inspector fixes (#1131)

Browse Source 
* code inspector fixes

* more
This commit is contained in:
Lars Hvam 2018-01-13 10:49:47 +01:00 committed by GitHub
parent 436a03936a
commit 97b5a3d143
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
31 changed files with 136 additions and 150 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
src/git/zcl_abapgit_git_branch_list.clas.abap
View File

@ -80,19 +80,23 @@ CLASS zcl_abapgit_git_branch_list DEFINITION
RETURNING RETURNING
VALUE(rv_name) TYPE string . VALUE(rv_name) TYPE string .
PRIVATE SECTION. PRIVATE SECTION.
DATA mt_branches TYPE ty_git_branch_list_tt.
DATA mv_head_symref TYPE string. DATA mt_branches TYPE ty_git_branch_list_tt .
DATA mv_head_symref TYPE string .
CLASS-METHODS parse_branch_list CLASS-METHODS parse_branch_list
IMPORTING iv_data TYPE string IMPORTING
EXPORTING et_list TYPE ty_git_branch_list_tt !iv_data TYPE string
ev_head_symref TYPE string EXPORTING
RAISING zcx_abapgit_exception. !et_list TYPE ty_git_branch_list_tt
!ev_head_symref TYPE string
RAISING
zcx_abapgit_exception .
CLASS-METHODS parse_head_params CLASS-METHODS parse_head_params
IMPORTING iv_data TYPE string IMPORTING
EXPORTING ev_head_symref TYPE string. !iv_data TYPE string
RETURNING
VALUE(rv_head_symref) TYPE string .
ENDCLASS. ENDCLASS.
@ -133,11 +137,11 @@ CLASS ZCL_ABAPGIT_GIT_BRANCH_LIST IMPLEMENTATION.
METHOD get_branches_only. METHOD get_branches_only.
FIELD-SYMBOLS <branch> LIKE LINE OF mt_branches. FIELD-SYMBOLS <ls_branch> LIKE LINE OF mt_branches.
LOOP AT mt_branches ASSIGNING <branch>. LOOP AT mt_branches ASSIGNING <ls_branch>.
IF <branch>-type = c_type-branch. IF <ls_branch>-type = c_type-branch.
APPEND <branch> TO rt_branches. APPEND <ls_branch> TO rt_branches.
ENDIF. ENDIF.
ENDLOOP. ENDLOOP.
ENDMETHOD. "get_branches_only ENDMETHOD. "get_branches_only
@ -172,11 +176,11 @@ CLASS ZCL_ABAPGIT_GIT_BRANCH_LIST IMPLEMENTATION.
METHOD get_tags_only. METHOD get_tags_only.
FIELD-SYMBOLS <branch> LIKE LINE OF mt_branches. FIELD-SYMBOLS <ls_branch> LIKE LINE OF mt_branches.
LOOP AT mt_branches ASSIGNING <branch>. LOOP AT mt_branches ASSIGNING <ls_branch>.
IF <branch>-type = c_type-tag. IF <ls_branch>-type = c_type-tag.
APPEND <branch> TO rt_branches. APPEND <ls_branch> TO rt_branches.
ENDIF. ENDIF.
ENDLOOP. ENDLOOP.
ENDMETHOD. "get_tags_only ENDMETHOD. "get_tags_only
@ -245,9 +249,7 @@ CLASS ZCL_ABAPGIT_GIT_BRANCH_LIST IMPLEMENTATION.
lv_char = zcl_abapgit_git_utils=>get_null( ). lv_char = zcl_abapgit_git_utils=>get_null( ).
SPLIT lv_name AT lv_char INTO lv_name lv_head_params. SPLIT lv_name AT lv_char INTO lv_name lv_head_params.
parse_head_params( ev_head_symref = parse_head_params( lv_head_params ).
EXPORTING iv_data = lv_head_params
IMPORTING ev_head_symref = ev_head_symref ).
ELSEIF sy-tabix > 2 AND strlen( lv_data ) > 45. ELSEIF sy-tabix > 2 AND strlen( lv_data ) > 45.
lv_hash = lv_data+4. lv_hash = lv_data+4.
lv_name = lv_data+45. lv_name = lv_data+45.
@ -281,7 +283,7 @@ CLASS ZCL_ABAPGIT_GIT_BRANCH_LIST IMPLEMENTATION.
FIND FIRST OCCURRENCE OF REGEX '\ssymref=HEAD:([^\s]+)' IN iv_data RESULTS ls_match. FIND FIRST OCCURRENCE OF REGEX '\ssymref=HEAD:([^\s]+)' IN iv_data RESULTS ls_match.
READ TABLE ls_match-submatches INTO ls_submatch INDEX 1. READ TABLE ls_match-submatches INTO ls_submatch INDEX 1.
IF sy-subrc IS INITIAL. IF sy-subrc IS INITIAL.
ev_head_symref = iv_data+ls_submatch-offset(ls_submatch-length). rv_head_symref = iv_data+ls_submatch-offset(ls_submatch-length).
ENDIF. ENDIF.
ENDMETHOD. "parse_head_params ENDMETHOD. "parse_head_params

18
src/git/zcl_abapgit_git_pack.clas.abap
View File

@ -381,6 +381,15 @@ CLASS ZCL_ABAPGIT_GIT_PACK IMPLEMENTATION.
METHOD delta. METHOD delta.
CONSTANTS: lc_1 TYPE x VALUE '01',
lc_2 TYPE x VALUE '02',
lc_4 TYPE x VALUE '04',
lc_8 TYPE x VALUE '08',
lc_16 TYPE x VALUE '10',
lc_32 TYPE x VALUE '20',
lc_64 TYPE x VALUE '40',
lc_128 TYPE x VALUE '80'.
DEFINE _eat_byte. DEFINE _eat_byte.
lv_x = lv_delta(1). lv_x = lv_delta(1).
lv_delta = lv_delta+1. lv_delta = lv_delta+1.
@ -416,15 +425,6 @@ CLASS ZCL_ABAPGIT_GIT_PACK IMPLEMENTATION.
delta_header( CHANGING cv_delta = lv_delta ). delta_header( CHANGING cv_delta = lv_delta ).
delta_header( CHANGING cv_delta = lv_delta ). delta_header( CHANGING cv_delta = lv_delta ).
CONSTANTS: lc_1 TYPE x VALUE '01',
lc_2 TYPE x VALUE '02',
lc_4 TYPE x VALUE '04',
lc_8 TYPE x VALUE '08',
lc_16 TYPE x VALUE '10',
lc_32 TYPE x VALUE '20',
lc_64 TYPE x VALUE '40',
lc_128 TYPE x VALUE '80'.
WHILE xstrlen( lv_delta ) > 0. WHILE xstrlen( lv_delta ) > 0.
_eat_byte. _eat_byte.

2
src/persist/zcl_abapgit_persist_migrate.clas.abap
View File

@ -216,7 +216,7 @@ CLASS ZCL_ABAPGIT_PERSIST_MIGRATE IMPLEMENTATION.
CATCH zcx_abapgit_not_found cx_sy_conversion_no_number. CATCH zcx_abapgit_not_found cx_sy_conversion_no_number.
ENDTRY. ENDTRY.
lr_persist_settings->modify( io_settings = lr_settings ). lr_persist_settings->modify( lr_settings ).
TRY. TRY.
zcl_abapgit_persistence_db=>get_instance( )->delete( zcl_abapgit_persistence_db=>get_instance( )->delete(

16
src/ui/zcl_abapgit_html.clas.abap
View File

@ -151,7 +151,7 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION.
DATA: lv_type TYPE c, DATA: lv_type TYPE c,
lo_html TYPE REF TO zcl_abapgit_html. lo_html TYPE REF TO zcl_abapgit_html.
FIELD-SYMBOLS: <tab> TYPE string_table. FIELD-SYMBOLS: <lt_tab> TYPE string_table.
DESCRIBE FIELD iv_chunk TYPE lv_type. " Describe is faster than RTTI classes DESCRIBE FIELD iv_chunk TYPE lv_type. " Describe is faster than RTTI classes
@ -159,8 +159,8 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION.
WHEN 'C' OR 'g'. " Char or string WHEN 'C' OR 'g'. " Char or string
APPEND iv_chunk TO mt_buffer. APPEND iv_chunk TO mt_buffer.
WHEN 'h'. " Table WHEN 'h'. " Table
ASSIGN iv_chunk TO <tab>. " Assuming table of strings ! Will dump otherwise ASSIGN iv_chunk TO <lt_tab>. " Assuming table of strings ! Will dump otherwise
APPEND LINES OF <tab> TO mt_buffer. APPEND LINES OF <lt_tab> TO mt_buffer.
WHEN 'r'. " Object ref WHEN 'r'. " Object ref
ASSERT iv_chunk IS BOUND. " Dev mistake ASSERT iv_chunk IS BOUND. " Dev mistake
TRY. TRY.
@ -288,14 +288,14 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION.
DATA: ls_context TYPE ty_indent_context, DATA: ls_context TYPE ty_indent_context,
lt_temp TYPE string_table. lt_temp TYPE string_table.
FIELD-SYMBOLS: <line> LIKE LINE OF lt_temp, FIELD-SYMBOLS: <lv_line> LIKE LINE OF lt_temp,
<line_c> LIKE LINE OF lt_temp. <lv_line_c> LIKE LINE OF lt_temp.
ls_context-no_indent_jscss = iv_no_indent_jscss. ls_context-no_indent_jscss = iv_no_indent_jscss.
LOOP AT mt_buffer ASSIGNING <line>. LOOP AT mt_buffer ASSIGNING <lv_line>.
APPEND <line> TO lt_temp ASSIGNING <line_c>. APPEND <lv_line> TO lt_temp ASSIGNING <lv_line_c>.
indent_line( CHANGING cs_context = ls_context cv_line = <line_c> ). indent_line( CHANGING cs_context = ls_context cv_line = <lv_line_c> ).
ENDLOOP. ENDLOOP.
CONCATENATE LINES OF lt_temp INTO rv_html SEPARATED BY zif_abapgit_definitions=>gc_newline. CONCATENATE LINES OF lt_temp INTO rv_html SEPARATED BY zif_abapgit_definitions=>gc_newline.

42
src/ui/zcl_abapgit_html_toolbar.clas.abap
View File

@ -161,7 +161,7 @@ CLASS ZCL_ABAPGIT_HTML_TOOLBAR IMPLEMENTATION.
lv_aux TYPE string, lv_aux TYPE string,
lv_has_icons TYPE abap_bool. lv_has_icons TYPE abap_bool.
FIELD-SYMBOLS <item> LIKE LINE OF mt_items. FIELD-SYMBOLS <ls_item> LIKE LINE OF mt_items.
CREATE OBJECT ro_html. CREATE OBJECT ro_html.
@ -170,7 +170,7 @@ CLASS ZCL_ABAPGIT_HTML_TOOLBAR IMPLEMENTATION.
ENDIF. ENDIF.
" Check has icons or check boxes " Check has icons or check boxes
LOOP AT mt_items ASSIGNING <item> WHERE ico IS NOT INITIAL OR chk <> abap_undefined. LOOP AT mt_items ASSIGNING <ls_item> WHERE ico IS NOT INITIAL OR chk <> abap_undefined.
lv_has_icons = abap_true. lv_has_icons = abap_true.
lv_class = ' class="with-icons"'. lv_class = ' class="with-icons"'.
EXIT. EXIT.
@ -183,48 +183,48 @@ CLASS ZCL_ABAPGIT_HTML_TOOLBAR IMPLEMENTATION.
ro_html->add( |<ul{ lv_id }{ lv_class }>| ). ro_html->add( |<ul{ lv_id }{ lv_class }>| ).
" Render items " Render items
LOOP AT mt_items ASSIGNING <item>. LOOP AT mt_items ASSIGNING <ls_item>.
CLEAR: lv_class, lv_icon. CLEAR: lv_class, lv_icon.
IF <item>-typ = zif_abapgit_definitions=>gc_action_type-separator. IF <ls_item>-typ = zif_abapgit_definitions=>gc_action_type-separator.
ro_html->add( |<li class="separator">{ <item>-txt }</li>| ). ro_html->add( |<li class="separator">{ <ls_item>-txt }</li>| ).
CONTINUE. CONTINUE.
ENDIF. ENDIF.
IF lv_has_icons = abap_true. IF lv_has_icons = abap_true.
IF <item>-chk = abap_true. IF <ls_item>-chk = abap_true.
lv_icon = zcl_abapgit_html=>icon( 'check/blue' ). lv_icon = zcl_abapgit_html=>icon( 'check/blue' ).
lv_check = ' data-check="X"'. lv_check = ' data-check="X"'.
ELSEIF <item>-chk = abap_false. ELSEIF <ls_item>-chk = abap_false.
lv_icon = zcl_abapgit_html=>icon( 'check/grey' ). lv_icon = zcl_abapgit_html=>icon( 'check/grey' ).
lv_check = ' data-check=""'. lv_check = ' data-check=""'.
ELSE. " abap_undefined -> not a check box ELSE. " abap_undefined -> not a check box
lv_icon = zcl_abapgit_html=>icon( <item>-ico ). lv_icon = zcl_abapgit_html=>icon( <ls_item>-ico ).
ENDIF. ENDIF.
ENDIF. ENDIF.
IF <item>-cur = abap_true. IF <ls_item>-cur = abap_true.
lv_class = ' class="current-menu-item"'. lv_class = ' class="current-menu-item"'.
ENDIF. ENDIF.
IF <item>-aux IS NOT INITIAL. IF <ls_item>-aux IS NOT INITIAL.
lv_aux = | data-aux="{ <item>-aux }"|. lv_aux = | data-aux="{ <ls_item>-aux }"|.
ENDIF. ENDIF.
ro_html->add( |<li{ lv_class }{ lv_check }{ lv_aux }>| ). ro_html->add( |<li{ lv_class }{ lv_check }{ lv_aux }>| ).
IF <item>-sub IS INITIAL. IF <ls_item>-sub IS INITIAL.
ro_html->add_a( iv_txt = lv_icon && <item>-txt ro_html->add_a( iv_txt = lv_icon && <ls_item>-txt
iv_typ = <item>-typ iv_typ = <ls_item>-typ
iv_act = <item>-act iv_act = <ls_item>-act
iv_id = <item>-id iv_id = <ls_item>-id
iv_opt = <item>-opt ). iv_opt = <ls_item>-opt ).
ELSE. ELSE.
ro_html->add_a( iv_txt = lv_icon && <item>-txt ro_html->add_a( iv_txt = lv_icon && <ls_item>-txt
iv_typ = zif_abapgit_definitions=>gc_action_type-dummy iv_typ = zif_abapgit_definitions=>gc_action_type-dummy
iv_act = '' iv_act = ''
iv_id = <item>-id iv_id = <ls_item>-id
iv_opt = <item>-opt ). iv_opt = <ls_item>-opt ).
ro_html->add( <item>-sub->render_items( iv_sort = iv_sort ) ). ro_html->add( <ls_item>-sub->render_items( iv_sort ) ).
ENDIF. ENDIF.
ro_html->add( '</li>' ). ro_html->add( '</li>' ).

2
src/utils/zcl_abapgit_log.clas.abap
View File

@ -114,7 +114,7 @@ CLASS ZCL_ABAPGIT_LOG IMPLEMENTATION.
ENDCASE. ENDCASE.
ro_html->add( |<span class="{ lv_class }">| ). ro_html->add( |<span class="{ lv_class }">| ).
ro_html->add_icon( iv_name = lv_icon ). ro_html->add_icon( lv_icon ).
ro_html->add( <ls_log>-msg ). ro_html->add( <ls_log>-msg ).
ro_html->add( '</span>' ). ro_html->add( '</span>' ).
ENDLOOP. ENDLOOP.

2
src/zabapgit_folder_logic.prog.abap
View File

@ -19,7 +19,7 @@ CLASS lcl_folder_logic DEFINITION.
io_dot TYPE REF TO zcl_abapgit_dot_abapgit io_dot TYPE REF TO zcl_abapgit_dot_abapgit
iv_path TYPE string iv_path TYPE string
iv_create_if_not_exists TYPE abap_bool DEFAULT abap_true iv_create_if_not_exists TYPE abap_bool DEFAULT abap_true
iv_local_path TYPE abap_bool DEFAULT abap_true * iv_local_path TYPE abap_bool DEFAULT abap_true
RETURNING RETURNING
VALUE(rv_package) TYPE devclass VALUE(rv_package) TYPE devclass
RAISING RAISING

2
src/zabapgit_object_cus2.prog.abap
View File

@ -72,8 +72,6 @@ CLASS lcl_object_cus2 IMPLEMENTATION.
METHOD lif_object~exists. METHOD lif_object~exists.
DATA: ls_message TYPE hier_mess.
CALL FUNCTION 'S_CUS_ATTRIBUTES_EXIST' CALL FUNCTION 'S_CUS_ATTRIBUTES_EXIST'
EXPORTING EXPORTING
img_attribute = mv_img_attribute img_attribute = mv_img_attribute

3
src/zabapgit_object_ddls.prog.abap
View File

@ -33,8 +33,7 @@ CLASS lcl_object_ddls IMPLEMENTATION.
METHOD lif_object~changed_by. METHOD lif_object~changed_by.
DATA: lv_state TYPE objstate, DATA: li_ddl TYPE REF TO object,
li_ddl TYPE REF TO object,
lr_data TYPE REF TO data. lr_data TYPE REF TO data.
FIELD-SYMBOLS: <ls_data> TYPE any, FIELD-SYMBOLS: <ls_data> TYPE any,

6
src/zabapgit_object_devc.prog.abap
View File

@ -79,15 +79,12 @@ CLASS lcl_object_devc IMPLEMENTATION.
DATA: li_package TYPE REF TO if_package, DATA: li_package TYPE REF TO if_package,
ls_package_data TYPE scompkdtln, ls_package_data TYPE scompkdtln,
ls_data_sign TYPE scompksign, ls_data_sign TYPE scompksign,
lv_changeable TYPE abap_bool,
lt_usage_data TYPE scomppdata, lt_usage_data TYPE scomppdata,
lt_permissions TYPE tpak_permission_to_use_list,
li_usage TYPE REF TO if_package_permission_to_use,
ls_usage_data_sign TYPE scomppsign,
ls_save_sign TYPE paksavsign. ls_save_sign TYPE paksavsign.
FIELD-SYMBOLS: <ls_usage_data> TYPE scomppdtln. FIELD-SYMBOLS: <ls_usage_data> TYPE scomppdtln.
mv_local_devclass = iv_package. mv_local_devclass = iv_package.
io_xml->read( io_xml->read(
@ -242,7 +239,6 @@ CLASS lcl_object_devc IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD lif_object~exists. METHOD lif_object~exists.
DATA: lv_check_devclass TYPE devclass.
" Check remote package if deserialize has not been called before this " Check remote package if deserialize has not been called before this
IF mv_local_devclass IS INITIAL. IF mv_local_devclass IS INITIAL.

2
src/zabapgit_object_docv.prog.abap
View File

@ -20,7 +20,7 @@ CLASS lcl_object_docv DEFINITION INHERITING FROM lcl_objects_super FINAL.
END OF ty_data. END OF ty_data.
METHODS: read METHODS: read
RETURNING value(rs_data) TYPE ty_data. RETURNING VALUE(rs_data) TYPE ty_data.
ENDCLASS. "lcl_object_msag DEFINITION ENDCLASS. "lcl_object_msag DEFINITION

12
src/zabapgit_object_enho.prog.abap
View File

@ -33,8 +33,7 @@ CLASS lcl_object_enho_wdyc DEFINITION.
INTERFACES: lif_object_enho. INTERFACES: lif_object_enho.
PRIVATE SECTION. PRIVATE SECTION.
DATA: ms_item TYPE zif_abapgit_definitions=>ty_item, DATA: ms_item TYPE zif_abapgit_definitions=>ty_item.
mo_files TYPE REF TO lcl_objects_files.
ENDCLASS. "lcl_object_enho_wdyconf DEFINITION ENDCLASS. "lcl_object_enho_wdyconf DEFINITION
@ -47,7 +46,6 @@ CLASS lcl_object_enho_wdyc IMPLEMENTATION.
METHOD constructor. METHOD constructor.
ms_item = is_item. ms_item = is_item.
mo_files = io_files.
ENDMETHOD. "constructor ENDMETHOD. "constructor
METHOD lif_object_enho~deserialize. METHOD lif_object_enho~deserialize.
@ -146,8 +144,7 @@ CLASS lcl_object_enho_wdyn DEFINITION.
INTERFACES: lif_object_enho. INTERFACES: lif_object_enho.
PRIVATE SECTION. PRIVATE SECTION.
DATA: ms_item TYPE zif_abapgit_definitions=>ty_item, DATA: ms_item TYPE zif_abapgit_definitions=>ty_item.
mo_files TYPE REF TO lcl_objects_files.
ENDCLASS. "lcl_object_enho_wdyconf DEFINITION ENDCLASS. "lcl_object_enho_wdyconf DEFINITION
@ -160,7 +157,6 @@ CLASS lcl_object_enho_wdyn IMPLEMENTATION.
METHOD constructor. METHOD constructor.
ms_item = is_item. ms_item = is_item.
mo_files = io_files.
ENDMETHOD. "constructor ENDMETHOD. "constructor
METHOD lif_object_enho~deserialize. METHOD lif_object_enho~deserialize.
@ -439,8 +435,7 @@ CLASS lcl_object_enho_badi DEFINITION.
INTERFACES: lif_object_enho. INTERFACES: lif_object_enho.
PRIVATE SECTION. PRIVATE SECTION.
DATA: ms_item TYPE zif_abapgit_definitions=>ty_item, DATA: ms_item TYPE zif_abapgit_definitions=>ty_item.
mo_files TYPE REF TO lcl_objects_files.
ENDCLASS. "lcl_object_enho_badi DEFINITION ENDCLASS. "lcl_object_enho_badi DEFINITION
@ -453,7 +448,6 @@ CLASS lcl_object_enho_badi IMPLEMENTATION.
METHOD constructor. METHOD constructor.
ms_item = is_item. ms_item = is_item.
mo_files = io_files.
ENDMETHOD. "constructor ENDMETHOD. "constructor
METHOD lif_object_enho~serialize. METHOD lif_object_enho~serialize.

4
src/zabapgit_object_enhs.prog.abap
View File

@ -252,7 +252,7 @@ CLASS lcl_object_enhs_badi_def IMPLEMENTATION.
lt_enh_badi TYPE enh_badi_data_it, lt_enh_badi TYPE enh_badi_data_it,
lo_badidef_tool TYPE REF TO cl_enh_tool_badi_def, lo_badidef_tool TYPE REF TO cl_enh_tool_badi_def,
lv_enh_shorttext TYPE string, lv_enh_shorttext TYPE string,
lv_package LIKE iv_package, * lv_package LIKE iv_package,
li_enh_object TYPE REF TO if_enh_object, li_enh_object TYPE REF TO if_enh_object,
li_enh_object_docu TYPE REF TO if_enh_object_docu, li_enh_object_docu TYPE REF TO if_enh_object_docu,
lv_text TYPE string, lv_text TYPE string,
@ -269,7 +269,7 @@ CLASS lcl_object_enhs_badi_def IMPLEMENTATION.
io_xml->read( EXPORTING iv_name = 'SHORTTEXT' io_xml->read( EXPORTING iv_name = 'SHORTTEXT'
CHANGING cg_data = lv_enh_shorttext ). CHANGING cg_data = lv_enh_shorttext ).
lv_package = iv_package. * lv_package = iv_package.
li_enh_object ?= ii_enh_spot_tool. li_enh_object ?= ii_enh_spot_tool.
li_enh_object_docu ?= ii_enh_spot_tool. li_enh_object_docu ?= ii_enh_spot_tool.

2
src/zabapgit_object_enqu.prog.abap
View File

@ -42,7 +42,7 @@ CLASS lcl_object_enqu IMPLEMENTATION.
METHOD lif_object~changed_by. METHOD lif_object~changed_by.
SELECT SINGLE AS4USER FROM dd25l SELECT SINGLE as4user FROM dd25l
INTO rv_user INTO rv_user
WHERE viewname = ms_item-obj_name WHERE viewname = ms_item-obj_name
AND as4local = 'A' AND as4local = 'A'

4
src/zabapgit_object_form.prog.abap
View File

@ -192,7 +192,7 @@ CLASS lcl_object_form IMPLEMENTATION.
DATA: ls_form_data TYPE tys_form_data. DATA: ls_form_data TYPE tys_form_data.
DATA: lt_text_header TYPE tyt_text_header. DATA: lt_text_header TYPE tyt_text_header.
DATA: lt_lines TYPE tyt_lines. DATA: lt_lines TYPE tyt_lines.
DATA: lo_xml TYPE REF TO zcl_abapgit_xml_output. * DATA: lo_xml TYPE REF TO zcl_abapgit_xml_output.
DATA: lv_form_found TYPE flag. DATA: lv_form_found TYPE flag.
FIELD-SYMBOLS: <ls_text_header> LIKE LINE OF lt_text_header. FIELD-SYMBOLS: <ls_text_header> LIKE LINE OF lt_text_header.
@ -201,7 +201,7 @@ CLASS lcl_object_form IMPLEMENTATION.
LOOP AT lt_text_header ASSIGNING <ls_text_header>. LOOP AT lt_text_header ASSIGNING <ls_text_header>.
CLEAR lt_lines. CLEAR lt_lines.
CLEAR ls_form_data. CLEAR ls_form_data.
FREE lo_xml. * FREE lo_xml.
_read_form( EXPORTING is_text_header = <ls_text_header> _read_form( EXPORTING is_text_header = <ls_text_header>
IMPORTING ev_form_found = lv_form_found IMPORTING ev_form_found = lv_form_found

3
src/zabapgit_object_msag.prog.abap
View File

@ -47,8 +47,7 @@ CLASS lcl_object_msag IMPLEMENTATION.
SELECT SINGLE lastuser FROM t100a INTO rv_user SELECT SINGLE lastuser FROM t100a INTO rv_user
WHERE arbgb = ms_item-obj_name. "#EC CI_GENBUFF WHERE arbgb = ms_item-obj_name. "#EC CI_GENBUFF
IF sy-subrc <> 0 OR IF sy-subrc <> 0 OR rv_user = ''.
rv_user EQ ''.
rv_user = c_user_unknown. rv_user = c_user_unknown.
ENDIF. ENDIF.

2
src/zabapgit_object_oo_functions.prog.abap
View File

@ -501,7 +501,7 @@ CLASS lcl_oo_base IMPLEMENTATION.
result = lo_settings. result = lo_settings.
CREATE DATA lr_settings TYPE REF TO ('IF_OO_CLIF_SOURCE_SETTINGS'). CREATE DATA lr_settings TYPE REF TO ('IF_OO_CLIF_SOURCE_SETTINGS').
ASSIGN lr_settings->* to <lo_settings>. ASSIGN lr_settings->* TO <lo_settings>.
<lo_settings> ?= lo_settings. <lo_settings> ?= lo_settings.

6
src/zabapgit_object_shma.prog.abap
View File

@ -59,8 +59,8 @@ CLASS lcl_object_shma IMPLEMENTATION.
CLEAR: ls_area_attributes-chg_user, CLEAR: ls_area_attributes-chg_user,
ls_area_attributes-chg_date, ls_area_attributes-chg_date,
ls_area_attributes-chg_time, ls_area_attributes-chg_time,
ls_area_attributes-cls_gen_user , ls_area_attributes-cls_gen_user,
ls_area_attributes-cls_gen_date , ls_area_attributes-cls_gen_date,
ls_area_attributes-cls_gen_time. ls_area_attributes-cls_gen_time.
io_xml->add( iv_name = 'AREA_ATTRIBUTES' io_xml->add( iv_name = 'AREA_ATTRIBUTES'
@ -107,7 +107,7 @@ CLASS lcl_object_shma IMPLEMENTATION.
" lifecycle. Therefore we have to reimplement most of the " lifecycle. Therefore we have to reimplement most of the
" FMs logic " FMs logic
CONSTANTS: lc_request_delete TYPE i VALUE '4'. CONSTANTS: lc_request_delete TYPE i VALUE 4.
DATA: lv_request TYPE i, DATA: lv_request TYPE i,
lv_area_name TYPE shm_area_name, lv_area_name TYPE shm_area_name,

2
src/zabapgit_object_srfc.prog.abap
View File

@ -117,7 +117,7 @@ CLASS lcl_object_srfc IMPLEMENTATION.
CREATE OBJECT lo_srfc_persist TYPE ('CL_UCONRFC_OBJECT_PERSIST'). CREATE OBJECT lo_srfc_persist TYPE ('CL_UCONRFC_OBJECT_PERSIST').
CREATE OBJECT lo_object_data TYPE ('CL_UCONRFC_OBJECT_DATA'). CREATE OBJECT lo_object_data TYPE ('CL_UCONRFC_OBJECT_DATA').
lo_object_data->set_data( p_data = <ls_srfc_data> ). lo_object_data->set_data( <ls_srfc_data> ).
lo_srfc_persist->save( lo_object_data ). lo_srfc_persist->save( lo_object_data ).

1
src/zabapgit_object_ssfo.prog.abap
View File

@ -129,7 +129,6 @@ CLASS lcl_object_ssfo IMPLEMENTATION.
li_node TYPE REF TO if_ixml_node, li_node TYPE REF TO if_ixml_node,
li_element TYPE REF TO if_ixml_element, li_element TYPE REF TO if_ixml_element,
li_iterator TYPE REF TO if_ixml_node_iterator, li_iterator TYPE REF TO if_ixml_node_iterator,
li_attr TYPE REF TO if_ixml_named_node_map,
lv_formname TYPE tdsfname, lv_formname TYPE tdsfname,
li_ixml TYPE REF TO if_ixml, li_ixml TYPE REF TO if_ixml,
li_xml_doc TYPE REF TO if_ixml_document. li_xml_doc TYPE REF TO if_ixml_document.

3
src/zabapgit_object_tabl.prog.abap
View File

@ -63,7 +63,8 @@ CLASS lcl_object_tabl IMPLEMENTATION.
INTO CORRESPONDING FIELDS OF TABLE lt_indexes INTO CORRESPONDING FIELDS OF TABLE lt_indexes
WHERE sqltab = ms_item-obj_name WHERE sqltab = ms_item-obj_name
AND as4local = 'A' AND as4local = 'A'
AND as4vers = '0000' ##TOO_MANY_ITAB_FIELDS. AND as4vers = '0000'
ORDER BY PRIMARY KEY ##TOO_MANY_ITAB_FIELDS.
LOOP AT lt_indexes ASSIGNING <ls_index>. LOOP AT lt_indexes ASSIGNING <ls_index>.
rv_changed = check_timestamp( rv_changed = check_timestamp(

4
src/zabapgit_object_tabl_valid.prog.abap
View File

@ -92,7 +92,7 @@ CLASS lcl_tabl_valid_dialog IMPLEMENTATION.
ENDCLASS. ENDCLASS.
CLASS lct_table_validation DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT FINAL. CLASS ltcl_table_validation DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT FINAL.
PRIVATE SECTION. PRIVATE SECTION.
METHODS: METHODS:
setup, setup,
@ -115,7 +115,7 @@ CLASS lct_table_validation DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION S
ENDCLASS. ENDCLASS.
CLASS lct_table_validation IMPLEMENTATION. CLASS ltcl_table_validation IMPLEMENTATION.
METHOD setup. METHOD setup.
CREATE OBJECT mo_table_validator. CREATE OBJECT mo_table_validator.
ENDMETHOD. ENDMETHOD.

2
src/zabapgit_object_wapa.prog.abap
View File

@ -231,7 +231,7 @@ CLASS lcl_object_wapa IMPLEMENTATION.
ls_attributes-devclass = iv_package. ls_attributes-devclass = iv_package.
IF me->lif_object~exists( ) EQ abap_true. IF me->lif_object~exists( ) = abap_true.
me->lif_object~delete( ). me->lif_object~delete( ).
ENDIF. ENDIF.

22
src/zabapgit_objects.prog.abap
View File

@ -1622,7 +1622,8 @@ CLASS lcl_objects_program IMPLEMENTATION.
SELECT dgen tgen FROM d020s " Screens SELECT dgen tgen FROM d020s " Screens
INTO CORRESPONDING FIELDS OF TABLE lt_screens INTO CORRESPONDING FIELDS OF TABLE lt_screens
WHERE prog = iv_program ##TOO_MANY_ITAB_FIELDS. "#EC CI_SUBRC WHERE prog = iv_program
ORDER BY PRIMARY KEY ##TOO_MANY_ITAB_FIELDS. "#EC CI_SUBRC
LOOP AT lt_screens ASSIGNING <ls_screen>. LOOP AT lt_screens ASSIGNING <ls_screen>.
rv_changed = check_timestamp( rv_changed = check_timestamp(
@ -1638,7 +1639,8 @@ CLASS lcl_objects_program IMPLEMENTATION.
INTO CORRESPONDING FIELDS OF TABLE lt_eudb INTO CORRESPONDING FIELDS OF TABLE lt_eudb
WHERE relid = 'CU' WHERE relid = 'CU'
AND name = iv_program AND name = iv_program
AND srtf2 = 0 ##TOO_MANY_ITAB_FIELDS. "#EC CI_SUBRC AND srtf2 = 0
ORDER BY PRIMARY KEY ##TOO_MANY_ITAB_FIELDS. "#EC CI_SUBRC
LOOP AT lt_eudb ASSIGNING <ls_eudb>. LOOP AT lt_eudb ASSIGNING <ls_eudb>.
rv_changed = check_timestamp( rv_changed = check_timestamp(
@ -1950,15 +1952,15 @@ CLASS lcl_objects_saxx_super IMPLEMENTATION.
DATA: lr_data TYPE REF TO data. DATA: lr_data TYPE REF TO data.
FIELD-SYMBOLS: <ls_data> TYPE any, FIELD-SYMBOLS: <lg_data> TYPE any,
<ls_header> TYPE any, <lg_header> TYPE any,
<changed_by> TYPE any. <lg_changed_by> TYPE any.
create_channel_objects( ). create_channel_objects( ).
TRY. TRY.
CREATE DATA lr_data TYPE (mv_data_structure_name). CREATE DATA lr_data TYPE (mv_data_structure_name).
ASSIGN lr_data->* TO <ls_data>. ASSIGN lr_data->* TO <lg_data>.
CATCH cx_root. CATCH cx_root.
zcx_abapgit_exception=>raise( |{ ms_item-obj_name } not supported| ). zcx_abapgit_exception=>raise( |{ ms_item-obj_name } not supported| ).
@ -1966,14 +1968,14 @@ CLASS lcl_objects_saxx_super IMPLEMENTATION.
get_data( get_data(
IMPORTING IMPORTING
p_data = <ls_data> ). p_data = <lg_data> ).
ASSIGN COMPONENT 'HEADER' OF STRUCTURE <ls_data> TO <ls_header>. ASSIGN COMPONENT 'HEADER' OF STRUCTURE <lg_data> TO <lg_header>.
ASSERT sy-subrc = 0. ASSERT sy-subrc = 0.
ASSIGN COMPONENT 'CHANGED_BY' OF STRUCTURE <ls_header> TO <changed_by>. ASSIGN COMPONENT 'CHANGED_BY' OF STRUCTURE <lg_header> TO <lg_changed_by>.
ASSERT sy-subrc = 0. ASSERT sy-subrc = 0.
rv_user = <changed_by>. rv_user = <lg_changed_by>.
ENDMETHOD. ENDMETHOD.

2
src/zabapgit_objects_impl.prog.abap
View File

@ -293,7 +293,7 @@ CLASS lcl_objects IMPLEMENTATION.
METHOD delete. METHOD delete.
DATA: ls_item TYPE zif_abapgit_definitions=>ty_item, DATA: ls_item TYPE zif_abapgit_definitions=>ty_item,
lv_tabclass TYPE dd02l-tabclass, * lv_tabclass TYPE dd02l-tabclass,
lt_tadir LIKE it_tadir. lt_tadir LIKE it_tadir.
FIELD-SYMBOLS: <ls_tadir> LIKE LINE OF it_tadir. FIELD-SYMBOLS: <ls_tadir> LIKE LINE OF it_tadir.

8
src/zabapgit_page_syntax_check.prog.abap
View File

@ -13,10 +13,10 @@ CLASS lcl_gui_page_syntax_check DEFINITION FINAL INHERITING FROM lcl_gui_page.
IMPORTING io_repo TYPE REF TO lcl_repo. IMPORTING io_repo TYPE REF TO lcl_repo.
PROTECTED SECTION. PROTECTED SECTION.
CONSTANTS: * CONSTANTS:
BEGIN OF c_action, * BEGIN OF c_action,
back TYPE string VALUE 'back', * back TYPE string VALUE 'back',
END OF c_action. * END OF c_action.
DATA: mo_repo TYPE REF TO lcl_repo. DATA: mo_repo TYPE REF TO lcl_repo.

6
src/zabapgit_popups.prog.abap
View File

@ -628,7 +628,7 @@ CLASS lcl_popups IMPLEMENTATION.
READ TABLE lt_selection ASSIGNING <ls_sel> WITH KEY selflag = abap_true. READ TABLE lt_selection ASSIGNING <ls_sel> WITH KEY selflag = abap_true.
ASSERT sy-subrc = 0. ASSERT sy-subrc = 0.
lv_name_with_prefix = lcl_tag=>add_Tag_prefix( <ls_sel>-varoption ). lv_name_with_prefix = lcl_tag=>add_tag_prefix( <ls_sel>-varoption ).
READ TABLE lt_tags ASSIGNING <ls_tag> WITH KEY name = lv_name_with_prefix. READ TABLE lt_tags ASSIGNING <ls_tag> WITH KEY name = lv_name_with_prefix.
ASSERT sy-subrc = 0. ASSERT sy-subrc = 0.
@ -1060,8 +1060,8 @@ CLASS lcl_popups IMPLEMENTATION.
<component>-name = co_fieldname_selected. <component>-name = co_fieldname_selected.
<component>-type ?= cl_abap_datadescr=>describe_by_name( 'FLAG' ). <component>-type ?= cl_abap_datadescr=>describe_by_name( 'FLAG' ).
struct_descr = cl_abap_structdescr=>create( p_components = lt_components ). struct_descr = cl_abap_structdescr=>create( lt_components ).
mo_table_descr = cl_abap_tabledescr=>create( p_line_type = struct_descr ). mo_table_descr = cl_abap_tabledescr=>create( struct_descr ).
CREATE DATA mr_table TYPE HANDLE mo_table_descr. CREATE DATA mr_table TYPE HANDLE mo_table_descr.
ASSIGN mr_table->* TO <table>. ASSIGN mr_table->* TO <table>.

4
src/zabapgit_requirements.prog.abap
View File

@ -37,14 +37,14 @@ CLASS lcl_requirement_helper DEFINITION FINAL.
"! @parameter rt_status | Result "! @parameter rt_status | Result
"! @raising zcx_abapgit_exception | Internal error "! @raising zcx_abapgit_exception | Internal error
get_requirement_met_status IMPORTING it_requirements TYPE zcl_abapgit_dot_abapgit=>ty_requirement_tt get_requirement_met_status IMPORTING it_requirements TYPE zcl_abapgit_dot_abapgit=>ty_requirement_tt
RETURNING value(rt_status) TYPE ty_requirement_status_tt RETURNING VALUE(rt_status) TYPE ty_requirement_status_tt
RAISING zcx_abapgit_exception. RAISING zcx_abapgit_exception.
PRIVATE SECTION. PRIVATE SECTION.
CLASS-METHODS: CLASS-METHODS:
show_requirement_popup IMPORTING it_requirements TYPE ty_requirement_status_tt show_requirement_popup IMPORTING it_requirements TYPE ty_requirement_status_tt
RAISING zcx_abapgit_exception, RAISING zcx_abapgit_exception,
version_greater_or_equal IMPORTING is_status TYPE ty_requirement_status version_greater_or_equal IMPORTING is_status TYPE ty_requirement_status
RETURNING value(rv_true) TYPE abap_bool. RETURNING VALUE(rv_true) TYPE abap_bool.
ENDCLASS. "lcl_requirement_helper DEFINITION ENDCLASS. "lcl_requirement_helper DEFINITION
*----------------------------------------------------------------------* *----------------------------------------------------------------------*

2
src/zabapgit_skip_objects.prog.abap
View File

@ -5,8 +5,6 @@
CLASS lcl_skip_objects IMPLEMENTATION. CLASS lcl_skip_objects IMPLEMENTATION.
METHOD skip_sadl_generated_objects. METHOD skip_sadl_generated_objects.
DATA: ls_tadir_class LIKE LINE OF rt_tadir, DATA: ls_tadir_class LIKE LINE OF rt_tadir,
lo_sadl_class TYPE REF TO lif_object,
ls_item TYPE zif_abapgit_definitions=>ty_tadir,
ls_tadir LIKE LINE OF rt_tadir, ls_tadir LIKE LINE OF rt_tadir,
lt_lines_to_delete TYPE zif_abapgit_definitions=>ty_tadir_tt. lt_lines_to_delete TYPE zif_abapgit_definitions=>ty_tadir_tt.

6
src/zabapgit_tadir.prog.abap
View File

@ -84,9 +84,6 @@ CLASS lcl_tadir IMPLEMENTATION.
METHOD read_single. METHOD read_single.
DATA: lv_obj_name TYPE tadir-obj_name.
IF iv_object = 'SICF'. IF iv_object = 'SICF'.
rs_tadir = read_single_sicf( iv_pgmid = iv_pgmid rs_tadir = read_single_sicf( iv_pgmid = iv_pgmid
iv_obj_name = iv_obj_name ). iv_obj_name = iv_obj_name ).
@ -114,7 +111,8 @@ CLASS lcl_tadir IMPLEMENTATION.
SELECT * FROM tadir INTO TABLE lt_tadir SELECT * FROM tadir INTO TABLE lt_tadir
WHERE pgmid = iv_pgmid WHERE pgmid = iv_pgmid
AND object = 'SICF' AND object = 'SICF'
AND obj_name LIKE lv_obj_name. AND obj_name LIKE lv_obj_name
ORDER BY PRIMARY KEY.
LOOP AT lt_tadir ASSIGNING <ls_tadir>. LOOP AT lt_tadir ASSIGNING <ls_tadir>.
IF read_sicf_url( <ls_tadir>-obj_name ) = lv_hash. IF read_sicf_url( <ls_tadir>-obj_name ) = lv_hash.

32
src/zcl_abapgit_dependencies.clas.abap
View File

@ -53,7 +53,7 @@ ENDCLASS.
CLASS zcl_abapgit_dependencies IMPLEMENTATION. CLASS ZCL_ABAPGIT_DEPENDENCIES IMPLEMENTATION.
METHOD get_ddls_dependencies. METHOD get_ddls_dependencies.
@ -151,17 +151,17 @@ CLASS zcl_abapgit_dependencies IMPLEMENTATION.
lv_index TYPE i, lv_index TYPE i,
lv_before TYPE i, lv_before TYPE i,
lt_founds TYPE TABLE OF rsfindlst, lt_founds TYPE TABLE OF rsfindlst,
lt_scope TYPE STANDARD TABLE OF seu_obj. lt_scope TYPE STANDARD TABLE OF seu_obj,
lt_dependency TYPE tty_dedenpency.
FIELD-SYMBOLS: <ls_tadir> LIKE LINE OF ct_tadir, FIELD-SYMBOLS: <ls_tadir_ddls> TYPE ty_tadir,
<ls_dependency> TYPE ty_dependency,
<ls_tadir_dependent> TYPE ty_tadir,
<ls_tadir> LIKE LINE OF ct_tadir,
<ls_edge> LIKE LINE OF lt_edges, <ls_edge> LIKE LINE OF lt_edges,
<ls_found> LIKE LINE OF lt_founds, <ls_found> LIKE LINE OF lt_founds,
<ls_node> LIKE LINE OF lt_nodes. <ls_node> LIKE LINE OF lt_nodes.
DATA: lt_dependency TYPE tty_dedenpency.
FIELD-SYMBOLS: <tadir_ddls> TYPE ty_tadir,
<dependency> TYPE ty_dependency,
<tadir_dependent> TYPE ty_tadir.
* build nodes * build nodes
LOOP AT ct_tadir ASSIGNING <ls_tadir> LOOP AT ct_tadir ASSIGNING <ls_tadir>
@ -223,31 +223,31 @@ CLASS zcl_abapgit_dependencies IMPLEMENTATION.
ENDLOOP. ENDLOOP.
* build DDLS edges * build DDLS edges
LOOP AT ct_tadir ASSIGNING <tadir_ddls> LOOP AT ct_tadir ASSIGNING <ls_tadir_ddls>
WHERE object = 'DDLS'. WHERE object = 'DDLS'.
CLEAR: lt_dependency. CLEAR: lt_dependency.
APPEND INITIAL LINE TO lt_nodes ASSIGNING <ls_node>. APPEND INITIAL LINE TO lt_nodes ASSIGNING <ls_node>.
<ls_node>-obj_name = <tadir_ddls>-obj_name. <ls_node>-obj_name = <ls_tadir_ddls>-obj_name.
<ls_node>-obj_type = <tadir_ddls>-object. <ls_node>-obj_type = <ls_tadir_ddls>-object.
lt_dependency = get_ddls_dependencies( <tadir_ddls>-obj_name ). lt_dependency = get_ddls_dependencies( <ls_tadir_ddls>-obj_name ).
LOOP AT lt_dependency ASSIGNING <dependency> LOOP AT lt_dependency ASSIGNING <ls_dependency>
WHERE deptyp = 'DDLS' WHERE deptyp = 'DDLS'
AND refname = <tadir_ddls>-obj_name. AND refname = <ls_tadir_ddls>-obj_name.
READ TABLE ct_tadir ASSIGNING <tadir_dependent> READ TABLE ct_tadir ASSIGNING <ls_tadir_dependent>
WITH KEY pgmid = 'R3TR' WITH KEY pgmid = 'R3TR'
object = 'DDLS' object = 'DDLS'
obj_name = <dependency>-depname obj_name = <ls_dependency>-depname
BINARY SEARCH. BINARY SEARCH.
CHECK sy-subrc = 0. CHECK sy-subrc = 0.
APPEND INITIAL LINE TO lt_edges ASSIGNING <ls_edge>. APPEND INITIAL LINE TO lt_edges ASSIGNING <ls_edge>.
<ls_edge>-from = <ls_node>. <ls_edge>-from = <ls_node>.
<ls_edge>-to-obj_name = <dependency>-depname. <ls_edge>-to-obj_name = <ls_dependency>-depname.
<ls_edge>-to-obj_type = 'DDLS'. <ls_edge>-to-obj_type = 'DDLS'.
ENDLOOP. ENDLOOP.