Refactor http agent factory (#6631)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2023-11-08 08:21:38 -05:00 committed by GitHub
parent 04609ae8cd
commit 97fc834edf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -44,9 +44,9 @@ CLASS zcl_abapgit_factory DEFINITION
CLASS-METHODS get_sap_report
RETURNING
VALUE(ri_report) TYPE REF TO zif_abapgit_sap_report.
CLASS-METHODS: get_function_module
RETURNING
VALUE(ri_function_module) TYPE REF TO zif_abapgit_function_module.
CLASS-METHODS get_function_module
RETURNING
VALUE(ri_function_module) TYPE REF TO zif_abapgit_function_module.
PROTECTED SECTION.
PRIVATE SECTION.
@ -128,14 +128,25 @@ CLASS zcl_abapgit_factory IMPLEMENTATION.
ENDMETHOD.
METHOD get_function_module.
IF gi_function_module IS INITIAL.
CREATE OBJECT gi_function_module TYPE zcl_abapgit_function_module.
ENDIF.
ri_function_module = gi_function_module.
ENDMETHOD.
METHOD get_http_agent.
IF gi_http_agent IS BOUND.
ri_http_agent = gi_http_agent.
ELSE.
ri_http_agent = zcl_abapgit_http_agent=>create( ).
IF gi_http_agent IS INITIAL.
gi_http_agent = zcl_abapgit_http_agent=>create( ).
ENDIF.
ri_http_agent = gi_http_agent.
ENDMETHOD.
@ -209,8 +220,7 @@ CLASS zcl_abapgit_factory IMPLEMENTATION.
METHOD get_stage_logic.
IF gi_stage_logic IS INITIAL.
CREATE OBJECT gi_stage_logic
TYPE zcl_abapgit_stage_logic.
CREATE OBJECT gi_stage_logic TYPE zcl_abapgit_stage_logic.
ENDIF.
ri_logic = gi_stage_logic.
@ -227,16 +237,4 @@ CLASS zcl_abapgit_factory IMPLEMENTATION.
ri_tadir = gi_tadir.
ENDMETHOD.
METHOD get_function_module.
IF gi_function_module IS INITIAL.
CREATE OBJECT gi_function_module TYPE zcl_abapgit_function_module.
ENDIF.
ri_function_module = gi_function_module.
ENDMETHOD.
ENDCLASS.