From 9c41a2b7d851e62a88785a90448a63b3ce34a8d3 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Thu, 3 Sep 2020 09:13:47 +0200 Subject: [PATCH] remove text pragmas and pseudo comments (#3827) * remove text pragmas and pseudo comments * fix whitespace * fix carriage return * test * test * Update zcl_abapgit_repo.clas.abap --- abaplint.json | 7 ++ .../zcl_abapgit_apack_migration.clas.abap | 70 +++++------ src/apack/zcl_abapgit_apack_reader.clas.abap | 2 +- .../zcl_abapgit_background.clas.abap | 6 +- .../zcl_abapgit_background_pull.clas.abap | 2 +- .../zcl_abapgit_background_push_au.clas.abap | 10 +- .../zcl_abapgit_background_push_fi.clas.abap | 4 +- src/git/zcl_abapgit_git_branch_list.clas.abap | 6 +- src/git/zcl_abapgit_git_pack.clas.abap | 12 +- src/git/zcl_abapgit_git_transport.clas.abap | 12 +- src/http/zcl_abapgit_2fa_auth_base.clas.abap | 2 +- .../zcl_abapgit_2fa_auth_registry.clas.abap | 2 +- .../zcl_abapgit_2fa_github_auth.clas.abap | 2 +- src/http/zcl_abapgit_http.clas.abap | 4 +- src/http/zcl_abapgit_http_client.clas.abap | 8 +- .../zcx_abapgit_2fa_auth_failed.clas.abap | 2 +- src/http/zcx_abapgit_2fa_comm_error.clas.abap | 2 +- src/http/zcx_abapgit_2fa_del_failed.clas.abap | 2 +- src/http/zcx_abapgit_2fa_error.clas.abap | 2 +- src/http/zcx_abapgit_2fa_gen_failed.clas.abap | 2 +- .../zcx_abapgit_2fa_illegal_state.clas.abap | 2 +- .../zcx_abapgit_2fa_unsupported.clas.abap | 2 +- .../ecatt/zcl_abapgit_ecatt_helper.clas.abap | 2 +- src/objects/zcl_abapgit_object_clas.clas.abap | 16 +-- src/objects/zcl_abapgit_object_ddls.clas.abap | 8 +- src/objects/zcl_abapgit_object_ddlx.clas.abap | 2 +- src/objects/zcl_abapgit_object_dtel.clas.abap | 2 +- src/objects/zcl_abapgit_object_ensc.clas.abap | 6 +- src/objects/zcl_abapgit_object_form.clas.abap | 12 +- src/objects/zcl_abapgit_object_iatu.clas.abap | 4 +- src/objects/zcl_abapgit_object_scp1.clas.abap | 4 +- src/objects/zcl_abapgit_object_ssfo.clas.abap | 8 +- src/objects/zcl_abapgit_object_tabl.clas.abap | 2 +- src/objects/zcl_abapgit_object_xslt.clas.abap | 4 +- src/objects/zcl_abapgit_objects.clas.abap | 12 +- .../zcl_abapgit_objects_files.clas.abap | 16 +-- .../zcl_abapgit_objects_generic.clas.abap | 2 +- .../zcl_abapgit_objects_program.clas.abap | 2 +- .../zcl_abapgit_objects_super.clas.abap | 2 +- src/objects/zcl_abapgit_oo_class.clas.abap | 4 +- .../zcl_abapgit_persist_background.clas.abap | 2 +- .../zcl_abapgit_persistence_repo.clas.abap | 2 +- .../zcl_abapgit_persistence_user.clas.abap | 2 +- ...t_syntax_highlighter.clas.testclasses.abap | 56 ++++----- src/ui/core/zcl_abapgit_gui.clas.abap | 4 +- src/ui/core/zcl_abapgit_html.clas.abap | 6 +- src/ui/db/zcl_abapgit_gui_page_db.clas.abap | 4 +- .../db/zcl_abapgit_gui_page_db_dis.clas.abap | 2 +- .../db/zcl_abapgit_gui_page_db_edit.clas.abap | 2 +- .../zcl_abapgit_frontend_services.clas.abap | 10 +- src/ui/zcl_abapgit_gui_chunk_lib.clas.abap | 12 +- src/ui/zcl_abapgit_gui_page.clas.abap | 22 ++-- src/ui/zcl_abapgit_gui_page_bkg.clas.abap | 18 +-- .../zcl_abapgit_gui_page_boverview.clas.abap | 22 ++-- .../zcl_abapgit_gui_page_code_insp.clas.abap | 4 +- .../zcl_abapgit_gui_page_codi_base.clas.abap | 4 +- src/ui/zcl_abapgit_gui_page_commit.clas.abap | 6 +- src/ui/zcl_abapgit_gui_page_diff.clas.abap | 62 +++++----- src/ui/zcl_abapgit_gui_page_merge.clas.abap | 4 +- .../zcl_abapgit_gui_page_merge_res.clas.abap | 110 +++++++++--------- src/ui/zcl_abapgit_gui_page_patch.clas.abap | 6 +- src/ui/zcl_abapgit_gui_page_stage.clas.abap | 6 +- src/ui/zcl_abapgit_gui_page_tag.clas.abap | 8 +- .../zcl_abapgit_gui_page_view_repo.clas.abap | 8 +- src/ui/zcl_abapgit_html_toolbar.clas.abap | 4 +- src/ui/zcl_abapgit_popups.clas.abap | 24 ++-- src/ui/zcl_abapgit_services_abapgit.clas.abap | 6 +- src/ui/zcl_abapgit_services_git.clas.abap | 4 +- src/ui/zcl_abapgit_services_repo.clas.abap | 10 +- src/utils/zcl_abapgit_login_manager.clas.abap | 6 +- ...bapgit_login_manager.clas.testclasses.abap | 4 +- .../zcl_abapgit_requirement_helper.clas.abap | 2 +- .../zcl_abapgit_url.clas.testclasses.abap | 8 +- src/utils/zcl_abapgit_utils.clas.abap | 2 +- src/xml/zcl_abapgit_xml.clas.abap | 36 +++--- src/xml/zcl_abapgit_xml_input.clas.abap | 2 +- src/zabapgit_password_dialog.prog.abap | 8 +- src/zcl_abapgit_branch_overview.clas.abap | 2 +- src/zcl_abapgit_dot_abapgit.clas.abap | 2 +- src/zcl_abapgit_environment.clas.abap | 2 +- src/zcl_abapgit_file_status.clas.abap | 10 +- src/zcl_abapgit_folder_logic.clas.abap | 2 +- src/zcl_abapgit_message_helper.clas.abap | 2 +- src/zcl_abapgit_repo.clas.abap | 2 +- src/zcl_abapgit_repo_online.clas.abap | 2 +- src/zcl_abapgit_serialize.clas.abap | 4 +- src/zcl_abapgit_stage.clas.abap | 2 +- ...bapgit_transport_mass.clas.locals_imp.abap | 2 +- 88 files changed, 404 insertions(+), 397 deletions(-) diff --git a/abaplint.json b/abaplint.json index ee5ed83d0..73e51e485 100644 --- a/abaplint.json +++ b/abaplint.json @@ -72,6 +72,13 @@ "globalMacros": [] }, "rules": { + "forbidden_pseudo_and_pragma": { + "ignoreGlobalClassDefinition": true, + "ignoreGlobalInterface": true, + "pragmas": ["##NO_TEXT"], + "pseudo": ["#EC NOTEXT"] + }, + "unused_types": true, "begin_single_include": true, "names_no_dash": true, "parser_missing_space": true, diff --git a/src/apack/zcl_abapgit_apack_migration.clas.abap b/src/apack/zcl_abapgit_apack_migration.clas.abap index 3d161b442..5a11bc226 100644 --- a/src/apack/zcl_abapgit_apack_migration.clas.abap +++ b/src/apack/zcl_abapgit_apack_migration.clas.abap @@ -56,7 +56,7 @@ CLASS zcl_abapgit_apack_migration IMPLEMENTATION. TRY. CALL METHOD lo_source->('IF_OO_CLIF_SOURCE~LOCK'). CATCH cx_oo_access_permission. - zcx_abapgit_exception=>raise( 'source_new, access permission exception' ) ##NO_TEXT. + zcx_abapgit_exception=>raise( 'source_new, access permission exception' ). ENDTRY. lt_source_code = get_interface_source( ). @@ -86,7 +86,7 @@ CLASS zcl_abapgit_apack_migration IMPLEMENTATION. class_not_existing = 1 OTHERS = 2. IF sy-subrc <> 0. - zcx_abapgit_exception=>raise( 'error from CL_OO_SOURCE' ) ##NO_TEXT. + zcx_abapgit_exception=>raise( 'error from CL_OO_SOURCE' ). ENDIF. TRY. @@ -96,9 +96,9 @@ CLASS zcl_abapgit_apack_migration IMPLEMENTATION. lo_source->save( ). lo_source->access_permission( seok_access_free ). CATCH cx_oo_access_permission. - zcx_abapgit_exception=>raise( 'permission error' ) ##NO_TEXT. + zcx_abapgit_exception=>raise( 'permission error' ). CATCH cx_oo_source_save_failure. - zcx_abapgit_exception=>raise( 'save failure' ) ##NO_TEXT. + zcx_abapgit_exception=>raise( 'save failure' ). ENDTRY. ENDMETHOD. @@ -110,7 +110,7 @@ CLASS zcl_abapgit_apack_migration IMPLEMENTATION. ls_interface_properties-clsname = c_interface_name. ls_interface_properties-version = '1'. ls_interface_properties-langu = 'E'. - ls_interface_properties-descript = 'APACK: Manifest interface' ##NO_TEXT. + ls_interface_properties-descript = 'APACK: Manifest interface'. ls_interface_properties-exposure = '2'. ls_interface_properties-state = '1'. ls_interface_properties-unicode = abap_true. @@ -129,7 +129,7 @@ CLASS zcl_abapgit_apack_migration IMPLEMENTATION. other = 6 OTHERS = 7. IF sy-subrc <> 0. - zcx_abapgit_exception=>raise( 'Error from SEO_INTERFACE_CREATE_COMPLETE' ) ##NO_TEXT. + zcx_abapgit_exception=>raise( 'Error from SEO_INTERFACE_CREATE_COMPLETE' ). ENDIF. add_intf_source_and_activate( ). @@ -139,34 +139,34 @@ CLASS zcl_abapgit_apack_migration IMPLEMENTATION. METHOD get_interface_source. - INSERT `INTERFACE zif_apack_manifest PUBLIC.` INTO TABLE rt_source ##NO_TEXT. - INSERT `` INTO TABLE rt_source ##NO_TEXT. - INSERT ` TYPES: BEGIN OF ty_dependency,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` group_id TYPE string,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` artifact_id TYPE string,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` version TYPE string,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` git_url TYPE string,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` target_package TYPE devclass,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` END OF ty_dependency,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` ty_dependencies TYPE STANDARD TABLE OF ty_dependency` INTO TABLE rt_source ##NO_TEXT. - INSERT ` WITH NON-UNIQUE DEFAULT KEY,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` ty_repository_type TYPE string,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` BEGIN OF ty_descriptor,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` group_id TYPE string,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` artifact_id TYPE string,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` version TYPE string,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` repository_type TYPE ty_repository_type,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` git_url TYPE string,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` dependencies TYPE ty_dependencies,` INTO TABLE rt_source ##NO_TEXT. - INSERT ` END OF ty_descriptor.` INTO TABLE rt_source ##NO_TEXT. - INSERT `` INTO TABLE rt_source ##NO_TEXT. - INSERT ` CONSTANTS: co_file_name TYPE string VALUE '.apack-manifest.xml',` INTO TABLE rt_source ##NO_TEXT. - INSERT ` co_abap_git TYPE ty_repository_type VALUE 'abapGit',` INTO TABLE rt_source ##NO_TEXT. - INSERT ` co_interface_version TYPE i VALUE 1.` INTO TABLE rt_source ##NO_TEXT. - INSERT `` INTO TABLE rt_source ##NO_TEXT. - INSERT ` DATA: descriptor TYPE ty_descriptor READ-ONLY.` INTO TABLE rt_source ##NO_TEXT. - INSERT `` INTO TABLE rt_source ##NO_TEXT. - INSERT `ENDINTERFACE.` INTO TABLE rt_source ##NO_TEXT. + INSERT `INTERFACE zif_apack_manifest PUBLIC.` INTO TABLE rt_source. + INSERT `` INTO TABLE rt_source. + INSERT ` TYPES: BEGIN OF ty_dependency,` INTO TABLE rt_source. + INSERT ` group_id TYPE string,` INTO TABLE rt_source. + INSERT ` artifact_id TYPE string,` INTO TABLE rt_source. + INSERT ` version TYPE string,` INTO TABLE rt_source. + INSERT ` git_url TYPE string,` INTO TABLE rt_source. + INSERT ` target_package TYPE devclass,` INTO TABLE rt_source. + INSERT ` END OF ty_dependency,` INTO TABLE rt_source. + INSERT ` ty_dependencies TYPE STANDARD TABLE OF ty_dependency` INTO TABLE rt_source. + INSERT ` WITH NON-UNIQUE DEFAULT KEY,` INTO TABLE rt_source. + INSERT ` ty_repository_type TYPE string,` INTO TABLE rt_source. + INSERT ` BEGIN OF ty_descriptor,` INTO TABLE rt_source. + INSERT ` group_id TYPE string,` INTO TABLE rt_source. + INSERT ` artifact_id TYPE string,` INTO TABLE rt_source. + INSERT ` version TYPE string,` INTO TABLE rt_source. + INSERT ` repository_type TYPE ty_repository_type,` INTO TABLE rt_source. + INSERT ` git_url TYPE string,` INTO TABLE rt_source. + INSERT ` dependencies TYPE ty_dependencies,` INTO TABLE rt_source. + INSERT ` END OF ty_descriptor.` INTO TABLE rt_source. + INSERT `` INTO TABLE rt_source. + INSERT ` CONSTANTS: co_file_name TYPE string VALUE '.apack-manifest.xml',` INTO TABLE rt_source. + INSERT ` co_abap_git TYPE ty_repository_type VALUE 'abapGit',` INTO TABLE rt_source. + INSERT ` co_interface_version TYPE i VALUE 1.` INTO TABLE rt_source. + INSERT `` INTO TABLE rt_source. + INSERT ` DATA: descriptor TYPE ty_descriptor READ-ONLY.` INTO TABLE rt_source. + INSERT `` INTO TABLE rt_source. + INSERT `ENDINTERFACE.` INTO TABLE rt_source. ENDMETHOD. @@ -239,7 +239,7 @@ CLASS zcl_abapgit_apack_migration IMPLEMENTATION. OTHERS = 4. IF sy-subrc <> 0. - zcx_abapgit_exception=>raise( 'error from RS_WORKING_OBJECTS_ACTIVATE' ) ##NO_TEXT. + zcx_abapgit_exception=>raise( 'error from RS_WORKING_OBJECTS_ACTIVATE' ). ENDIF. ENDMETHOD. diff --git a/src/apack/zcl_abapgit_apack_reader.clas.abap b/src/apack/zcl_abapgit_apack_reader.clas.abap index c3f286d96..ce1559175 100644 --- a/src/apack/zcl_abapgit_apack_reader.clas.abap +++ b/src/apack/zcl_abapgit_apack_reader.clas.abap @@ -111,7 +111,7 @@ CLASS zcl_abapgit_apack_reader IMPLEMENTATION. CALL TRANSFORMATION id OPTIONS value_handling = 'accept_data_loss' SOURCE XML lv_xml - RESULT data = rs_data ##NO_TEXT. + RESULT data = rs_data. ENDMETHOD. diff --git a/src/background/zcl_abapgit_background.clas.abap b/src/background/zcl_abapgit_background.clas.abap index d6d474f94..fd68a33d7 100644 --- a/src/background/zcl_abapgit_background.clas.abap +++ b/src/background/zcl_abapgit_background.clas.abap @@ -91,14 +91,14 @@ CLASS ZCL_ABAPGIT_BACKGROUND IMPLEMENTATION. system_failure = 2 OTHERS = 3. IF sy-subrc <> 0. - WRITE: / 'Another intance of the program is already running' ##NO_TEXT. + WRITE: / 'Another intance of the program is already running'. RETURN. ENDIF. CREATE OBJECT lo_per. lt_list = lo_per->list( ). - WRITE: / 'Background mode' ##NO_TEXT. + WRITE: / 'Background mode'. LOOP AT lt_list ASSIGNING . lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( -key ). @@ -122,7 +122,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND IMPLEMENTATION. ENDLOOP. IF lines( lt_list ) = 0. - WRITE: / 'Nothing configured' ##NO_TEXT. + WRITE: / 'Nothing configured'. ENDIF. CALL FUNCTION 'DEQUEUE_EZABAPGIT' diff --git a/src/background/zcl_abapgit_background_pull.clas.abap b/src/background/zcl_abapgit_background_pull.clas.abap index 5a7f4880e..a5a951a5a 100644 --- a/src/background/zcl_abapgit_background_pull.clas.abap +++ b/src/background/zcl_abapgit_background_pull.clas.abap @@ -16,7 +16,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PULL IMPLEMENTATION. METHOD zif_abapgit_background~get_description. - rv_description = 'Automatic pull' ##NO_TEXT. + rv_description = 'Automatic pull'. ENDMETHOD. diff --git a/src/background/zcl_abapgit_background_push_au.clas.abap b/src/background/zcl_abapgit_background_push_au.clas.abap index ea8fb277e..73358e6f0 100644 --- a/src/background/zcl_abapgit_background_push_au.clas.abap +++ b/src/background/zcl_abapgit_background_push_au.clas.abap @@ -58,7 +58,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_AU IMPLEMENTATION. IF lines( lt_objects ) = 1. rv_comment = |BG: { lv_str }|. ELSE. - rv_comment = 'BG: Multiple objects' ##NO_TEXT. + rv_comment = 'BG: Multiple objects'. LOOP AT lt_objects INTO lv_str. CONCATENATE rv_comment zif_abapgit_definitions=>c_newline lv_str INTO rv_comment. ENDLOOP. @@ -192,7 +192,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_AU IMPLEMENTATION. CREATE OBJECT lo_stage. - ls_comment-comment = 'BG: Deletion' ##NO_TEXT. + ls_comment-comment = 'BG: Deletion'. LOOP AT is_files-remote ASSIGNING . @@ -206,7 +206,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_AU IMPLEMENTATION. ENDLOOP. - ls_comment-committer-name = 'Deletion' ##NO_TEXT. + ls_comment-committer-name = 'Deletion'. ls_comment-committer-email = 'deletion@localhost'. io_repo->push( is_comment = ls_comment @@ -217,7 +217,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_AU IMPLEMENTATION. METHOD zif_abapgit_background~get_description. - rv_description = 'Automatic push, auto author' ##NO_TEXT. + rv_description = 'Automatic push, auto author'. ENDMETHOD. @@ -237,7 +237,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_AU IMPLEMENTATION. ls_files = zcl_abapgit_factory=>get_stage_logic( )->get( io_repo ). IF lines( ls_files-local ) = 0 AND lines( ls_files-remote ) = 0. - ii_log->add_info( 'Nothing to stage' ) ##NO_TEXT. + ii_log->add_info( 'Nothing to stage' ). RETURN. ENDIF. diff --git a/src/background/zcl_abapgit_background_push_fi.clas.abap b/src/background/zcl_abapgit_background_push_fi.clas.abap index d5a9c76a4..9504c582c 100644 --- a/src/background/zcl_abapgit_background_push_fi.clas.abap +++ b/src/background/zcl_abapgit_background_push_fi.clas.abap @@ -54,7 +54,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_FI IMPLEMENTATION. IF lines( lt_objects ) = 1. rv_comment = |BG: { lv_str }|. ELSE. - rv_comment = 'BG: Multiple objects' ##NO_TEXT. + rv_comment = 'BG: Multiple objects'. LOOP AT lt_objects INTO lv_str. CONCATENATE rv_comment zif_abapgit_definitions=>c_newline lv_str INTO rv_comment. ENDLOOP. @@ -107,7 +107,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_FI IMPLEMENTATION. METHOD zif_abapgit_background~get_description. - rv_description = 'Automatic push, fixed author' ##NO_TEXT. + rv_description = 'Automatic push, fixed author'. ENDMETHOD. diff --git a/src/git/zcl_abapgit_git_branch_list.clas.abap b/src/git/zcl_abapgit_git_branch_list.clas.abap index f2d0cdcdb..bb8cc5032 100644 --- a/src/git/zcl_abapgit_git_branch_list.clas.abap +++ b/src/git/zcl_abapgit_git_branch_list.clas.abap @@ -117,7 +117,7 @@ CLASS ZCL_ABAPGIT_GIT_BRANCH_LIST IMPLEMENTATION. METHOD find_by_name. IF iv_branch_name IS INITIAL. - zcx_abapgit_exception=>raise( 'Branch name empty' ) ##NO_TEXT. + zcx_abapgit_exception=>raise( 'Branch name empty' ). ENDIF. IF iv_branch_name CP zif_abapgit_definitions=>c_git_branch-tags. @@ -148,7 +148,7 @@ CLASS ZCL_ABAPGIT_GIT_BRANCH_LIST IMPLEMENTATION. READ TABLE mt_branches INTO rs_branch WITH KEY name = iv_branch_name. IF sy-subrc <> 0. - zcx_abapgit_exception=>raise( 'Branch not found' ) ##NO_TEXT. + zcx_abapgit_exception=>raise( 'Branch not found' ). ENDIF. ENDIF. @@ -271,7 +271,7 @@ CLASS ZCL_ABAPGIT_GIT_BRANCH_LIST IMPLEMENTATION. lv_hash = lv_data+4. lv_name = lv_data+45. ELSEIF sy-tabix = 1 AND strlen( lv_data ) = 8 AND lv_data(8) = '00000000'. - zcx_abapgit_exception=>raise( 'No branches, create branch manually by adding file' ) ##NO_TEXT. + zcx_abapgit_exception=>raise( 'No branches, create branch manually by adding file' ). ELSE. CONTINUE. ENDIF. diff --git a/src/git/zcl_abapgit_git_pack.clas.abap b/src/git/zcl_abapgit_git_pack.clas.abap index 77c24aca9..ea2e1f601 100644 --- a/src/git/zcl_abapgit_git_pack.clas.abap +++ b/src/git/zcl_abapgit_git_pack.clas.abap @@ -373,7 +373,7 @@ CLASS ZCL_ABAPGIT_GIT_PACK IMPLEMENTATION. LOOP AT lt_deltas INTO ls_object. li_progress->show( iv_current = sy-tabix - iv_text = 'Decode deltas' ) ##NO_TEXT. + iv_text = 'Decode deltas' ). delta( EXPORTING is_object = ls_object CHANGING ct_objects = ct_objects ). @@ -687,7 +687,7 @@ CLASS ZCL_ABAPGIT_GIT_PACK IMPLEMENTATION. lv_string = ''. - CONCATENATE 'tree' lv_tree_lower INTO lv_tmp SEPARATED BY space. "#EC NOTEXT + CONCATENATE 'tree' lv_tree_lower INTO lv_tmp SEPARATED BY space. CONCATENATE lv_string lv_tmp zif_abapgit_definitions=>c_newline INTO lv_string. IF NOT is_commit-parent IS INITIAL. @@ -695,7 +695,7 @@ CLASS ZCL_ABAPGIT_GIT_PACK IMPLEMENTATION. TRANSLATE lv_parent_lower TO LOWER CASE. CONCATENATE 'parent' lv_parent_lower - INTO lv_tmp SEPARATED BY space. "#EC NOTEXT + INTO lv_tmp SEPARATED BY space. CONCATENATE lv_string lv_tmp zif_abapgit_definitions=>c_newline INTO lv_string. ENDIF. @@ -704,16 +704,16 @@ CLASS ZCL_ABAPGIT_GIT_PACK IMPLEMENTATION. TRANSLATE lv_parent_lower TO LOWER CASE. CONCATENATE 'parent' lv_parent_lower - INTO lv_tmp SEPARATED BY space. "#EC NOTEXT + INTO lv_tmp SEPARATED BY space. CONCATENATE lv_string lv_tmp zif_abapgit_definitions=>c_newline INTO lv_string. ENDIF. CONCATENATE 'author' is_commit-author - INTO lv_tmp SEPARATED BY space. "#EC NOTEXT + INTO lv_tmp SEPARATED BY space. CONCATENATE lv_string lv_tmp zif_abapgit_definitions=>c_newline INTO lv_string. CONCATENATE 'committer' is_commit-committer - INTO lv_tmp SEPARATED BY space. "#EC NOTEXT + INTO lv_tmp SEPARATED BY space. CONCATENATE lv_string lv_tmp zif_abapgit_definitions=>c_newline INTO lv_string. IF NOT is_commit-gpgsig IS INITIAL. diff --git a/src/git/zcl_abapgit_git_transport.clas.abap b/src/git/zcl_abapgit_git_transport.clas.abap index 86470d5cd..68320e1a8 100644 --- a/src/git/zcl_abapgit_git_transport.clas.abap +++ b/src/git/zcl_abapgit_git_transport.clas.abap @@ -206,7 +206,7 @@ CLASS zcl_abapgit_git_transport IMPLEMENTATION. iv_url = iv_url iv_service = c_service-receive ). - lv_cap_list = 'report-status' ##NO_TEXT. + lv_cap_list = 'report-status'. lv_line = iv_old && ` ` && @@ -216,7 +216,7 @@ CLASS zcl_abapgit_git_transport IMPLEMENTATION. zcl_abapgit_git_utils=>get_null( ) && ` ` && lv_cap_list && - zif_abapgit_definitions=>c_newline. "#EC NOTEXT + zif_abapgit_definitions=>c_newline. lv_cmd_pkt = zcl_abapgit_git_utils=>pkt_string( lv_line ). lv_buffer = lv_cmd_pkt && '0000'. @@ -293,19 +293,19 @@ CLASS zcl_abapgit_git_transport IMPLEMENTATION. LOOP AT lt_branches FROM 1 ASSIGNING . IF sy-tabix = 1. - lv_capa = 'side-band-64k no-progress multi_ack' ##NO_TEXT. + lv_capa = 'side-band-64k no-progress multi_ack'. lv_line = 'want' && ` ` && -sha1 - && ` ` && lv_capa && zif_abapgit_definitions=>c_newline. "#EC NOTEXT + && ` ` && lv_capa && zif_abapgit_definitions=>c_newline. ELSE. lv_line = 'want' && ` ` && -sha1 - && zif_abapgit_definitions=>c_newline. "#EC NOTEXT + && zif_abapgit_definitions=>c_newline. ENDIF. lv_buffer = lv_buffer && zcl_abapgit_git_utils=>pkt_string( lv_line ). ENDLOOP. IF iv_deepen = abap_true. lv_buffer = lv_buffer && zcl_abapgit_git_utils=>pkt_string( 'deepen 1' - && zif_abapgit_definitions=>c_newline ). "#EC NOTEXT + && zif_abapgit_definitions=>c_newline ). ENDIF. lv_buffer = lv_buffer diff --git a/src/http/zcl_abapgit_2fa_auth_base.clas.abap b/src/http/zcl_abapgit_2fa_auth_base.clas.abap index 75447ff60..96a58e882 100644 --- a/src/http/zcl_abapgit_2fa_auth_base.clas.abap +++ b/src/http/zcl_abapgit_2fa_auth_base.clas.abap @@ -139,7 +139,7 @@ CLASS ZCL_ABAPGIT_2FA_AUTH_BASE IMPLEMENTATION. INTO lv_error_msg. RAISE EXCEPTION TYPE zcx_abapgit_2fa_comm_error EXPORTING - mv_text = |Communication error: { lv_error_msg }| ##NO_TEXT. + mv_text = |Communication error: { lv_error_msg }|. ENDMETHOD. diff --git a/src/http/zcl_abapgit_2fa_auth_registry.clas.abap b/src/http/zcl_abapgit_2fa_auth_registry.clas.abap index f8391732d..aa80e52a3 100644 --- a/src/http/zcl_abapgit_2fa_auth_registry.clas.abap +++ b/src/http/zcl_abapgit_2fa_auth_registry.clas.abap @@ -125,7 +125,7 @@ CLASS ZCL_ABAPGIT_2FA_AUTH_REGISTRY IMPLEMENTATION. fields = lt_fields EXCEPTIONS error_in_fields = 1 - OTHERS = 2. "#EC NOTEXT + OTHERS = 2. IF sy-subrc <> 0. zcx_abapgit_exception=>raise( 'Error from POPUP_GET_VALUES' ). ENDIF. diff --git a/src/http/zcl_abapgit_2fa_github_auth.clas.abap b/src/http/zcl_abapgit_2fa_github_auth.clas.abap index a462317d2..8a3f44fbf 100644 --- a/src/http/zcl_abapgit_2fa_github_auth.clas.abap +++ b/src/http/zcl_abapgit_2fa_github_auth.clas.abap @@ -237,7 +237,7 @@ CLASS ZCL_ABAPGIT_2FA_GITHUB_AUTH IMPLEMENTATION. IF rv_access_token IS INITIAL. RAISE EXCEPTION TYPE zcx_abapgit_2fa_gen_failed EXPORTING - mv_text = 'Token generation failed: parser error' ##NO_TEXT. + mv_text = 'Token generation failed: parser error'. ENDIF. " GitHub might need some time until the new token is ready to use, give it a second diff --git a/src/http/zcl_abapgit_http.clas.abap b/src/http/zcl_abapgit_http.clas.abap index 7f5cd6c1e..7a113c1c5 100644 --- a/src/http/zcl_abapgit_http.clas.abap +++ b/src/http/zcl_abapgit_http.clas.abap @@ -158,7 +158,7 @@ CLASS ZCL_ABAPGIT_HTTP IMPLEMENTATION. " a) SSL is setup properly in STRUST lv_text = 'HTTPS ARGUMENT_NOT_FOUND | STRUST/SSL Setup correct?'. WHEN OTHERS. - lv_text = 'While creating HTTP Client'. "#EC NOTEXT + lv_text = 'While creating HTTP Client'. ENDCASE. zcx_abapgit_exception=>raise( lv_text ). @@ -184,7 +184,7 @@ CLASS ZCL_ABAPGIT_HTTP IMPLEMENTATION. value = 'GET' ). li_client->request->set_header_field( name = 'user-agent' - value = get_agent( ) ). "#EC NOTEXT + value = get_agent( ) ). lv_uri = zcl_abapgit_url=>path_name( iv_url ) && '/info/refs?service=git-' && iv_service && diff --git a/src/http/zcl_abapgit_http_client.clas.abap b/src/http/zcl_abapgit_http_client.clas.abap index 55dbbe1b2..a37aca1dd 100644 --- a/src/http/zcl_abapgit_http_client.clas.abap +++ b/src/http/zcl_abapgit_http_client.clas.abap @@ -176,16 +176,16 @@ CLASS zcl_abapgit_http_client IMPLEMENTATION. value = lv_value ). lv_value = 'application/x-git-' - && iv_service && '-pack-request'. "#EC NOTEXT + && iv_service && '-pack-request'. mi_client->request->set_header_field( name = 'Content-Type' - value = lv_value ). "#EC NOTEXT + value = lv_value ). lv_value = 'application/x-git-' - && iv_service && '-pack-result'. "#EC NOTEXT + && iv_service && '-pack-result'. mi_client->request->set_header_field( name = 'Accept' - value = lv_value ). "#EC NOTEXT + value = lv_value ). IF mo_digest IS BOUND. mo_digest->run( mi_client ). diff --git a/src/http/zcx_abapgit_2fa_auth_failed.clas.abap b/src/http/zcx_abapgit_2fa_auth_failed.clas.abap index b51b6def9..b87f215b7 100644 --- a/src/http/zcx_abapgit_2fa_auth_failed.clas.abap +++ b/src/http/zcx_abapgit_2fa_auth_failed.clas.abap @@ -34,6 +34,6 @@ MV_TEXT = MV_TEXT METHOD get_default_text. - rv_text = 'Authentication failed using 2FA.' ##NO_TEXT. + rv_text = 'Authentication failed using 2FA.' . ENDMETHOD. ENDCLASS. diff --git a/src/http/zcx_abapgit_2fa_comm_error.clas.abap b/src/http/zcx_abapgit_2fa_comm_error.clas.abap index d06f0cb23..5bf1b1d97 100644 --- a/src/http/zcx_abapgit_2fa_comm_error.clas.abap +++ b/src/http/zcx_abapgit_2fa_comm_error.clas.abap @@ -34,6 +34,6 @@ MV_TEXT = MV_TEXT METHOD get_default_text. - rv_text = 'Communication error.' ##NO_TEXT. + rv_text = 'Communication error.' . ENDMETHOD. ENDCLASS. diff --git a/src/http/zcx_abapgit_2fa_del_failed.clas.abap b/src/http/zcx_abapgit_2fa_del_failed.clas.abap index d2ee8f5c9..dd90f2698 100644 --- a/src/http/zcx_abapgit_2fa_del_failed.clas.abap +++ b/src/http/zcx_abapgit_2fa_del_failed.clas.abap @@ -34,6 +34,6 @@ MV_TEXT = MV_TEXT METHOD get_default_text. - rv_text = 'Deleting previous access tokens failed.' ##NO_TEXT. + rv_text = 'Deleting previous access tokens failed.' . ENDMETHOD. ENDCLASS. diff --git a/src/http/zcx_abapgit_2fa_error.clas.abap b/src/http/zcx_abapgit_2fa_error.clas.abap index 354be43f7..6bd2939b9 100644 --- a/src/http/zcx_abapgit_2fa_error.clas.abap +++ b/src/http/zcx_abapgit_2fa_error.clas.abap @@ -40,7 +40,7 @@ me->MV_TEXT = MV_TEXT . METHOD get_default_text. - rv_text = 'Error in two factor authentication.' ##NO_TEXT. + rv_text = 'Error in two factor authentication.' . ENDMETHOD. diff --git a/src/http/zcx_abapgit_2fa_gen_failed.clas.abap b/src/http/zcx_abapgit_2fa_gen_failed.clas.abap index 5bfff4b2a..e0302d4a8 100644 --- a/src/http/zcx_abapgit_2fa_gen_failed.clas.abap +++ b/src/http/zcx_abapgit_2fa_gen_failed.clas.abap @@ -34,6 +34,6 @@ MV_TEXT = MV_TEXT METHOD get_default_text. - rv_text = 'Two factor access token generation failed.' ##NO_TEXT. + rv_text = 'Two factor access token generation failed.' . ENDMETHOD. ENDCLASS. diff --git a/src/http/zcx_abapgit_2fa_illegal_state.clas.abap b/src/http/zcx_abapgit_2fa_illegal_state.clas.abap index 282dfc73b..47e632fe0 100644 --- a/src/http/zcx_abapgit_2fa_illegal_state.clas.abap +++ b/src/http/zcx_abapgit_2fa_illegal_state.clas.abap @@ -34,6 +34,6 @@ MV_TEXT = MV_TEXT METHOD get_default_text. - rv_text = 'Illegal state.' ##NO_TEXT. + rv_text = 'Illegal state.' . ENDMETHOD. ENDCLASS. diff --git a/src/http/zcx_abapgit_2fa_unsupported.clas.abap b/src/http/zcx_abapgit_2fa_unsupported.clas.abap index 02fa62e64..bd94a4d8e 100644 --- a/src/http/zcx_abapgit_2fa_unsupported.clas.abap +++ b/src/http/zcx_abapgit_2fa_unsupported.clas.abap @@ -34,6 +34,6 @@ MV_TEXT = MV_TEXT METHOD get_default_text. - rv_text = 'The service is not supported for two factor authentication.' ##NO_TEXT. + rv_text = 'The service is not supported for two factor authentication.' . ENDMETHOD. ENDCLASS. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap index ab3cf8b78..cfde24152 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap @@ -127,7 +127,7 @@ CLASS zcl_abapgit_ecatt_helper IMPLEMENTATION. lo_xml->get_attributes( IMPORTING ex_dom = ri_template_over_all ). * MD: Workaround, because nodes starting with "XML" are not allowed - li_nc_xmlref_typ ?= ri_template_over_all->get_elements_by_tag_name_ns( 'XMLREF_TYP' ). "#EC NOTEXT + li_nc_xmlref_typ ?= ri_template_over_all->get_elements_by_tag_name_ns( 'XMLREF_TYP' ). CALL METHOD li_nc_xmlref_typ->('GET_LENGTH') " downport RECEIVING rval = lv_count. diff --git a/src/objects/zcl_abapgit_object_clas.clas.abap b/src/objects/zcl_abapgit_object_clas.clas.abap index 64757d437..d2aea3226 100644 --- a/src/objects/zcl_abapgit_object_clas.clas.abap +++ b/src/objects/zcl_abapgit_object_clas.clas.abap @@ -112,16 +112,16 @@ CLASS ZCL_ABAPGIT_OBJECT_CLAS IMPLEMENTATION. lt_source = mo_files->read_abap( ). lt_local_definitions = mo_files->read_abap( iv_extra = 'locals_def' - iv_error = abap_false ). "#EC NOTEXT + iv_error = abap_false ). lt_local_implementations = mo_files->read_abap( iv_extra = 'locals_imp' - iv_error = abap_false ). "#EC NOTEXT + iv_error = abap_false ). lt_local_macros = mo_files->read_abap( iv_extra = 'macros' - iv_error = abap_false ). "#EC NOTEXT + iv_error = abap_false ). lt_test_classes = mo_files->read_abap( iv_extra = 'testclasses' - iv_error = abap_false ). "#EC NOTEXT + iv_error = abap_false ). ls_class_key-clsname = ms_item-obj_name. @@ -653,7 +653,7 @@ CLASS ZCL_ABAPGIT_OBJECT_CLAS IMPLEMENTATION. iv_type = seop_ext_class_locals_def ). IF lines( lt_source ) > 0. mo_files->add_abap( iv_extra = 'locals_def' - it_abap = lt_source ). "#EC NOTEXT + it_abap = lt_source ). ENDIF. lt_source = mi_object_oriented_object_fct->serialize_abap( @@ -661,7 +661,7 @@ CLASS ZCL_ABAPGIT_OBJECT_CLAS IMPLEMENTATION. iv_type = seop_ext_class_locals_imp ). IF lines( lt_source ) > 0. mo_files->add_abap( iv_extra = 'locals_imp' - it_abap = lt_source ). "#EC NOTEXT + it_abap = lt_source ). ENDIF. lt_source = mi_object_oriented_object_fct->serialize_abap( @@ -671,7 +671,7 @@ CLASS ZCL_ABAPGIT_OBJECT_CLAS IMPLEMENTATION. mv_skip_testclass = mi_object_oriented_object_fct->get_skip_test_classes( ). IF lines( lt_source ) > 0 AND mv_skip_testclass = abap_false. mo_files->add_abap( iv_extra = 'testclasses' - it_abap = lt_source ). "#EC NOTEXT + it_abap = lt_source ). ENDIF. lt_source = mi_object_oriented_object_fct->serialize_abap( @@ -679,7 +679,7 @@ CLASS ZCL_ABAPGIT_OBJECT_CLAS IMPLEMENTATION. iv_type = seop_ext_class_macros ). IF lines( lt_source ) > 0. mo_files->add_abap( iv_extra = 'macros' - it_abap = lt_source ). "#EC NOTEXT + it_abap = lt_source ). ENDIF. serialize_xml( io_xml ). diff --git a/src/objects/zcl_abapgit_object_ddls.clas.abap b/src/objects/zcl_abapgit_object_ddls.clas.abap index 96fe3c0fb..10d81c2bd 100644 --- a/src/objects/zcl_abapgit_object_ddls.clas.abap +++ b/src/objects/zcl_abapgit_object_ddls.clas.abap @@ -187,7 +187,7 @@ CLASS ZCL_ABAPGIT_OBJECT_DDLS IMPLEMENTATION. ASSIGN COMPONENT 'SOURCE' OF STRUCTURE TO . ASSERT sy-subrc = 0. - = mo_files->read_string( 'asddls' ) ##no_text. + = mo_files->read_string( 'asddls' ). CALL METHOD ('CL_DD_DDL_HANDLER_FACTORY')=>('CREATE') RECEIVING @@ -375,7 +375,7 @@ CLASS ZCL_ABAPGIT_OBJECT_DDLS IMPLEMENTATION. ASSIGN COMPONENT 'BASEINFO_STRING' OF STRUCTURE TO . ASSERT sy-subrc = 0. mo_files->add_string( iv_ext = 'baseinfo' - iv_string = ) ##no_text. + iv_string = ). EXIT. ENDIF. ENDLOOP. @@ -411,7 +411,7 @@ CLASS ZCL_ABAPGIT_OBJECT_DDLS IMPLEMENTATION. ASSERT sy-subrc = 0. mo_files->add_string( iv_ext = 'asddls' - iv_string = ) ##no_text. + iv_string = ). CLEAR . @@ -424,7 +424,7 @@ CLASS ZCL_ABAPGIT_OBJECT_DDLS IMPLEMENTATION. METHOD read_baseinfo. TRY. - rv_baseinfo_string = mo_files->read_string( 'baseinfo' ) ##no_text. + rv_baseinfo_string = mo_files->read_string( 'baseinfo' ). CATCH zcx_abapgit_exception. " File not found. That's ok, as the object could have been created in a diff --git a/src/objects/zcl_abapgit_object_ddlx.clas.abap b/src/objects/zcl_abapgit_object_ddlx.clas.abap index 4a3fd6d6d..2b3fcb739 100644 --- a/src/objects/zcl_abapgit_object_ddlx.clas.abap +++ b/src/objects/zcl_abapgit_object_ddlx.clas.abap @@ -157,7 +157,7 @@ CLASS zcl_abapgit_object_ddlx IMPLEMENTATION. TRY. " If the file doesn't exist that's ok, because previously " the source code was stored in the xml. We are downward compatible. - = mo_files->read_string( 'asddlxs' ) ##no_text. + = mo_files->read_string( 'asddlxs' ). CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. diff --git a/src/objects/zcl_abapgit_object_dtel.clas.abap b/src/objects/zcl_abapgit_object_dtel.clas.abap index 091e7438e..8e2608ad0 100644 --- a/src/objects/zcl_abapgit_object_dtel.clas.abap +++ b/src/objects/zcl_abapgit_object_dtel.clas.abap @@ -287,7 +287,7 @@ CLASS ZCL_ABAPGIT_OBJECT_DTEL IMPLEMENTATION. AND as4local = 'A' AND as4vers = '0000'. IF sy-subrc <> 0 OR ls_dd04v IS INITIAL. - zcx_abapgit_exception=>raise( 'Not found in DD04L' ) ##NO_TEXT. + zcx_abapgit_exception=>raise( 'Not found in DD04L' ). ENDIF. SELECT SINGLE * FROM dd04t diff --git a/src/objects/zcl_abapgit_object_ensc.clas.abap b/src/objects/zcl_abapgit_object_ensc.clas.abap index 6bb8b4874..cfda6f89b 100644 --- a/src/objects/zcl_abapgit_object_ensc.clas.abap +++ b/src/objects/zcl_abapgit_object_ensc.clas.abap @@ -38,7 +38,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ENSC IMPLEMENTATION. li_spot_ref->if_enh_object~unlock( ). CATCH cx_enh_root INTO lx_root. lv_message = `Error occured while deleting ENSC: ` - && lx_root->get_text( ) ##NO_TEXT. + && lx_root->get_text( ). zcx_abapgit_exception=>raise( lv_message ). ENDTRY. @@ -106,7 +106,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ENSC IMPLEMENTATION. CATCH cx_enh_root INTO lx_root. lv_message = `Error occured while deserializing ENSC: ` - && lx_root->get_text( ) ##NO_TEXT. + && lx_root->get_text( ). zcx_abapgit_exception=>raise( lv_message ). ENDTRY. @@ -213,7 +213,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ENSC IMPLEMENTATION. CATCH cx_enh_root INTO lx_root. lv_message = `Error occured while serializing ENSC: ` - && lx_root->get_text( ) ##NO_TEXT. + && lx_root->get_text( ). zcx_abapgit_exception=>raise( lv_message ). ENDTRY. diff --git a/src/objects/zcl_abapgit_object_form.clas.abap b/src/objects/zcl_abapgit_object_form.clas.abap index 45d456f6f..016fe2d2a 100644 --- a/src/objects/zcl_abapgit_object_form.clas.abap +++ b/src/objects/zcl_abapgit_object_form.clas.abap @@ -195,7 +195,7 @@ CLASS ZCL_ABAPGIT_OBJECT_FORM IMPLEMENTATION. TABLES selections = rt_text_header EXCEPTIONS - OTHERS = 1 ##fm_subrc_ok ##NO_TEXT. "#EC CI_SUBRC + OTHERS = 1 ##fm_subrc_ok. "#EC CI_SUBRC ENDMETHOD. @@ -372,16 +372,16 @@ CLASS ZCL_ABAPGIT_OBJECT_FORM IMPLEMENTATION. FIELD-SYMBOLS: LIKE LINE OF lt_bdcdata. APPEND INITIAL LINE TO lt_bdcdata ASSIGNING . - -program = 'SAPMSSCF' ##NO_TEXT. - -dynpro = '1102' ##NO_TEXT. + -program = 'SAPMSSCF'. + -dynpro = '1102'. -dynbegin = abap_true. APPEND INITIAL LINE TO lt_bdcdata ASSIGNING . - -fnam = 'BDC_OKCODE' ##NO_TEXT. - -fval = '=SHOW' ##NO_TEXT. + -fnam = 'BDC_OKCODE'. + -fval = '=SHOW'. APPEND INITIAL LINE TO lt_bdcdata ASSIGNING . - -fnam = 'RSSCF-TDFORM' ##NO_TEXT. + -fnam = 'RSSCF-TDFORM'. -fval = ms_item-obj_name. CALL FUNCTION 'ABAP4_CALL_TRANSACTION' diff --git a/src/objects/zcl_abapgit_object_iatu.clas.abap b/src/objects/zcl_abapgit_object_iatu.clas.abap index fe6bd604c..b38556595 100644 --- a/src/objects/zcl_abapgit_object_iatu.clas.abap +++ b/src/objects/zcl_abapgit_object_iatu.clas.abap @@ -143,7 +143,7 @@ CLASS zcl_abapgit_object_iatu IMPLEMENTATION. io_xml->read( EXPORTING iv_name = 'ATTR' CHANGING cg_data = ls_attr ). - lv_source = mo_files->read_string( 'html' ) ##NO_TEXT. + lv_source = mo_files->read_string( 'html' ). ls_attr-devclass = iv_package. save( is_attr = ls_attr @@ -218,7 +218,7 @@ CLASS zcl_abapgit_object_iatu IMPLEMENTATION. ig_data = ls_attr ). mo_files->add_string( iv_ext = 'html' - iv_string = lv_source ) ##NO_TEXT. + iv_string = lv_source ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_scp1.clas.abap b/src/objects/zcl_abapgit_object_scp1.clas.abap index e18669101..b9b67411a 100644 --- a/src/objects/zcl_abapgit_object_scp1.clas.abap +++ b/src/objects/zcl_abapgit_object_scp1.clas.abap @@ -101,8 +101,8 @@ CLASS ZCL_ABAPGIT_OBJECT_SCP1 IMPLEMENTATION. METHOD call_delete_fms. CONSTANTS: - lc_version_new TYPE c VALUE 'N' ##NO_TEXT, "Include SCPRINTCONST version_new - lc_operation_delete TYPE c VALUE 'D' ##NO_TEXT. + lc_version_new TYPE c VALUE 'N', "Include SCPRINTCONST version_new + lc_operation_delete TYPE c VALUE 'D'. DATA: lv_profile_type TYPE scprattr-type, diff --git a/src/objects/zcl_abapgit_object_ssfo.clas.abap b/src/objects/zcl_abapgit_object_ssfo.clas.abap index 812446b9e..82a595d78 100644 --- a/src/objects/zcl_abapgit_object_ssfo.clas.abap +++ b/src/objects/zcl_abapgit_object_ssfo.clas.abap @@ -43,8 +43,8 @@ CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION. METHOD code_item_section_handling. - CONSTANTS: lc_node_item TYPE string VALUE 'item' ##NO_TEXT. - CONSTANTS: lc_node_text TYPE string VALUE '#text' ##NO_TEXT. + CONSTANTS: lc_node_item TYPE string VALUE 'item'. + CONSTANTS: lc_node_text TYPE string VALUE '#text'. IF iv_name IN get_range_node_codes( ). cv_within_code_section = abap_true. @@ -451,10 +451,10 @@ CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION. li_element->set_attribute( name = 'sf' namespace = 'xmlns' - value = 'urn:sap-com:SmartForms:2000:internal-structure' ). "#EC NOTEXT + value = 'urn:sap-com:SmartForms:2000:internal-structure' ). li_element->set_attribute( name = 'xmlns' - value = 'urn:sap-com:sdixml-ifr:2000' ). "#EC NOTEXT + value = 'urn:sap-com:sdixml-ifr:2000' ). io_xml->set_raw( li_xml_doc->get_root_element( ) ). diff --git a/src/objects/zcl_abapgit_object_tabl.clas.abap b/src/objects/zcl_abapgit_object_tabl.clas.abap index 8a5d78640..4ee9c29cf 100644 --- a/src/objects/zcl_abapgit_object_tabl.clas.abap +++ b/src/objects/zcl_abapgit_object_tabl.clas.abap @@ -103,7 +103,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL IMPLEMENTATION. METHOD clear_dd03p_fields. - CONSTANTS lc_comptype_dataelement TYPE comptype VALUE 'E' ##NO_TEXT. + CONSTANTS lc_comptype_dataelement TYPE comptype VALUE 'E'. DATA: lv_masklen TYPE c LENGTH 4. diff --git a/src/objects/zcl_abapgit_object_xslt.clas.abap b/src/objects/zcl_abapgit_object_xslt.clas.abap index 8f37e5a6f..31324be57 100644 --- a/src/objects/zcl_abapgit_object_xslt.clas.abap +++ b/src/objects/zcl_abapgit_object_xslt.clas.abap @@ -112,7 +112,7 @@ CLASS ZCL_ABAPGIT_OBJECT_XSLT IMPLEMENTATION. ls_attributes-devclass = iv_package. lv_source = mo_files->read_string( iv_extra = 'source' - iv_ext = 'xml' ) ##NO_TEXT. + iv_ext = 'xml' ). * workaround: somewhere additional linefeeds are added lv_len = strlen( lv_source ) - 2. @@ -224,7 +224,7 @@ CLASS ZCL_ABAPGIT_OBJECT_XSLT IMPLEMENTATION. mo_files->add_string( iv_extra = 'source' iv_ext = 'xml' - iv_string = lv_source ) ##NO_TEXT. + iv_string = lv_source ). ENDMETHOD. ENDCLASS. diff --git a/src/objects/zcl_abapgit_objects.clas.abap b/src/objects/zcl_abapgit_objects.clas.abap index c784398bd..c9391167c 100644 --- a/src/objects/zcl_abapgit_objects.clas.abap +++ b/src/objects/zcl_abapgit_objects.clas.abap @@ -343,7 +343,7 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. METHOD class_name. - CONCATENATE 'ZCL_ABAPGIT_OBJECT_' is_item-obj_type INTO rv_class_name. "#EC NOTEXT + CONCATENATE 'ZCL_ABAPGIT_OBJECT_' is_item-obj_type INTO rv_class_name. ENDMETHOD. @@ -413,7 +413,7 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. answer = lv_answer EXCEPTIONS text_not_found = 1 - OTHERS = 2. "#EC NOTEXT + OTHERS = 2. IF sy-subrc <> 0 OR lv_answer = 1. zcx_abapgit_exception=>raise( |Deserialization for object { is_result-obj_name } | & |(type { is_result-obj_type }) aborted by user| ). @@ -459,7 +459,7 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. is_item = is_item iv_language = iv_language. CATCH cx_sy_create_object_error. - lv_message = |Object type { is_item-obj_type } not supported, serialize|. "#EC NOTEXT + lv_message = |Object type { is_item-obj_type } not supported, serialize|. IF iv_native_only = abap_false. TRY. " 2nd step, try looking for plugins CREATE OBJECT ri_obj TYPE zcl_abapgit_objects_bridge @@ -505,7 +505,7 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. LOOP AT lt_tadir ASSIGNING . li_progress->show( iv_current = sy-tabix - iv_text = |Delete { -obj_name }| ) ##NO_TEXT. + iv_text = |Delete { -obj_name }| ). CLEAR ls_item. ls_item-obj_type = -object. @@ -618,7 +618,7 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. lo_folder_logic = zcl_abapgit_folder_logic=>get_instance( ). LOOP AT lt_results ASSIGNING . li_progress->show( iv_current = sy-tabix - iv_text = |Deserialize { -obj_name }| ) ##NO_TEXT. + iv_text = |Deserialize { -obj_name }| ). CLEAR ls_item. ls_item-obj_type = -obj_type. @@ -748,7 +748,7 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. LOOP AT is_step-objects ASSIGNING . li_progress->show( iv_current = sy-tabix - iv_text = |Deserialize { is_step-descr } - { -item-obj_name }| ) ##NO_TEXT. + iv_text = |Deserialize { is_step-descr } - { -item-obj_name }| ). TRY. -obj->deserialize( iv_package = -package diff --git a/src/objects/zcl_abapgit_objects_files.clas.abap b/src/objects/zcl_abapgit_objects_files.clas.abap index 138422b2a..08a2b5d58 100644 --- a/src/objects/zcl_abapgit_objects_files.clas.abap +++ b/src/objects/zcl_abapgit_objects_files.clas.abap @@ -131,7 +131,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_FILES IMPLEMENTATION. ls_file-path = '/'. ls_file-filename = filename( iv_extra = iv_extra - iv_ext = 'abap' ). "#EC NOTEXT + iv_ext = 'abap' ). ls_file-data = zcl_abapgit_convert=>string_to_xstring_utf8( lv_source ). APPEND ls_file TO mt_files. @@ -160,7 +160,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_FILES IMPLEMENTATION. ls_file-path = '/'. ls_file-filename = filename( iv_extra = iv_extra - iv_ext = iv_ext ). "#EC NOTEXT + iv_ext = iv_ext ). ls_file-data = zcl_abapgit_convert=>string_to_xstring_utf8( iv_string ). APPEND ls_file TO mt_files. @@ -178,7 +178,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_FILES IMPLEMENTATION. ls_file-path = '/'. ls_file-filename = filename( iv_extra = iv_extra - iv_ext = 'xml' ). "#EC NOTEXT + iv_ext = 'xml' ). REPLACE FIRST OCCURRENCE OF REGEX '<\?xml version="1\.0" encoding="[\w-]+"\?>' @@ -245,10 +245,10 @@ CLASS ZCL_ABAPGIT_OBJECTS_FILES IMPLEMENTATION. IF iv_extra IS INITIAL. CONCATENATE lv_obj_name '.' ms_item-obj_type - INTO rv_filename. "#EC NOTEXT + INTO rv_filename. ELSE. CONCATENATE lv_obj_name '.' ms_item-obj_type '.' iv_extra - INTO rv_filename. "#EC NOTEXT + INTO rv_filename. ENDIF. IF iv_ext IS NOT INITIAL. @@ -281,7 +281,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_FILES IMPLEMENTATION. lv_filename = filename( iv_extra = iv_extra - iv_ext = 'abap' ). "#EC NOTEXT + iv_ext = 'abap' ). lv_data = read_file( iv_filename = lv_filename iv_error = iv_error ). @@ -349,7 +349,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_FILES IMPLEMENTATION. lv_data TYPE xstring. lv_filename = filename( iv_extra = iv_extra - iv_ext = iv_ext ). "#EC NOTEXT + iv_ext = iv_ext ). lv_data = read_file( lv_filename ). @@ -365,7 +365,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_FILES IMPLEMENTATION. lv_xml TYPE string. lv_filename = filename( iv_extra = iv_extra - iv_ext = 'xml' ). "#EC NOTEXT + iv_ext = 'xml' ). lv_data = read_file( lv_filename ). diff --git a/src/objects/zcl_abapgit_objects_generic.clas.abap b/src/objects/zcl_abapgit_objects_generic.clas.abap index f6407cd5f..2c025d4a3 100644 --- a/src/objects/zcl_abapgit_objects_generic.clas.abap +++ b/src/objects/zcl_abapgit_objects_generic.clas.abap @@ -156,7 +156,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_GENERIC IMPLEMENTATION. WITH KEY objectname = ms_item-obj_type objecttype = 'L' - method = 'BEFORE_EXP' ##no_text. + method = 'BEFORE_EXP'. IF sy-subrc = 0. lv_client = sy-mandt. diff --git a/src/objects/zcl_abapgit_objects_program.clas.abap b/src/objects/zcl_abapgit_objects_program.clas.abap index 7dface908..96b48b122 100644 --- a/src/objects/zcl_abapgit_objects_program.clas.abap +++ b/src/objects/zcl_abapgit_objects_program.clas.abap @@ -301,7 +301,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_PROGRAM IMPLEMENTATION. METHOD deserialize_dynpros. - CONSTANTS lc_rpyty_force_off TYPE char01 VALUE '/' ##NO_TEXT. + CONSTANTS lc_rpyty_force_off TYPE char01 VALUE '/'. DATA: lv_name TYPE dwinactiv-obj_name, ls_dynpro LIKE LINE OF it_dynpros. diff --git a/src/objects/zcl_abapgit_objects_super.clas.abap b/src/objects/zcl_abapgit_objects_super.clas.abap index 320671b0a..8713670fc 100644 --- a/src/objects/zcl_abapgit_objects_super.clas.abap +++ b/src/objects/zcl_abapgit_objects_super.clas.abap @@ -269,7 +269,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_SUPER IMPLEMENTATION. REPLACE FIRST OCCURRENCE OF 'ZCL_ABAPGIT' IN lv_class WITH 'LCL'. rs_metadata-class = lv_class. - rs_metadata-version = 'v1.0.0' ##no_text. + rs_metadata-version = 'v1.0.0'. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_oo_class.clas.abap b/src/objects/zcl_abapgit_oo_class.clas.abap index 30546cc3a..054241a7a 100644 --- a/src/objects/zcl_abapgit_oo_class.clas.abap +++ b/src/objects/zcl_abapgit_oo_class.clas.abap @@ -354,8 +354,8 @@ CLASS ZCL_ABAPGIT_OO_CLASS IMPLEMENTATION. METHOD update_source_index. CONSTANTS: - lc_version_active TYPE r3state VALUE 'A', "#EC NOTEXT - lc_version_inactive TYPE r3state VALUE 'I'. "#EC NOTEXT + lc_version_active TYPE r3state VALUE 'A', + lc_version_inactive TYPE r3state VALUE 'I'. " dynamic invocation, IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist in 702. DATA lo_index_helper TYPE REF TO object. diff --git a/src/persist/zcl_abapgit_persist_background.clas.abap b/src/persist/zcl_abapgit_persist_background.clas.abap index 5f19ab96e..187c813f5 100644 --- a/src/persist/zcl_abapgit_persist_background.clas.abap +++ b/src/persist/zcl_abapgit_persist_background.clas.abap @@ -90,7 +90,7 @@ CLASS ZCL_ABAPGIT_PERSIST_BACKGROUND IMPLEMENTATION. CALL TRANSFORMATION id OPTIONS value_handling = 'accept_data_loss' SOURCE XML iv_string - RESULT data = rs_xml ##NO_TEXT. + RESULT data = rs_xml. ENDMETHOD. diff --git a/src/persist/zcl_abapgit_persistence_repo.clas.abap b/src/persist/zcl_abapgit_persistence_repo.clas.abap index ff6531e9e..c32cbf719 100644 --- a/src/persist/zcl_abapgit_persistence_repo.clas.abap +++ b/src/persist/zcl_abapgit_persistence_repo.clas.abap @@ -76,7 +76,7 @@ CLASS ZCL_ABAPGIT_PERSISTENCE_REPO IMPLEMENTATION. CALL TRANSFORMATION id OPTIONS value_handling = 'accept_data_loss' SOURCE XML lv_xml - RESULT repo = rs_repo ##NO_TEXT. + RESULT repo = rs_repo. * automatic migration of old fields FIND FIRST OCCURRENCE OF 'X' IN lv_xml. diff --git a/src/persist/zcl_abapgit_persistence_user.clas.abap b/src/persist/zcl_abapgit_persistence_user.clas.abap index 506fa5c9f..352861ddd 100644 --- a/src/persist/zcl_abapgit_persistence_user.clas.abap +++ b/src/persist/zcl_abapgit_persistence_user.clas.abap @@ -103,7 +103,7 @@ CLASS ZCL_ABAPGIT_PERSISTENCE_USER IMPLEMENTATION. CALL TRANSFORMATION id OPTIONS value_handling = 'accept_data_loss' SOURCE XML lv_xml - RESULT user = rs_user ##NO_TEXT. + RESULT user = rs_user. ENDMETHOD. diff --git a/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap b/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap index d10e228cd..00e352898 100644 --- a/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap +++ b/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap @@ -121,7 +121,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = '* commented out line with key word data'. "#EC NOTEXT + lv_line = '* commented out line with key word data'. " Generate table with expected values after parsing generate_parse( iv_token = 'C' @@ -171,7 +171,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = 'data: lv_var_name type string.'. "#EC NOTEXT + lv_line = 'data: lv_var_name type string.'. " Generate table with expected values after parsing generate_parse( iv_token = 'K' @@ -222,7 +222,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = 'call function ''FM_NAME''. " Commented'. "#EC NOTEXT + lv_line = 'call function ''FM_NAME''. " Commented'. " Generate table with expected values after parsing generate_parse( iv_token = 'K' @@ -301,7 +301,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = 'constants: lc_var type string value ''simpletext data simpletext''.'. "#EC NOTEXT + lv_line = 'constants: lc_var type string value ''simpletext data simpletext''.'. " Generate table with expected values after parsing generate_parse( iv_token = 'K' @@ -387,7 +387,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = 'a = |{ b }={ c }|.'. "#EC NOTEXT + lv_line = 'a = |{ b }={ c }|.'. " Generate table with expected values after parsing generate_parse( iv_token = 'T' @@ -480,7 +480,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = 'lv_line = lc_constant && |XYZ { ''ab'' && |ac{ ''UU'' }| }|'. "#EC NOTEXT + lv_line = 'lv_line = lc_constant && |XYZ { ''ab'' && |ac{ ''UU'' }| }|'. " Generate table with expected values after parsing generate_parse( iv_token = 'K' @@ -638,7 +638,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = 'SELECT * FROM foo'. "#EC NOTEXT + lv_line = 'SELECT * FROM foo'. " Generate table with expected values after parsing generate_parse( iv_token = 'K' @@ -689,7 +689,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = 'lv_length = -length.'. "#EC NOTEXT + lv_line = 'lv_length = -length.'. " Generate table with expected values after parsing generate_parse( iv_token = 'K' @@ -717,7 +717,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = 'Text'. "#EC NOTEXT + lv_line = 'Text'. " Generate table with expected values after parsing generate_parse( iv_token = 'X' @@ -767,7 +767,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = ''. "#EC NOTEXT + lv_line = ''. " Generate table with expected values after parsing generate_parse( iv_token = 'X' @@ -797,7 +797,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = ''. "#EC NOTEXT + lv_line = ''. " Generate table with expected values after parsing generate_parse( iv_token = 'X' @@ -862,7 +862,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = ''. "#EC NOTEXT + lv_line = ''. " Generate table with expected values after parsing generate_parse( iv_token = 'X' @@ -927,7 +927,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. - lv_line = '"text"'. "#EC NOTEXT + lv_line = '"text"'. " Generate table with expected values after parsing generate_parse( iv_token = 'X' @@ -1039,7 +1039,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. "unclosed tag - lv_line = ' "/>'. "#EC NOTEXT + lv_line = ''. " Generate table with expected values after parsing generate_parse( iv_token = 'X' @@ -1161,7 +1161,7 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. DATA lv_line TYPE string. "attribute at beginning of line - lv_line = 'attribute=''>" '''. "#EC NOTEXT + lv_line = 'attribute=''>" '''. " Generate table with expected values after parsing generate_parse( iv_token = 'A' @@ -1242,13 +1242,13 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION. lv_line_act TYPE string, lv_line_exp TYPE string. - lv_line = 'call function ''FM_NAME''. " Commented'. "#EC NOTEXT + lv_line = 'call function ''FM_NAME''. " Commented'. lv_line_exp = - 'call' && "#EC NOTEXT - ' function' && "#EC NOTEXT - ' 'FM_NAME'.' && "#EC NOTEXT - ' " Commented'. "#EC NOTEXT + 'call' && + ' function' && + ' 'FM_NAME'.' && + ' " Commented'. lv_line_act = mo_syntax_highlighter->process_line( lv_line ). @@ -1263,13 +1263,13 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION. DATA lv_line_act TYPE string. " Call the method and compare results - lv_line_act = mo_syntax_highlighter->apply_style( iv_line = 'CALL FUNCTION' "#EC NOTEXT + lv_line_act = mo_syntax_highlighter->apply_style( iv_line = 'CALL FUNCTION' iv_class = zcl_abapgit_syntax_abap=>c_css-keyword ). cl_abap_unit_assert=>assert_equals( act = lv_line_act - exp = 'CALL FUNCTION' "#EC NOTEXT - msg = 'Failure during applying of style.' ). "#EC NOTEXT + exp = 'CALL FUNCTION' + msg = 'Failure during applying of style.' ). ENDMETHOD. @@ -1283,15 +1283,15 @@ CLASS ltcl_syntax_basic_logic IMPLEMENTATION. cl_abap_unit_assert=>assert_equals( act = lv_line_act exp = '' - msg = 'Failure in method process_line.' ). "#EC NOTEXT + msg = 'Failure in method process_line.' ). " Call the method with non-empty line and compare results - lv_line_act = mo_syntax_highlighter->process_line( '* CALL FUNCTION' ). "#EC NOTEXT + lv_line_act = mo_syntax_highlighter->process_line( '* CALL FUNCTION' ). cl_abap_unit_assert=>assert_equals( act = lv_line_act - exp = '* CALL FUNCTION' "#EC NOTEXT - msg = 'Failure in method process_line.' ). "#EC NOTEXT + exp = '* CALL FUNCTION' + msg = 'Failure in method process_line.' ). ENDMETHOD. diff --git a/src/ui/core/zcl_abapgit_gui.clas.abap b/src/ui/core/zcl_abapgit_gui.clas.abap index eeed9355b..ddfe4f947 100644 --- a/src/ui/core/zcl_abapgit_gui.clas.abap +++ b/src/ui/core/zcl_abapgit_gui.clas.abap @@ -438,7 +438,7 @@ CLASS ZCL_ABAPGIT_GUI IMPLEMENTATION. CHANGING data_table = lt_html EXCEPTIONS - OTHERS = 1 ) ##NO_TEXT. + OTHERS = 1 ). ELSE. " Raw input zcl_abapgit_convert=>xstring_to_bintab( EXPORTING @@ -458,7 +458,7 @@ CLASS ZCL_ABAPGIT_GUI IMPLEMENTATION. CHANGING data_table = lt_xdata EXCEPTIONS - OTHERS = 1 ) ##NO_TEXT. + OTHERS = 1 ). ENDIF. ASSERT sy-subrc = 0. " Image data error diff --git a/src/ui/core/zcl_abapgit_html.clas.abap b/src/ui/core/zcl_abapgit_html.clas.abap index 8d92d5130..f0561bcce 100644 --- a/src/ui/core/zcl_abapgit_html.clas.abap +++ b/src/ui/core/zcl_abapgit_html.clas.abap @@ -239,13 +239,13 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION. lv_class = iv_class. IF iv_opt CA zif_abapgit_html=>c_html_opt-strong. - lv_class = lv_class && ' emphasis' ##NO_TEXT. + lv_class = lv_class && ' emphasis'. ENDIF. IF iv_opt CA zif_abapgit_html=>c_html_opt-cancel. - lv_class = lv_class && ' attention' ##NO_TEXT. + lv_class = lv_class && ' attention'. ENDIF. IF iv_opt CA zif_abapgit_html=>c_html_opt-crossout. - lv_class = lv_class && ' crossout grey' ##NO_TEXT. + lv_class = lv_class && ' crossout grey'. ENDIF. IF lv_class IS NOT INITIAL. SHIFT lv_class LEFT DELETING LEADING space. diff --git a/src/ui/db/zcl_abapgit_gui_page_db.clas.abap b/src/ui/db/zcl_abapgit_gui_page_db.clas.abap index f4308251c..02951f90d 100644 --- a/src/ui/db/zcl_abapgit_gui_page_db.clas.abap +++ b/src/ui/db/zcl_abapgit_gui_page_db.clas.abap @@ -61,7 +61,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DB IMPLEMENTATION. iv_text_button_2 = 'Cancel' iv_icon_button_2 = 'ICON_CANCEL' iv_default_button = '2' - iv_display_cancel_button = abap_false ). "#EC NOTEXT + iv_display_cancel_button = abap_false ). IF lv_answer = '2'. RAISE EXCEPTION TYPE zcx_abapgit_cancel. @@ -160,7 +160,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DB IMPLEMENTATION. LOOP AT lt_data ASSIGNING . CLEAR lv_trclass. IF sy-tabix = 1. - lv_trclass = ' class="firstrow"' ##NO_TEXT. + lv_trclass = ' class="firstrow"'. ENDIF. lv_action = zcl_abapgit_html_action_utils=>dbkey_encode( ). diff --git a/src/ui/db/zcl_abapgit_gui_page_db_dis.clas.abap b/src/ui/db/zcl_abapgit_gui_page_db_dis.clas.abap index e6bd0ffcf..32dd7078f 100644 --- a/src/ui/db/zcl_abapgit_gui_page_db_dis.clas.abap +++ b/src/ui/db/zcl_abapgit_gui_page_db_dis.clas.abap @@ -60,7 +60,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DB_DIS IMPLEMENTATION. CREATE OBJECT ri_html TYPE zcl_abapgit_html. CREATE OBJECT lo_toolbar. lo_toolbar->add( iv_act = |{ zif_abapgit_definitions=>c_action-db_edit }?{ lv_action }| - iv_txt = 'Edit' ) ##NO_TEXT. + iv_txt = 'Edit' ). ri_html->add( '
' ). ri_html->add( '
' ). diff --git a/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap b/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap index df69c98e6..9e7ecdcc2 100644 --- a/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap +++ b/src/ui/db/zcl_abapgit_gui_page_db_edit.clas.abap @@ -102,7 +102,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DB_EDIT IMPLEMENTATION. lo_toolbar->add( iv_act = 'submitFormById(''db_form'');' iv_txt = 'Save' iv_typ = zif_abapgit_html=>c_action_type-onclick - iv_opt = zif_abapgit_html=>c_html_opt-strong ) ##NO_TEXT. + iv_opt = zif_abapgit_html=>c_html_opt-strong ). ri_html->add( '
' ). diff --git a/src/ui/zcl_abapgit_frontend_services.clas.abap b/src/ui/zcl_abapgit_frontend_services.clas.abap index fd8b67666..6e2cf75c1 100644 --- a/src/ui/zcl_abapgit_frontend_services.clas.abap +++ b/src/ui/zcl_abapgit_frontend_services.clas.abap @@ -55,7 +55,7 @@ CLASS ZCL_ABAPGIT_FRONTEND_SERVICES IMPLEMENTATION. error_no_gui = 23 OTHERS = 24 ). IF sy-subrc <> 0. - zcx_abapgit_exception=>raise( 'error from gui_download' ). "#EC NOTEXT + zcx_abapgit_exception=>raise( 'error from gui_download' ). ENDIF. ENDMETHOD. @@ -135,10 +135,10 @@ CLASS ZCL_ABAPGIT_FRONTEND_SERVICES IMPLEMENTATION. not_supported_by_gui = 4 OTHERS = 5 ). IF sy-subrc <> 0. - zcx_abapgit_exception=>raise( 'error from file_open_dialog' ). "#EC NOTEXT + zcx_abapgit_exception=>raise( 'error from file_open_dialog' ). ENDIF. IF lv_action = cl_gui_frontend_services=>action_cancel. - zcx_abapgit_exception=>raise( 'cancelled' ). "#EC NOTEXT + zcx_abapgit_exception=>raise( 'cancelled' ). ENDIF. READ TABLE lt_file_table INDEX 1 INTO ls_file_table. @@ -177,10 +177,10 @@ CLASS ZCL_ABAPGIT_FRONTEND_SERVICES IMPLEMENTATION. not_supported_by_gui = 3 OTHERS = 4 ). IF sy-subrc <> 0. - zcx_abapgit_exception=>raise( 'error from file_save_dialog' ). "#EC NOTEXT + zcx_abapgit_exception=>raise( 'error from file_save_dialog' ). ENDIF. IF lv_action = cl_gui_frontend_services=>action_cancel. - zcx_abapgit_exception=>raise( 'cancelled' ). "#EC NOTEXT + zcx_abapgit_exception=>raise( 'cancelled' ). ENDIF. ENDMETHOD. diff --git a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap index 3ed98c7a8..1de414552 100644 --- a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap @@ -677,11 +677,11 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. CREATE OBJECT lo_pback. IF io_repo->is_offline( ) = abap_true. - lv_icon = 'plug/darkgrey' ##NO_TEXT. - lv_hint = 'Offline repository' ##NO_TEXT. + lv_icon = 'plug/darkgrey'. + lv_hint = 'Offline repository'. ELSE. - lv_icon = 'cloud-upload-alt/blue' ##NO_TEXT. - lv_hint = 'On-line repository' ##NO_TEXT. + lv_icon = 'cloud-upload-alt/blue'. + lv_hint = 'On-line repository'. ENDIF. ri_html->add( '' ). @@ -724,9 +724,9 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. " Fav IF abap_true = zcl_abapgit_persistence_user=>get_instance( )->is_favorite_repo( io_repo->get_key( ) ). - lv_icon = 'star/blue' ##NO_TEXT. + lv_icon = 'star/blue'. ELSE. - lv_icon = 'star/grey' ##NO_TEXT. + lv_icon = 'star/grey'. ENDIF. ri_html->add_a( iv_act = |{ zif_abapgit_definitions=>c_action-repo_toggle_fav }?{ io_repo->get_key( ) }| iv_txt = zcl_abapgit_html=>icon( iv_name = lv_icon diff --git a/src/ui/zcl_abapgit_gui_page.clas.abap b/src/ui/zcl_abapgit_gui_page.clas.abap index 654fbc09b..bd418e9e4 100644 --- a/src/ui/zcl_abapgit_gui_page.clas.abap +++ b/src/ui/zcl_abapgit_gui_page.clas.abap @@ -117,12 +117,12 @@ CLASS ZCL_ABAPGIT_GUI_PAGE IMPLEMENTATION. CREATE OBJECT ri_html TYPE zcl_abapgit_html. - ri_html->add( '' ). "#EC NOTEXT + ri_html->add( '' ). - ri_html->add( '' ). "#EC NOTEXT - ri_html->add( '' ). "#EC NOTEXT + ri_html->add( '' ). + ri_html->add( '' ). - ri_html->add( 'abapGit' ). "#EC NOTEXT + ri_html->add( 'abapGit' ). ri_html->add( '' ). ri_html->add( '' ). @@ -135,7 +135,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE IMPLEMENTATION. ri_html->add( '' ). ENDCASE. - ri_html->add( '' ). "#EC NOTEXT + ri_html->add( '' ). CASE mo_settings->get_icon_scaling( ). " Enforce icon scaling WHEN mo_settings->c_icon_scaling-large. @@ -144,7 +144,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE IMPLEMENTATION. ri_html->add( '' ). ENDCASE. - ri_html->add( '' ). "#EC NOTEXT + ri_html->add( '' ). ENDMETHOD. @@ -312,10 +312,10 @@ CLASS ZCL_ABAPGIT_GUI_PAGE IMPLEMENTATION. " Real page CREATE OBJECT ri_html TYPE zcl_abapgit_html. - ri_html->add( '' ). "#EC NOTEXT - ri_html->add( '' ). "#EC NOTEXT + ri_html->add( '' ). + ri_html->add( '' ). ri_html->add( html_head( ) ). - ri_html->add( '' ). "#EC NOTEXT + ri_html->add( '' ). ri_html->add( title( ) ). ri_html->add( render_content( ) ). " TODO -> render child @@ -328,7 +328,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE IMPLEMENTATION. iv_part_category = c_html_parts-hidden_forms ). ri_html->add( footer( ) ). - ri_html->add( '' ). "#EC NOTEXT + ri_html->add( '' ). li_script = scripts( ). @@ -339,7 +339,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE IMPLEMENTATION. ri_html->add( '' ). ENDIF. - ri_html->add( '' ). "#EC NOTEXT + ri_html->add( '' ). ENDMETHOD. ENDCLASS. diff --git a/src/ui/zcl_abapgit_gui_page_bkg.clas.abap b/src/ui/zcl_abapgit_gui_page_bkg.clas.abap index f8e660612..ea69a6d7e 100644 --- a/src/ui/zcl_abapgit_gui_page_bkg.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_bkg.clas.abap @@ -68,7 +68,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BKG IMPLEMENTATION. CREATE OBJECT ro_menu. ro_menu->add( iv_txt = 'Run background logic' - iv_act = zif_abapgit_definitions=>c_action-go_background_run ) ##NO_TEXT. + iv_act = zif_abapgit_definitions=>c_action-go_background_run ). ENDMETHOD. @@ -173,8 +173,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BKG IMPLEMENTATION. ro_html->add( render_methods( ls_per ) ). - ro_html->add( 'HTTP Authentication, optional
' ) ##NO_TEXT. - ro_html->add( '(password will be saved in clear text)
' ) ##NO_TEXT. + ro_html->add( 'HTTP Authentication, optional
' ). + ro_html->add( '(password will be saved in clear text)
' ). ro_html->add( '
' ). ro_html->add( '' ). ro_html->add( '' ). @@ -221,25 +221,25 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BKG IMPLEMENTATION. lt_methods = zcl_abapgit_background=>list_methods( ). - ro_html->add( 'Method
' ) ##NO_TEXT. + ro_html->add( 'Method
' ). ro_html->add( || ). IF is_per-method IS INITIAL. - lv_checked = ' checked' ##NO_TEXT. + lv_checked = ' checked'. ENDIF. - ro_html->add( 'Do nothing
' ) ##NO_TEXT. + ro_html->add( 'Do nothing
' ). LOOP AT lt_methods INTO ls_method. CLEAR lv_checked. IF is_per-method = ls_method-class. - lv_checked = ' checked' ##NO_TEXT. + lv_checked = ' checked'. ENDIF. ro_html->add( '' && - ls_method-description && '
' ) ##NO_TEXT. + ls_method-description && '
' ). ENDLOOP. ro_html->add( '
' ). @@ -298,7 +298,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BKG IMPLEMENTATION. lo_persistence->modify( is_bg_task ). ENDIF. - MESSAGE 'Saved' TYPE 'S' ##NO_TEXT. + MESSAGE 'Saved' TYPE 'S'. COMMIT WORK. diff --git a/src/ui/zcl_abapgit_gui_page_boverview.clas.abap b/src/ui/zcl_abapgit_gui_page_boverview.clas.abap index f182616f5..badf5bb4c 100644 --- a/src/ui/zcl_abapgit_gui_page_boverview.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_boverview.clas.abap @@ -103,12 +103,12 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BOVERVIEW IMPLEMENTATION. ro_html->add( '' ) ##NO_TEXT. + '' ). ro_html->add( '
Username: