SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-03 05:18:59 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

PREFIX: error handling fixed

Browse Source
This commit is contained in:
larshp 2017-02-15 16:23:14 +00:00
parent 0d2e66e837
commit 9dae60ebad
1 changed files with 29 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/zabapgit_folder_logic.prog.abap
View File

@ -92,17 +92,21 @@ CLASS lcl_folder_logic IMPLEMENTATION.
ENDIF. ENDIF.
WHEN lcl_dot_abapgit=>c_folder_logic-prefix. WHEN lcl_dot_abapgit=>c_folder_logic-prefix.
lv_len = strlen( lv_parentcl ). lv_len = strlen( lv_parentcl ).
IF iv_package(lv_len) <> lv_parentcl.
* if abapGit project is installed in package ZZZ, all subpackages should be named
* ZZZ_something. This will define the folder name in the zip file to be "something",
* similarily with online projects. Alternatively change to FULL folder logic
lv_message = 'PREFIX: Unexpected package naming(' && iv_package && ')' ##no_text.
lcx_exception=>raise( lv_message ).
ENDIF.
WHEN OTHERS. WHEN OTHERS.
ASSERT 0 = 1. ASSERT 0 = 1.
ENDCASE. ENDCASE.
lv_path = iv_package+lv_len. lv_path = iv_package+lv_len.
IF strlen( lv_path ) = 0. IF strlen( lv_path ) = 0.
* if abapGit project is installed in package ZZZ, all subpackages should be named lcx_exception=>raise( 'Folder logic: length = 0' ).
* ZZZ_something. This will define the folder name in the zip file to be "something",
* similarily with online projects
lv_message = 'Unexpected package naming(' && iv_package && ')' ##no_text.
lcx_exception=>raise( lv_message ).
ENDIF. ENDIF.
IF lv_path(1) = '_'. IF lv_path(1) = '_'.
@ -144,6 +148,7 @@ CLASS ltcl_folder_logic DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHOR
RAISING lcx_exception, RAISING lcx_exception,
prefix1 FOR TESTING RAISING lcx_exception, prefix1 FOR TESTING RAISING lcx_exception,
prefix2 FOR TESTING RAISING lcx_exception, prefix2 FOR TESTING RAISING lcx_exception,
prefix_error1 FOR TESTING RAISING lcx_exception,
full1 FOR TESTING RAISING lcx_exception, full1 FOR TESTING RAISING lcx_exception,
full2 FOR TESTING RAISING lcx_exception. full2 FOR TESTING RAISING lcx_exception.
@ -180,6 +185,10 @@ CLASS ltcl_folder_logic IMPLEMENTATION.
APPEND INITIAL LINE TO lcl_sap_package=>gt_injected ASSIGNING <ls_inject>. APPEND INITIAL LINE TO lcl_sap_package=>gt_injected ASSIGNING <ls_inject>.
<ls_inject>-package = '$TOP_FOO'. <ls_inject>-package = '$TOP_FOO'.
<ls_inject>-object = me. <ls_inject>-object = me.
APPEND INITIAL LINE TO lcl_sap_package=>gt_injected ASSIGNING <ls_inject>.
<ls_inject>-package = '$FOOBAR'.
<ls_inject>-object = me.
ENDMETHOD. ENDMETHOD.
METHOD teardown. METHOD teardown.
@ -198,6 +207,17 @@ CLASS ltcl_folder_logic IMPLEMENTATION.
iv_path = '/src/foo/' ). iv_path = '/src/foo/' ).
ENDMETHOD. ENDMETHOD.
METHOD prefix_error1.
* PREFIX mode, top package is $TOP, so all subpackages should be named $TOP_something
TRY.
test( iv_logic = lcl_dot_abapgit=>c_folder_logic-prefix
iv_package = '$FOOBAR'
iv_path = '/src/' ).
cl_abap_unit_assert=>fail( 'Error expected' ).
CATCH lcx_exception.
ENDTRY.
ENDMETHOD.
METHOD full1. METHOD full1.
test( iv_logic = lcl_dot_abapgit=>c_folder_logic-full test( iv_logic = lcl_dot_abapgit=>c_folder_logic-full
iv_package = lc_top iv_package = lc_top
@ -226,15 +246,15 @@ CLASS ltcl_folder_logic IMPLEMENTATION.
io_dot = lo_dot io_dot = lo_dot
iv_path = iv_path ). iv_path = iv_path ).
cl_abap_unit_assert=>assert_equals(
act = lv_package
exp = iv_package ).
lv_path = lcl_folder_logic=>package_to_path( lv_path = lcl_folder_logic=>package_to_path(
iv_top = lc_top iv_top = lc_top
io_dot = lo_dot io_dot = lo_dot
iv_package = iv_package ). iv_package = iv_package ).
cl_abap_unit_assert=>assert_equals(
act = lv_package
exp = iv_package ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
act = lv_path act = lv_path
exp = iv_path ). exp = iv_path ).