Commit Page: Repo Header and Summary (#5087)

* Commit Page: Repo Header and Summary

- Added repo header back
- Changed summary as suggested by @sbcgua
- Adjusted display of details accordingly

* Remove var

* Revert color on details

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2021-11-02 09:12:53 -04:00 committed by GitHub
parent 882ef7dc8d
commit 9fa3579739
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -356,7 +356,7 @@ CLASS zcl_abapgit_gui_page_commit IMPLEMENTATION.
ri_html->add( '<table class="stage_tab">' ). ri_html->add( '<table class="stage_tab">' ).
ri_html->add( '<thead>' ). ri_html->add( '<thead>' ).
ri_html->add( '<tr>' ). ri_html->add( '<tr>' ).
ri_html->add( '<th colspan="3">Staged Files (<a href="#header">Summary</a>)</th>' ). ri_html->add( '<th colspan="3">Staged Files (<a href="#top">Summary</a>)</th>' ).
ri_html->add( '</tr>' ). ri_html->add( '</tr>' ).
ri_html->add( '</thead>' ). ri_html->add( '</thead>' ).
@ -397,36 +397,33 @@ CLASS zcl_abapgit_gui_page_commit IMPLEMENTATION.
CREATE OBJECT ri_html TYPE zcl_abapgit_html. CREATE OBJECT ri_html TYPE zcl_abapgit_html.
LOOP AT mt_stage ASSIGNING <ls_stage>. LOOP AT mt_stage ASSIGNING <ls_stage>.
ls_sum-method = zcl_abapgit_stage=>method_description( <ls_stage>-method ). ls_sum-method = <ls_stage>-method.
ls_sum-count = 1. ls_sum-count = 1.
COLLECT ls_sum INTO lt_sum. COLLECT ls_sum INTO lt_sum.
ENDLOOP. ENDLOOP.
ri_html->add( '<table class="stage_tab">' ). ri_html->add( 'Stage Summary: ' ).
ri_html->add( '<thead>' ).
ri_html->add( '<tr>' ).
ri_html->add( '<th colspan="2">Stage Summary (<a href="#stage-details">Details</a>)</th>' ).
ri_html->add( '</tr>' ).
ri_html->add( '</thead>' ).
ri_html->add( '<tbody>' ). READ TABLE lt_sum INTO ls_sum WITH TABLE KEY method = zif_abapgit_definitions=>c_method-add.
LOOP AT lt_sum INTO ls_sum. IF sy-subrc = 0.
ri_html->add( '<tr>' ). ri_html->add( |<span class="diff_banner diff_ins" title="add">+ { ls_sum-count }</span>| ).
ri_html->add( '<td class="method" width="20%">' ). ENDIF.
ri_html->add( ls_sum-method ). READ TABLE lt_sum INTO ls_sum WITH TABLE KEY method = zif_abapgit_definitions=>c_method-rm.
ri_html->add( '</td>' ). IF sy-subrc = 0.
ri_html->add( '<td>' ). ri_html->add( |<span class="diff_banner diff_del" title="remove">- { ls_sum-count }</span>| ).
IF ls_sum-count = 1. ENDIF.
ri_html->add( |{ ls_sum-count } file| ). READ TABLE lt_sum INTO ls_sum WITH TABLE KEY method = zif_abapgit_definitions=>c_method-ignore.
ELSE. IF sy-subrc = 0.
ri_html->add( |{ ls_sum-count } files| ). ri_html->add( |<span class="diff_banner diff_upd" title="ignore">~ { ls_sum-count }</span>| ).
ENDIF. ENDIF.
ri_html->add( '</td>' ).
ri_html->add( '</tr>' ).
ENDLOOP.
ri_html->add( '</tbody>' ).
ri_html->add( '</table>' ). IF lines( mt_stage ) = 1.
ri_html->add( 'file' ).
ELSE.
ri_html->add( 'files' ).
ENDIF.
ri_html->add( '(<a href="#stage-details">Details</a>)' ).
ENDMETHOD. ENDMETHOD.
@ -496,7 +493,11 @@ CLASS zcl_abapgit_gui_page_commit IMPLEMENTATION.
CREATE OBJECT ri_html TYPE zcl_abapgit_html. CREATE OBJECT ri_html TYPE zcl_abapgit_html.
ri_html->add( '<div id="stage-summary" class="dialog w800px">' ). ri_html->add( '<div id="top" class="paddings">' ).
ri_html->add( zcl_abapgit_gui_chunk_lib=>render_repo_top( mo_repo ) ).
ri_html->add( '</div>' ).
ri_html->add( '<div id="stage-summary" class="dialog w800px paddings">' ).
ri_html->add( render_stage_summary( ) ). ri_html->add( render_stage_summary( ) ).
ri_html->add( '</div>' ). ri_html->add( '</div>' ).