From 9fade8985663cda5d710bc23180cbc5bfb551f06 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Thu, 16 May 2019 23:20:10 -0700 Subject: [PATCH] change constructors to public (#2677) * enable abaplint constructor check * change constructor to public * change constructor to public * change constructors to public --- abaplint.json | 4 ++ src/apack/zcl_abapgit_apack_reader.clas.abap | 51 +++++++++++-------- src/apack/zcl_abapgit_apack_writer.clas.abap | 29 ++++++----- .../zcl_abapgit_persistence_user.clas.abap | 7 +-- src/zcl_abapgit_news.clas.abap | 14 ++--- 5 files changed, 62 insertions(+), 43 deletions(-) diff --git a/abaplint.json b/abaplint.json index fff1f3b47..3d4efbb2f 100644 --- a/abaplint.json +++ b/abaplint.json @@ -46,6 +46,10 @@ "enabled": true, "exclude": [] }, + "constructor_visibility_public": { + "enabled": true, + "exclude": [] + }, "contains_tab": { "enabled": true, "exclude": [] diff --git a/src/apack/zcl_abapgit_apack_reader.clas.abap b/src/apack/zcl_abapgit_apack_reader.clas.abap index 753b2ec53..a88d60920 100644 --- a/src/apack/zcl_abapgit_apack_reader.clas.abap +++ b/src/apack/zcl_abapgit_apack_reader.clas.abap @@ -1,38 +1,46 @@ CLASS zcl_abapgit_apack_reader DEFINITION PUBLIC FINAL - CREATE PRIVATE. + CREATE PRIVATE . PUBLIC SECTION. - TYPES: ty_package_name TYPE devclass. - - CLASS-METHODS: create_instance IMPORTING iv_package_name TYPE ty_package_name - RETURNING VALUE(ro_manifest_reader) TYPE REF TO zcl_abapgit_apack_reader. - METHODS: - get_manifest_descriptor RETURNING VALUE(rs_manifest_descriptor) - TYPE zif_abapgit_apack_definitions=>ty_descriptor, - set_manifest_descriptor IMPORTING is_manifest_descriptor TYPE zif_abapgit_apack_definitions=>ty_descriptor, - has_manifest RETURNING VALUE(rv_has_manifest) TYPE abap_bool. + TYPES ty_package_name TYPE devclass . + CLASS-METHODS create_instance + IMPORTING + !iv_package_name TYPE ty_package_name + RETURNING + VALUE(ro_manifest_reader) TYPE REF TO zcl_abapgit_apack_reader . + METHODS get_manifest_descriptor + RETURNING + VALUE(rs_manifest_descriptor) TYPE zif_abapgit_apack_definitions=>ty_descriptor . + METHODS set_manifest_descriptor + IMPORTING + !is_manifest_descriptor TYPE zif_abapgit_apack_definitions=>ty_descriptor . + METHODS has_manifest + RETURNING + VALUE(rv_has_manifest) TYPE abap_bool . + METHODS constructor + IMPORTING + !iv_package_name TYPE ty_package_name . PROTECTED SECTION. PRIVATE SECTION. - TYPES: BEGIN OF ty_s_manifest_declaration, - clsname TYPE seometarel-clsname, - devclass TYPE devclass, - END OF ty_s_manifest_declaration. + TYPES: + BEGIN OF ty_s_manifest_declaration, + clsname TYPE seometarel-clsname, + devclass TYPE devclass, + END OF ty_s_manifest_declaration . - DATA: mv_package_name TYPE ty_package_name, - ms_cached_descriptor TYPE zif_abapgit_apack_definitions=>ty_descriptor, - mv_is_cached TYPE abap_bool. - - METHODS: constructor IMPORTING iv_package_name TYPE ty_package_name. + DATA mv_package_name TYPE ty_package_name . + DATA ms_cached_descriptor TYPE zif_abapgit_apack_definitions=>ty_descriptor . + DATA mv_is_cached TYPE abap_bool . ENDCLASS. -CLASS zcl_abapgit_apack_reader IMPLEMENTATION. +CLASS ZCL_ABAPGIT_APACK_READER IMPLEMENTATION. METHOD constructor. @@ -44,6 +52,7 @@ CLASS zcl_abapgit_apack_reader IMPLEMENTATION. CREATE OBJECT ro_manifest_reader EXPORTING iv_package_name = iv_package_name. ENDMETHOD. + METHOD get_manifest_descriptor. DATA: lo_manifest_provider TYPE REF TO object, @@ -93,9 +102,9 @@ CLASS zcl_abapgit_apack_reader IMPLEMENTATION. ENDMETHOD. + METHOD set_manifest_descriptor. me->mv_is_cached = abap_true. me->ms_cached_descriptor = is_manifest_descriptor. ENDMETHOD. - ENDCLASS. diff --git a/src/apack/zcl_abapgit_apack_writer.clas.abap b/src/apack/zcl_abapgit_apack_writer.clas.abap index f4dd59924..dd5a26c6f 100644 --- a/src/apack/zcl_abapgit_apack_writer.clas.abap +++ b/src/apack/zcl_abapgit_apack_writer.clas.abap @@ -1,26 +1,32 @@ CLASS zcl_abapgit_apack_writer DEFINITION PUBLIC FINAL - CREATE PRIVATE. + CREATE PRIVATE . PUBLIC SECTION. - CLASS-METHODS: - create_instance IMPORTING is_apack_manifest_descriptor TYPE zif_abapgit_apack_definitions=>ty_descriptor - RETURNING VALUE(ro_manifest_writer) TYPE REF TO zcl_abapgit_apack_writer. - METHODS: - serialize RETURNING VALUE(rv_xml) TYPE string RAISING zcx_abapgit_exception. + CLASS-METHODS create_instance + IMPORTING + !is_apack_manifest_descriptor TYPE zif_abapgit_apack_definitions=>ty_descriptor + RETURNING + VALUE(ro_manifest_writer) TYPE REF TO zcl_abapgit_apack_writer . + METHODS serialize + RETURNING + VALUE(rv_xml) TYPE string + RAISING + zcx_abapgit_exception . + METHODS constructor + IMPORTING + !is_apack_manifest_descriptor TYPE zif_abapgit_apack_definitions=>ty_descriptor . PROTECTED SECTION. PRIVATE SECTION. - DATA: ms_manifest_descriptor TYPE zif_abapgit_apack_definitions=>ty_descriptor. - METHODS: - constructor IMPORTING is_apack_manifest_descriptor TYPE zif_abapgit_apack_definitions=>ty_descriptor. + + DATA ms_manifest_descriptor TYPE zif_abapgit_apack_definitions=>ty_descriptor . ENDCLASS. -CLASS zcl_abapgit_apack_writer IMPLEMENTATION. - +CLASS ZCL_ABAPGIT_APACK_WRITER IMPLEMENTATION. METHOD constructor. @@ -51,5 +57,4 @@ CLASS zcl_abapgit_apack_writer IMPLEMENTATION. WITH ''. ENDMETHOD. - ENDCLASS. diff --git a/src/persist/zcl_abapgit_persistence_user.clas.abap b/src/persist/zcl_abapgit_persistence_user.clas.abap index d5cd04192..394e89ba0 100644 --- a/src/persist/zcl_abapgit_persistence_user.clas.abap +++ b/src/persist/zcl_abapgit_persistence_user.clas.abap @@ -13,6 +13,10 @@ CLASS zcl_abapgit_persistence_user DEFINITION !iv_user TYPE xubname DEFAULT sy-uname RETURNING VALUE(ri_user) TYPE REF TO zif_abapgit_persist_user . + METHODS constructor + IMPORTING + !iv_user TYPE xubname DEFAULT sy-uname . + PROTECTED SECTION. PRIVATE SECTION. TYPES: @@ -39,9 +43,6 @@ CLASS zcl_abapgit_persistence_user DEFINITION DATA mv_user TYPE xubname . CLASS-DATA gi_current_user TYPE REF TO zif_abapgit_persist_user . - METHODS constructor - IMPORTING - !iv_user TYPE xubname DEFAULT sy-uname . METHODS from_xml IMPORTING !iv_xml TYPE string diff --git a/src/zcl_abapgit_news.clas.abap b/src/zcl_abapgit_news.clas.abap index 604d91d85..ee87ed6e6 100644 --- a/src/zcl_abapgit_news.clas.abap +++ b/src/zcl_abapgit_news.clas.abap @@ -16,9 +16,9 @@ CLASS zcl_abapgit_news DEFINITION TYPES: tt_log TYPE STANDARD TABLE OF ty_log WITH DEFAULT KEY . - CONSTANTS c_tail_length TYPE i VALUE 5 ##NO_TEXT. " Number of versions to display if no updates + CONSTANTS c_tail_length TYPE i VALUE 5 ##NO_TEXT. " Number of versions to display if no updates - CLASS-METHODS create " TODO REFACTOR + CLASS-METHODS create " TODO REFACTOR IMPORTING !io_repo TYPE REF TO zcl_abapgit_repo RETURNING @@ -40,6 +40,11 @@ CLASS zcl_abapgit_news DEFINITION METHODS has_unseen RETURNING VALUE(rv_boolean) TYPE abap_bool . + METHODS constructor + IMPORTING + !iv_rawdata TYPE xstring + !iv_lastseen_version TYPE string + !iv_current_version TYPE string . PROTECTED SECTION. PRIVATE SECTION. @@ -56,11 +61,6 @@ CLASS zcl_abapgit_news DEFINITION METHODS latest_version RETURNING VALUE(rv_version) TYPE string . - METHODS constructor - IMPORTING - !iv_rawdata TYPE xstring - !iv_lastseen_version TYPE string - !iv_current_version TYPE string . CLASS-METHODS version_to_numeric IMPORTING !iv_version TYPE string