From a0a9eb17716a3768d4ad613ca2b4ead75782b836 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Tue, 1 Dec 2020 05:00:55 +0100 Subject: [PATCH] REPO online: change get_objects to private (#4262) #2127 --- src/zcl_abapgit_repo_online.clas.abap | 8 ++++++-- src/zif_abapgit_repo_online.intf.abap | 18 +++++++----------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/zcl_abapgit_repo_online.clas.abap b/src/zcl_abapgit_repo_online.clas.abap index eabb377d7..2c9b6c971 100644 --- a/src/zcl_abapgit_repo_online.clas.abap +++ b/src/zcl_abapgit_repo_online.clas.abap @@ -17,7 +17,6 @@ CLASS zcl_abapgit_repo_online DEFINITION get_selected_commit FOR zif_abapgit_repo_online~get_selected_commit, get_current_remote FOR zif_abapgit_repo_online~get_current_remote, select_commit FOR zif_abapgit_repo_online~select_commit, - get_objects FOR zif_abapgit_repo_online~get_objects, get_switched_origin FOR zif_abapgit_repo_online~get_switched_origin, switch_origin FOR zif_abapgit_repo_online~switch_origin. @@ -46,6 +45,11 @@ CLASS zcl_abapgit_repo_online DEFINITION METHODS fetch_remote RAISING zcx_abapgit_exception . + METHODS get_objects + RETURNING + VALUE(rt_objects) TYPE zif_abapgit_definitions=>ty_objects_tt + RAISING + zcx_abapgit_exception . ENDCLASS. @@ -173,7 +177,7 @@ CLASS ZCL_ABAPGIT_REPO_ONLINE IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_repo_online~get_objects. + METHOD get_objects. fetch_remote( ). rt_objects = mt_objects. ENDMETHOD. diff --git a/src/zif_abapgit_repo_online.intf.abap b/src/zif_abapgit_repo_online.intf.abap index 3c67912af..f2e63ea2c 100644 --- a/src/zif_abapgit_repo_online.intf.abap +++ b/src/zif_abapgit_repo_online.intf.abap @@ -1,5 +1,7 @@ INTERFACE zif_abapgit_repo_online PUBLIC . + + METHODS get_url RETURNING VALUE(rv_url) TYPE zif_abapgit_persistence=>ty_repo-url . @@ -8,12 +10,12 @@ INTERFACE zif_abapgit_repo_online VALUE(rv_name) TYPE zif_abapgit_persistence=>ty_repo-branch_name . METHODS set_url IMPORTING - iv_url TYPE zif_abapgit_persistence=>ty_repo-url + !iv_url TYPE zif_abapgit_persistence=>ty_repo-url RAISING zcx_abapgit_exception . METHODS select_branch IMPORTING - iv_branch_name TYPE zif_abapgit_persistence=>ty_repo-branch_name + !iv_branch_name TYPE zif_abapgit_persistence=>ty_repo-branch_name RAISING zcx_abapgit_exception . METHODS get_selected_commit @@ -28,12 +30,7 @@ INTERFACE zif_abapgit_repo_online zcx_abapgit_exception . METHODS select_commit IMPORTING - iv_selected_commit TYPE zif_abapgit_persistence=>ty_repo-selected_commit - RAISING - zcx_abapgit_exception . - METHODS get_objects - RETURNING - VALUE(rt_objects) TYPE zif_abapgit_definitions=>ty_objects_tt + !iv_selected_commit TYPE zif_abapgit_persistence=>ty_repo-selected_commit RAISING zcx_abapgit_exception . METHODS get_switched_origin @@ -41,8 +38,8 @@ INTERFACE zif_abapgit_repo_online VALUE(rv_url) TYPE zif_abapgit_persistence=>ty_repo-switched_origin . METHODS switch_origin IMPORTING - iv_url TYPE zif_abapgit_persistence=>ty_repo-url - iv_overwrite TYPE abap_bool DEFAULT abap_false + !iv_url TYPE zif_abapgit_persistence=>ty_repo-url + !iv_overwrite TYPE abap_bool DEFAULT abap_false RAISING zcx_abapgit_exception . METHODS push @@ -51,7 +48,6 @@ INTERFACE zif_abapgit_repo_online !io_stage TYPE REF TO zcl_abapgit_stage RAISING zcx_abapgit_exception . - METHODS create_branch IMPORTING !iv_name TYPE string