From a23c1d6d58b9464ffdc1564a4565be6142b9fbd1 Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Thu, 5 Dec 2024 11:35:53 -0500 Subject: [PATCH] Fix extended check issues - Part 3 (#7088) Co-authored-by: Lars Hvam --- src/objects/core/zcl_abapgit_dependencies.clas.abap | 2 +- .../core/zcl_abapgit_objects_activation.clas.abap | 4 ++-- src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap | 2 +- .../ecatt/zcl_abapgit_ecatt_sp_download.clas.abap | 4 ++-- .../ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap | 10 ++++------ src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap | 2 +- src/objects/oo/zcl_abapgit_oo_class.clas.abap | 5 ++--- src/objects/oo/zcl_abapgit_oo_interface.clas.abap | 5 ++--- src/objects/oo/zcl_abapgit_oo_serializer.clas.abap | 2 +- src/objects/sap/zcl_abapgit_sap_report.clas.abap | 4 ++-- 10 files changed, 18 insertions(+), 22 deletions(-) diff --git a/src/objects/core/zcl_abapgit_dependencies.clas.abap b/src/objects/core/zcl_abapgit_dependencies.clas.abap index 2d76f2320..3c6c3523a 100644 --- a/src/objects/core/zcl_abapgit_dependencies.clas.abap +++ b/src/objects/core/zcl_abapgit_dependencies.clas.abap @@ -61,7 +61,7 @@ CLASS zcl_abapgit_dependencies IMPLEMENTATION. INSERT ls_ddls_name INTO TABLE lt_ddls_name. PERFORM ('DDLS_GET_DEP') IN PROGRAM ('RADMASDL') - TABLES lt_ddls_name rt_dependency. + TABLES lt_ddls_name rt_dependency ##PERF_NO_FORM. ENDMETHOD. diff --git a/src/objects/core/zcl_abapgit_objects_activation.clas.abap b/src/objects/core/zcl_abapgit_objects_activation.clas.abap index 833f456b7..09d549be6 100644 --- a/src/objects/core/zcl_abapgit_objects_activation.clas.abap +++ b/src/objects/core/zcl_abapgit_objects_activation.clas.abap @@ -310,7 +310,7 @@ CLASS zcl_abapgit_objects_activation IMPLEMENTATION. excecution_error = 1 cancelled = 2 insert_into_corr_error = 3 - OTHERS = 4 ##SUBRC_OK. + OTHERS = 4 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'RS_WORKING_OBJECTS_ACTIVATE' EXPORTING @@ -324,7 +324,7 @@ CLASS zcl_abapgit_objects_activation IMPLEMENTATION. excecution_error = 1 cancelled = 2 insert_into_corr_error = 3 - OTHERS = 4 ##SUBRC_OK. + OTHERS = 4 ##FM_SUBRC_OK. ENDTRY. CASE sy-subrc. WHEN 1 OR 3 OR 4. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap index e4244297e..a6768c13e 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap @@ -66,7 +66,7 @@ CLASS zcl_abapgit_ecatt_helper IMPLEMENTATION. lv_text = lx_ecatt->get_text( ). zcx_abapgit_exception=>raise( lv_text ). " note, exception cx_ecatt_ui_attachment doesn't exist in 702 - CATCH cx_ecatt. + CATCH cx_ecatt ##NO_HANDLER. "will never be raised from download, when called with mv_generate_xml_no_download = 'X'. ENDTRY. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap index 03b6a0eeb..175e3544a 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap @@ -25,7 +25,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION. +CLASS zcl_abapgit_ecatt_sp_download IMPLEMENTATION. METHOD download. @@ -93,7 +93,7 @@ CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION. CALL METHOD lo_ecatt_sp->('GET_SP_ATTRIBUTES') IMPORTING e_sp_xml = lv_sp_xml. - CATCH cx_ecatt_apl. + CATCH cx_ecatt_apl ##NO_HANDLER. ENDTRY. CALL FUNCTION 'SDIXML_XML_TO_DOM' diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap index fab1f31f8..2874dfbf7 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap @@ -27,7 +27,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION. +CLASS zcl_abapgit_ecatt_sp_upload IMPLEMENTATION. METHOD get_ecatt_sp. @@ -129,7 +129,6 @@ CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION. ENDTRY. ASSIGN ecatt_object TO . - ASSERT sy-subrc = 0. lo_ecatt_sp = . @@ -162,13 +161,12 @@ CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION. CATCH cx_ecatt_apl INTO lx_ecatt. lv_exc_occ = 'X'. ENDTRY. -* Devesh,C5129871 18.07.2011 Releasing enqueue after uploading -*begin + " Releasing enqueue after uploading TRY. ecatt_object->close_object( im_suppress_events = 'X' ). - CATCH cx_ecatt_apl INTO lx_ecatt. + CATCH cx_ecatt_apl INTO lx_ecatt ##NO_HANDLER. ENDTRY. -*end + * get devclass from existing object TRY. cl_apl_ecatt_object=>get_tadir_entry( diff --git a/src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap b/src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap index 7eceedf0b..206100054 100644 --- a/src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap +++ b/src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap @@ -62,7 +62,7 @@ CLASS zcl_abapgit_object_enho_clif IMPLEMENTATION. TRY. io_clif->add_change_enha_type( type_line = ls_type_line ). CATCH cx_enh_mod_not_allowed - cx_enh_is_not_enhanceable. + cx_enh_is_not_enhanceable ##NO_HANDLER. " TODO ENDTRY. ENDLOOP. diff --git a/src/objects/oo/zcl_abapgit_oo_class.clas.abap b/src/objects/oo/zcl_abapgit_oo_class.clas.abap index 7d7091a3b..ad60369bb 100644 --- a/src/objects/oo/zcl_abapgit_oo_class.clas.abap +++ b/src/objects/oo/zcl_abapgit_oo_class.clas.abap @@ -611,7 +611,7 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION. component_error = 4 no_access = 5 other = 6 - OTHERS = 7. + OTHERS = 7 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE' EXPORTING @@ -628,7 +628,7 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION. component_error = 4 no_access = 5 other = 6 - OTHERS = 7. + OTHERS = 7 ##FM_SUBRC_OK. ENDTRY. IF sy-subrc <> 0. zcx_abapgit_exception=>raise_t100( ). @@ -998,5 +998,4 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION. zcx_abapgit_exception=>raise( |Class { ls_clskey-clsname } has syntax errors | ). ENDIF. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/oo/zcl_abapgit_oo_interface.clas.abap b/src/objects/oo/zcl_abapgit_oo_interface.clas.abap index a4852bee2..2715e70ac 100644 --- a/src/objects/oo/zcl_abapgit_oo_interface.clas.abap +++ b/src/objects/oo/zcl_abapgit_oo_interface.clas.abap @@ -212,7 +212,7 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION. component_error = 4 no_access = 5 other = 6 - OTHERS = 7. + OTHERS = 7 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'SEO_INTERFACE_CREATE_COMPLETE' EXPORTING @@ -229,7 +229,7 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION. component_error = 4 no_access = 5 other = 6 - OTHERS = 7. + OTHERS = 7 ##FM_SUBRC_OK. ENDTRY. IF sy-subrc <> 0. zcx_abapgit_exception=>raise_t100( ). @@ -368,5 +368,4 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION. zcx_abapgit_exception=>raise( |Interface { ls_intkey-clsname } has syntax errors | ). ENDIF. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/oo/zcl_abapgit_oo_serializer.clas.abap b/src/objects/oo/zcl_abapgit_oo_serializer.clas.abap index d90d1fc6f..bf55ef56a 100644 --- a/src/objects/oo/zcl_abapgit_oo_serializer.clas.abap +++ b/src/objects/oo/zcl_abapgit_oo_serializer.clas.abap @@ -151,7 +151,7 @@ CLASS zcl_abapgit_oo_serializer IMPLEMENTATION. lv_program = ls_include. TRY. lt_source = zcl_abapgit_factory=>get_sap_report( )->read_report( lv_program ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. * ignore if the report is not found, sometimes the CCDEF include does not exist ENDTRY. rt_source = lt_source. diff --git a/src/objects/sap/zcl_abapgit_sap_report.clas.abap b/src/objects/sap/zcl_abapgit_sap_report.clas.abap index 4f0bfaa2c..4f229d659 100644 --- a/src/objects/sap/zcl_abapgit_sap_report.clas.abap +++ b/src/objects/sap/zcl_abapgit_sap_report.clas.abap @@ -47,7 +47,7 @@ CLASS zcl_abapgit_sap_report IMPLEMENTATION. no_show_permission = 7 permission_failure = 8 request_language_denied = 9 - OTHERS = 10. + OTHERS = 10 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'RS_ACCESS_PERMISSION' EXPORTING @@ -67,7 +67,7 @@ CLASS zcl_abapgit_sap_report IMPLEMENTATION. no_show_permission = 7 permission_failure = 8 request_language_denied = 9 - OTHERS = 10. + OTHERS = 10 ##FM_SUBRC_OK. ENDTRY. IF sy-subrc <> 0. zcx_abapgit_exception=>raise_t100( ).