Fix extended check issues - Part 3 (#7088)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

src/objects/core/zcl_abapgit_dependencies.clas.abap

@@ -61,7 +61,7 @@ CLASS zcl_abapgit_dependencies IMPLEMENTATION.
     INSERT ls_ddls_name INTO TABLE lt_ddls_name.
 
     PERFORM ('DDLS_GET_DEP') IN PROGRAM ('RADMASDL')
-                             TABLES lt_ddls_name rt_dependency.
+                             TABLES lt_ddls_name rt_dependency ##PERF_NO_FORM.
 
   ENDMETHOD.
 

src/objects/core/zcl_abapgit_objects_activation.clas.abap

@@ -310,7 +310,7 @@ CLASS zcl_abapgit_objects_activation IMPLEMENTATION.
               excecution_error       = 1
               cancelled              = 2
               insert_into_corr_error = 3
-              OTHERS                 = 4 ##SUBRC_OK.
+              OTHERS                 = 4 ##FM_SUBRC_OK.
         CATCH cx_sy_dyn_call_param_not_found.
           CALL FUNCTION 'RS_WORKING_OBJECTS_ACTIVATE'
             EXPORTING
@@ -324,7 +324,7 @@ CLASS zcl_abapgit_objects_activation IMPLEMENTATION.
               excecution_error       = 1
               cancelled              = 2
               insert_into_corr_error = 3
-              OTHERS                 = 4 ##SUBRC_OK.
+              OTHERS                 = 4 ##FM_SUBRC_OK.
       ENDTRY.
       CASE sy-subrc.
         WHEN 1 OR 3 OR 4.

src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap

@@ -66,7 +66,7 @@ CLASS zcl_abapgit_ecatt_helper IMPLEMENTATION.
         lv_text = lx_ecatt->get_text( ).
         zcx_abapgit_exception=>raise( lv_text ).
         " note, exception cx_ecatt_ui_attachment doesn't exist in 702
-      CATCH cx_ecatt.
+      CATCH cx_ecatt ##NO_HANDLER.
         "will never be raised from download, when called with mv_generate_xml_no_download = 'X'.
     ENDTRY.
 

src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap

@@ -25,7 +25,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION.
+CLASS zcl_abapgit_ecatt_sp_download IMPLEMENTATION.
 
 
   METHOD download.
@@ -93,7 +93,7 @@ CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION.
         CALL METHOD lo_ecatt_sp->('GET_SP_ATTRIBUTES')
           IMPORTING
             e_sp_xml = lv_sp_xml.
-      CATCH cx_ecatt_apl.
+      CATCH cx_ecatt_apl ##NO_HANDLER.
     ENDTRY.
 
     CALL FUNCTION 'SDIXML_XML_TO_DOM'

src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap

@@ -27,7 +27,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION.
+CLASS zcl_abapgit_ecatt_sp_upload IMPLEMENTATION.
 
 
   METHOD get_ecatt_sp.
@@ -129,7 +129,6 @@ CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION.
     ENDTRY.
 
     ASSIGN ecatt_object TO <lg_ecatt_sp>.
-    ASSERT sy-subrc = 0.
 
     lo_ecatt_sp = <lg_ecatt_sp>.
 
@@ -162,13 +161,12 @@ CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION.
       CATCH cx_ecatt_apl INTO lx_ecatt.
         lv_exc_occ = 'X'.
     ENDTRY.
-* Devesh,C5129871  18.07.2011  Releasing enqueue after uploading
+    " Releasing enqueue after uploading
-*begin
     TRY.
         ecatt_object->close_object( im_suppress_events = 'X' ).
-      CATCH cx_ecatt_apl INTO lx_ecatt.
+      CATCH cx_ecatt_apl INTO lx_ecatt ##NO_HANDLER.
     ENDTRY.
-*end
+
 *     get devclass from existing object
     TRY.
         cl_apl_ecatt_object=>get_tadir_entry(

src/objects/enh/zcl_abapgit_object_enho_clif.clas.abap

@@ -62,7 +62,7 @@ CLASS zcl_abapgit_object_enho_clif IMPLEMENTATION.
       TRY.
           io_clif->add_change_enha_type( type_line = ls_type_line ).
         CATCH cx_enh_mod_not_allowed
-        cx_enh_is_not_enhanceable.
+        cx_enh_is_not_enhanceable ##NO_HANDLER.
           " TODO
       ENDTRY.
     ENDLOOP.

src/objects/oo/zcl_abapgit_oo_class.clas.abap

@@ -611,7 +611,7 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION.
             component_error = 4
             no_access       = 5
             other           = 6
-            OTHERS          = 7.
+            OTHERS          = 7 ##FM_SUBRC_OK.
       CATCH cx_sy_dyn_call_param_not_found.
         CALL FUNCTION 'SEO_CLASS_CREATE_COMPLETE'
           EXPORTING
@@ -628,7 +628,7 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION.
             component_error = 4
             no_access       = 5
             other           = 6
-            OTHERS          = 7.
+            OTHERS          = 7 ##FM_SUBRC_OK.
     ENDTRY.
     IF sy-subrc <> 0.
       zcx_abapgit_exception=>raise_t100( ).
@@ -998,5 +998,4 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION.
       zcx_abapgit_exception=>raise( |Class { ls_clskey-clsname } has syntax errors | ).
     ENDIF.
   ENDMETHOD.
-
 ENDCLASS.

src/objects/oo/zcl_abapgit_oo_interface.clas.abap

@@ -212,7 +212,7 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION.
             component_error = 4
             no_access       = 5
             other           = 6
-            OTHERS          = 7.
+            OTHERS          = 7 ##FM_SUBRC_OK.
       CATCH cx_sy_dyn_call_param_not_found.
         CALL FUNCTION 'SEO_INTERFACE_CREATE_COMPLETE'
           EXPORTING
@@ -229,7 +229,7 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION.
             component_error = 4
             no_access       = 5
             other           = 6
-            OTHERS          = 7.
+            OTHERS          = 7 ##FM_SUBRC_OK.
     ENDTRY.
     IF sy-subrc <> 0.
       zcx_abapgit_exception=>raise_t100( ).
@@ -368,5 +368,4 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION.
       zcx_abapgit_exception=>raise( |Interface { ls_intkey-clsname } has syntax errors | ).
     ENDIF.
   ENDMETHOD.
-
 ENDCLASS.

src/objects/oo/zcl_abapgit_oo_serializer.clas.abap

@@ -151,7 +151,7 @@ CLASS zcl_abapgit_oo_serializer IMPLEMENTATION.
     lv_program = ls_include.
     TRY.
         lt_source = zcl_abapgit_factory=>get_sap_report( )->read_report( lv_program ).
-      CATCH zcx_abapgit_exception.
+      CATCH zcx_abapgit_exception ##NO_HANDLER.
 * ignore if the report is not found, sometimes the CCDEF include does not exist
     ENDTRY.
     rt_source = lt_source.

src/objects/sap/zcl_abapgit_sap_report.clas.abap

@@ -47,7 +47,7 @@ CLASS zcl_abapgit_sap_report IMPLEMENTATION.
               no_show_permission             = 7
               permission_failure             = 8
               request_language_denied        = 9
-              OTHERS                         = 10.
+              OTHERS                         = 10 ##FM_SUBRC_OK.
         CATCH cx_sy_dyn_call_param_not_found.
           CALL FUNCTION 'RS_ACCESS_PERMISSION'
             EXPORTING
@@ -67,7 +67,7 @@ CLASS zcl_abapgit_sap_report IMPLEMENTATION.
               no_show_permission       = 7
               permission_failure       = 8
               request_language_denied  = 9
-              OTHERS                   = 10.
+              OTHERS                   = 10 ##FM_SUBRC_OK.
       ENDTRY.
       IF sy-subrc <> 0.
         zcx_abapgit_exception=>raise_t100( ).