delete unused method in ZCL_ABAPGIT_OBJECT_CHDO (#4130)

* delete unused method

delete unused method GET_GENERIC in class zcl_abapgit_object_chdo

* enable rule unused_methods
This commit is contained in:
Lars Hvam 2020-11-03 14:55:01 +01:00 committed by GitHub
parent 990441dbe0
commit a53776ab5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 145 additions and 163 deletions

View File

@ -81,7 +81,7 @@
"method_overwrites_builtin": false,
"omit_parameter_name": false,
"omit_receiving": true,
"unused_methods": false,
"unused_methods": true,
"identical_contents": false,
"many_parenthesis": true,
"prefer_xsdbool": true,

View File

@ -14,28 +14,20 @@ CLASS zcl_abapgit_object_chdo DEFINITION
iv_language TYPE spras.
PROTECTED SECTION.
METHODS get_generic
RETURNING
VALUE(ro_generic) TYPE REF TO zcl_abapgit_objects_generic
RAISING
zcx_abapgit_exception.
METHODS after_import
RAISING
zcx_abapgit_exception.
zcx_abapgit_exception .
METHODS delete_tadir_cdnames
IMPORTING
!is_cdnames TYPE cdnames
RAISING
zcx_abapgit_exception.
zcx_abapgit_exception .
METHODS delete_tadir_tabl
IMPORTING
!is_tcdrs TYPE tcdrs
RAISING
zcx_abapgit_exception.
zcx_abapgit_exception .
PRIVATE SECTION.
TYPES: BEGIN OF ty_change_document,
reports_generated TYPE SORTED TABLE OF tcdrps WITH UNIQUE KEY object reportname,
@ -49,7 +41,37 @@ ENDCLASS.
CLASS zcl_abapgit_object_chdo IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECT_CHDO IMPLEMENTATION.
METHOD after_import.
DATA: lt_cts_object_entry TYPE STANDARD TABLE OF e071 WITH DEFAULT KEY,
ls_cts_object_entry LIKE LINE OF lt_cts_object_entry,
lt_errormsg TYPE STANDARD TABLE OF sprot_u WITH DEFAULT KEY.
ls_cts_object_entry-pgmid = seok_pgmid_r3tr.
ls_cts_object_entry-object = ms_item-obj_type.
ls_cts_object_entry-obj_name = ms_item-obj_name.
INSERT ls_cts_object_entry INTO TABLE lt_cts_object_entry.
CALL FUNCTION 'AFTER_IMP_CHDO'
EXPORTING
iv_tarclient = sy-mandt
iv_is_upgrade = abap_false
TABLES
tt_e071 = lt_cts_object_entry
tt_errormsg = lt_errormsg.
LOOP AT lt_errormsg TRANSPORTING NO FIELDS WHERE severity = 'E' OR severity = 'A'.
EXIT.
ENDLOOP.
IF sy-subrc = 0.
zcx_abapgit_exception=>raise( 'Error from AFTER_IMP_CHDO' ).
ENDIF.
ENDMETHOD.
METHOD constructor.
@ -62,6 +84,116 @@ CLASS zcl_abapgit_object_chdo IMPLEMENTATION.
ENDMETHOD.
METHOD delete_tadir_cdnames.
DATA: lv_obj_name TYPE sobj_name.
IF is_cdnames-repnamec IS NOT INITIAL.
lv_obj_name = is_cdnames-repnamec.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'PROG'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
IF is_cdnames-repnamet IS NOT INITIAL.
lv_obj_name = is_cdnames-repnamet.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'PROG'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
IF is_cdnames-repnamefix IS NOT INITIAL.
lv_obj_name = is_cdnames-repnamefix.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'PROG'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
IF is_cdnames-repnamevar IS NOT INITIAL.
lv_obj_name = is_cdnames-repnamevar.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'PROG'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
IF is_cdnames-fgrp IS NOT INITIAL.
lv_obj_name = is_cdnames-fgrp.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'FUGR'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD delete_tadir_tabl.
DATA: lv_obj_name TYPE sobj_name.
IF is_tcdrs-tabname IS NOT INITIAL.
lv_obj_name = is_tcdrs-tabname.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'FUGR'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
SELECT SINGLE updname INTO rv_user
@ -280,154 +412,4 @@ CLASS zcl_abapgit_object_chdo IMPLEMENTATION.
ig_data = ls_change_object ).
ENDMETHOD.
METHOD get_generic.
CREATE OBJECT ro_generic
EXPORTING
is_item = ms_item.
ENDMETHOD.
METHOD after_import.
DATA: lt_cts_object_entry TYPE STANDARD TABLE OF e071 WITH DEFAULT KEY,
ls_cts_object_entry LIKE LINE OF lt_cts_object_entry,
lt_errormsg TYPE STANDARD TABLE OF sprot_u WITH DEFAULT KEY.
ls_cts_object_entry-pgmid = seok_pgmid_r3tr.
ls_cts_object_entry-object = ms_item-obj_type.
ls_cts_object_entry-obj_name = ms_item-obj_name.
INSERT ls_cts_object_entry INTO TABLE lt_cts_object_entry.
CALL FUNCTION 'AFTER_IMP_CHDO'
EXPORTING
iv_tarclient = sy-mandt
iv_is_upgrade = abap_false
TABLES
tt_e071 = lt_cts_object_entry
tt_errormsg = lt_errormsg.
LOOP AT lt_errormsg TRANSPORTING NO FIELDS WHERE severity = 'E' OR severity = 'A'.
EXIT.
ENDLOOP.
IF sy-subrc = 0.
zcx_abapgit_exception=>raise( 'Error from AFTER_IMP_CHDO' ).
ENDIF.
ENDMETHOD.
METHOD delete_tadir_cdnames.
DATA: lv_obj_name TYPE sobj_name.
IF is_cdnames-repnamec IS NOT INITIAL.
lv_obj_name = is_cdnames-repnamec.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'PROG'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
IF is_cdnames-repnamet IS NOT INITIAL.
lv_obj_name = is_cdnames-repnamet.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'PROG'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
IF is_cdnames-repnamefix IS NOT INITIAL.
lv_obj_name = is_cdnames-repnamefix.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'PROG'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
IF is_cdnames-repnamevar IS NOT INITIAL.
lv_obj_name = is_cdnames-repnamevar.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'PROG'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
IF is_cdnames-fgrp IS NOT INITIAL.
lv_obj_name = is_cdnames-fgrp.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'FUGR'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
ENDMETHOD.
METHOD delete_tadir_tabl.
DATA: lv_obj_name TYPE sobj_name.
IF is_tcdrs-tabname IS NOT INITIAL.
lv_obj_name = is_tcdrs-tabname.
CALL FUNCTION 'TR_TADIR_INTERFACE'
EXPORTING
wi_delete_tadir_entry = abap_true
wi_tadir_pgmid = 'R3TR'
wi_tadir_object = 'FUGR'
wi_tadir_obj_name = lv_obj_name
EXCEPTIONS
tadir_entry_not_existing = 1
OTHERS = 2.
IF sy-subrc > 1.
zcx_abapgit_exception=>raise( |Error from TR_TADIR_INTERFACE (subrc={ sy-subrc } ).| ).
ENDIF.
ENDIF.
ENDMETHOD.
ENDCLASS.