diff --git a/src/objects/core/zcl_abapgit_tadir.clas.abap b/src/objects/core/zcl_abapgit_tadir.clas.abap index 3695fd57a..d1212a16b 100644 --- a/src/objects/core/zcl_abapgit_tadir.clas.abap +++ b/src/objects/core/zcl_abapgit_tadir.clas.abap @@ -10,11 +10,6 @@ CLASS zcl_abapgit_tadir DEFINITION PROTECTED SECTION. PRIVATE SECTION. - METHODS exists - IMPORTING - !is_item TYPE zif_abapgit_definitions=>ty_item - RETURNING - VALUE(rv_exists) TYPE abap_bool . METHODS check_exists IMPORTING !it_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt @@ -86,7 +81,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_TADIR IMPLEMENTATION. +CLASS zcl_abapgit_tadir IMPLEMENTATION. METHOD add_local_packages. @@ -253,7 +248,7 @@ CLASS ZCL_ABAPGIT_TADIR IMPLEMENTATION. ls_item-obj_name = -obj_name. ls_item-devclass = -devclass. - IF exists( ls_item ) = abap_true. + IF zcl_abapgit_objects=>exists( ls_item ) = abap_true. APPEND TO rt_tadir. ENDIF. ENDLOOP. @@ -294,22 +289,6 @@ CLASS ZCL_ABAPGIT_TADIR IMPLEMENTATION. ENDMETHOD. - METHOD exists. - - IF is_item IS INITIAL. - RETURN. - ENDIF. - - IF zcl_abapgit_objects=>is_supported( is_item ) = abap_false. - rv_exists = abap_true. - RETURN. - ENDIF. - - rv_exists = zcl_abapgit_objects=>exists( is_item ). - - ENDMETHOD. - - METHOD select_objects. DATA: @@ -392,7 +371,7 @@ CLASS ZCL_ABAPGIT_TADIR IMPLEMENTATION. ls_item-obj_type = ls_tadir-object. ls_item-obj_name = ls_tadir-obj_name. ls_item-devclass = ls_tadir-devclass. - IF exists( ls_item ) = abap_false. + IF zcl_abapgit_objects=>exists( ls_item ) = abap_false. RETURN. ENDIF. diff --git a/src/objects/zcl_abapgit_objects.clas.abap b/src/objects/zcl_abapgit_objects.clas.abap index a63cfd1d7..ad0cbfb75 100644 --- a/src/objects/zcl_abapgit_objects.clas.abap +++ b/src/objects/zcl_abapgit_objects.clas.abap @@ -57,9 +57,7 @@ CLASS zcl_abapgit_objects DEFINITION IMPORTING !is_item TYPE zif_abapgit_definitions=>ty_item RETURNING - VALUE(rv_user) TYPE xubname - RAISING - zcx_abapgit_exception . + VALUE(rv_user) TYPE xubname . CLASS-METHODS is_supported IMPORTING !is_item TYPE zif_abapgit_definitions=>ty_item diff --git a/src/ui/zcl_abapgit_gui_page_stage.clas.abap b/src/ui/zcl_abapgit_gui_page_stage.clas.abap index b03737a15..335bad7ee 100644 --- a/src/ui/zcl_abapgit_gui_page_stage.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_stage.clas.abap @@ -261,29 +261,26 @@ CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION. ENDLOOP. LOOP AT rt_changed_by ASSIGNING . - TRY. - -name = zcl_abapgit_objects=>changed_by( -item ). - CATCH zcx_abapgit_exception. - ENDTRY. + -name = zcl_abapgit_objects=>changed_by( -item ). ENDLOOP. LOOP AT lt_changed_by_remote ASSIGNING . - TRY. - " deleted files might still be in a transport - CLEAR lv_transport. - READ TABLE it_transports WITH KEY - obj_type = -item-obj_type - obj_name = -item-obj_name - INTO lv_transport. - IF sy-subrc = 0. - SELECT SINGLE as4user FROM e070 INTO lv_user - WHERE trkorr = lv_transport-trkorr. - -name = lv_user. - ELSE. - -name = zcl_abapgit_objects_super=>c_user_unknown. - ENDIF. - CATCH zcx_abapgit_exception. - ENDTRY. + " deleted files might still be in a transport + CLEAR lv_transport. + READ TABLE it_transports WITH KEY + obj_type = -item-obj_type + obj_name = -item-obj_name + INTO lv_transport. + IF sy-subrc = 0. + SELECT SINGLE as4user FROM e070 INTO lv_user + WHERE trkorr = lv_transport-trkorr. + IF sy-subrc = 0. + -name = lv_user. + ENDIF. + ENDIF. + IF -name IS INITIAL. + -name = zcl_abapgit_objects_super=>c_user_unknown. + ENDIF. ENDLOOP. INSERT LINES OF lt_changed_by_remote INTO TABLE rt_changed_by.