SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Remove exception from changed_by (#4952)

Browse Source 
Simplify some code since `zcl_abapgit_objects=>changed_by` does not raise any exceptions.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2021-09-16 03:44:05 -04:00 committed by GitHub
parent 6fcc223c31
commit a72d3314cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/objects/core/zcl_abapgit_tadir.clas.abap
View File

@ -10,11 +10,6 @@ CLASS zcl_abapgit_tadir DEFINITION
PROTECTED SECTION. PROTECTED SECTION.
PRIVATE SECTION. PRIVATE SECTION.
METHODS exists
IMPORTING
!is_item TYPE zif_abapgit_definitions=>ty_item
RETURNING
VALUE(rv_exists) TYPE abap_bool .
METHODS check_exists METHODS check_exists
IMPORTING IMPORTING
!it_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt !it_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt
@ -86,7 +81,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_TADIR IMPLEMENTATION. CLASS zcl_abapgit_tadir IMPLEMENTATION.
METHOD add_local_packages. METHOD add_local_packages.
@ -253,7 +248,7 @@ CLASS ZCL_ABAPGIT_TADIR IMPLEMENTATION.
ls_item-obj_name = <ls_tadir>-obj_name. ls_item-obj_name = <ls_tadir>-obj_name.
ls_item-devclass = <ls_tadir>-devclass. ls_item-devclass = <ls_tadir>-devclass.
IF exists( ls_item ) = abap_true. IF zcl_abapgit_objects=>exists( ls_item ) = abap_true.
APPEND <ls_tadir> TO rt_tadir. APPEND <ls_tadir> TO rt_tadir.
ENDIF. ENDIF.
ENDLOOP. ENDLOOP.
@ -294,22 +289,6 @@ CLASS ZCL_ABAPGIT_TADIR IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD exists.
IF is_item IS INITIAL.
RETURN.
ENDIF.
IF zcl_abapgit_objects=>is_supported( is_item ) = abap_false.
rv_exists = abap_true.
RETURN.
ENDIF.
rv_exists = zcl_abapgit_objects=>exists( is_item ).
ENDMETHOD.
METHOD select_objects. METHOD select_objects.
DATA: DATA:
@ -392,7 +371,7 @@ CLASS ZCL_ABAPGIT_TADIR IMPLEMENTATION.
ls_item-obj_type = ls_tadir-object. ls_item-obj_type = ls_tadir-object.
ls_item-obj_name = ls_tadir-obj_name. ls_item-obj_name = ls_tadir-obj_name.
ls_item-devclass = ls_tadir-devclass. ls_item-devclass = ls_tadir-devclass.
IF exists( ls_item ) = abap_false. IF zcl_abapgit_objects=>exists( ls_item ) = abap_false.
RETURN. RETURN.
ENDIF. ENDIF.

4
src/objects/zcl_abapgit_objects.clas.abap
View File

@ -57,9 +57,7 @@ CLASS zcl_abapgit_objects DEFINITION
IMPORTING IMPORTING
!is_item TYPE zif_abapgit_definitions=>ty_item !is_item TYPE zif_abapgit_definitions=>ty_item
RETURNING RETURNING
VALUE(rv_user) TYPE xubname VALUE(rv_user) TYPE xubname .
RAISING
zcx_abapgit_exception .
CLASS-METHODS is_supported CLASS-METHODS is_supported
IMPORTING IMPORTING
!is_item TYPE zif_abapgit_definitions=>ty_item !is_item TYPE zif_abapgit_definitions=>ty_item

11
src/ui/zcl_abapgit_gui_page_stage.clas.abap
View File

@ -261,14 +261,10 @@ CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION.
ENDLOOP. ENDLOOP.
LOOP AT rt_changed_by ASSIGNING <ls_changed_by>. LOOP AT rt_changed_by ASSIGNING <ls_changed_by>.
TRY.
<ls_changed_by>-name = zcl_abapgit_objects=>changed_by( <ls_changed_by>-item ). <ls_changed_by>-name = zcl_abapgit_objects=>changed_by( <ls_changed_by>-item ).
CATCH zcx_abapgit_exception.
ENDTRY.
ENDLOOP. ENDLOOP.
LOOP AT lt_changed_by_remote ASSIGNING <ls_changed_by>. LOOP AT lt_changed_by_remote ASSIGNING <ls_changed_by>.
TRY.
" deleted files might still be in a transport " deleted files might still be in a transport
CLEAR lv_transport. CLEAR lv_transport.
READ TABLE it_transports WITH KEY READ TABLE it_transports WITH KEY
@ -278,12 +274,13 @@ CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION.
IF sy-subrc = 0. IF sy-subrc = 0.
SELECT SINGLE as4user FROM e070 INTO lv_user SELECT SINGLE as4user FROM e070 INTO lv_user
WHERE trkorr = lv_transport-trkorr. WHERE trkorr = lv_transport-trkorr.
IF sy-subrc = 0.
<ls_changed_by>-name = lv_user. <ls_changed_by>-name = lv_user.
ELSE. ENDIF.
ENDIF.
IF <ls_changed_by>-name IS INITIAL.
<ls_changed_by>-name = zcl_abapgit_objects_super=>c_user_unknown. <ls_changed_by>-name = zcl_abapgit_objects_super=>c_user_unknown.
ENDIF. ENDIF.
CATCH zcx_abapgit_exception.
ENDTRY.
ENDLOOP. ENDLOOP.
INSERT LINES OF lt_changed_by_remote INTO TABLE rt_changed_by. INSERT LINES OF lt_changed_by_remote INTO TABLE rt_changed_by.