SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 04:08:27 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Remove experimental status from PDTS (#4831)

Browse Source 
* Remove experimental status of PDTS

* Remove experimental status from PDTS
This commit is contained in:
Mike Pokraka 2021-06-10 09:03:17 +01:00 committed by GitHub
parent f857194037
commit a9c40ea972
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/objects/zcl_abapgit_object_pdts.clas.abap
View File

@ -36,14 +36,6 @@ CLASS zcl_abapgit_object_pdts IMPLEMENTATION.
super->constructor( is_item = is_item super->constructor( is_item = is_item
iv_language = iv_language ). iv_language = iv_language ).
IF is_experimental( ) = abap_false.
"Alpha version, known issues:
"- Container texts not de/serialized properly (functionally OK)
"- Container handling still a bad hack, needs refactoring with lots of debugging time
"- Probably has a few more bugs, more testing needed
zcx_abapgit_exception=>raise( 'PDTS not fully implemented, enable experimental features to test it' ).
ENDIF.
ms_objkey-otype = 'TS'. ms_objkey-otype = 'TS'.
ms_objkey-objid = ms_item-obj_name. ms_objkey-objid = ms_item-obj_name.
@ -88,7 +80,7 @@ CLASS zcl_abapgit_object_pdts IMPLEMENTATION.
include_initial_values = abap_true include_initial_values = abap_true
include_typenames = abap_true include_typenames = abap_true
include_change_data = abap_true include_change_data = abap_true
include_texts = abap_false "Todo: Get texts to work properly include_texts = abap_false "Todo: Get texts to work properly #4164
include_extension_elements = abap_true include_extension_elements = abap_true
save_delta_handling_info = abap_true save_delta_handling_info = abap_true
use_xslt = abap_false use_xslt = abap_false

13
src/objects/zcl_abapgit_object_pdxx_super.clas.abap
View File

@ -16,27 +16,14 @@ CLASS zcl_abapgit_object_pdxx_super DEFINITION
METHODS check_subrc_for IMPORTING iv_call TYPE clike OPTIONAL METHODS check_subrc_for IMPORTING iv_call TYPE clike OPTIONAL
RAISING zcx_abapgit_exception. RAISING zcx_abapgit_exception.
METHODS is_experimental RETURNING VALUE(rv_result) TYPE abap_bool.
PRIVATE SECTION. PRIVATE SECTION.
ENDCLASS. ENDCLASS.
CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION. CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION.
METHOD is_experimental.
DATA lo_settings TYPE REF TO zcl_abapgit_settings.
DATA lo_settings_persistence TYPE REF TO zcl_abapgit_persist_settings.
lo_settings_persistence = zcl_abapgit_persist_settings=>get_instance( ).
lo_settings = lo_settings_persistence->read( ).
rv_result = lo_settings->get_experimental_features( ).
ENDMETHOD.
METHOD check_subrc_for. METHOD check_subrc_for.
IF sy-subrc <> 0. IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( iv_call && ' returned ' && sy-subrc ). zcx_abapgit_exception=>raise( iv_call && ' returned ' && sy-subrc ).