SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

naming conventions

Browse Source
This commit is contained in:
larshp 2018-11-11 07:24:12 +00:00 committed by Lars Hvam
parent 78eb30606a
commit aae099b93d
8 changed files with 100 additions and 109 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/objects/ecatt/zcl_abapgit_ecatt_val_obj_down.clas.abap
View File

@ -17,11 +17,10 @@ CLASS zcl_abapgit_ecatt_val_obj_down DEFINITION
PROTECTED SECTION.
DATA:
li_objects_node TYPE REF TO if_ixml_element.
mi_objects_node TYPE REF TO if_ixml_element.
METHODS:
download_data REDEFINITION.
PRIVATE SECTION.
DATA:
mv_xml_stream TYPE xstring,
@ -36,7 +35,7 @@ ENDCLASS.
CLASS zcl_abapgit_ecatt_val_obj_down IMPLEMENTATION.
CLASS ZCL_ABAPGIT_ECATT_VAL_OBJ_DOWN IMPLEMENTATION.
METHOD download.
@ -145,7 +144,7 @@ CLASS zcl_abapgit_ecatt_val_obj_down IMPLEMENTATION.
lo_ecatt_vo = <lg_ecatt_vo>.
li_objects_node = template_over_all->create_simple_element(
mi_objects_node = template_over_all->create_simple_element(
name = 'BUSINESS_MESSAGES'
parent = root_node ).
@ -187,7 +186,7 @@ CLASS zcl_abapgit_ecatt_val_obj_down IMPLEMENTATION.
FIELD-SYMBOLS: <lg_ecatt_vo> TYPE any.
li_objects_node = template_over_all->create_simple_element(
mi_objects_node = template_over_all->create_simple_element(
name = 'VO_FLAGS'
parent = root_node ).
@ -257,7 +256,7 @@ CLASS zcl_abapgit_ecatt_val_obj_down IMPLEMENTATION.
FIELD-SYMBOLS: <lg_ecatt_vo> TYPE any.
li_objects_node = template_over_all->create_simple_element(
mi_objects_node = template_over_all->create_simple_element(
name = 'IMPL_DETAILS'
parent = root_node ).

23
src/objects/zcl_abapgit_object_ssfo.clas.abap
View File

@ -4,10 +4,11 @@ CLASS zcl_abapgit_object_ssfo DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
INTERFACES zif_abapgit_object.
ALIASES mo_files FOR zif_abapgit_object~mo_files.
PROTECTED SECTION.
PRIVATE SECTION.
TYPES: ty_string_range TYPE RANGE OF string.
CLASS-DATA: range_node_codes TYPE ty_string_range.
CLASS-DATA: gt_range_node_codes TYPE ty_string_range.
CONSTANTS: attrib_abapgit_leadig_spaces TYPE string VALUE 'abapgit-leadig-spaces' ##NO_TEXT.
METHODS fix_ids IMPORTING ii_xml_doc TYPE REF TO if_ixml_document.
@ -31,15 +32,15 @@ CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION.
METHOD code_item_section_handling.
CONSTANTS: node_item TYPE string VALUE 'item' ##NO_TEXT.
CONSTANTS: node_text TYPE string VALUE '#text' ##NO_TEXT.
CONSTANTS: lc_node_item TYPE string VALUE 'item' ##NO_TEXT.
CONSTANTS: lc_node_text TYPE string VALUE '#text' ##NO_TEXT.
IF iv_name IN get_range_node_codes( ).
cv_within_code_section = abap_true.
ENDIF.
IF cv_within_code_section = abap_true.
IF iv_name = node_item.
IF iv_name = lc_node_item.
TRY.
ei_code_item_element ?= ii_node.
RETURN.
@ -47,7 +48,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION.
ENDTRY.
ELSEIF iv_name NOT IN get_range_node_codes( ) AND
iv_name <> node_text.
iv_name <> lc_node_text.
cv_within_code_section = abap_false.
ENDIF.
ENDIF.
@ -134,20 +135,20 @@ CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION.
DATA: ls_range_node_code TYPE LINE OF ty_string_range.
IF me->range_node_codes IS INITIAL.
IF me->gt_range_node_codes IS INITIAL.
ls_range_node_code-sign = 'I'.
ls_range_node_code-option = 'EQ'.
ls_range_node_code-low = 'CODE'.
INSERT ls_range_node_code INTO TABLE me->range_node_codes.
INSERT ls_range_node_code INTO TABLE me->gt_range_node_codes.
ls_range_node_code-low = 'GTYPES'.
INSERT ls_range_node_code INTO TABLE me->range_node_codes.
INSERT ls_range_node_code INTO TABLE me->gt_range_node_codes.
ls_range_node_code-low = 'GCODING'.
INSERT ls_range_node_code INTO TABLE me->range_node_codes.
INSERT ls_range_node_code INTO TABLE me->gt_range_node_codes.
ls_range_node_code-low = 'FCODING'.
INSERT ls_range_node_code INTO TABLE me->range_node_codes.
INSERT ls_range_node_code INTO TABLE me->gt_range_node_codes.
ENDIF.
rt_range_node_codes = me->range_node_codes.
rt_range_node_codes = me->gt_range_node_codes.
ENDMETHOD.

18
src/objects/zcl_abapgit_object_suso.clas.abap
View File

@ -27,7 +27,7 @@ ENDCLASS.
CLASS zcl_abapgit_object_suso IMPLEMENTATION.
CLASS ZCL_ABAPGIT_OBJECT_SUSO IMPLEMENTATION.
METHOD constructor.
@ -83,7 +83,7 @@ CLASS zcl_abapgit_object_suso IMPLEMENTATION.
METHOD pre_check.
CONSTANTS:
co_act_delete TYPE activ_auth VALUE '06'.
lc_act_delete TYPE activ_auth VALUE '06'.
DATA:
lv_act_head TYPE activ_auth,
@ -130,11 +130,11 @@ CLASS zcl_abapgit_object_suso IMPLEMENTATION.
CALL METHOD lo_suso->('GET_SUSO_EDIT_MODE')
EXPORTING
id_object = mv_objectname
id_planed_act = co_act_delete
id_planed_act = lc_act_delete
IMPORTING
ed_mode_head = lv_act_head.
IF lv_act_head <> co_act_delete.
IF lv_act_head <> lc_act_delete.
zcx_abapgit_exception=>raise( |AUTH { mv_objectname }: Delete not allowed| ).
ENDIF.
@ -263,6 +263,11 @@ CLASS zcl_abapgit_object_suso IMPLEMENTATION.
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
@ -333,9 +338,4 @@ CLASS zcl_abapgit_object_suso IMPLEMENTATION.
iv_name = 'TOBJVOR' ).
ENDMETHOD.
METHOD zif_abapgit_object~is_active.
rv_active = is_active( ).
ENDMETHOD.
ENDCLASS.

12
src/persist/zcl_abapgit_persistence_db.clas.abap
View File

@ -68,7 +68,7 @@ CLASS zcl_abapgit_persistence_db DEFINITION
PRIVATE SECTION.
CLASS-DATA go_db TYPE REF TO zcl_abapgit_persistence_db .
DATA: gv_update_function TYPE funcname.
DATA: mv_update_function TYPE funcname.
METHODS get_update_function RETURNING VALUE(rv_funcname) TYPE funcname.
@ -126,19 +126,19 @@ CLASS ZCL_ABAPGIT_PERSISTENCE_DB IMPLEMENTATION.
METHOD get_update_function.
IF gv_update_function IS INITIAL.
gv_update_function = 'CALL_V1_PING'.
IF mv_update_function IS INITIAL.
mv_update_function = 'CALL_V1_PING'.
CALL FUNCTION 'FUNCTION_EXISTS'
EXPORTING
funcname = gv_update_function
funcname = mv_update_function
EXCEPTIONS
OTHERS = 2.
IF sy-subrc <> 0.
gv_update_function = 'BANK_OBJ_WORKL_RELEASE_LOCKS'.
mv_update_function = 'BANK_OBJ_WORKL_RELEASE_LOCKS'.
ENDIF.
ENDIF.
rv_funcname = gv_update_function.
rv_funcname = mv_update_function.
ENDMETHOD.

65
src/ui/zcl_abapgit_popups.clas.abap
View File

@ -26,6 +26,7 @@ CLASS zcl_abapgit_popups DEFINITION
package_popup_callback FOR zif_abapgit_popups~package_popup_callback,
popup_transport_request FOR zif_abapgit_popups~popup_transport_request.
PROTECTED SECTION.
PRIVATE SECTION.
TYPES:
@ -34,10 +35,10 @@ CLASS zcl_abapgit_popups DEFINITION
CONSTANTS c_fieldname_selected TYPE lvc_fname VALUE `SELECTED` ##NO_TEXT.
CONSTANTS c_answer_cancel TYPE char1 VALUE 'A' ##NO_TEXT.
DATA go_select_list_popup TYPE REF TO cl_salv_table .
DATA gr_table TYPE REF TO data .
DATA gv_cancel TYPE abap_bool .
DATA go_table_descr TYPE REF TO cl_abap_tabledescr .
DATA mo_select_list_popup TYPE REF TO cl_salv_table .
DATA mr_table TYPE REF TO data .
DATA mv_cancel TYPE abap_bool .
DATA mo_table_descr TYPE REF TO cl_abap_tabledescr .
METHODS add_field
IMPORTING
@ -119,8 +120,8 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
<lg_line> TYPE data,
<lg_data> TYPE any.
go_table_descr ?= cl_abap_tabledescr=>describe_by_data( it_list ).
lo_struct_descr ?= go_table_descr->get_table_line_type( ).
mo_table_descr ?= cl_abap_tabledescr=>describe_by_data( it_list ).
lo_struct_descr ?= mo_table_descr->get_table_line_type( ).
lt_components = lo_struct_descr->get_components( ).
INSERT INITIAL LINE INTO lt_components ASSIGNING <ls_component> INDEX 1.
@ -130,10 +131,10 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
<ls_component>-type ?= cl_abap_datadescr=>describe_by_name( 'FLAG' ).
lo_struct_descr2 = cl_abap_structdescr=>create( lt_components ).
go_table_descr = cl_abap_tabledescr=>create( lo_struct_descr2 ).
mo_table_descr = cl_abap_tabledescr=>create( lo_struct_descr2 ).
CREATE DATA gr_table TYPE HANDLE go_table_descr.
ASSIGN gr_table->* TO <lt_table>.
CREATE DATA mr_table TYPE HANDLE mo_table_descr.
ASSIGN mr_table->* TO <lt_table>.
ASSERT sy-subrc = 0.
CREATE DATA lr_struct TYPE HANDLE lo_struct_descr2.
@ -184,7 +185,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
lv_condition = |{ c_fieldname_selected } = ABAP_TRUE|.
ASSIGN gr_table->* TO <lt_table>.
ASSIGN mr_table->* TO <lt_table>.
ASSERT sy-subrc = 0.
CREATE DATA lr_exporting LIKE LINE OF et_list.
@ -205,19 +206,19 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
<lg_line> TYPE any,
<lv_selected> TYPE flag.
ASSIGN gr_table->* TO <lt_table>.
ASSIGN mr_table->* TO <lt_table>.
ASSERT sy-subrc = 0.
CASE e_salv_function.
WHEN 'O.K.'.
gv_cancel = abap_false.
go_select_list_popup->close_screen( ).
mv_cancel = abap_false.
mo_select_list_popup->close_screen( ).
WHEN 'ABR'.
"Canceled: clear list to overwrite nothing
CLEAR <lt_table>.
gv_cancel = abap_true.
go_select_list_popup->close_screen( ).
mv_cancel = abap_true.
mo_select_list_popup->close_screen( ).
WHEN 'SALL'.
@ -232,7 +233,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
ENDLOOP.
go_select_list_popup->refresh( ).
mo_select_list_popup->refresh( ).
WHEN 'DSEL'.
@ -247,11 +248,11 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
ENDLOOP.
go_select_list_popup->refresh( ).
mo_select_list_popup->refresh( ).
WHEN OTHERS.
CLEAR <lt_table>.
go_select_list_popup->close_screen( ).
mo_select_list_popup->close_screen( ).
ENDCASE.
ENDMETHOD.
@ -265,7 +266,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
<lg_line> TYPE any,
<lv_selected> TYPE flag.
ASSIGN gr_table->* TO <lt_table>.
ASSIGN mr_table->* TO <lt_table>.
ASSERT sy-subrc = 0.
lv_line = row.
@ -287,7 +288,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
ENDIF.
go_select_list_popup->refresh( ).
mo_select_list_popup->refresh( ).
ENDMETHOD.
@ -744,22 +745,22 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
create_new_table( it_list ).
ASSIGN gr_table->* TO <lt_table>.
ASSIGN mr_table->* TO <lt_table>.
ASSERT sy-subrc = 0.
TRY.
cl_salv_table=>factory( IMPORTING r_salv_table = go_select_list_popup
cl_salv_table=>factory( IMPORTING r_salv_table = mo_select_list_popup
CHANGING t_table = <lt_table> ).
go_select_list_popup->set_screen_status( pfstatus = '102'
mo_select_list_popup->set_screen_status( pfstatus = '102'
report = 'SAPMSVIM' ).
go_select_list_popup->set_screen_popup( start_column = 1
mo_select_list_popup->set_screen_popup( start_column = 1
end_column = 65
start_line = 1
end_line = 20 ).
lo_events = go_select_list_popup->get_event( ).
lo_events = mo_select_list_popup->get_event( ).
SET HANDLER on_select_list_link_click FOR lo_events.
SET HANDLER on_select_list_function_click FOR lo_events.
@ -768,9 +769,9 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
EXPORTING
text = iv_header_text.
go_select_list_popup->set_top_of_list( lo_table_header ).
mo_select_list_popup->set_top_of_list( lo_table_header ).
lo_columns = go_select_list_popup->get_columns( ).
lo_columns = mo_select_list_popup->get_columns( ).
lo_columns->set_optimize( abap_true ).
lt_columns = lo_columns->get( ).
@ -794,13 +795,13 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
ENDLOOP.
go_select_list_popup->display( ).
mo_select_list_popup->display( ).
CATCH cx_salv_msg.
zcx_abapgit_exception=>raise( 'Error from POPUP_TO_SELECT_FROM_LIST' ).
ENDTRY.
IF gv_cancel = abap_true.
IF mv_cancel = abap_true.
RAISE EXCEPTION TYPE zcx_abapgit_cancel.
ENDIF.
@ -808,9 +809,9 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
IMPORTING
et_list = et_list ).
CLEAR: go_select_list_popup,
gr_table,
go_table_descr.
CLEAR: mo_select_list_popup,
mr_table,
mo_table_descr.
ENDMETHOD.

4
src/utils/zcl_abapgit_progress.clas.abap
View File

@ -58,7 +58,7 @@ CLASS ZCL_ABAPGIT_PROGRESS IMPLEMENTATION.
DATA: lv_pct TYPE i.
DATA: lv_time TYPE t.
CONSTANTS: c_wait_secs TYPE i VALUE 2.
CONSTANTS: lc_wait_secs TYPE i VALUE 2.
GET TIME.
lv_time = sy-uzeit.
@ -77,7 +77,7 @@ CLASS ZCL_ABAPGIT_PROGRESS IMPLEMENTATION.
EXPORTING
percentage = lv_pct
text = iv_text.
mv_cv_time_next = lv_time + c_wait_secs.
mv_cv_time_next = lv_time + lc_wait_secs.
ENDIF.
IF sy-datum > mv_cv_datum_next.

10
src/utils/zcl_abapgit_user_master_record.clas.abap
View File

@ -33,17 +33,16 @@ CLASS zcl_abapgit_user_master_record DEFINITION
END OF ty_user.
CLASS-DATA:
mt_user TYPE HASHED TABLE OF ty_user
gt_user TYPE HASHED TABLE OF ty_user
WITH UNIQUE KEY user.
DATA:
ms_user TYPE zif_abapgit_definitions=>ty_git_user.
ENDCLASS.
CLASS zcl_abapgit_user_master_record IMPLEMENTATION.
CLASS ZCL_ABAPGIT_USER_MASTER_RECORD IMPLEMENTATION.
METHOD constructor.
@ -88,7 +87,7 @@ CLASS zcl_abapgit_user_master_record IMPLEMENTATION.
DATA: ls_user TYPE ty_user.
FIELD-SYMBOLS: <ls_user> TYPE ty_user.
READ TABLE mt_user ASSIGNING <ls_user>
READ TABLE gt_user ASSIGNING <ls_user>
WITH KEY user = iv_user.
IF sy-subrc <> 0.
@ -98,7 +97,7 @@ CLASS zcl_abapgit_user_master_record IMPLEMENTATION.
iv_user = iv_user.
INSERT ls_user
INTO TABLE mt_user
INTO TABLE gt_user
ASSIGNING <ls_user>.
ENDIF.
@ -113,5 +112,4 @@ CLASS zcl_abapgit_user_master_record IMPLEMENTATION.
rv_name = ms_user-name.
ENDMETHOD.
ENDCLASS.

66
src/zcl_abapgit_default_transport.clas.abap
View File

@ -28,45 +28,37 @@ CLASS zcl_abapgit_default_transport DEFINITION
PRIVATE SECTION.
CLASS-DATA:
mo_instance TYPE REF TO zcl_abapgit_default_transport .
DATA:
mv_is_set_by_abapgit TYPE abap_bool,
ms_save TYPE e070use.
METHODS:
store
RAISING
zcx_abapgit_exception,
restore
RAISING
zcx_abapgit_exception,
get
RETURNING
VALUE(rs_default_task) TYPE e070use
RAISING
zcx_abapgit_exception,
set_internal
IMPORTING
iv_transport TYPE trkorr
RAISING
zcx_abapgit_exception,
clear
IMPORTING
is_default_task TYPE e070use
RAISING
zcx_abapgit_exception.
CLASS-DATA go_instance TYPE REF TO zcl_abapgit_default_transport .
DATA mv_is_set_by_abapgit TYPE abap_bool .
DATA ms_save TYPE e070use .
METHODS store
RAISING
zcx_abapgit_exception .
METHODS restore
RAISING
zcx_abapgit_exception .
METHODS get
RETURNING
VALUE(rs_default_task) TYPE e070use
RAISING
zcx_abapgit_exception .
METHODS set_internal
IMPORTING
!iv_transport TYPE trkorr
RAISING
zcx_abapgit_exception .
METHODS clear
IMPORTING
!is_default_task TYPE e070use
RAISING
zcx_abapgit_exception .
ENDCLASS.
CLASS zcl_abapgit_default_transport IMPLEMENTATION.
CLASS ZCL_ABAPGIT_DEFAULT_TRANSPORT IMPLEMENTATION.
METHOD clear.
@ -121,11 +113,11 @@ CLASS zcl_abapgit_default_transport IMPLEMENTATION.
METHOD get_instance.
IF mo_instance IS NOT BOUND.
CREATE OBJECT mo_instance.
IF go_instance IS NOT BOUND.
CREATE OBJECT go_instance.
ENDIF.
ro_instance = mo_instance.
ro_instance = go_instance.
ENDMETHOD.