From adb529152ba4b55c68dc40d54f3eceb5b70cc452 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederik=20Hud=C3=A1k?= Date: Mon, 21 Feb 2022 17:37:40 +0100 Subject: [PATCH] minor css adjustments (#5372) Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com> --- src/ui/zabapgit_css_common.w3mi.data.css | 7 +++++-- src/ui/zabapgit_css_theme_default.w3mi.data.css | 3 +++ src/ui/zcl_abapgit_gui_page_repo_view.clas.abap | 16 ++++++++++++---- 3 files changed, 20 insertions(+), 6 deletions(-) diff --git a/src/ui/zabapgit_css_common.w3mi.data.css b/src/ui/zabapgit_css_common.w3mi.data.css index 61b3827ed..39b8fd44a 100644 --- a/src/ui/zabapgit_css_common.w3mi.data.css +++ b/src/ui/zabapgit_css_common.w3mi.data.css @@ -278,7 +278,7 @@ table.repo_tab { border: 1px solid; border-radius: 3px; width: 100%; - line-height: 1.5; + line-height: 1.2; } .repo_tab th { text-align: left; @@ -287,7 +287,6 @@ table.repo_tab { font-weight: normal; } .repo_tab td { - border-top: 1px solid; vertical-align: middle; padding-top: 2px; padding-bottom: 2px; @@ -322,6 +321,10 @@ table.repo_tab { line-height: 1.5; } +.repo_tab tr.object_row{ + border-top: 1px solid; +} + .repo_tab td.cmd, .repo_tab th.cmd { text-align: right; padding-left: 0.5em; diff --git a/src/ui/zabapgit_css_theme_default.w3mi.data.css b/src/ui/zabapgit_css_theme_default.w3mi.data.css index 6a6c866bb..d63a97384 100644 --- a/src/ui/zabapgit_css_theme_default.w3mi.data.css +++ b/src/ui/zabapgit_css_theme_default.w3mi.data.css @@ -146,6 +146,9 @@ table.repo_tab { } .repo_tab td { color: #333; +} + +.repo_tab tr.object_row{ border-top-color: var(--theme-table-border-color); } .repo_tab .inactive { color: orange; } diff --git a/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap b/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap index 18c2f1e1a..f6e2a9119 100644 --- a/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_repo_view.clas.abap @@ -85,9 +85,10 @@ CLASS zcl_abapgit_gui_page_repo_view DEFINITION VALUE(ri_html) TYPE REF TO zif_abapgit_html . METHODS get_item_class IMPORTING - !is_item TYPE zif_abapgit_definitions=>ty_repo_item + !is_item TYPE zif_abapgit_definitions=>ty_repo_item + iv_is_object_row TYPE abap_bool DEFAULT abap_false RETURNING - VALUE(rv_html) TYPE string . + VALUE(rv_html) TYPE string . METHODS get_item_icon IMPORTING !is_item TYPE zif_abapgit_definitions=>ty_repo_item @@ -188,7 +189,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_VIEW IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION. METHOD apply_order_by. @@ -658,6 +659,12 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_VIEW IMPLEMENTATION. DATA lt_class TYPE TABLE OF string. + IF iv_is_object_row = abap_true. + APPEND 'object_row' TO lt_class. + ELSE. + APPEND 'file_row' TO lt_class. + ENDIF. + IF is_item-is_dir = abap_true. APPEND 'folder' TO lt_class. ELSEIF is_item-changes > 0. @@ -975,7 +982,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_VIEW IMPLEMENTATION. CREATE OBJECT ri_html TYPE zcl_abapgit_html. - ri_html->add( || ). + ri_html->add( || ). IF is_item-obj_name IS INITIAL AND is_item-is_dir = abap_false. ri_html->add( ||