SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-02 13:03:01 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Removed Branch Overview Singleton - issue#2047 (#2048)

Browse Source 
* Removed Branch Overview Singleton - issue#2047

* Implement Multiton for Branch Overview

* Removing zabapgit_test_ssl

* Fixes #2047

ZCL_ABAPGIT_FACTORY%3D>GET_BRANCH_OVERVIEW now updates BRANCH_OBERVIEW state if the instance it's already created

* Remove Singleton Logic for Branch Overview

* Remove Setup method
This commit is contained in:
Sdfraga 2018-11-15 10:47:29 +01:00 committed by Lars Hvam
parent e61108511d
commit af2ac36253
2 changed files with 7 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/zcl_abapgit_branch_overview.clas.abap
View File

@ -82,9 +82,8 @@ CLASS ZCL_ABAPGIT_BRANCH_OVERVIEW IMPLEMENTATION.
DATA: lt_objects TYPE zif_abapgit_definitions=>ty_objects_tt. DATA: lt_objects TYPE zif_abapgit_definitions=>ty_objects_tt.
CLEAR mt_branches.
lt_objects = get_git_objects( io_repo ). lt_objects = get_git_objects( io_repo ).
mt_commits = parse_commits( lt_objects ). mt_commits = parse_commits( lt_objects ).
_sort_commits( CHANGING ct_commits = mt_commits ). _sort_commits( CHANGING ct_commits = mt_commits ).
@ -97,7 +96,6 @@ CLASS ZCL_ABAPGIT_BRANCH_OVERVIEW IMPLEMENTATION.
determine_tags( ). determine_tags( ).
fixes( ). fixes( ).
ENDMETHOD. ENDMETHOD.
@ -310,6 +308,7 @@ CLASS ZCL_ABAPGIT_BRANCH_OVERVIEW IMPLEMENTATION.
DELETE rt_objects WHERE type = zif_abapgit_definitions=>c_type-blob. DELETE rt_objects WHERE type = zif_abapgit_definitions=>c_type-blob.
ENDMETHOD. ENDMETHOD.
@ -563,4 +562,5 @@ CLASS ZCL_ABAPGIT_BRANCH_OVERVIEW IMPLEMENTATION.
ct_commits = lt_sorted_commits. ct_commits = lt_sorted_commits.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

21
src/zcl_abapgit_factory.clas.abap
View File

@ -84,20 +84,11 @@ CLASS zcl_abapgit_factory DEFINITION
TYPES: TYPES:
tty_syntax_check TYPE HASHED TABLE OF ty_syntax_check tty_syntax_check TYPE HASHED TABLE OF ty_syntax_check
WITH UNIQUE KEY package . WITH UNIQUE KEY package .
TYPES:
BEGIN OF ty_branch_overview,
repo_key TYPE zif_abapgit_persistence=>ty_value,
instance TYPE REF TO zif_abapgit_branch_overview,
END OF ty_branch_overview .
TYPES:
tty_branch_overview TYPE HASHED TABLE OF ty_branch_overview
WITH UNIQUE KEY repo_key .
CLASS-DATA gi_tadir TYPE REF TO zif_abapgit_tadir . CLASS-DATA gi_tadir TYPE REF TO zif_abapgit_tadir .
CLASS-DATA gt_sap_package TYPE tty_sap_package . CLASS-DATA gt_sap_package TYPE tty_sap_package .
CLASS-DATA gt_code_inspector TYPE tty_code_inspector . CLASS-DATA gt_code_inspector TYPE tty_code_inspector .
CLASS-DATA gt_syntax_check TYPE tty_syntax_check . CLASS-DATA gt_syntax_check TYPE tty_syntax_check .
CLASS-DATA gi_branch_overview TYPE REF TO zif_abapgit_branch_overview .
CLASS-DATA gi_stage_logic TYPE REF TO zif_abapgit_stage_logic . CLASS-DATA gi_stage_logic TYPE REF TO zif_abapgit_stage_logic .
CLASS-DATA gi_cts_api TYPE REF TO zif_abapgit_cts_api. CLASS-DATA gi_cts_api TYPE REF TO zif_abapgit_cts_api.
CLASS-DATA gi_adhoc_code_inspector TYPE REF TO zif_abapgit_code_inspector. CLASS-DATA gi_adhoc_code_inspector TYPE REF TO zif_abapgit_code_inspector.
@ -110,14 +101,10 @@ CLASS zcl_abapgit_factory IMPLEMENTATION.
METHOD get_branch_overview. METHOD get_branch_overview.
IF gi_branch_overview IS INITIAL. CREATE OBJECT ri_branch_overview
CREATE OBJECT gi_branch_overview TYPE zcl_abapgit_branch_overview
TYPE zcl_abapgit_branch_overview EXPORTING
EXPORTING io_repo = io_repo.
io_repo = io_repo.
ENDIF.
ri_branch_overview = gi_branch_overview.
ENDMETHOD. ENDMETHOD.