From b063e35c492d957150e15c2d3783f75a38e17117 Mon Sep 17 00:00:00 2001
From: Fabian Lupa <f.lupa@flaiker.com>
Date: Sun, 5 Feb 2017 13:34:02 +0100
Subject: [PATCH] Cache authenticated session for one time SMS token

---
 src/zabapgit_2fa.prog.abap | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/src/zabapgit_2fa.prog.abap b/src/zabapgit_2fa.prog.abap
index be267d9d2..6d9f7afd8 100644
--- a/src/zabapgit_2fa.prog.abap
+++ b/src/zabapgit_2fa.prog.abap
@@ -523,10 +523,20 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION.
   ENDMETHOD.
 
   METHOD get_authenticated_client.
+    STATICS: BEGIN OF ss_cached_client,
+               username TYPE string,
+               client   TYPE REF TO if_http_client,
+             END OF ss_cached_client.
     DATA: lv_http_code             TYPE i,
           lv_http_code_description TYPE string,
           lo_settings              TYPE REF TO lcl_settings.
 
+    " If there is a cached client for the same user return it instead
+    IF ss_cached_client-client IS BOUND AND ss_cached_client-username = iv_username.
+      ri_client = ss_cached_client-client.
+      RETURN.
+    ENDIF.
+
     " Try to login to GitHub API with username, password and 2fa token
 
     lo_settings = lcl_app=>settings( )->read( ).
@@ -574,6 +584,10 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION.
         EXPORTING
           iv_error_text = |Authentication failed: { lv_http_code_description }|.
     ENDIF.
+
+    " Cache the authenticated http session / client to avoid unnecessary additional authentication
+    ss_cached_client-username = iv_username.
+    ss_cached_client-client = ri_client.
   ENDMETHOD.
 ENDCLASS.