SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Clean-up unused_variables (#6564)

Browse Source 
Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2023-10-25 10:23:47 -04:00 committed by GitHub
parent dadc955352
commit b107457017
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
22 changed files with 21 additions and 62 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
abaplint.json
View File

@ -442,6 +442,7 @@
"omit_parameter_name": {
"exclude": ["/json/"]
},
"unused_variables": true,
"unnecessary_pragma": {
"allowNoTextGlobal": true
},
@ -453,7 +454,6 @@
"skipForAllEntries": true
},
"slow_parameter_passing": true,
"select_single_full_key": true,
"unused_variables": true
"select_single_full_key": true
}
}

6
src/data/zcl_abapgit_data_deserializer.clas.abap
View File

@ -20,13 +20,12 @@ CLASS zcl_abapgit_data_deserializer DEFINITION
METHODS preview_database_changes
IMPORTING
!iv_name TYPE tadir-obj_name
!it_where TYPE string_table
!ir_lc_data TYPE REF TO data
!ir_db_data TYPE REF TO data
RETURNING
VALUE(rs_result) TYPE zif_abapgit_data_deserializer=>ty_result
RAISING
zcx_abapgit_exception .
zcx_abapgit_exception.
METHODS write_database_table
IMPORTING
!iv_name TYPE tadir-obj_name
@ -119,7 +118,6 @@ CLASS zcl_abapgit_data_deserializer IMPLEMENTATION.
FIELD-SYMBOLS <lg_new> TYPE ANY TABLE.
FIELD-SYMBOLS <ls_del> TYPE any.
FIELD-SYMBOLS <ls_ins> TYPE any.
FIELD-SYMBOLS <ls_upd> TYPE any.
FIELD-SYMBOLS <lg_del> TYPE ANY TABLE.
FIELD-SYMBOLS <lg_ins> TYPE ANY TABLE.
FIELD-SYMBOLS <lg_upd> TYPE ANY TABLE.
@ -218,7 +216,6 @@ CLASS zcl_abapgit_data_deserializer IMPLEMENTATION.
DATA ls_result LIKE LINE OF it_result.
DATA li_cts_api TYPE REF TO zif_abapgit_cts_api.
DATA ls_file LIKE LINE OF rt_accessed_files.
FIELD-SYMBOLS:
<lt_ins> TYPE ANY TABLE,
@ -308,7 +305,6 @@ CLASS zcl_abapgit_data_deserializer IMPLEMENTATION.
ls_result = preview_database_changes(
iv_name = ls_config-name
it_where = ls_config-where
ir_lc_data = lr_lc_data
ir_db_data = lr_db_data ).

3
src/data/zcl_abapgit_data_deserializer.clas.testclasses.abap
View File

@ -73,7 +73,6 @@ CLASS ltcl_test IMPLEMENTATION.
CREATE OBJECT li_cut TYPE zcl_abapgit_data_deserializer.
ls_result = li_cut->preview_database_changes(
iv_name = ls_config-name
it_where = ls_config-where
ir_db_data = lr_db_data
ir_lc_data = lr_lc_data ).
@ -142,7 +141,6 @@ CLASS ltcl_test IMPLEMENTATION.
CREATE OBJECT li_cut TYPE zcl_abapgit_data_deserializer.
ls_result = li_cut->preview_database_changes(
iv_name = ls_config-name
it_where = ls_config-where
ir_db_data = lr_db_data
ir_lc_data = lr_lc_data ).
@ -205,7 +203,6 @@ CLASS ltcl_test IMPLEMENTATION.
CREATE OBJECT li_cut TYPE zcl_abapgit_data_deserializer.
ls_result = li_cut->preview_database_changes(
iv_name = ls_config-name
it_where = ls_config-where
ir_db_data = lr_db_data
ir_lc_data = lr_lc_data ).

3
src/objects/aff/zcl_abapgit_object_common_aff.clas.abap
View File

@ -23,8 +23,9 @@ CLASS zcl_abapgit_object_common_aff DEFINITION
END OF ty_extension_mapper_pair,
ty_extension_mapper_pairs TYPE STANDARD TABLE OF ty_extension_mapper_pair WITH DEFAULT KEY.
" Can be redefined in subclasses
METHODS get_additional_extensions
RETURNING VALUE(rv_additional_extensions) TYPE ty_extension_mapper_pairs.
RETURNING VALUE(rv_additional_extensions) TYPE ty_extension_mapper_pairs ##NEEDED.
METHODS get_object_handler
RETURNING
VALUE(ro_object_handler) TYPE REF TO object

4
src/objects/core/zcl_abapgit_tadir.clas.abap
View File

@ -23,7 +23,6 @@ CLASS zcl_abapgit_tadir DEFINITION
!io_dot TYPE REF TO zcl_abapgit_dot_abapgit
!iv_ignore_subpackages TYPE abap_bool DEFAULT abap_false
!iv_only_local_objects TYPE abap_bool DEFAULT abap_false
!ii_log TYPE REF TO zif_abapgit_log OPTIONAL
RETURNING
VALUE(rt_tadir) TYPE zif_abapgit_definitions=>ty_tadir_tt
RAISING
@ -397,8 +396,7 @@ CLASS zcl_abapgit_tadir IMPLEMENTATION.
iv_package = iv_package
io_dot = io_dot
iv_ignore_subpackages = iv_ignore_subpackages
iv_only_local_objects = iv_only_local_objects
ii_log = ii_log ).
iv_only_local_objects = iv_only_local_objects ).
li_exit = zcl_abapgit_exit=>get_instance( ).
li_exit->change_tadir(

1
src/objects/sap/zcl_abapgit_sap_namespace.clas.abap
View File

@ -63,7 +63,6 @@ CLASS ZCL_ABAPGIT_SAP_NAMESPACE IMPLEMENTATION.
METHOD zif_abapgit_sap_namespace~split_by_name.
* use this method instead of function module RS_NAME_SPLIT_NAMESPACE
DATA lv_regex TYPE string.
DATA lv_object TYPE string.
DATA lv_length TYPE i.
DATA lr_ex TYPE REF TO cx_root.

5
src/objects/texts/zcl_abapgit_lxe_texts.clas.abap
View File

@ -52,7 +52,7 @@ CLASS zcl_abapgit_lxe_texts DEFINITION
PROTECTED SECTION.
PRIVATE SECTION.
CONSTANTS c_custmnr TYPE lxecustmnr VALUE '999999'.
CONSTANTS c_custmnr TYPE lxecustmnr VALUE '999999' ##NEEDED.
" The value for ABAP system translation is always 999999 (from lxecustmnr docs)
TYPES:
@ -90,13 +90,14 @@ CLASS zcl_abapgit_lxe_texts DEFINITION
RAISING
zcx_abapgit_exception .
" Implementation of deserialize_xml is not complete (but kept as future option)
METHODS deserialize_xml
IMPORTING
!iv_lxe_text_name TYPE string DEFAULT 'LXE_TEXTS'
!iv_object_type TYPE tadir-object OPTIONAL
!iv_object_name TYPE tadir-obj_name OPTIONAL
RAISING
zcx_abapgit_exception .
zcx_abapgit_exception ##NEEDED.
METHODS deserialize_from_po
IMPORTING

1
src/objects/texts/zcl_abapgit_po_file.clas.testclasses.abap
View File

@ -22,7 +22,6 @@ CLASS ltcl_po_file IMPLEMENTATION.
DATA lo_po TYPE REF TO zcl_abapgit_po_file.
DATA lt_lxe_pairs TYPE zif_abapgit_lxe_texts=>ty_text_pairs.
DATA lv_act TYPE string.
DATA lv_exp TYPE string.
DATA lo_buf TYPE REF TO zcl_abapgit_string_buffer.
FIELD-SYMBOLS <ls_p> LIKE LINE OF lt_lxe_pairs.

4
src/objects/texts/zcl_abapgit_sots_handler.clas.abap
View File

@ -187,9 +187,7 @@ CLASS ZCL_ABAPGIT_SOTS_HANDLER IMPLEMENTATION.
METHOD delete_sots.
DATA:
ls_sots TYPE ty_sots,
lt_sots_use TYPE ty_sots_use_tt.
DATA lt_sots_use TYPE ty_sots_use_tt.
FIELD-SYMBOLS <ls_sots_use> LIKE LINE OF lt_sots_use.

8
src/objects/zcl_abapgit_object_aifc.clas.abap
View File

@ -59,8 +59,6 @@ CLASS zcl_abapgit_object_aifc DEFINITION
RAISING
zcx_abapgit_exception.
METHODS authorization_check
IMPORTING
!io_log TYPE REF TO zif_abapgit_log
RETURNING
VALUE(rv_success) TYPE abap_bool
RAISING
@ -82,7 +80,6 @@ CLASS zcl_abapgit_object_aifc DEFINITION
METHODS compress_interface
IMPORTING
!is_ifkeys TYPE ty_aif_key_s
!io_log TYPE REF TO zif_abapgit_log
RETURNING
VALUE(rv_success) TYPE abap_bool
RAISING
@ -357,7 +354,7 @@ CLASS zcl_abapgit_object_aifc IMPLEMENTATION.
iv_package = iv_package ).
IF authorization_check( ii_log ) = abap_false.
IF authorization_check( ) = abap_false.
RETURN.
ENDIF.
@ -365,8 +362,7 @@ CLASS zcl_abapgit_object_aifc IMPLEMENTATION.
RETURN.
ENDIF.
IF compress_interface( is_ifkeys = ls_ifkey
io_log = ii_log ) = abap_false.
IF compress_interface( ls_ifkey ) = abap_false.
RETURN.
ENDIF.

3
src/objects/zcl_abapgit_object_para.clas.abap
View File

@ -38,8 +38,7 @@ CLASS zcl_abapgit_object_para IMPLEMENTATION.
" We can't use FM RS_PARAMETER_DELETE because of the popup to confirm
"Therefore we have to reimplement most of the FMs logic
DATA: lv_paramid TYPE tpara-paramid,
ls_transpkey TYPE trkey.
DATA lv_paramid TYPE tpara-paramid.
lv_paramid = ms_item-obj_name.

3
src/objects/zcl_abapgit_object_sktd.clas.abap
View File

@ -358,8 +358,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SKTD IMPLEMENTATION.
DATA:
li_wb_object_operator TYPE REF TO object,
li_object_data_model TYPE REF TO if_wb_object_data_model,
lx_error TYPE REF TO cx_root,
lv_source TYPE string.
lx_error TYPE REF TO cx_root.
FIELD-SYMBOLS <ls_data> TYPE any.

12
src/objects/zcl_abapgit_object_view.clas.abap
View File

@ -17,18 +17,6 @@ CLASS zcl_abapgit_object_view DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
ddtext TYPE dd25t-ddtext,
END OF ty_dd25_text ,
ty_dd25_texts TYPE STANDARD TABLE OF ty_dd25_text.
CONSTANTS: BEGIN OF co_viewclass,
help TYPE viewclass VALUE 'H',
database TYPE viewclass VALUE 'D',
projection TYPE viewclass VALUE 'P',
structure TYPE viewclass VALUE 'S',
maintenance TYPE viewclass VALUE 'C',
entity TYPE viewclass VALUE 'E',
view_variant TYPE viewclass VALUE 'V',
append TYPE viewclass VALUE 'A',
external TYPE viewclass VALUE 'X',
replication TYPE viewclass VALUE 'R',
END OF co_viewclass.
CONSTANTS c_longtext_id_view TYPE dokil-id VALUE 'VW'.
METHODS:

1
src/objects/zcl_abapgit_objects.clas.abap
View File

@ -50,7 +50,6 @@ CLASS zcl_abapgit_objects DEFINITION
CLASS-METHODS changed_by
IMPORTING
!is_item TYPE zif_abapgit_definitions=>ty_item
!is_sub_item TYPE zif_abapgit_definitions=>ty_item OPTIONAL
!iv_filename TYPE string OPTIONAL
RETURNING
VALUE(rv_user) TYPE syuname .

2
src/persist/zcl_abapgit_persist_migrate.clas.locals_imp.abap
View File

@ -60,7 +60,7 @@ CLASS lcl_own_cua_provider DEFINITION FINAL.
PUBLIC SECTION.
CLASS-METHODS get
RETURNING
VALUE(rs_cua) TYPE zcl_abapgit_objects_program=>ty_cua.
VALUE(rs_cua) TYPE zcl_abapgit_objects_program=>ty_cua ##NEEDED.
ENDCLASS.
CLASS lcl_own_cua_provider IMPLEMENTATION.

5
src/repo/zcl_abapgit_repo_status.clas.locals_imp.abap
View File

@ -51,7 +51,6 @@ CLASS lcl_status_consistency_checks DEFINITION FINAL.
METHODS check_namespace
IMPORTING
!it_results TYPE zif_abapgit_definitions=>ty_results_tt
!iv_root_package TYPE devclass
RAISING
zcx_abapgit_exception .
@ -89,9 +88,7 @@ CLASS lcl_status_consistency_checks IMPLEMENTATION.
check_multiple_files( it_results ).
" Check if namespaces exist already
check_namespace(
it_results = it_results
iv_root_package = mv_root_package ).
check_namespace( it_results ).
ri_log = mi_log.

5
src/ui/pages/zcl_abapgit_gui_page_sett_info.clas.abap
View File

@ -48,10 +48,7 @@ CLASS zcl_abapgit_gui_page_sett_info DEFINITION
stats TYPE string VALUE 'stats',
stats_table TYPE string VALUE 'stats_table',
END OF c_id .
CONSTANTS:
BEGIN OF c_event,
save TYPE string VALUE 'save',
END OF c_event .
DATA mo_form TYPE REF TO zcl_abapgit_html_form .
DATA mo_form_data TYPE REF TO zcl_abapgit_string_map .
DATA mo_repo TYPE REF TO zcl_abapgit_repo .

2
src/utils/zcl_abapgit_string_map.clas.abap
View File

@ -166,6 +166,8 @@ CLASS ZCL_ABAPGIT_STRING_MAP IMPLEMENTATION.
iv_val = <ls_entry>-v ).
ENDLOOP.
ro_instance = me.
ENDMETHOD.

4
src/xml/zcl_abapgit_xml.clas.testclasses.abap
View File

@ -27,8 +27,6 @@ CLASS ltcl_xml DEFINITION FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
RAISING
zcx_abapgit_exception,
render_xml
IMPORTING
iv_name TYPE string
RETURNING
VALUE(rv_xml) TYPE string.
@ -65,7 +63,7 @@ CLASS ltcl_xml IMPLEMENTATION.
parse_xml( lv_from_xml ).
lv_to_xml = render_xml( 'FOO' ).
lv_to_xml = render_xml( ).
cl_abap_unit_assert=>assert_char_cp(
act = lv_to_xml

2
src/xml/zcl_abapgit_xml_input.clas.abap
View File

@ -17,8 +17,6 @@ CLASS zcl_abapgit_xml_input DEFINITION
PROTECTED SECTION.
PRIVATE SECTION.
DATA ms_i18n_params TYPE zif_abapgit_definitions=>ty_i18n_params.
METHODS fix_xml.
ENDCLASS.

1
src/xml/zcl_abapgit_xml_output.clas.abap
View File

@ -11,7 +11,6 @@ CLASS zcl_abapgit_xml_output DEFINITION
PRIVATE SECTION.
DATA mi_raw TYPE REF TO if_ixml_element .
DATA ms_i18n_params TYPE zif_abapgit_definitions=>ty_i18n_params .
METHODS build_asx_node
RETURNING

2
test/zcl_abapgit_tadir_test.clas.testclasses.abap
View File

@ -146,8 +146,6 @@ CLASS ltcl_build IMPLEMENTATION.
DATA lo_dot TYPE REF TO zcl_abapgit_dot_abapgit.
DATA li_log TYPE REF TO zif_abapgit_log.
DATA lr_ex TYPE REF TO zcx_abapgit_exception.
DATA lo_tadir TYPE REF TO zcl_abapgit_tadir.
DATA lo_ex TYPE REF TO zcx_abapgit_exception.
DATA lv_top_package TYPE devclass.
DATA lt_filter TYPE zif_abapgit_definitions=>ty_tadir_tt.