From b3996f2cfac13ac25e8f237b38b74621ac9b3791 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=BCnter?= Date: Wed, 28 Nov 2018 09:22:14 +0100 Subject: [PATCH] Fix abapGit repo existence check Before this commit is applied forked abapGit repos aren't recognized --- src/ui/zcl_abapgit_services_abapgit.clas.abap | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/ui/zcl_abapgit_services_abapgit.clas.abap b/src/ui/zcl_abapgit_services_abapgit.clas.abap index dda936919..a34e37812 100644 --- a/src/ui/zcl_abapgit_services_abapgit.clas.abap +++ b/src/ui/zcl_abapgit_services_abapgit.clas.abap @@ -9,6 +9,7 @@ CLASS zcl_abapgit_services_abapgit DEFINITION CONSTANTS c_abapgit_wikipage TYPE string VALUE 'http://docs.abapgit.org' ##NO_TEXT. CONSTANTS c_package_abapgit TYPE devclass VALUE '$ABAPGIT' ##NO_TEXT. CONSTANTS c_abapgit_url TYPE string VALUE 'https://github.com/larshp/abapGit.git' ##NO_TEXT. + CONSTANTS c_abapgit_tcode TYPE tcode VALUE `ZABAPGIT` ##NO_TEXT. CLASS-METHODS open_abapgit_homepage RAISING @@ -102,13 +103,11 @@ CLASS zcl_abapgit_services_abapgit IMPLEMENTATION. METHOD is_installed. - TRY. - rv_installed = zcl_abapgit_repo_srv=>get_instance( )->is_repo_installed( c_abapgit_url ). - " TODO, alternative checks for presence in the system - CATCH zcx_abapgit_exception. - " cannot be installed anyway in this case, e.g. no connection - rv_installed = abap_false. - ENDTRY. + DATA: ls_item TYPE zif_abapgit_definitions=>ty_item. + + ls_item-obj_type = 'TRAN'. + ls_item-obj_name = c_abapgit_tcode. + rv_installed = zcl_abapgit_objects=>exists( ls_item ). ENDMETHOD.