SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Refactoring (#3134)

Browse Source 
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
This commit is contained in:
Lars Hvam 2019-12-28 12:11:32 +01:00 committed by GitHub
parent 819a26527c
commit b42f3bc485
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
45 changed files with 135 additions and 272 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

105
abaplint.json
View File

@ -58,8 +58,9 @@
"rules": {
"allowed_object_naming": true,
"check_comments": false,
"fully_type_constants": false,
"keep_single_parameter_on_one_line": false,
"fully_type_constants": true,
"keep_single_parameter_on_one_line": true,
"prefer_returning_to_exporting": false,
"selection_screen_naming": true,
"sicf_consistency": true,
"sql_escape_host_variables": true,
@ -75,15 +76,10 @@
"enabled": true,
"exclude": ["zcl_abapgit_utils.clas.testclasses.abap"]
},
"abapdoc": {
"enabled": false,
"checkLocal": false
},
"abapdoc": false,
"check_ddic": true,
"check_include": true,
"form_no_dash": {
"enabled": false
},
"form_no_dash": false,
"allowed_object_types": {
"allowed": [
"PROG",
@ -95,7 +91,7 @@
"W3MI"
]
},
"ambiguous_statement": {},
"ambiguous_statement": true,
"avoid_use": {
"define": false,
"endselect": true,
@ -105,33 +101,27 @@
"systemCall": true,
"statics": true
},
"begin_end_names": {},
"breakpoint": {},
"check_transformation_exists": {},
"check_syntax": {},
"begin_end_names": true,
"breakpoint": true,
"check_transformation_exists": true,
"check_syntax": true,
"class_attribute_names": {
"ignoreExceptions": true,
"statics": "^G._.*$",
"instance": "^M._.*$"
},
"cloud_types": {},
"colon_missing_space": {},
"commented_code": {},
"constructor_visibility_public": {},
"contains_tab": {},
"definitions_top": {},
"description_empty": {},
"double_space": {
"enabled": false,
"keywords": true,
"startParen": true,
"afterColon": true,
"endParen": true
},
"cloud_types": true,
"colon_missing_space": true,
"commented_code": true,
"constructor_visibility_public": true,
"contains_tab": true,
"definitions_top": true,
"description_empty": true,
"double_space": false,
"empty_line_in_statement": {
"allowChained": true
},
"empty_statement": {},
"empty_statement": true,
"empty_structure": {
"loop": true,
"if": false,
@ -141,22 +131,17 @@
"do": true,
"at": true
},
"exit_or_check": {},
"exporting": {},
"form_tables_obsolete": {
"enabled": false
},
"exit_or_check": true,
"exporting": true,
"form_tables_obsolete": false,
"functional_writing": {
"ignoreExceptions": true
},
"global_class": {},
"identical_form_names": {},
"if_in_if": {},
"implement_methods": {},
"in_statement_indentation": {
"enabled": false,
"ignoreExceptions": true
},
"global_class": true,
"identical_form_names": true,
"if_in_if": true,
"implement_methods": true,
"in_statement_indentation": false,
"indentation": {
"ignoreExceptions": true,
"alignTryCatch": false,
@ -164,7 +149,7 @@
"ignoreGlobalClassDefinition": false,
"ignoreGlobalInterface": false
},
"inline_data_old_versions": {},
"inline_data_old_versions": true,
"keyword_case": {
"style": "upper",
"ignoreExceptions": true,
@ -184,17 +169,15 @@
"local": "^LCL_.*$",
"test": "^LTCL_.*$"
},
"local_testclass_location": {},
"local_testclass_location": true,
"local_variable_names": {
"expectedData": "^L._.*$",
"expectedConstant": "^LC_.*$",
"expectedFS": "^<L._.*>$"
},
"main_file_contents": {},
"max_one_statement": {},
"message_exists": {
"enabled": false
},
"main_file_contents": true,
"max_one_statement": true,
"message_exists": false,
"method_length": {
"statements": 100,
"ignoreTestClasses": false,
@ -210,8 +193,8 @@
"P_TASK"
]
},
"mix_returning": {},
"msag_consistency": {},
"mix_returning": true,
"msag_consistency": true,
"nesting": {
"depth": 5
},
@ -271,20 +254,18 @@
"sy"
]
},
"space_before_colon": {},
"space_before_colon": true,
"space_before_dot": {
"ignoreGlobalDefinition": true,
"ignoreExceptions": true
},
"start_at_tab": {},
"superclass_final": {},
"tabl_enhancement_category": {},
"type_form_parameters": {
"enabled": false
},
"unreachable_code": {},
"use_new": {},
"when_others_last": {},
"whitespace_end": {}
"start_at_tab": true,
"superclass_final": true,
"tabl_enhancement_category": true,
"type_form_parameters": false,
"unreachable_code": true,
"use_new": true,
"when_others_last": true,
"whitespace_end": true
}
}

8
src/background/zcl_abapgit_background_push_au.clas.abap
View File

@ -156,9 +156,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_AU IMPLEMENTATION.
WHERE filename = <ls_local>-file-filename
AND path <> <ls_local>-file-path
AND filename <> 'package.devc.xml'.
mi_log->add_info( |rm: {
<ls_remote>-path } {
<ls_remote>-filename }| ).
mi_log->add_info( |rm: { <ls_remote>-path } { <ls_remote>-filename }| ).
* rm old file when object has moved
lo_stage->rm(
@ -198,9 +196,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_AU IMPLEMENTATION.
LOOP AT is_files-remote ASSIGNING <ls_remote>.
mi_log->add_info( |removed: {
<ls_remote>-path } {
<ls_remote>-filename }| ).
mi_log->add_info( |removed: { <ls_remote>-path } { <ls_remote>-filename }| ).
lo_stage->rm( iv_path = <ls_remote>-path
iv_filename = <ls_remote>-filename ).

8
src/background/zcl_abapgit_background_push_fi.clas.abap
View File

@ -80,9 +80,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_FI IMPLEMENTATION.
CREATE OBJECT lo_stage.
LOOP AT ls_files-local ASSIGNING <ls_local>.
mi_log->add_info( |stage: {
<ls_local>-file-path } {
<ls_local>-file-filename }| ).
mi_log->add_info( |stage: { <ls_local>-file-path } { <ls_local>-file-filename }| ).
lo_stage->add( iv_path = <ls_local>-file-path
iv_filename = <ls_local>-file-filename
iv_data = <ls_local>-file-data ).
@ -90,9 +88,7 @@ CLASS ZCL_ABAPGIT_BACKGROUND_PUSH_FI IMPLEMENTATION.
LOOP AT ls_files-remote ASSIGNING <ls_remote>.
mi_log->add_info( |removed: {
<ls_remote>-path } {
<ls_remote>-filename }| ).
mi_log->add_info( |removed: { <ls_remote>-path } { <ls_remote>-filename }| ).
lo_stage->rm( iv_path = <ls_remote>-path
iv_filename = <ls_remote>-filename ).

3
src/git/zcl_abapgit_git_transport.clas.abap
View File

@ -311,8 +311,7 @@ CLASS ZCL_ABAPGIT_GIT_TRANSPORT IMPLEMENTATION.
&& '0000'
&& '0009done' && zif_abapgit_definitions=>c_newline.
lv_xstring = lo_client->send_receive_close(
zcl_abapgit_convert=>string_to_xstring_utf8( lv_buffer ) ).
lv_xstring = lo_client->send_receive_close( zcl_abapgit_convert=>string_to_xstring_utf8( lv_buffer ) ).
parse( IMPORTING ev_pack = lv_pack
CHANGING cv_data = lv_xstring ).

4
src/http/zcl_abapgit_http.clas.abap
View File

@ -115,9 +115,7 @@ CLASS ZCL_ABAPGIT_HTTP IMPLEMENTATION.
DATA: lv_code TYPE i.
ii_client->response->get_status(
IMPORTING
code = lv_code ).
ii_client->response->get_status( IMPORTING code = lv_code ).
IF lv_code = 401.
rv_auth_requested = abap_true.
ENDIF.

4
src/http/zcl_abapgit_http_client.clas.abap
View File

@ -43,9 +43,7 @@ CLASS zcl_abapgit_http_client IMPLEMENTATION.
DATA: lv_code TYPE i,
lv_text TYPE string.
mi_client->response->get_status(
IMPORTING
code = lv_code ).
mi_client->response->get_status( IMPORTING code = lv_code ).
CASE lv_code.
WHEN 200.
RETURN.

11
src/objects/ecatt/zcl_abapgit_ecatt_helper.clas.abap
View File

@ -91,9 +91,7 @@ CLASS zcl_abapgit_ecatt_helper IMPLEMENTATION.
lo_xml->set_attributes( im_dom = ii_template_over_all ).
lo_xml->get_attributes(
IMPORTING
ex_xml = rv_xml_stream ).
lo_xml->get_attributes( IMPORTING ex_xml = rv_xml_stream ).
CATCH cx_ecatt_apl_xml.
RETURN.
@ -126,13 +124,10 @@ CLASS zcl_abapgit_ecatt_helper IMPLEMENTATION.
im_ignore_white_space = 'X'
im_uri = cl_apl_xml_const=>schema_uri ).
lo_xml->get_attributes(
IMPORTING
ex_dom = ri_template_over_all ).
lo_xml->get_attributes( IMPORTING ex_dom = ri_template_over_all ).
* MD: Workaround, because nodes starting with "XML" are not allowed
li_nc_xmlref_typ ?= ri_template_over_all->get_elements_by_tag_name_ns(
'XMLREF_TYP' ). "#EC NOTEXT
li_nc_xmlref_typ ?= ri_template_over_all->get_elements_by_tag_name_ns( 'XMLREF_TYP' ). "#EC NOTEXT
CALL METHOD li_nc_xmlref_typ->('GET_LENGTH') " downport
RECEIVING
rval = lv_count.

7
src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap
View File

@ -144,8 +144,7 @@ CLASS ZCL_ABAPGIT_ECATT_SCRIPT_DOWNL IMPLEMENTATION.
li_elem TYPE REF TO if_ixml_element.
li_vars = ii_element->find_from_name_ns( iv_tabname ).
li_filter = ii_element->create_filter_node_type(
if_ixml_node=>co_node_text ).
li_filter = ii_element->create_filter_node_type( if_ixml_node=>co_node_text ).
IF li_vars IS NOT INITIAL.
li_abapctrl = ii_element->get_elements_by_tag_name_ns( iv_node ).
@ -404,9 +403,7 @@ CLASS ZCL_ABAPGIT_ECATT_SCRIPT_DOWNL IMPLEMENTATION.
li_element TYPE REF TO if_ixml_element,
lv_rc TYPE sy-subrc.
ecatt_script->get_script_text(
CHANGING
scripttext = lt_text ).
ecatt_script->get_script_text( CHANGING scripttext = lt_text ).
mi_script_node = template_over_all->create_simple_element(
name = 'SCRIPT'

4
src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap
View File

@ -108,9 +108,7 @@ CLASS zcl_abapgit_ecatt_sp_upload IMPLEMENTATION.
<lv_i_akh> = <lv_d_akh>.
ENDIF.
super->upload(
CHANGING
ch_object = ch_object ).
super->upload( CHANGING ch_object = ch_object ).
upload_data_from_stream( ch_object-filename ).

4
src/objects/ecatt/zcl_abapgit_ecatt_val_obj_upl.clas.abap
View File

@ -235,9 +235,7 @@ CLASS zcl_abapgit_ecatt_val_obj_upl IMPLEMENTATION.
<lv_i_akh> = <lv_d_akh>.
ENDIF.
super->upload(
CHANGING
ch_object = ch_object ).
super->upload( CHANGING ch_object = ch_object ).
upload_data_from_stream( ch_object-filename ).
CATCH cx_ecatt_apl INTO lx_ex.

4
src/objects/zcl_abapgit_object_acid.clas.abap
View File

@ -96,9 +96,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ACID IMPLEMENTATION.
lo_aab = create_object( ).
lo_aab->get_state(
IMPORTING
ex_state = lv_state ).
lo_aab->get_state( IMPORTING ex_state = lv_state ).
rv_bool = boolc( lv_state = abap_true ).
ENDMETHOD.

15
src/objects/zcl_abapgit_object_avas.clas.abap
View File

@ -119,9 +119,7 @@ CLASS ZCL_ABAPGIT_OBJECT_AVAS IMPLEMENTATION.
lo_avas = instantiate( ).
lo_avas->if_pak_wb_object~get_last_changed(
IMPORTING
ex_changed_by = rv_user ).
lo_avas->if_pak_wb_object~get_last_changed( IMPORTING ex_changed_by = rv_user ).
IF rv_user IS INITIAL.
rv_user = c_user_unknown.
@ -138,8 +136,7 @@ CLASS ZCL_ABAPGIT_OBJECT_AVAS IMPLEMENTATION.
lo_avas = instantiate( ).
TRY.
lo_avas->if_cls_attr_value_assignment~lock_and_refresh(
im_allow_popups = abap_false ).
lo_avas->if_cls_attr_value_assignment~lock_and_refresh( im_allow_popups = abap_false ).
CATCH cx_pak_invalid_state
cx_pak_invalid_data
cx_pak_not_authorized
@ -242,13 +239,9 @@ CLASS ZCL_ABAPGIT_OBJECT_AVAS IMPLEMENTATION.
ls_avas-header-attribute = lo_avas->if_cls_attr_value_assignment~get_attribute( ).
ls_avas-header-object = lo_avas->if_cls_attr_value_assignment~get_object( ).
lo_avas->if_cls_attr_value_assignment~get_values(
IMPORTING
ex_values = ls_avas-values ).
lo_avas->if_cls_attr_value_assignment~get_values( IMPORTING ex_values = ls_avas-values ).
lo_avas->if_cls_attr_value_assignment~get_links(
IMPORTING
ex_links = ls_avas-links ).
lo_avas->if_cls_attr_value_assignment~get_links( IMPORTING ex_links = ls_avas-links ).
LOOP AT ls_avas-values ASSIGNING <ls_value>.
CLEAR: <ls_value>-set_by, <ls_value>-changed_on.

4
src/objects/zcl_abapgit_object_ddlx.clas.abap
View File

@ -305,9 +305,7 @@ CLASS ZCL_ABAPGIT_OBJECT_DDLX IMPLEMENTATION.
p_object_data = li_data_model ).
ENDIF.
li_data_model->get_data(
IMPORTING
p_data = <lg_data> ).
li_data_model->get_data( IMPORTING p_data = <lg_data> ).
clear_fields( CHANGING cs_data = <lg_data> ).

12
src/objects/zcl_abapgit_object_ecatt_super.clas.abap
View File

@ -243,9 +243,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ECATT_SUPER IMPLEMENTATION.
ls_object-d_overwrite = abap_true.
TRY.
lo_upload->upload(
CHANGING
ch_object = ls_object ).
lo_upload->upload( CHANGING ch_object = ls_object ).
CATCH cx_ecatt INTO lx_error.
lv_text = lx_error->get_text( ).
@ -365,13 +363,9 @@ CLASS ZCL_ABAPGIT_OBJECT_ECATT_SUPER IMPLEMENTATION.
li_document = cl_ixml_80_20=>parse_to_document( stream_xstring = lv_xml ).
clear_attributes(
CHANGING
ci_document = li_document ).
clear_attributes( CHANGING ci_document = li_document ).
clear_elements(
CHANGING
ci_document = li_document ).
clear_elements( CHANGING ci_document = li_document ).
lo_node = li_document->create_element( co_name-version ).
lo_node->append_child( li_document->get_root_element( ) ).

16
src/objects/zcl_abapgit_object_enho_clif.clas.abap
View File

@ -34,21 +34,13 @@ CLASS zcl_abapgit_object_enho_clif IMPLEMENTATION.
<ls_event_param> LIKE LINE OF <ls_event>-event_param.
io_clif->get_enhattributes(
IMPORTING
tab_attributes = lt_tab_attributes ).
io_clif->get_enhattributes( IMPORTING tab_attributes = lt_tab_attributes ).
io_clif->get_enhatypes(
IMPORTING
tab_types = lt_tab_types ).
io_clif->get_enhatypes( IMPORTING tab_types = lt_tab_types ).
io_clif->get_enh_new_methodes(
IMPORTING
tab_methodes = lt_tab_methods ).
io_clif->get_enh_new_methodes( IMPORTING tab_methodes = lt_tab_methods ).
io_clif->get_enhevents(
IMPORTING
tab_eventdata = lt_tab_eventdata ).
io_clif->get_enhevents( IMPORTING tab_eventdata = lt_tab_eventdata ).
LOOP AT lt_tab_attributes ASSIGNING <ls_attr>.
CLEAR: <ls_attr>-author,

4
src/objects/zcl_abapgit_object_enho_fugr.clas.abap
View File

@ -91,9 +91,7 @@ CLASS zcl_abapgit_object_enho_fugr IMPLEMENTATION.
lo_fugrdata ?= ii_enh_tool.
lo_fugrdata->get_fugr(
IMPORTING
fugr_name = lv_fugr_name ).
lo_fugrdata->get_fugr( IMPORTING fugr_name = lv_fugr_name ).
TRY.
lo_fugrdata->get_all_data_for_fugr(

3
src/objects/zcl_abapgit_object_iobj.clas.abap
View File

@ -57,8 +57,7 @@ CLASS zcl_abapgit_object_iobj IMPLEMENTATION.
lv_object_class TYPE string,
lv_transp_pkg TYPE abap_bool.
lv_transp_pkg = zcl_abapgit_factory=>get_sap_package( iv_package
)->are_changes_recorded_in_tr_req( ).
lv_transp_pkg = zcl_abapgit_factory=>get_sap_package( iv_package )->are_changes_recorded_in_tr_req( ).
APPEND ms_item-obj_name TO lt_iobjname.

3
src/objects/zcl_abapgit_object_pinf.clas.abap
View File

@ -345,8 +345,7 @@ CLASS ZCL_ABAPGIT_OBJECT_PINF IMPLEMENTATION.
li_interface = load( |{ ms_item-obj_name }| ).
li_interface->get_all_attributes(
IMPORTING es_package_interface_data = ls_pinf-attributes ).
li_interface->get_all_attributes( IMPORTING es_package_interface_data = ls_pinf-attributes ).
CLEAR: ls_pinf-attributes-pack_name,
ls_pinf-attributes-author,

4
src/objects/zcl_abapgit_object_smim.clas.abap
View File

@ -142,9 +142,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SMIM IMPLEMENTATION.
TRY.
get_url_for_io(
IMPORTING
ev_url = lv_url ).
get_url_for_io( IMPORTING ev_url = lv_url ).
CATCH zcx_abapgit_not_found.
RETURN.
ENDTRY.

4
src/objects/zcl_abapgit_object_srfc.clas.abap
View File

@ -176,9 +176,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SRFC IMPLEMENTATION.
CHANGING
p_object_data = li_object_data ).
li_object_data->get_data(
IMPORTING
p_data = <lg_srfc_data> ).
li_object_data->get_data( IMPORTING p_data = <lg_srfc_data> ).
CATCH cx_root INTO lx_error.
lv_text = lx_error->get_text( ).

6
src/objects/zcl_abapgit_object_ssfo.clas.abap
View File

@ -264,11 +264,9 @@ CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION.
lv_name = li_node->get_name( ).
CASE lv_name.
WHEN 'LASTDATE'.
li_node->set_value(
sy-datum(4) && '-' && sy-datum+4(2) && '-' && sy-datum+6(2) ).
li_node->set_value( sy-datum(4) && '-' && sy-datum+4(2) && '-' && sy-datum+6(2) ).
WHEN 'LASTTIME'.
li_node->set_value(
sy-uzeit(2) && ':' && sy-uzeit+2(2) && ':' && sy-uzeit+4(2) ).
li_node->set_value( sy-uzeit(2) && ':' && sy-uzeit+2(2) && ':' && sy-uzeit+4(2) ).
WHEN 'FIRSTUSER' OR 'LASTUSER'.
li_node->set_value( sy-uname && '' ).

3
src/objects/zcl_abapgit_object_tobj.clas.abap
View File

@ -256,8 +256,7 @@ CLASS ZCL_ABAPGIT_OBJECT_TOBJ IMPLEMENTATION.
OTHERS = 2.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Jump not possible. Subrc={ sy-subrc } |
&& |from TR_OBJECT_JUMP_TO_TOOL| ).
zcx_abapgit_exception=>raise( |Jump not possible. Subrc={ sy-subrc } from TR_OBJECT_JUMP_TO_TOOL| ).
ENDIF.
ENDMETHOD.

28
src/objects/zcl_abapgit_object_tran.clas.abap
View File

@ -12,22 +12,18 @@ CLASS zcl_abapgit_object_tran DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
WITH NON-UNIQUE DEFAULT KEY .
CONSTANTS:
c_oo_program(9) VALUE '\PROGRAM=' ##NO_TEXT.
CONSTANTS:
c_oo_class(7) VALUE '\CLASS=' ##NO_TEXT.
CONSTANTS:
c_oo_method(8) VALUE '\METHOD=' ##NO_TEXT.
CONSTANTS c_oo_tcode TYPE tcode VALUE 'OS_APPLICATION' ##NO_TEXT.
CONSTANTS:
c_oo_frclass(30) VALUE 'CLASS' ##NO_TEXT.
CONSTANTS:
c_oo_frmethod(30) VALUE 'METHOD' ##NO_TEXT.
CONSTANTS:
c_oo_frupdtask(30) VALUE 'UPDATE_MODE' ##NO_TEXT.
CONSTANTS c_oo_synchron TYPE c VALUE 'S' ##NO_TEXT.
CONSTANTS c_oo_asynchron TYPE c VALUE 'U' ##NO_TEXT.
CONSTANTS c_true TYPE c VALUE 'X' ##NO_TEXT.
CONSTANTS c_false TYPE c VALUE space ##NO_TEXT.
c_oo_program TYPE c LENGTH 9 VALUE '\PROGRAM=' ##NO_TEXT,
c_oo_class TYPE c LENGTH 7 VALUE '\CLASS=' ##NO_TEXT,
c_oo_method TYPE c LENGTH 8 VALUE '\METHOD=' ##NO_TEXT,
c_oo_tcode TYPE tcode VALUE 'OS_APPLICATION' ##NO_TEXT,
c_oo_frclass TYPE c LENGTH 30 VALUE 'CLASS' ##NO_TEXT,
c_oo_frmethod TYPE c LENGTH 30 VALUE 'METHOD' ##NO_TEXT,
c_oo_frupdtask TYPE c LENGTH 30 VALUE 'UPDATE_MODE' ##NO_TEXT,
c_oo_synchron TYPE c VALUE 'S' ##NO_TEXT,
c_oo_asynchron TYPE c VALUE 'U' ##NO_TEXT,
c_true TYPE c VALUE 'X' ##NO_TEXT,
c_false TYPE c VALUE space ##NO_TEXT.
DATA:
mt_bcdata TYPE STANDARD TABLE OF bdcdata .

4
src/objects/zcl_abapgit_object_view.clas.abap
View File

@ -197,9 +197,7 @@ CLASS ZCL_ABAPGIT_OBJECT_VIEW IMPLEMENTATION.
DATA: ls_dd25v TYPE dd25v.
read_view(
IMPORTING
es_dd25v = ls_dd25v ).
read_view( IMPORTING es_dd25v = ls_dd25v ).
CASE ls_dd25v-viewclass.
WHEN co_viewclass-view_variant.

4
src/objects/zcl_abapgit_object_w3super.clas.abap
View File

@ -379,9 +379,7 @@ CLASS ZCL_ABAPGIT_OBJECT_W3SUPER IMPLEMENTATION.
ls_bdcdata-dynbegin = 'X'.
APPEND ls_bdcdata TO lt_bdcdata.
change_bdc_jump_data(
CHANGING
ct_bdcdata = lt_bdcdata ).
change_bdc_jump_data( CHANGING ct_bdcdata = lt_bdcdata ).
CLEAR ls_bdcdata.
ls_bdcdata-fnam = 'BDC_OKCODE'.

4
src/objects/zcl_abapgit_object_wapa.clas.abap
View File

@ -199,9 +199,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WAPA IMPLEMENTATION.
IMPORTING
p_page = lo_page ).
lo_page->get_attrs(
IMPORTING
p_attrs = rs_page-attributes ).
lo_page->get_attrs( IMPORTING p_attrs = rs_page-attributes ).
IF rs_page-attributes-pagetype <> so2_controller.

6
src/objects/zcl_abapgit_object_webi.clas.abap
View File

@ -227,8 +227,7 @@ CLASS zcl_abapgit_object_webi IMPLEMENTATION.
li_elem->set_signed( <ls_elem>-signed ).
li_elem->set_abaptype( <ls_elem>-abaptype ).
IF li_elem->if_ws_md_vif_type~has_soap_extension_type(
sews_c_vif_version-all ) = abap_false.
IF li_elem->if_ws_md_vif_type~has_soap_extension_type( sews_c_vif_version-all ) = abap_false.
READ TABLE is_webi-pveptypesoapext ASSIGNING <ls_soap>
WITH KEY typename = <ls_elem>-typename.
IF sy-subrc = 0.
@ -271,8 +270,7 @@ CLASS zcl_abapgit_object_webi IMPLEMENTATION.
li_table->set_line_type( mi_vi->get_type( typename = <ls_table>-typeref
version = sews_c_vif_version-inactive ) ).
IF li_table->if_ws_md_vif_type~has_soap_extension_type(
sews_c_vif_version-all ) = abap_false.
IF li_table->if_ws_md_vif_type~has_soap_extension_type( sews_c_vif_version-all ) = abap_false.
READ TABLE is_webi-pveptypesoapext ASSIGNING <ls_soap>
WITH KEY typename = <ls_table>-typename.
IF sy-subrc = 0.

15
src/objects/zcl_abapgit_objects_generic.clas.abap
View File

@ -195,8 +195,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_GENERIC IMPLEMENTATION.
AND tobject = 'TABU'
ORDER BY PRIMARY KEY.
IF mt_object_table IS INITIAL.
zcx_abapgit_exception=>raise( |Obviously corrupted object-type {
is_item-obj_type }: No tables defined| ).
zcx_abapgit_exception=>raise( |Obviously corrupted object-type { is_item-obj_type }: No tables defined| ).
ENDIF.
* only unique tables
SORT mt_object_table BY tobj_name ASCENDING.
@ -297,8 +296,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_GENERIC IMPLEMENTATION.
INSERT (<ls_table>-tobj_name) FROM TABLE <lt_data>.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Error inserting data, {
<ls_table>-tobj_name }| ).
zcx_abapgit_exception=>raise( |Error inserting data, { <ls_table>-tobj_name }| ).
ENDIF.
ENDLOOP.
@ -669,11 +667,9 @@ CLASS ZCL_ABAPGIT_OBJECTS_GENERIC IMPLEMENTATION.
cg_data = <lt_data> ).
IF lines( <lt_data> ) = 0.
zcx_abapgit_exception=>raise( |Primary table { lv_primary
} not found in imported container | ).
zcx_abapgit_exception=>raise( |Primary table { lv_primary } not found in imported container| ).
ELSEIF lines( <lt_data> ) <> 1.
zcx_abapgit_exception=>raise( |Primary table { lv_primary
} contains more than one instance! | ).
zcx_abapgit_exception=>raise( |Primary table { lv_primary } contains more than one instance!| ).
ENDIF.
lv_where = get_where_clause( lv_primary ).
@ -681,8 +677,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_GENERIC IMPLEMENTATION.
* validate that max one local instance was affected by the import
SELECT COUNT(*) FROM (lv_primary) WHERE (lv_where).
IF sy-dbcnt > 1.
zcx_abapgit_exception=>raise( |More than one instance exists locally in primary table {
lv_primary }| ).
zcx_abapgit_exception=>raise( |More than one instance exists locally in primary table { lv_primary }| ).
ENDIF.
ENDMETHOD.

12
src/objects/zcl_abapgit_objects_saxx_super.clas.abap
View File

@ -90,9 +90,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_SAXX_SUPER IMPLEMENTATION.
zcx_abapgit_exception=>raise( |{ ms_item-obj_type } not supported| ).
ENDTRY.
mo_appl_obj_data->get_data(
IMPORTING
p_data = eg_data ).
mo_appl_obj_data->get_data( IMPORTING p_data = eg_data ).
ENDMETHOD.
@ -177,9 +175,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_SAXX_SUPER IMPLEMENTATION.
zcx_abapgit_exception=>raise( |{ ms_item-obj_name } not supported| ).
ENDTRY.
get_data(
IMPORTING
eg_data = <lg_data> ).
get_data( IMPORTING eg_data = <lg_data> ).
ASSIGN COMPONENT 'HEADER' OF STRUCTURE <lg_data> TO <lg_header>.
ASSERT sy-subrc = 0.
@ -370,9 +366,7 @@ CLASS ZCL_ABAPGIT_OBJECTS_SAXX_SUPER IMPLEMENTATION.
zcx_abapgit_exception=>raise( |{ ms_item-obj_type } not supported| ).
ENDTRY.
get_data(
IMPORTING
eg_data = <lg_data> ).
get_data( IMPORTING eg_data = <lg_data> ).
ASSIGN COMPONENT 'HEADER' OF STRUCTURE <lg_data> TO <lg_header>.
ASSERT sy-subrc = 0.

16
src/ui/core/zcl_abapgit_gui.clas.abap
View File

@ -5,14 +5,14 @@ CLASS zcl_abapgit_gui DEFINITION
PUBLIC SECTION.
CONSTANTS:
BEGIN OF c_event_state,
not_handled VALUE 0,
re_render VALUE 1,
new_page VALUE 2,
go_back VALUE 3,
no_more_act VALUE 4,
new_page_w_bookmark VALUE 5,
go_back_to_bookmark VALUE 6,
new_page_replacing VALUE 7,
not_handled TYPE c LENGTH 1 VALUE '0',
re_render TYPE c LENGTH 1 VALUE '1',
new_page TYPE c LENGTH 1 VALUE '2',
go_back TYPE c LENGTH 1 VALUE '3',
no_more_act TYPE c LENGTH 1 VALUE '4',
new_page_w_bookmark TYPE c LENGTH 1 VALUE '5',
go_back_to_bookmark TYPE c LENGTH 1 VALUE '6',
new_page_replacing TYPE c LENGTH 1 VALUE '7',
END OF c_event_state .
CONSTANTS:

11
src/ui/zcl_abapgit_gui_chunk_lib.clas.abap
View File

@ -277,9 +277,7 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
CREATE OBJECT ro_html.
ro_html->add( '<ul class="hotkeys">' ).
ro_html->add( |<li>|
&& |<span>{ iv_content }</span>|
&& |</li>| ).
ro_html->add( |<li>| && |<span>{ iv_content }</span>| && |</li>| ).
ro_html->add( '</ul>' ).
ro_html = render_infopanel(
@ -373,9 +371,7 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
ENDIF.
ix_error->get_source_position(
IMPORTING
program_name = lv_program_name ).
ix_error->get_source_position( IMPORTING program_name = lv_program_name ).
lv_title = normalize_program_name( lv_program_name ).
@ -732,8 +728,7 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
CREATE OBJECT ro_html.
ro_html->add( '<div class="dummydiv warning">' ).
ro_html->add( |{ zcl_abapgit_html=>icon( 'exclamation-triangle/yellow' ) }| &&
| { iv_text }| ).
ro_html->add( |{ zcl_abapgit_html=>icon( 'exclamation-triangle/yellow' ) }| && | { iv_text }| ).
ro_html->add( '</div>' ).
ENDMETHOD.

7
src/ui/zcl_abapgit_gui_page.clas.abap
View File

@ -328,8 +328,7 @@ CLASS zcl_abapgit_gui_page IMPLEMENTATION.
ro_html->add( '<!DOCTYPE html>' ). "#EC NOTEXT
ro_html->add( '<html>' ). "#EC NOTEXT
ro_html->add( '<head>' ). "#EC NOTEXT
ro_html->add( |<meta http-equiv="refresh" content="0; url={
ms_control-redirect_url }">| ). "#EC NOTEXT
ro_html->add( |<meta http-equiv="refresh" content="0; url={ ms_control-redirect_url }">| ). "#EC NOTEXT
ro_html->add( '</head>' ). "#EC NOTEXT
ro_html->add( '</html>' ). "#EC NOTEXT
@ -414,9 +413,7 @@ CLASS zcl_abapgit_gui_page IMPLEMENTATION.
iv_act = zif_abapgit_definitions=>c_action-abapgit_home )
}</td>| ). "#EC NOTEXT
ro_html->add( |<td><span class="page_title"> &#x25BA; {
ms_control-page_title
}</span></td>| ). "#EC NOTEXT
ro_html->add( |<td><span class="page_title"> &#x25BA; { ms_control-page_title }</span></td>| ). "#EC NOTEXT
IF ms_control-page_menu IS BOUND.
ro_html->add( '<td class="right">' ). "#EC NOTEXT

9
src/ui/zcl_abapgit_gui_page_bkg.clas.abap
View File

@ -178,13 +178,11 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BKG IMPLEMENTATION.
ro_html->add( '<table>' ).
ro_html->add( '<tr>' ).
ro_html->add( '<td>Username:</td>' ).
ro_html->add( '<td><input type="text" name="username" value="' &&
ls_per-username && '"></td>' ).
ro_html->add( '<td><input type="text" name="username" value="' && ls_per-username && '"></td>' ).
ro_html->add( '</tr>' ).
ro_html->add( '<tr>' ).
ro_html->add( '<td>Password:</td>' ).
ro_html->add( '<td><input type="text" name="password" value="' &&
ls_per-password && '"></td>' ).
ro_html->add( '<td><input type="text" name="password" value="' && ls_per-password && '"></td>' ).
ro_html->add( '</tr>' ).
ro_html->add( '</table>' ).
@ -230,8 +228,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BKG IMPLEMENTATION.
lv_checked = ' checked' ##NO_TEXT.
ENDIF.
ro_html->add( '<input type="radio" name="method" value=""' &&
lv_checked && '>Do nothing<br>' ) ##NO_TEXT.
ro_html->add( '<input type="radio" name="method" value=""' && lv_checked && '>Do nothing<br>' ) ##NO_TEXT.
LOOP AT lt_methods INTO ls_method.
CLEAR lv_checked.

6
src/ui/zcl_abapgit_gui_page_diff.clas.abap
View File

@ -769,11 +769,9 @@ CLASS zcl_abapgit_gui_page_diff IMPLEMENTATION.
ENDIF.
IF lv_adt_link IS NOT INITIAL.
ro_html->add(
|<span class="diff_name">{ lv_adt_link }</span>| ). "#EC NOTEXT
ro_html->add( |<span class="diff_name">{ lv_adt_link }</span>| ). "#EC NOTEXT
ELSE.
ro_html->add(
|<span class="diff_name">{ is_diff-path }{ is_diff-filename }</span>| ). "#EC NOTEXT
ro_html->add( |<span class="diff_name">{ is_diff-path }{ is_diff-filename }</span>| ). "#EC NOTEXT
ENDIF.
ro_html->add( zcl_abapgit_gui_chunk_lib=>render_item_state(

3
src/ui/zcl_abapgit_gui_page_repo_over.clas.abap
View File

@ -204,8 +204,7 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION.
DATA: lt_overview TYPE tty_overview.
lt_overview = map_repo_list_to_overview(
zcl_abapgit_persist_factory=>get_repo( )->list( ) ).
lt_overview = map_repo_list_to_overview( zcl_abapgit_persist_factory=>get_repo( )->list( ) ).
apply_order_by( CHANGING ct_overview = lt_overview ).

7
src/ui/zcl_abapgit_gui_page_tag.clas.abap
View File

@ -257,9 +257,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION.
CLEAR: lv_selected.
ENDIF.
ro_html->add( |<option value="{ <lv_type> }" |
&& |{ lv_selected }>|
&& |{ <lv_type> }</option>| ).
ro_html->add( |<option value="{ <lv_type> }" | && |{ lv_selected }>| && |{ <lv_type> }</option>| ).
ENDLOOP.
@ -301,8 +299,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TAG IMPLEMENTATION.
IF lv_body_size > lc_body_col_max.
lv_body_size = lc_body_col_max.
ENDIF.
ro_html->add( |<textarea id="c-body" name="body" rows="10" cols="| &&
|{ lv_body_size }"></textarea>| ).
ro_html->add( |<textarea id="c-body" name="body" rows="10" cols="| && |{ lv_body_size }"></textarea>| ).
ENDIF.

4
src/ui/zcl_abapgit_popups.clas.abap
View File

@ -864,9 +864,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
RAISE EXCEPTION TYPE zcx_abapgit_cancel.
ENDIF.
get_selected_rows(
IMPORTING
et_list = et_list ).
get_selected_rows( IMPORTING et_list = et_list ).
CLEAR: mo_select_list_popup,
mr_table,

4
src/ui/zcl_abapgit_services_abapgit.clas.abap
View File

@ -171,9 +171,7 @@ CLASS zcl_abapgit_services_abapgit IMPLEMENTATION.
TO <lv_parameters>.
ASSERT sy-subrc = 0.
lt_fields = cl_http_utility=>string_to_fields(
cl_http_utility=>unescape_url(
<lv_parameters> ) ).
lt_fields = cl_http_utility=>string_to_fields( cl_http_utility=>unescape_url( <lv_parameters> ) ).
READ TABLE lt_fields ASSIGNING <ls_field>
WITH KEY name = 'p_package_name'.

9
src/utils/zcl_abapgit_utils.clas.testclasses.abap
View File

@ -13,8 +13,7 @@ CLASS ltcl_utils_test IMPLEMENTATION.
METHOD extract_author_data.
TRY.
zcl_abapgit_utils=>extract_author_data(
'Volker Jägle äÖüß <github@beimir.net> 1573216988 +0000' ).
zcl_abapgit_utils=>extract_author_data( 'Volker Jägle äÖüß <github@beimir.net> 1573216988 +0000' ).
CATCH zcx_abapgit_exception.
cl_abap_unit_assert=>fail( |Language-related special characters in author name are allowed.| ).
ENDTRY.
@ -48,15 +47,13 @@ CLASS ltcl_utils_test IMPLEMENTATION.
ENDTRY.
TRY.
zcl_abapgit_utils=>extract_author_data(
'pull[bot] 1573216988 +0000' ).
zcl_abapgit_utils=>extract_author_data( 'pull[bot] 1573216988 +0000' ).
cl_abap_unit_assert=>fail( |Value shouldn't be valid cause no email was supplied.| ).
CATCH zcx_abapgit_exception.
ENDTRY.
TRY.
zcl_abapgit_utils=>extract_author_data(
'pull[bot] <39814207+pull[bot]@users.noreply.github.com> +0000' ).
zcl_abapgit_utils=>extract_author_data( 'pull[bot] <39814207+pull[bot]@users.noreply.github.com> +0000' ).
cl_abap_unit_assert=>fail( |Value shouldn't be valid cause no time was supplied.| ).
CATCH zcx_abapgit_exception.
ENDTRY.

4
src/zcl_abapgit_code_inspector.clas.abap
View File

@ -230,9 +230,7 @@ CLASS ZCL_ABAPGIT_CODE_INSPECTOR IMPLEMENTATION.
zcx_abapgit_exception=>raise( |Code inspector run failed. Subrc = { sy-subrc }| ).
ENDIF.
io_inspection->plain_list(
IMPORTING
p_list = rt_list ).
io_inspection->plain_list( IMPORTING p_list = rt_list ).
ENDMETHOD.

4
src/zcl_abapgit_dependencies.clas.testclasses.abap
View File

@ -174,9 +174,7 @@ CLASS ltcl_resolve_packages IMPLEMENTATION.
zcl_abapgit_injector=>set_sap_package( iv_package = 'Z_MAIN'
ii_sap_package = lo_mock_sap_package ).
zcl_abapgit_dependencies=>resolve_packages(
CHANGING
ct_tadir = mt_tadir ).
zcl_abapgit_dependencies=>resolve_packages( CHANGING ct_tadir = mt_tadir ).
ENDMETHOD.

4
src/zcl_abapgit_message_helper.clas.abap
View File

@ -229,9 +229,7 @@ CLASS ZCL_ABAPGIT_MESSAGE_HELPER IMPLEMENTATION.
CONTINUE.
ENDIF.
replace_section_head_with_text(
CHANGING
cs_itf = <ls_itf_section> ).
replace_section_head_with_text( CHANGING cs_itf = <ls_itf_section> ).
ENDLOOP.

3
src/zcl_abapgit_repo.clas.abap
View File

@ -341,8 +341,7 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
rs_checks = zcl_abapgit_objects=>deserialize_checks( me ).
lt_requirements = get_dot_abapgit( )->get_data( )-requirements.
rs_checks-requirements-met = zcl_abapgit_requirement_helper=>is_requirements_met(
lt_requirements ).
rs_checks-requirements-met = zcl_abapgit_requirement_helper=>is_requirements_met( lt_requirements ).
ENDMETHOD.

3
src/zcl_abapgit_transport_objects.clas.testclasses.abap
View File

@ -181,8 +181,7 @@ CLASS ltcl_transport_objects IMPLEMENTATION.
iv_filename = 'CL_FOO.abap'
iv_path = '/path'
iv_data = 'data' ).
then_it_should_raise_exception(
iv_with_text = 'Object CL_FOO not found in the local repository files' ).
then_it_should_raise_exception( iv_with_text = 'Object CL_FOO not found in the local repository files' ).
ENDMETHOD.
METHOD cant_be_added_with_del_flag.

4
src/zcl_abapgit_zip.clas.abap
View File

@ -163,9 +163,7 @@ CLASS ZCL_ABAPGIT_ZIP IMPLEMENTATION.
gv_prev = lv_folder.
cl_gui_frontend_services=>get_file_separator(
CHANGING
file_separator = lv_sep ).
cl_gui_frontend_services=>get_file_separator( CHANGING file_separator = lv_sep ).
LOOP AT ls_files_item-files ASSIGNING <ls_file>.
CONCATENATE lv_folder lv_sep <ls_file>-filename INTO lv_fullpath.