diff --git a/abaplint.json b/abaplint.json index 6771f66fe..343b061ed 100644 --- a/abaplint.json +++ b/abaplint.json @@ -446,6 +446,7 @@ "unnecessary_pragma": { "allowNoTextGlobal": true }, + "slow_parameter_passing": true, "double_space": true, "whitespace_end": true }, @@ -453,7 +454,6 @@ "select_add_order_by": { "skipForAllEntries": true }, - "slow_parameter_passing": true, "select_single_full_key": true } } diff --git a/src/background/zif_abapgit_background.intf.abap b/src/background/zif_abapgit_background.intf.abap index 5f1ea86b2..620ca0fbf 100644 --- a/src/background/zif_abapgit_background.intf.abap +++ b/src/background/zif_abapgit_background.intf.abap @@ -15,7 +15,7 @@ INTERFACE zif_abapgit_background VALUE(rv_description) TYPE string . CLASS-METHODS get_settings CHANGING - VALUE(ct_settings) TYPE ty_settings_tt . + ct_settings TYPE ty_settings_tt . METHODS run IMPORTING !io_repo TYPE REF TO zcl_abapgit_repo_online diff --git a/src/objects/zcl_abapgit_object_pinf.clas.locals_def.abap b/src/objects/zcl_abapgit_object_pinf.clas.locals_def.abap index 6c9cff336..75b802c7f 100644 --- a/src/objects/zcl_abapgit_object_pinf.clas.locals_def.abap +++ b/src/objects/zcl_abapgit_object_pinf.clas.locals_def.abap @@ -10,7 +10,7 @@ INTERFACE lif_package_interface_facade. set_elements_changeable IMPORTING - VALUE(iv_changeable) TYPE abap_bool + iv_changeable TYPE abap_bool RAISING zcx_abapgit_exception, @@ -26,7 +26,7 @@ INTERFACE lif_package_interface_facade. set_changeable IMPORTING - VALUE(iv_changeable) TYPE abap_bool + iv_changeable TYPE abap_bool RAISING zcx_abapgit_exception, diff --git a/src/objects/zcl_abapgit_object_ueno.clas.abap b/src/objects/zcl_abapgit_object_ueno.clas.abap index b9fd202ff..6e16b7a0b 100644 --- a/src/objects/zcl_abapgit_object_ueno.clas.abap +++ b/src/objects/zcl_abapgit_object_ueno.clas.abap @@ -34,7 +34,7 @@ CLASS zcl_abapgit_object_ueno DEFINITION METHODS build_text_name - IMPORTING VALUE(iv_id) TYPE tdid + IMPORTING iv_id TYPE tdid RETURNING VALUE(rv_result) TYPE doku_obj. METHODS is_name_permitted @@ -85,7 +85,7 @@ CLASS zcl_abapgit_object_ueno DEFINITION zcx_abapgit_exception. METHODS serialize_docu_xxxx - IMPORTING VALUE(iv_id) TYPE tdid + IMPORTING iv_id TYPE tdid RETURNING VALUE(rt_result) TYPE ty_docu_lines. METHODS serialize_docu_usp diff --git a/src/objects/zcl_abapgit_objects.clas.testclasses.abap b/src/objects/zcl_abapgit_objects.clas.testclasses.abap index 39c8fabf2..364dcdb41 100644 --- a/src/objects/zcl_abapgit_objects.clas.testclasses.abap +++ b/src/objects/zcl_abapgit_objects.clas.testclasses.abap @@ -66,7 +66,7 @@ CLASS ltcl_serialize DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT F METHODS: check - IMPORTING VALUE(is_item) TYPE zif_abapgit_definitions=>ty_item + IMPORTING is_item TYPE zif_abapgit_definitions=>ty_item RAISING zcx_abapgit_exception, serialize_tabl FOR TESTING RAISING zcx_abapgit_exception, serialize_shlp FOR TESTING RAISING zcx_abapgit_exception, diff --git a/src/repo/zcl_abapgit_dot_abapgit.clas.abap b/src/repo/zcl_abapgit_dot_abapgit.clas.abap index 89ed5d0df..18e198aac 100644 --- a/src/repo/zcl_abapgit_dot_abapgit.clas.abap +++ b/src/repo/zcl_abapgit_dot_abapgit.clas.abap @@ -66,7 +66,7 @@ CLASS zcl_abapgit_dot_abapgit DEFINITION zcx_abapgit_exception . METHODS set_i18n_languages IMPORTING - VALUE(it_languages) TYPE zif_abapgit_definitions=>ty_languages + it_languages TYPE zif_abapgit_definitions=>ty_languages RAISING zcx_abapgit_exception . METHODS get_signature diff --git a/src/ui/pages/zcl_abapgit_gui_page_merge.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_merge.clas.abap index a7d5c797c..ad85bb728 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_merge.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_merge.clas.abap @@ -37,9 +37,9 @@ CLASS zcl_abapgit_gui_page_merge DEFINITION !is_result TYPE zif_abapgit_git_definitions=>ty_expanded . METHODS build_menu IMPORTING - VALUE(iv_with_conflict) TYPE abap_bool OPTIONAL + !iv_with_conflict TYPE abap_bool OPTIONAL RETURNING - VALUE(ro_menu) TYPE REF TO zcl_abapgit_html_toolbar . + VALUE(ro_menu) TYPE REF TO zcl_abapgit_html_toolbar . ENDCLASS. diff --git a/src/zcx_abapgit_exception.clas.abap b/src/zcx_abapgit_exception.clas.abap index 2bfc24ef6..17d2a39db 100644 --- a/src/zcx_abapgit_exception.clas.abap +++ b/src/zcx_abapgit_exception.clas.abap @@ -63,15 +63,15 @@ CLASS zcx_abapgit_exception DEFINITION "! @raising zcx_abapgit_exception | Exception CLASS-METHODS raise_t100 IMPORTING - VALUE(iv_msgid) TYPE symsgid DEFAULT sy-msgid - VALUE(iv_msgno) TYPE symsgno DEFAULT sy-msgno - VALUE(iv_msgv1) TYPE symsgv DEFAULT sy-msgv1 - VALUE(iv_msgv2) TYPE symsgv DEFAULT sy-msgv2 - VALUE(iv_msgv3) TYPE symsgv DEFAULT sy-msgv3 - VALUE(iv_msgv4) TYPE symsgv DEFAULT sy-msgv4 - !ii_log TYPE REF TO zif_abapgit_log OPTIONAL - !ix_previous TYPE REF TO cx_root OPTIONAL - !iv_longtext TYPE csequence OPTIONAL + !iv_msgid TYPE symsgid DEFAULT sy-msgid + !iv_msgno TYPE symsgno DEFAULT sy-msgno + !iv_msgv1 TYPE symsgv DEFAULT sy-msgv1 + !iv_msgv2 TYPE symsgv DEFAULT sy-msgv2 + !iv_msgv3 TYPE symsgv DEFAULT sy-msgv3 + !iv_msgv4 TYPE symsgv DEFAULT sy-msgv4 + !ii_log TYPE REF TO zif_abapgit_log OPTIONAL + !ix_previous TYPE REF TO cx_root OPTIONAL + !iv_longtext TYPE csequence OPTIONAL RAISING zcx_abapgit_exception . "! Raise with text from previous exception