From b5d40ca2a30197681f186c5c9182b7f1d35f82ca Mon Sep 17 00:00:00 2001
From: mariusraht2 <45243391+mariusraht2@users.noreply.github.com>
Date: Thu, 28 May 2020 07:23:05 +0200
Subject: [PATCH] Build commit popup (#3400)

* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Added new method checkout_commit_build_popup

* abapLint

* Use hash to identify selected popup row

* Moved definitions

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
---
 src/ui/zcl_abapgit_services_git.clas.abap | 70 ++++++++++++++++++++++-
 1 file changed, 69 insertions(+), 1 deletion(-)

diff --git a/src/ui/zcl_abapgit_services_git.clas.abap b/src/ui/zcl_abapgit_services_git.clas.abap
index 5738cf1b3..0b83ebd8e 100644
--- a/src/ui/zcl_abapgit_services_git.clas.abap
+++ b/src/ui/zcl_abapgit_services_git.clas.abap
@@ -54,6 +54,12 @@ CLASS zcl_abapgit_services_git DEFINITION
       RAISING
         zcx_abapgit_exception.
   PROTECTED SECTION.
+    TYPES: BEGIN OF ty_commit_value_tab,
+             sha1     TYPE zif_abapgit_definitions=>ty_sha1,
+             message  TYPE c LENGTH 50,
+             datetime TYPE c LENGTH 20,
+           END OF ty_commit_value_tab.
+    TYPES: ty_commit_value_tab_tt TYPE STANDARD TABLE OF ty_commit_value_tab WITH DEFAULT KEY .
 
     CLASS-METHODS get_unnecessary_local_objs
       IMPORTING
@@ -63,7 +69,15 @@ CLASS zcl_abapgit_services_git DEFINITION
       RAISING
         zcx_abapgit_exception .
   PRIVATE SECTION.
-
+    CLASS-METHODS checkout_commit_build_popup
+      IMPORTING
+        !it_commits         TYPE zif_abapgit_definitions=>ty_commit_tt
+      EXPORTING
+        !es_selected_commit TYPE zif_abapgit_definitions=>ty_commit
+      CHANGING
+        !ct_value_tab       TYPE ty_commit_value_tab_tt
+      RAISING
+        zcx_abapgit_exception .
 
 ENDCLASS.
 
@@ -72,6 +86,60 @@ ENDCLASS.
 CLASS zcl_abapgit_services_git IMPLEMENTATION.
 
 
+  METHOD checkout_commit_build_popup.
+
+    DATA: lt_columns         TYPE zif_abapgit_definitions=>ty_alv_column_tt,
+          li_popups          TYPE REF TO zif_abapgit_popups,
+          lt_selected_values TYPE ty_commit_value_tab_tt.
+
+    FIELD-SYMBOLS: <ls_value_tab> TYPE ty_commit_value_tab,
+                   <ls_column>    TYPE zif_abapgit_definitions=>ty_alv_column.
+
+    CLEAR: es_selected_commit.
+
+    APPEND INITIAL LINE TO lt_columns ASSIGNING <ls_column>.
+    <ls_column>-name   = 'SHA1'.
+    <ls_column>-text   = 'Hash'.
+    <ls_column>-length = 7.
+    APPEND INITIAL LINE TO lt_columns ASSIGNING <ls_column>.
+    <ls_column>-name = 'MESSAGE'.
+    <ls_column>-text = 'Message'.
+    APPEND INITIAL LINE TO lt_columns ASSIGNING <ls_column>.
+    <ls_column>-name = 'DATETIME'.
+    <ls_column>-text = 'Datetime'.
+
+    li_popups = zcl_abapgit_ui_factory=>get_popups( ).
+    li_popups->popup_to_select_from_list(
+      EXPORTING
+        it_list               = ct_value_tab
+        iv_title              = |Checkout Commit|
+        iv_end_column         = 83
+        iv_striped_pattern    = abap_true
+        iv_optimize_col_width = abap_false
+        iv_selection_mode     = if_salv_c_selection_mode=>single
+        it_columns_to_display = lt_columns
+      IMPORTING
+        et_list              = lt_selected_values ).
+
+    IF lt_selected_values IS INITIAL.
+      RAISE EXCEPTION TYPE zcx_abapgit_cancel.
+    ENDIF.
+
+    READ TABLE lt_selected_values
+      ASSIGNING <ls_value_tab>
+      INDEX 1.
+
+    IF <ls_value_tab> IS NOT ASSIGNED.
+      zcx_abapgit_exception=>raise( |Though result set of popup wasn't empty selected value couldn't retrieved.| ).
+    ENDIF.
+
+    READ TABLE it_commits
+      INTO es_selected_commit
+      WITH KEY sha1 = <ls_value_tab>-sha1.
+
+  ENDMETHOD.
+
+
   METHOD commit.
 
     DATA: ls_comment TYPE zif_abapgit_definitions=>ty_comment,