SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Improve error information - follow up Part 2 (#2814)

Browse Source 
- Cleanup JS
- Delete superflous functions and methods
This commit is contained in:
Christian Günter 2019-08-03 13:24:03 +02:00 committed by Lars Hvam
parent 5cd2044745
commit b994382f78
2 changed files with 0 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/ui/zabapgit_js_common.w3mi.data.js
View File

@ -22,7 +22,6 @@
/* exported onDirectionChange */
/* exported onOrderByChange */
/* exported onTagTypeChange */
/* exported errorMessagePanelRegisterClick */
/* exported getIndocStyleSheet */
/**********************************************************
@ -1352,22 +1351,3 @@ function GitGraphScroller() { // eslint-disable-line no-unused-vars
var gitGraphscrollWrapperEl = document.querySelector(".gitGraph-scrollWrapper");
gitGraphWrapperEl.scrollLeft = gitGraphscrollWrapperEl.scrollLeft;
}
// Click on error message panel toggles longtext
function errorMessagePanelRegisterClick(){
var elMessage = document.getElementById("message");
if (elMessage){
elMessage.addEventListener("click", function(oEvent){
toggleMessageDetail(oEvent);
});
}
}
function toggleMessageDetail(oEvent){
if (oEvent && ( oEvent.target.id === "a_goto_source"
|| oEvent.target.id === "a_callstack"
|| oEvent.target.id === "a_goto_message") ) {
return;
}
toggleDisplay("message-detail");
}

10
src/ui/zcl_abapgit_gui_page.clas.abap
View File

@ -95,10 +95,6 @@ CLASS zcl_abapgit_gui_page DEFINITION PUBLIC ABSTRACT CREATE PUBLIC.
RAISING
zcx_abapgit_exception.
METHODS reg_error_message_panel_click
IMPORTING
io_html TYPE REF TO zcl_abapgit_html.
ENDCLASS.
@ -315,11 +311,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE IMPLEMENTATION.
ENDMETHOD.
METHOD reg_error_message_panel_click.
io_html->add( |errorMessagePanelRegisterClick();| ).
ENDMETHOD.
METHOD render_error_message_box.
" You should remember that the we have to instantiate ro_html even
@ -362,7 +353,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE IMPLEMENTATION.
link_hints( ro_html ).
insert_hotkeys_to_page( ro_html ).
reg_error_message_panel_click( ro_html ).
ENDMETHOD.