From baef4483e224edff6c2743a7c3da940c5f39d579 Mon Sep 17 00:00:00 2001
From: Marc Bernard <marc@marcbernardtools.com>
Date: Sun, 30 Mar 2025 15:23:15 +0000
Subject: [PATCH] Refactor repo type in overview

Replaces "type type string" with "offline type abap_bool"
---
 src/ui/pages/zcl_abapgit_gui_page_repo_over.clas.abap | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/ui/pages/zcl_abapgit_gui_page_repo_over.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_repo_over.clas.abap
index 6b79e09d3..9413cc38b 100644
--- a/src/ui/pages/zcl_abapgit_gui_page_repo_over.clas.abap
+++ b/src/ui/pages/zcl_abapgit_gui_page_repo_over.clas.abap
@@ -32,8 +32,7 @@ CLASS zcl_abapgit_gui_page_repo_over DEFINITION
     TYPES:
       BEGIN OF ty_overview,
         favorite            TYPE string,
-        "! True for offline, false for online repo
-        type                TYPE string,
+        offline             TYPE abap_bool,
         key                 TYPE zif_abapgit_persistence=>ty_value,
         name                TYPE string,
         labels              TYPE string_table,
@@ -384,7 +383,7 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION.
 
       ls_overview-favorite        = zcl_abapgit_persistence_user=>get_instance(
         )->is_favorite_repo( <ls_repo>->ms_data-key ).
-      ls_overview-type            = <ls_repo>->ms_data-offline.
+      ls_overview-offline         = <ls_repo>->ms_data-offline.
       ls_overview-key             = <ls_repo>->ms_data-key.
       ls_overview-name            = <ls_repo>->get_name( ).
       ls_overview-labels          = zcl_abapgit_repo_labels=>split( <ls_repo>->ms_data-local_settings-labels ).
@@ -712,7 +711,7 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION.
       lv_lock           TYPE string,
       lv_flow           TYPE string.
 
-    lv_is_online_repo = boolc( is_repo-type = abap_false ).
+    lv_is_online_repo = boolc( is_repo-offline = abap_false ).
 
     " Start of row
     IF is_repo-favorite = abap_true.
@@ -721,7 +720,7 @@ CLASS zcl_abapgit_gui_page_repo_over IMPLEMENTATION.
       lv_fav_tr_class = ''.
     ENDIF.
 
-    ii_html->add( |<tr{ lv_fav_tr_class } data-key="{ is_repo-key }" data-offline="{ is_repo-type }">| ).
+    ii_html->add( |<tr{ lv_fav_tr_class } data-key="{ is_repo-key }" data-offline="{ is_repo-offline }">| ).
 
     " Favorite
     lv_favorite_icon = ii_html->icon(