diff --git a/src/ui/zcl_abapgit_gui_page_explore.clas.abap b/src/ui/zcl_abapgit_gui_page_explore.clas.abap deleted file mode 100644 index c33802bb4..000000000 --- a/src/ui/zcl_abapgit_gui_page_explore.clas.abap +++ /dev/null @@ -1,34 +0,0 @@ -CLASS zcl_abapgit_gui_page_explore DEFINITION - PUBLIC - FINAL - CREATE PUBLIC INHERITING FROM zcl_abapgit_gui_page. - - PUBLIC SECTION. - - CONSTANTS c_explore_url TYPE string - VALUE 'https://dotabap.github.io/explore.html'. - - METHODS constructor - RAISING zcx_abapgit_exception. - - PROTECTED SECTION. - METHODS render_content REDEFINITION. - - PRIVATE SECTION. -ENDCLASS. - - - -CLASS ZCL_ABAPGIT_GUI_PAGE_EXPLORE IMPLEMENTATION. - - - METHOD constructor. - super->constructor( ). - ms_control-redirect_url = c_explore_url. - ENDMETHOD. - - - METHOD render_content. - ASSERT 1 = 1. " Dummy - ENDMETHOD. -ENDCLASS. diff --git a/src/ui/zcl_abapgit_gui_page_explore.clas.xml b/src/ui/zcl_abapgit_gui_page_explore.clas.xml deleted file mode 100644 index 8b268d594..000000000 --- a/src/ui/zcl_abapgit_gui_page_explore.clas.xml +++ /dev/null @@ -1,16 +0,0 @@ - - - - - - ZCL_ABAPGIT_GUI_PAGE_EXPLORE - E - GUI - Explore page - 1 - X - X - X - - - - diff --git a/src/ui/zcl_abapgit_gui_page_main.clas.abap b/src/ui/zcl_abapgit_gui_page_main.clas.abap index 6814bfb2a..5f6a4f414 100644 --- a/src/ui/zcl_abapgit_gui_page_main.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_main.clas.abap @@ -45,7 +45,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_main IMPLEMENTATION. METHOD build_main_menu. @@ -78,6 +78,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION. iv_act = zif_abapgit_definitions=>c_action-go_tutorial ) ##NO_TEXT. lo_helpsub->add( iv_txt = 'Documentation' iv_act = c_actions-documentation ) ##NO_TEXT. + lo_helpsub->add( iv_txt = 'Explore' + iv_act = zif_abapgit_definitions=>c_action-go_explore ) ##NO_TEXT. lo_helpsub->add( iv_txt = 'Changelog' iv_act = c_actions-changelog ) ##NO_TEXT. @@ -85,8 +87,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION. iv_act = zif_abapgit_definitions=>c_action-repo_newonline ) ##NO_TEXT. ro_menu->add( iv_txt = '+ Offline' iv_act = zif_abapgit_definitions=>c_action-repo_newoffline ) ##NO_TEXT. - ro_menu->add( iv_txt = 'Explore' - iv_act = zif_abapgit_definitions=>c_action-go_explore ) ##NO_TEXT. ro_menu->add( iv_txt = 'Advanced' io_sub = lo_advsub ) ##NO_TEXT. @@ -348,6 +348,9 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION. WHEN c_actions-documentation. zcl_abapgit_services_abapgit=>open_abapgit_wikipage( ). ev_state = zcl_abapgit_gui=>c_event_state-no_more_act. + WHEN zif_abapgit_definitions=>c_action-go_explore. + zcl_abapgit_services_abapgit=>open_dotabap_homepage( ). + ev_state = zcl_abapgit_gui=>c_event_state-no_more_act. WHEN c_actions-changelog. zcl_abapgit_services_abapgit=>open_abapgit_changelog( ). ev_state = zcl_abapgit_gui=>c_event_state-no_more_act. diff --git a/src/ui/zcl_abapgit_gui_router.clas.abap b/src/ui/zcl_abapgit_gui_router.clas.abap index 5577334a0..7df945a76 100644 --- a/src/ui/zcl_abapgit_gui_router.clas.abap +++ b/src/ui/zcl_abapgit_gui_router.clas.abap @@ -126,7 +126,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_ROUTER IMPLEMENTATION. +CLASS zcl_abapgit_gui_router IMPLEMENTATION. METHOD abapgit_services_actions. @@ -491,9 +491,6 @@ CLASS ZCL_ABAPGIT_GUI_ROUTER IMPLEMENTATION. WHEN zif_abapgit_definitions=>c_action-repo_newonline. zcl_abapgit_services_repo=>new_online( lv_url ). ev_state = zcl_abapgit_gui=>c_event_state-re_render. - WHEN 'install'. " 'install' is for explore page - zcl_abapgit_services_repo=>new_online( lv_url ). - ev_state = zcl_abapgit_gui=>c_event_state-re_render. WHEN zif_abapgit_definitions=>c_action-repo_refresh_checksums. " Rebuild local checksums zcl_abapgit_services_repo=>refresh_local_checksums( lv_key ). ev_state = zcl_abapgit_gui=>c_event_state-re_render. diff --git a/src/ui/zcl_abapgit_services_abapgit.clas.abap b/src/ui/zcl_abapgit_services_abapgit.clas.abap index bbe0634e7..510c96da2 100644 --- a/src/ui/zcl_abapgit_services_abapgit.clas.abap +++ b/src/ui/zcl_abapgit_services_abapgit.clas.abap @@ -6,8 +6,9 @@ CLASS zcl_abapgit_services_abapgit DEFINITION PUBLIC SECTION. CONSTANTS: c_abapgit_repo TYPE string VALUE 'https://github.com/larshp/abapGit' ##NO_TEXT, - c_abapgit_homepage TYPE string VALUE 'http://www.abapgit.org' ##NO_TEXT, - c_abapgit_wikipage TYPE string VALUE 'http://docs.abapgit.org' ##NO_TEXT, + c_abapgit_homepage TYPE string VALUE 'https://www.abapgit.org' ##NO_TEXT, + c_abapgit_wikipage TYPE string VALUE 'https://docs.abapgit.org' ##NO_TEXT, + c_dotabap_homepage TYPE string VALUE 'https://dotabap.org' ##NO_TEXT, c_abapgit_package TYPE devclass VALUE '$ABAPGIT' ##NO_TEXT, c_abapgit_url TYPE string VALUE 'https://github.com/larshp/abapGit.git' ##NO_TEXT, c_abapgit_tcode TYPE tcode VALUE `ZABAPGIT` ##NO_TEXT. @@ -18,6 +19,9 @@ CLASS zcl_abapgit_services_abapgit DEFINITION CLASS-METHODS open_abapgit_wikipage RAISING zcx_abapgit_exception . + CLASS-METHODS open_dotabap_homepage + RAISING + zcx_abapgit_exception . CLASS-METHODS open_abapgit_changelog RAISING zcx_abapgit_exception . @@ -261,6 +265,17 @@ CLASS zcl_abapgit_services_abapgit IMPLEMENTATION. ENDMETHOD. + METHOD open_dotabap_homepage. + + cl_gui_frontend_services=>execute( + EXPORTING document = c_dotabap_homepage + EXCEPTIONS OTHERS = 1 ). + IF sy-subrc <> 0. + zcx_abapgit_exception=>raise( 'Opening page in external browser failed.' ). + ENDIF. + + ENDMETHOD. + METHOD prepare_gui_startup.