From c266a4826caa151aee08091e57ccb2deea4d5251 Mon Sep 17 00:00:00 2001
From: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Date: Thu, 5 Dec 2024 11:45:22 -0500
Subject: [PATCH] Fix extended check issues - Part 5 (#7090)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
---
 .../zcl_abapgit_popup_branch_list.clas.abap   | 34 +++++++++----------
 .../zcl_abapgit_popup_code_insp.clas.abap     |  3 +-
 .../zcl_abapgit_popup_pull_request.clas.abap  |  1 -
 .../zcl_abapgit_popup_tag_list.clas.abap      | 30 ++++++++--------
 4 files changed, 33 insertions(+), 35 deletions(-)

diff --git a/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap b/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap
index 7e6d5e8c3..232395a02 100644
--- a/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap
+++ b/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap
@@ -22,6 +22,7 @@ CLASS zcl_abapgit_popup_branch_list DEFINITION
         !iv_default_branch  TYPE string OPTIONAL
         !iv_show_new_option TYPE abap_bool DEFAULT abap_false.
 
+  PROTECTED SECTION.
   PRIVATE SECTION.
 
     DATA mv_repo_url TYPE string.
@@ -41,15 +42,6 @@ ENDCLASS.
 CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
 
 
-  METHOD create.
-    CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_branch_list
-      EXPORTING
-        iv_url             = iv_url
-        iv_default_branch  = iv_default_branch
-        iv_show_new_option = iv_show_new_option.
-  ENDMETHOD.
-
-
   METHOD constructor.
     mv_repo_url        = iv_url.
     mv_default_branch  = zif_abapgit_git_definitions=>c_git_branch-heads_prefix && iv_default_branch.
@@ -57,14 +49,12 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
   ENDMETHOD.
 
 
-  METHOD zif_abapgit_html_popup~create_picklist.
-
-    CREATE OBJECT ro_picklist
+  METHOD create.
+    CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_branch_list
       EXPORTING
-        iv_title         = 'Choose Branch'
-        it_list          = fetch_branch_list( )
-        ii_item_renderer = me.
-
+        iv_url             = iv_url
+        iv_default_branch  = iv_default_branch
+        iv_show_new_option = iv_show_new_option.
   ENDMETHOD.
 
 
@@ -109,7 +99,6 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
     FIELD-SYMBOLS <ls_b> TYPE zif_abapgit_git_definitions=>ty_git_branch.
 
     ASSIGN iv_item TO <ls_b>.
-    ASSERT sy-subrc = 0.
 
     " TODO render mv_default_branch properly, needs respecting support from the picklist components
 
@@ -120,4 +109,15 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
     ri_html = zcl_abapgit_html=>create( |{ <ls_b>-display_name }{ lv_head_marker }| ).
 
   ENDMETHOD.
+
+
+  METHOD zif_abapgit_html_popup~create_picklist.
+
+    CREATE OBJECT ro_picklist
+      EXPORTING
+        iv_title         = 'Choose Branch'
+        it_list          = fetch_branch_list( )
+        ii_item_renderer = me.
+
+  ENDMETHOD.
 ENDCLASS.
diff --git a/src/ui/popups/zcl_abapgit_popup_code_insp.clas.abap b/src/ui/popups/zcl_abapgit_popup_code_insp.clas.abap
index 4e39b9984..09b14720c 100644
--- a/src/ui/popups/zcl_abapgit_popup_code_insp.clas.abap
+++ b/src/ui/popups/zcl_abapgit_popup_code_insp.clas.abap
@@ -24,7 +24,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_POPUP_CODE_INSP IMPLEMENTATION.
+CLASS zcl_abapgit_popup_code_insp IMPLEMENTATION.
 
 
   METHOD create.
@@ -44,7 +44,6 @@ CLASS ZCL_ABAPGIT_POPUP_CODE_INSP IMPLEMENTATION.
     FIELD-SYMBOLS <ls_item> TYPE LINE OF zif_abapgit_code_inspector=>ty_variants.
 
     ASSIGN iv_item TO <ls_item>.
-    ASSERT sy-subrc = 0.
 
     ri_html = zcl_abapgit_html=>create( |<b>{ <ls_item>-name }</b> - { <ls_item>-description }| ).
 
diff --git a/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap b/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap
index e6ed9f72b..327550038 100644
--- a/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap
+++ b/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap
@@ -67,7 +67,6 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
     FIELD-SYMBOLS <ls_pr> TYPE zif_abapgit_pr_enum_provider=>ty_pull_request.
 
     ASSIGN iv_item TO <ls_pr>.
-    ASSERT sy-subrc = 0.
 
     ri_html = zcl_abapgit_html=>create( |<b>{ <ls_pr>-number }</b> - { <ls_pr>-title } @{ <ls_pr>-user }| ).
 
diff --git a/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap b/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap
index 85ecdb296..fb99de911 100644
--- a/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap
+++ b/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap
@@ -18,6 +18,7 @@ CLASS zcl_abapgit_popup_tag_list DEFINITION
       IMPORTING
         iv_url TYPE string.
 
+  PROTECTED SECTION.
   PRIVATE SECTION.
 
     DATA mv_repo_url TYPE string.
@@ -34,26 +35,15 @@ ENDCLASS.
 CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION.
 
 
-  METHOD create.
-    CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_tag_list
-      EXPORTING
-        iv_url = iv_url.
-  ENDMETHOD.
-
-
   METHOD constructor.
     mv_repo_url = iv_url.
   ENDMETHOD.
 
 
-  METHOD zif_abapgit_html_popup~create_picklist.
-
-    CREATE OBJECT ro_picklist
+  METHOD create.
+    CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_tag_list
       EXPORTING
-        iv_title         = 'Choose Tag'
-        it_list          = fetch_tag_list( )
-        ii_item_renderer = me.
-
+        iv_url = iv_url.
   ENDMETHOD.
 
 
@@ -80,9 +70,19 @@ CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION.
     FIELD-SYMBOLS <ls_tag> TYPE zif_abapgit_git_definitions=>ty_git_branch.
 
     ASSIGN iv_item TO <ls_tag>.
-    ASSERT sy-subrc = 0.
 
     ri_html = zcl_abapgit_html=>create( |{ <ls_tag>-display_name }| ).
 
   ENDMETHOD.
+
+
+  METHOD zif_abapgit_html_popup~create_picklist.
+
+    CREATE OBJECT ro_picklist
+      EXPORTING
+        iv_title         = 'Choose Tag'
+        it_list          = fetch_tag_list( )
+        ii_item_renderer = me.
+
+  ENDMETHOD.
 ENDCLASS.