From c40964ec3351f1da19472a414e9ed54d1665bfd3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francisco=20Mil=C3=A1n?= <36721657+francisco-milan@users.noreply.github.com> Date: Thu, 21 Mar 2024 05:06:32 -0600 Subject: [PATCH] Fix Unexpected Functionality for "Maximum Length of Comment" Field (#6871) Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com> --- src/ui/lib/zcl_abapgit_html_form_utils.clas.abap | 2 +- src/ui/pages/sett/zcl_abapgit_gui_page_sett_glob.clas.abap | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/ui/lib/zcl_abapgit_html_form_utils.clas.abap b/src/ui/lib/zcl_abapgit_html_form_utils.clas.abap index b5d734366..edf235c6b 100644 --- a/src/ui/lib/zcl_abapgit_html_form_utils.clas.abap +++ b/src/ui/lib/zcl_abapgit_html_form_utils.clas.abap @@ -247,7 +247,7 @@ CLASS zcl_abapgit_html_form_utils IMPLEMENTATION. DATA: lt_fields TYPE zif_abapgit_html_form=>ty_fields, lv_value TYPE string, - lv_number TYPE i. + lv_number TYPE p LENGTH 16 DECIMALS 0. FIELD-SYMBOLS LIKE LINE OF lt_fields. diff --git a/src/ui/pages/sett/zcl_abapgit_gui_page_sett_glob.clas.abap b/src/ui/pages/sett/zcl_abapgit_gui_page_sett_glob.clas.abap index 130ce0555..0dbcc1b94 100644 --- a/src/ui/pages/sett/zcl_abapgit_gui_page_sett_glob.clas.abap +++ b/src/ui/pages/sett/zcl_abapgit_gui_page_sett_glob.clas.abap @@ -145,7 +145,8 @@ CLASS zcl_abapgit_gui_page_sett_glob IMPLEMENTATION. iv_required = abap_true iv_label = 'Maximum Length of Comment' iv_hint = |At most { zcl_abapgit_settings=>c_commitmsg_comment_length_dft } characters| - iv_min = zcl_abapgit_settings=>c_commitmsg_comment_length_dft + iv_min = 1 + iv_max = 255 )->text( iv_name = c_id-commitmsg_comment_deflt iv_label = 'Default Text For Comment'