From c750a82726a052bb39f954b093e17650606c5ef7 Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Thu, 26 Oct 2023 00:35:01 -0400 Subject: [PATCH] Pretty-print a couple files (#6572) --- src/exits/zif_abapgit_exit.intf.abap | 87 ++++++++++++------- .../pages/zcl_abapgit_gui_page_db.clas.abap | 9 +- 2 files changed, 60 insertions(+), 36 deletions(-) diff --git a/src/exits/zif_abapgit_exit.intf.abap b/src/exits/zif_abapgit_exit.intf.abap index 5061ccfbf..c866005f5 100644 --- a/src/exits/zif_abapgit_exit.intf.abap +++ b/src/exits/zif_abapgit_exit.intf.abap @@ -1,16 +1,18 @@ -INTERFACE zif_abapgit_exit - PUBLIC . - +INTERFACE zif_abapgit_exit PUBLIC. TYPES: BEGIN OF ty_ci_repo, name TYPE string, clone_url TYPE string, - END OF ty_ci_repo . + END OF ty_ci_repo. TYPES: - ty_ci_repos TYPE TABLE OF ty_ci_repo . + ty_ci_repos TYPE TABLE OF ty_ci_repo. TYPES: - ty_object_types TYPE STANDARD TABLE OF tadir-object WITH DEFAULT KEY . + ty_object_types TYPE STANDARD TABLE OF tadir-object WITH DEFAULT KEY. + TYPES: + BEGIN OF ty_class_key, + clsname TYPE abap_classname, + END OF ty_class_key. METHODS adjust_display_commit_url IMPORTING @@ -21,64 +23,74 @@ INTERFACE zif_abapgit_exit CHANGING !cv_display_url TYPE csequence RAISING - zcx_abapgit_exception . + zcx_abapgit_exception. + METHODS adjust_display_filename IMPORTING !is_repo_meta TYPE zif_abapgit_persistence=>ty_repo !iv_filename TYPE string RETURNING - VALUE(rv_filename) TYPE string . + VALUE(rv_filename) TYPE string. + METHODS allow_sap_objects RETURNING - VALUE(rv_allowed) TYPE abap_bool . + VALUE(rv_allowed) TYPE abap_bool. + METHODS change_local_host CHANGING - !ct_hosts TYPE zif_abapgit_definitions=>ty_string_tt . + !ct_hosts TYPE zif_abapgit_definitions=>ty_string_tt. + METHODS change_max_parallel_processes IMPORTING iv_package TYPE devclass CHANGING cv_max_processes TYPE i. + METHODS change_proxy_authentication IMPORTING !iv_repo_url TYPE csequence CHANGING - !cv_proxy_authentication TYPE abap_bool . + !cv_proxy_authentication TYPE abap_bool. + METHODS change_proxy_port IMPORTING !iv_repo_url TYPE csequence CHANGING - !cv_proxy_port TYPE string . + !cv_proxy_port TYPE string. + METHODS change_proxy_url IMPORTING !iv_repo_url TYPE csequence CHANGING - !cv_proxy_url TYPE string . + !cv_proxy_url TYPE string. + METHODS change_rfc_server_group CHANGING cv_group TYPE rzlli_apcl. + METHODS change_supported_data_objects CHANGING !ct_objects TYPE zif_abapgit_data_supporter=>ty_objects. + METHODS change_supported_object_types CHANGING - !ct_types TYPE ty_object_types . + !ct_types TYPE ty_object_types. + METHODS change_tadir IMPORTING !iv_package TYPE devclass !ii_log TYPE REF TO zif_abapgit_log CHANGING - !ct_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt . + !ct_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt. + METHODS create_http_client IMPORTING !iv_url TYPE string RETURNING VALUE(ri_client) TYPE REF TO if_http_client RAISING - zcx_abapgit_exception . - TYPES: BEGIN OF ty_class_key, - clsname TYPE abap_classname, - END OF ty_class_key. + zcx_abapgit_exception. + METHODS custom_serialize_abap_clif IMPORTING !is_class_key TYPE ty_class_key @@ -86,41 +98,49 @@ INTERFACE zif_abapgit_exit RETURNING VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt RAISING - zcx_abapgit_exception . + zcx_abapgit_exception. + METHODS deserialize_postprocess IMPORTING !is_step TYPE zif_abapgit_objects=>ty_step_data - !ii_log TYPE REF TO zif_abapgit_log . + !ii_log TYPE REF TO zif_abapgit_log. + METHODS determine_transport_request IMPORTING !io_repo TYPE REF TO zcl_abapgit_repo !iv_transport_type TYPE zif_abapgit_definitions=>ty_transport_type CHANGING - !cv_transport_request TYPE trkorr . + !cv_transport_request TYPE trkorr. + METHODS enhance_repo_toolbar IMPORTING !io_menu TYPE REF TO zcl_abapgit_html_toolbar !iv_key TYPE zif_abapgit_persistence=>ty_value !iv_act TYPE string. + METHODS get_ci_tests IMPORTING !iv_object TYPE tadir-object CHANGING - !ct_ci_repos TYPE ty_ci_repos . + !ct_ci_repos TYPE ty_ci_repos. + METHODS get_ssl_id RETURNING - VALUE(rv_ssl_id) TYPE ssfapplssl . + VALUE(rv_ssl_id) TYPE ssfapplssl. + METHODS http_client IMPORTING !iv_url TYPE string - !ii_client TYPE REF TO if_http_client . + !ii_client TYPE REF TO if_http_client. + METHODS on_event IMPORTING !ii_event TYPE REF TO zif_abapgit_gui_event RETURNING VALUE(rs_handled) TYPE zif_abapgit_gui_event_handler=>ty_handling_result RAISING - zcx_abapgit_exception . + zcx_abapgit_exception. + METHODS pre_calculate_repo_status IMPORTING !is_repo_meta TYPE zif_abapgit_persistence=>ty_repo @@ -128,25 +148,30 @@ INTERFACE zif_abapgit_exit !ct_local TYPE zif_abapgit_definitions=>ty_files_item_tt !ct_remote TYPE zif_abapgit_git_definitions=>ty_files_tt RAISING - zcx_abapgit_exception . + zcx_abapgit_exception. + METHODS serialize_postprocess IMPORTING !iv_package TYPE devclass !ii_log TYPE REF TO zif_abapgit_log CHANGING - !ct_files TYPE zif_abapgit_definitions=>ty_files_item_tt . + !ct_files TYPE zif_abapgit_definitions=>ty_files_item_tt. + METHODS validate_before_push IMPORTING !is_comment TYPE zif_abapgit_git_definitions=>ty_comment !io_stage TYPE REF TO zcl_abapgit_stage !io_repo TYPE REF TO zcl_abapgit_repo_online RAISING - zcx_abapgit_exception . + zcx_abapgit_exception. + METHODS wall_message_list IMPORTING - !ii_html TYPE REF TO zif_abapgit_html . + !ii_html TYPE REF TO zif_abapgit_html. + METHODS wall_message_repo IMPORTING !is_repo_meta TYPE zif_abapgit_persistence=>ty_repo - !ii_html TYPE REF TO zif_abapgit_html . + !ii_html TYPE REF TO zif_abapgit_html. + ENDINTERFACE. diff --git a/src/ui/pages/zcl_abapgit_gui_page_db.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_db.clas.abap index a1781e131..30c340337 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_db.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_db.clas.abap @@ -21,7 +21,6 @@ CLASS zcl_abapgit_gui_page_db DEFINITION RAISING zcx_abapgit_exception. - PROTECTED SECTION. PRIVATE SECTION. CONSTANTS: @@ -48,7 +47,7 @@ CLASS zcl_abapgit_gui_page_db DEFINITION METHODS render_table IMPORTING - it_db_entries TYPE zif_abapgit_persistence=>ty_contents + it_db_entries TYPE zif_abapgit_persistence=>ty_contents RETURNING VALUE(ri_html) TYPE REF TO zif_abapgit_html RAISING @@ -75,21 +74,21 @@ CLASS zcl_abapgit_gui_page_db DEFINITION zcx_abapgit_exception. METHODS explain_content_repo IMPORTING - !is_data TYPE zif_abapgit_persistence=>ty_content + !is_data TYPE zif_abapgit_persistence=>ty_content RETURNING VALUE(rs_expl) TYPE ty_explanation RAISING zcx_abapgit_exception. METHODS explain_content_repo_cs IMPORTING - !is_data TYPE zif_abapgit_persistence=>ty_content + !is_data TYPE zif_abapgit_persistence=>ty_content RETURNING VALUE(rs_expl) TYPE ty_explanation RAISING zcx_abapgit_exception. METHODS explain_content_background IMPORTING - !is_data TYPE zif_abapgit_persistence=>ty_content + !is_data TYPE zif_abapgit_persistence=>ty_content RETURNING VALUE(rs_expl) TYPE ty_explanation RAISING