SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Minor lint updates (#2766)

Browse Source 
* remove some double space

* update abaplint to latest

* fixes
This commit is contained in:
Lars Hvam 2019-07-01 22:08:54 -07:00 committed by GitHub
parent df0aca8272
commit c84b209944
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 39 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
abaplint.json
View File

@ -49,7 +49,7 @@
"constructor_visibility_public": { "constructor_visibility_public": {
"enabled": true, "enabled": true,
"exclude": [] "exclude": []
}, },
"contains_tab": { "contains_tab": {
"enabled": true, "enabled": true,
"exclude": [] "exclude": []
@ -63,23 +63,32 @@
"exclude": [] "exclude": []
}, },
"double_space": { "double_space": {
"enabled": true, "enabled": false,
"exclude": [] "exclude": [],
"keywords": true,
"startParen": true,
"endParen": true
}, },
"empty_line_in_statement": { "empty_line_in_statement": {
"enabled": true, "enabled": true,
"exclude": [], "exclude": [],
"allowChained": true "allowChained": true
}, },
"empty_loop": {
"enabled": true,
"exclude": [],
"length": 120
},
"empty_statement": { "empty_statement": {
"enabled": true, "enabled": true,
"exclude": [] "exclude": []
}, },
"empty_structure": {
"enabled": true,
"exclude": [],
"loop": true,
"if": false,
"while": true,
"case": true,
"select": true,
"do": true,
"at": true
},
"exit_or_check": { "exit_or_check": {
"enabled": true, "enabled": true,
"exclude": [] "exclude": []
@ -105,6 +114,11 @@
"enabled": true, "enabled": true,
"exclude": [] "exclude": []
}, },
"in_statement_indentation": {
"enabled": false,
"exclude": [],
"ignoreExceptions": true
},
"indentation": { "indentation": {
"enabled": true, "enabled": true,
"exclude": [], "exclude": [],
@ -258,6 +272,12 @@
"enabled": true, "enabled": true,
"exclude": [] "exclude": []
}, },
"space_before_dot": {
"enabled": true,
"exclude": [],
"ignoreGlobalDefinition": true,
"ignoreExceptions": true
},
"start_at_tab": { "start_at_tab": {
"enabled": true, "enabled": true,
"exclude": [] "exclude": []
@ -274,6 +294,10 @@
"enabled": true, "enabled": true,
"exclude": [] "exclude": []
}, },
"use_new": {
"enabled": true,
"exclude": []
},
"when_others_last": { "when_others_last": {
"enabled": true, "enabled": true,
"exclude": [] "exclude": []

2
src/http/zcl_abapgit_2fa_auth_base.clas.abap
View File

@ -92,7 +92,7 @@ CLASS ZCL_ABAPGIT_2FA_AUTH_BASE IMPLEMENTATION.
url = iv_url url = iv_url
ssl_id = zcl_abapgit_exit=>get_instance( )->get_ssl_id( ) ssl_id = zcl_abapgit_exit=>get_instance( )->get_ssl_id( )
proxy_host = lo_proxy->get_proxy_url( iv_url ) proxy_host = lo_proxy->get_proxy_url( iv_url )
proxy_service = lo_proxy->get_proxy_port( iv_url ) proxy_service = lo_proxy->get_proxy_port( iv_url )
IMPORTING IMPORTING
client = ri_client client = ri_client
EXCEPTIONS EXCEPTIONS

2
src/objects/zcl_abapgit_object_sfpf.clas.abap
View File

@ -82,7 +82,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SFPF IMPLEMENTATION.
* Renumber id='o...' attributes * Renumber id='o...' attributes
li_iterator = ii_document->create_iterator_filtered( li_iterator = ii_document->create_iterator_filtered(
ii_document->create_filter_and( ii_document->create_filter_and(
filter1 = ii_document->create_filter_node_type( if_ixml_node=>co_node_element ) filter1 = ii_document->create_filter_node_type( if_ixml_node=>co_node_element )
filter2 = ii_document->create_filter_attribute( 'id' ) ) ). filter2 = ii_document->create_filter_attribute( 'id' ) ) ).
li_elem ?= li_iterator->get_next( ). li_elem ?= li_iterator->get_next( ).
WHILE li_elem IS NOT INITIAL. WHILE li_elem IS NOT INITIAL.

4
src/ui/core/zcl_abapgit_gui_asset_manager.clas.testclasses.abap
View File

@ -56,7 +56,7 @@ CLASS ltcl_abapgit_gui_asset_manager IMPLEMENTATION.
iv_assert_subtype = 'css' ) iv_assert_subtype = 'css' )
exp = 'ABC' ). exp = 'ABC' ).
TRY . TRY.
lo_assetman->zif_abapgit_gui_asset_manager~get_text_asset( lo_assetman->zif_abapgit_gui_asset_manager~get_text_asset(
iv_url = 'css/common.css' iv_url = 'css/common.css'
iv_assert_subtype = 'xyz' ). iv_assert_subtype = 'xyz' ).
@ -70,7 +70,7 @@ CLASS ltcl_abapgit_gui_asset_manager IMPLEMENTATION.
iv_type = 'nottext/bin' iv_type = 'nottext/bin'
iv_inline = 'XYZ' ). iv_inline = 'XYZ' ).
TRY . TRY.
lo_assetman->zif_abapgit_gui_asset_manager~get_text_asset( 'css/common.xyz' ). lo_assetman->zif_abapgit_gui_asset_manager~get_text_asset( 'css/common.xyz' ).
cl_abap_unit_assert=>fail( ). cl_abap_unit_assert=>fail( ).
CATCH zcx_abapgit_exception. CATCH zcx_abapgit_exception.

2
src/ui/core/zcl_abapgit_gui_html_processor.clas.testclasses.abap
View File

@ -160,7 +160,7 @@ CLASS ltcl_html_processor_test IMPLEMENTATION.
METHOD process_fails. METHOD process_fails.
TRY . TRY.
" BTW this is valid HTML, maybe refactor the code ... " BTW this is valid HTML, maybe refactor the code ...
mo_cut->zif_abapgit_gui_html_processor~process( mo_cut->zif_abapgit_gui_html_processor~process(
iv_html = '<html><body></body></html>' iv_html = '<html><body></body></html>'

2
src/ui/zcl_abapgit_services_repo.clas.abap
View File

@ -322,7 +322,7 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION.
ls_checks = lo_repo->delete_checks( ). ls_checks = lo_repo->delete_checks( ).
IF ls_checks-transport-required = abap_true. IF ls_checks-transport-required = abap_true.
ls_checks-transport-transport = zcl_abapgit_ui_factory=>get_popups( ls_checks-transport-transport = zcl_abapgit_ui_factory=>get_popups(
)->popup_transport_request( ls_checks-transport-type ). )->popup_transport_request( ls_checks-transport-type ).
ENDIF. ENDIF.
zcl_abapgit_repo_srv=>get_instance( )->purge( io_repo = lo_repo zcl_abapgit_repo_srv=>get_instance( )->purge( io_repo = lo_repo

2
src/zcl_abapgit_transport_mass.clas.abap
View File

@ -50,7 +50,7 @@ CLASS ZCL_ABAPGIT_TRANSPORT_MASS IMPLEMENTATION.
iv_logic = zcl_abapgit_ui_factory=>get_popups( )->popup_folder_logic( ) ). iv_logic = zcl_abapgit_ui_factory=>get_popups( )->popup_folder_logic( ) ).
* Open output folder if user asked it * Open output folder if user asked it
lcl_gui=>open_folder_frontend( lo_transport_zipper->gv_full_folder ). lcl_gui=>open_folder_frontend( lo_transport_zipper->gv_full_folder ).
ELSE. ELSE.
* No data found for the provided selection criterias * No data found for the provided selection criterias