From c9ae5ac1222d0b1b1be968edb83fea11e0267a32 Mon Sep 17 00:00:00 2001
From: Jaime Rodriguez Capote <jrodriguez@resultoconsultoria.com>
Date: Wed, 4 Mar 2020 06:41:04 +0100
Subject: [PATCH] Transaction, unknown cinfo #3223 (#3232)

* Determination transaction type

* Determine TX type

* abaplint checks
---
 src/objects/zcl_abapgit_object_tran.clas.abap | 49 +++++++++----------
 1 file changed, 24 insertions(+), 25 deletions(-)

diff --git a/src/objects/zcl_abapgit_object_tran.clas.abap b/src/objects/zcl_abapgit_object_tran.clas.abap
index cbc1dfec6..c7a7f0226 100644
--- a/src/objects/zcl_abapgit_object_tran.clas.abap
+++ b/src/objects/zcl_abapgit_object_tran.clas.abap
@@ -12,17 +12,17 @@ CLASS zcl_abapgit_object_tran DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
                                      WITH NON-UNIQUE DEFAULT KEY .
 
     CONSTANTS:
-      c_oo_program TYPE c LENGTH 9 VALUE '\PROGRAM=' ##NO_TEXT,
-      c_oo_class TYPE c LENGTH 7 VALUE '\CLASS=' ##NO_TEXT,
-      c_oo_method TYPE c LENGTH 8 VALUE '\METHOD=' ##NO_TEXT,
-      c_oo_tcode TYPE tcode VALUE 'OS_APPLICATION' ##NO_TEXT,
-      c_oo_frclass TYPE c LENGTH 30 VALUE 'CLASS' ##NO_TEXT,
-      c_oo_frmethod TYPE c LENGTH 30 VALUE 'METHOD' ##NO_TEXT,
+      c_oo_program   TYPE c LENGTH 9 VALUE '\PROGRAM=' ##NO_TEXT,
+      c_oo_class     TYPE c LENGTH 7 VALUE '\CLASS=' ##NO_TEXT,
+      c_oo_method    TYPE c LENGTH 8 VALUE '\METHOD=' ##NO_TEXT,
+      c_oo_tcode     TYPE tcode VALUE 'OS_APPLICATION' ##NO_TEXT,
+      c_oo_frclass   TYPE c LENGTH 30 VALUE 'CLASS' ##NO_TEXT,
+      c_oo_frmethod  TYPE c LENGTH 30 VALUE 'METHOD' ##NO_TEXT,
       c_oo_frupdtask TYPE c LENGTH 30 VALUE 'UPDATE_MODE' ##NO_TEXT,
-      c_oo_synchron TYPE c VALUE 'S' ##NO_TEXT,
+      c_oo_synchron  TYPE c VALUE 'S' ##NO_TEXT,
       c_oo_asynchron TYPE c VALUE 'U' ##NO_TEXT,
-      c_true TYPE c VALUE 'X' ##NO_TEXT,
-      c_false TYPE c VALUE space ##NO_TEXT.
+      c_true         TYPE c VALUE 'X' ##NO_TEXT,
+      c_false        TYPE c VALUE space ##NO_TEXT.
 
     DATA:
       mt_bcdata TYPE STANDARD TABLE OF bdcdata .
@@ -78,7 +78,7 @@ ENDCLASS.
 
 
 
-CLASS ZCL_ABAPGIT_OBJECT_TRAN IMPLEMENTATION.
+CLASS zcl_abapgit_object_tran IMPLEMENTATION.
 
 
   METHOD add_data.
@@ -532,10 +532,10 @@ CLASS ZCL_ABAPGIT_OBJECT_TRAN IMPLEMENTATION.
   METHOD zif_abapgit_object~deserialize.
 
     CONSTANTS: lc_hex_tra TYPE x VALUE '00',
-*               c_hex_men TYPE x VALUE '01',
+*               lc_hex_men TYPE x VALUE '01',
                lc_hex_par TYPE x VALUE '02',
                lc_hex_rep TYPE x VALUE '80',
-*               c_hex_rpv TYPE x VALUE '10',
+*               lc_hex_rpv TYPE x VALUE '10',
                lc_hex_obj TYPE x VALUE '08'.
 
     DATA: lv_dynpro       TYPE d020s-dnum,
@@ -563,19 +563,18 @@ CLASS ZCL_ABAPGIT_OBJECT_TRAN IMPLEMENTATION.
 
     lv_dynpro = ls_tstc-dypno.
 
-    CASE ls_tstc-cinfo.
-      WHEN lc_hex_tra.
-        lv_type = ststc_c_type_dialog.
-      WHEN lc_hex_rep.
-        lv_type = ststc_c_type_report.
-      WHEN lc_hex_par.
-        lv_type = ststc_c_type_parameters.
-      WHEN lc_hex_obj.
-        lv_type = ststc_c_type_object.
-* todo, or ststc_c_type_variant?
-      WHEN OTHERS.
-        zcx_abapgit_exception=>raise( 'Transaction, unknown CINFO' ).
-    ENDCASE.
+    IF     ls_tstc-cinfo O lc_hex_rep.
+      lv_type = ststc_c_type_report.
+    ELSEIF ls_tstc-cinfo O lc_hex_obj.
+      lv_type = ststc_c_type_object.
+      " todo, or ststc_c_type_variant?
+    ELSEIF ls_tstc-cinfo O lc_hex_par.
+      lv_type = ststc_c_type_parameters.
+    ELSEIF ls_tstc-cinfo O lc_hex_tra.
+      lv_type = ststc_c_type_dialog.
+    ELSE.
+      zcx_abapgit_exception=>raise( 'Transaction, unknown CINFO' ).
+    ENDIF.
 
     IF ls_tstcp IS NOT INITIAL.
       split_parameters(