From caf7c92eaf756664b191287b3687443a1b25b9d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=BCnter?= Date: Tue, 26 May 2020 06:09:17 +0200 Subject: [PATCH] SAP Package: Replace ASSERT with RAISE (#3421) * Package read_parent: RAISE instead of ASSERT * remove pseudo comment Co-authored-by: Lars Hvam --- src/zcl_abapgit_sap_package.clas.abap | 6 ++++-- src/zcl_abapgit_transport.clas.abap | 4 +++- src/zif_abapgit_sap_package.intf.abap | 8 +++++--- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/src/zcl_abapgit_sap_package.clas.abap b/src/zcl_abapgit_sap_package.clas.abap index b9a31d68d..f2a7bcb52 100644 --- a/src/zcl_abapgit_sap_package.clas.abap +++ b/src/zcl_abapgit_sap_package.clas.abap @@ -308,8 +308,10 @@ CLASS ZCL_ABAPGIT_SAP_PACKAGE IMPLEMENTATION. METHOD zif_abapgit_sap_package~read_parent. SELECT SINGLE parentcl FROM tdevc INTO rv_parentcl - WHERE devclass = mv_package. "#EC CI_SUBRC "#EC CI_GENBUFF - ASSERT sy-subrc = 0. + WHERE devclass = mv_package. "#EC CI_GENBUFF + IF sy-subrc <> 0. + zcx_abapgit_exception=>raise( |Inconsistent package structure! Cannot find parent for { mv_package }| ). + ENDIF. ENDMETHOD. ENDCLASS. diff --git a/src/zcl_abapgit_transport.clas.abap b/src/zcl_abapgit_transport.clas.abap index cfd3c74c6..cd149a6f8 100644 --- a/src/zcl_abapgit_transport.clas.abap +++ b/src/zcl_abapgit_transport.clas.abap @@ -38,7 +38,9 @@ CLASS zcl_abapgit_transport DEFINITION IMPORTING !it_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt RETURNING - VALUE(rv_package) TYPE devclass . + VALUE(rv_package) TYPE devclass + RAISING + zcx_abapgit_exception . CLASS-METHODS resolve IMPORTING !it_requests TYPE trwbo_requests diff --git a/src/zif_abapgit_sap_package.intf.abap b/src/zif_abapgit_sap_package.intf.abap index 932b28065..6c3c185c2 100644 --- a/src/zif_abapgit_sap_package.intf.abap +++ b/src/zif_abapgit_sap_package.intf.abap @@ -6,13 +6,15 @@ INTERFACE zif_abapgit_sap_package PUBLIC. IMPORTING is_package TYPE scompkdtln RAISING zcx_abapgit_exception, create_local - RAISING zcx_abapgit_exception, + RAISING zcx_abapgit_exception, list_subpackages RETURNING VALUE(rt_list) TYPE ty_devclass_tt, list_superpackages - RETURNING VALUE(rt_list) TYPE ty_devclass_tt, + RETURNING VALUE(rt_list) TYPE ty_devclass_tt + RAISING zcx_abapgit_exception, read_parent - RETURNING VALUE(rv_parentcl) TYPE tdevc-parentcl, + RETURNING VALUE(rv_parentcl) TYPE tdevc-parentcl + RAISING zcx_abapgit_exception, create_child IMPORTING iv_child TYPE devclass RAISING zcx_abapgit_exception,