SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

SAP Package: Replace ASSERT with RAISE (#3421)

Browse Source 
* Package read_parent: RAISE instead of ASSERT

* remove pseudo comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Christian Günter 2020-05-26 06:09:17 +02:00 committed by GitHub
parent f1c249b073
commit caf7c92eaf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/zcl_abapgit_sap_package.clas.abap
View File

@ -308,8 +308,10 @@ CLASS ZCL_ABAPGIT_SAP_PACKAGE IMPLEMENTATION.
METHOD zif_abapgit_sap_package~read_parent.
SELECT SINGLE parentcl FROM tdevc INTO rv_parentcl
WHERE devclass = mv_package. "#EC CI_SUBRC "#EC CI_GENBUFF
ASSERT sy-subrc = 0.
WHERE devclass = mv_package. "#EC CI_GENBUFF
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( |Inconsistent package structure! Cannot find parent for { mv_package }| ).
ENDIF.
ENDMETHOD.
ENDCLASS.

4
src/zcl_abapgit_transport.clas.abap
View File

@ -38,7 +38,9 @@ CLASS zcl_abapgit_transport DEFINITION
IMPORTING
!it_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt
RETURNING
VALUE(rv_package) TYPE devclass .
VALUE(rv_package) TYPE devclass
RAISING
zcx_abapgit_exception .
CLASS-METHODS resolve
IMPORTING
!it_requests TYPE trwbo_requests

8
src/zif_abapgit_sap_package.intf.abap
View File

@ -6,13 +6,15 @@ INTERFACE zif_abapgit_sap_package PUBLIC.
IMPORTING is_package TYPE scompkdtln
RAISING zcx_abapgit_exception,
create_local
RAISING zcx_abapgit_exception,
RAISING zcx_abapgit_exception,
list_subpackages
RETURNING VALUE(rt_list) TYPE ty_devclass_tt,
list_superpackages
RETURNING VALUE(rt_list) TYPE ty_devclass_tt,
RETURNING VALUE(rt_list) TYPE ty_devclass_tt
RAISING zcx_abapgit_exception,
read_parent
RETURNING VALUE(rv_parentcl) TYPE tdevc-parentcl,
RETURNING VALUE(rv_parentcl) TYPE tdevc-parentcl
RAISING zcx_abapgit_exception,
create_child
IMPORTING iv_child TYPE devclass
RAISING zcx_abapgit_exception,