SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-02 04:36:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Remove usages of REST API for compatibility

Browse Source
This commit is contained in:
Fabian Lupa 2017-01-14 18:22:53 +01:00
parent 36b817b405
commit cb0161d3e3
No known key found for this signature in database
GPG Key ID: 727817E619B6CA48
1 changed files with 27 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/zabapgit_2fa.prog.abap
View File

@ -337,9 +337,9 @@ CLASS lcl_2fa_github_authenticator DEFINITION
authenticate_internal REDEFINITION. authenticate_internal REDEFINITION.
PRIVATE SECTION. PRIVATE SECTION.
METHODS: METHODS:
set_access_token_request IMPORTING ii_entity TYPE REF TO if_rest_entity set_access_token_request IMPORTING ii_request TYPE REF TO if_http_request
iv_repo_name TYPE string, iv_repo_name TYPE string,
get_token_from_response IMPORTING ii_entity TYPE REF TO if_rest_entity get_token_from_response IMPORTING ii_response TYPE REF TO if_http_response
RETURNING VALUE(rv_token) TYPE string, RETURNING VALUE(rv_token) TYPE string,
parse_repo_from_url IMPORTING iv_url TYPE string parse_repo_from_url IMPORTING iv_url TYPE string
RETURNING VALUE(rv_repo_name) TYPE string. RETURNING VALUE(rv_repo_name) TYPE string.
@ -354,12 +354,9 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION.
CONSTANTS: lc_github_api_url TYPE string VALUE `https://api.github.com/`, CONSTANTS: lc_github_api_url TYPE string VALUE `https://api.github.com/`,
lc_otp_header_name TYPE string VALUE `X-Github-OTP`, lc_otp_header_name TYPE string VALUE `X-Github-OTP`,
lc_restendpoint_authorizations TYPE string VALUE `/authorizations`. lc_restendpoint_authorizations TYPE string VALUE `/authorizations`.
DATA: li_rest_client TYPE REF TO if_rest_client, DATA: li_http_client TYPE REF TO if_http_client,
li_http_client TYPE REF TO if_http_client,
lv_http_code TYPE i, lv_http_code TYPE i,
lv_http_code_description TYPE string, lv_http_code_description TYPE string,
li_request_entity TYPE REF TO if_rest_entity,
li_response_entity TYPE REF TO if_rest_entity,
lv_binary_response TYPE xstring, lv_binary_response TYPE xstring,
BEGIN OF ls_success_response, BEGIN OF ls_success_response,
token TYPE string, token TYPE string,
@ -408,30 +405,38 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION.
iv_error_text = |Authentication failed: { lv_http_code_description }|. iv_error_text = |Authentication failed: { lv_http_code_description }|.
ENDIF. ENDIF.
" Authentication worked, now the rest client can be used
CREATE OBJECT li_rest_client TYPE cl_rest_http_client
EXPORTING
io_http_client = li_http_client.
" 2. Create an access token which can be used instead of a password " 2. Create an access token which can be used instead of a password
" https://developer.github.com/v3/oauth_authorizations/#create-a-new-authorization " https://developer.github.com/v3/oauth_authorizations/#create-a-new-authorization
li_request_entity = li_rest_client->create_request_entity( ). set_access_token_request( ii_request = li_http_client->request
set_access_token_request( ii_entity = li_request_entity
iv_repo_name = parse_repo_from_url( iv_url ) ). iv_repo_name = parse_repo_from_url( iv_url ) ).
li_rest_client->set_request_header( iv_name = if_http_header_fields_sap=>request_uri li_http_client->request->set_header_field( name = if_http_header_fields_sap=>request_uri
iv_value = lc_restendpoint_authorizations ). value = lc_restendpoint_authorizations ).
li_rest_client->post( li_request_entity ). li_http_client->request->set_method( if_http_request=>co_request_method_post ).
lv_http_code = li_rest_client->get_status( ). li_http_client->send( EXCEPTIONS OTHERS = 1 ).
IF sy-subrc <> 0.
raise_internal_error_from_sy( ).
ENDIF.
li_http_client->receive( EXCEPTIONS OTHERS = 1 ).
IF sy-subrc <> 0.
raise_internal_error_from_sy( ).
ENDIF.
li_http_client->response->get_status(
IMPORTING
code = lv_http_code
reason = lv_http_code_description
).
IF lv_http_code <> 201. IF lv_http_code <> 201.
RAISE EXCEPTION TYPE lcx_2fa_token_gen_failed RAISE EXCEPTION TYPE lcx_2fa_token_gen_failed
EXPORTING EXPORTING
iv_error_text = |Token generation failed: { lv_http_code }|. iv_error_text = |Token generation failed: { lv_http_code } { lv_http_code_description }|.
ENDIF. ENDIF.
rv_access_token = get_token_from_response( li_rest_client->get_response_entity( ) ). rv_access_token = get_token_from_response( li_http_client->response ).
IF rv_access_token IS INITIAL. IF rv_access_token IS INITIAL.
RAISE EXCEPTION TYPE lcx_2fa_token_gen_failed. RAISE EXCEPTION TYPE lcx_2fa_token_gen_failed.
ENDIF. ENDIF.
@ -479,7 +484,7 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION.
CALL TRANSFORMATION id SOURCE (lt_rest_parvalues) CALL TRANSFORMATION id SOURCE (lt_rest_parvalues)
RESULT XML lo_json_writer. RESULT XML lo_json_writer.
ii_entity->set_string_data( cl_abap_codepage=>convert_from( lo_json_writer->get_output( ) ) ). ii_request->set_data( lo_json_writer->get_output( ) ).
ENDMETHOD. ENDMETHOD.
METHOD get_token_from_response. METHOD get_token_from_response.
@ -494,7 +499,8 @@ CLASS lcl_2fa_github_authenticator IMPLEMENTATION.
ls_result_line-value = lr_data_ref. ls_result_line-value = lr_data_ref.
APPEND ls_result_line TO lt_result_parvalues. APPEND ls_result_line TO lt_result_parvalues.
lv_binary_response = ii_entity->get_binary_data( ). lv_binary_response = ii_response->get_data( ).
CALL TRANSFORMATION id SOURCE XML lv_binary_response CALL TRANSFORMATION id SOURCE XML lv_binary_response
RESULT (lt_result_parvalues). RESULT (lt_result_parvalues).
ENDMETHOD. ENDMETHOD.