Refactor: Types related to object interface (#7096)
Some checks are pending
main-build / build-merged (push) Waiting to run
main-build / auto-tag (push) Waiting to run
main-build / auto-tag-artifact (push) Blocked by required conditions
main-build / coverage (push) Waiting to run

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2024-12-05 12:01:09 -05:00 committed by GitHub
parent da3f5e2a08
commit cb58678c79
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
11 changed files with 28 additions and 32 deletions

View File

@ -432,7 +432,7 @@ CLASS zcl_abapgit_serialize IMPLEMENTATION.
METHOD filter_unsupported_objects. METHOD filter_unsupported_objects.
DATA: ls_unsupported_count TYPE ty_unsupported_count, DATA: ls_unsupported_count TYPE ty_unsupported_count,
lt_supported_types TYPE zcl_abapgit_objects=>ty_types_tt, lt_supported_types TYPE zif_abapgit_objects=>ty_types_tt,
lt_unsupported_count TYPE ty_unsupported_count_tt. lt_unsupported_count TYPE ty_unsupported_count_tt.
FIELD-SYMBOLS: <ls_tadir> LIKE LINE OF ct_tadir, FIELD-SYMBOLS: <ls_tadir> LIKE LINE OF ct_tadir,

View File

@ -43,7 +43,7 @@ CLASS zcl_abapgit_object_doma DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
METHODS handle_dependencies METHODS handle_dependencies
IMPORTING IMPORTING
!iv_step TYPE zif_abapgit_definitions=>ty_deserialization_step !iv_step TYPE zif_abapgit_objects=>ty_deserialization_step
CHANGING CHANGING
!cv_exit TYPE dd01v-convexit !cv_exit TYPE dd01v-convexit
!cv_done TYPE abap_bool. !cv_done TYPE abap_bool.

View File

@ -7,7 +7,7 @@ CLASS zcl_abapgit_object_shlp DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
METHODS handle_dependencies METHODS handle_dependencies
IMPORTING IMPORTING
!iv_step TYPE zif_abapgit_definitions=>ty_deserialization_step !iv_step TYPE zif_abapgit_objects=>ty_deserialization_step
CHANGING CHANGING
!cv_exit TYPE dd30v-selmexit !cv_exit TYPE dd30v-selmexit
!cv_done TYPE abap_bool. !cv_done TYPE abap_bool.

View File

@ -4,9 +4,6 @@ CLASS zcl_abapgit_objects DEFINITION
PUBLIC SECTION. PUBLIC SECTION.
TYPES:
ty_types_tt TYPE SORTED TABLE OF tadir-object WITH UNIQUE KEY table_line .
CLASS-METHODS serialize CLASS-METHODS serialize
IMPORTING IMPORTING
!is_item TYPE zif_abapgit_definitions=>ty_item !is_item TYPE zif_abapgit_definitions=>ty_item
@ -71,7 +68,7 @@ CLASS zcl_abapgit_objects DEFINITION
VALUE(rv_bool) TYPE abap_bool . VALUE(rv_bool) TYPE abap_bool .
CLASS-METHODS supported_list CLASS-METHODS supported_list
RETURNING RETURNING
VALUE(rt_types) TYPE ty_types_tt . VALUE(rt_types) TYPE zif_abapgit_objects=>ty_types_tt.
CLASS-METHODS is_active CLASS-METHODS is_active
IMPORTING IMPORTING
!is_item TYPE zif_abapgit_definitions=>ty_item !is_item TYPE zif_abapgit_definitions=>ty_item
@ -663,7 +660,7 @@ CLASS zcl_abapgit_objects IMPLEMENTATION.
li_progress TYPE REF TO zif_abapgit_progress, li_progress TYPE REF TO zif_abapgit_progress,
lv_path TYPE string, lv_path TYPE string,
lt_items TYPE zif_abapgit_definitions=>ty_items_tt, lt_items TYPE zif_abapgit_definitions=>ty_items_tt,
lt_steps_id TYPE zif_abapgit_definitions=>ty_deserialization_step_tt, lt_steps_id TYPE zif_abapgit_objects=>ty_deserialization_step_tt,
lt_steps TYPE zif_abapgit_objects=>ty_step_data_tt, lt_steps TYPE zif_abapgit_objects=>ty_step_data_tt,
lx_exc TYPE REF TO zcx_abapgit_exception. lx_exc TYPE REF TO zcx_abapgit_exception.
DATA lo_folder_logic TYPE REF TO zcl_abapgit_folder_logic. DATA lo_folder_logic TYPE REF TO zcl_abapgit_folder_logic.
@ -672,7 +669,7 @@ CLASS zcl_abapgit_objects IMPLEMENTATION.
DATA lo_abap_language_vers TYPE REF TO zcl_abapgit_abap_language_vers. DATA lo_abap_language_vers TYPE REF TO zcl_abapgit_abap_language_vers.
FIELD-SYMBOLS: <ls_result> TYPE zif_abapgit_definitions=>ty_result, FIELD-SYMBOLS: <ls_result> TYPE zif_abapgit_definitions=>ty_result,
<lv_step_id> TYPE LINE OF zif_abapgit_definitions=>ty_deserialization_step_tt, <lv_step_id> TYPE LINE OF zif_abapgit_objects=>ty_deserialization_step_tt,
<ls_step> TYPE LINE OF zif_abapgit_objects=>ty_step_data_tt, <ls_step> TYPE LINE OF zif_abapgit_objects=>ty_step_data_tt,
<ls_deser> TYPE LINE OF zif_abapgit_objects=>ty_deserialization_tt. <ls_deser> TYPE LINE OF zif_abapgit_objects=>ty_deserialization_tt.

View File

@ -29,7 +29,7 @@ CLASS ltcl_object_types IMPLEMENTATION.
DATA: ls_item TYPE zif_abapgit_definitions=>ty_item, DATA: ls_item TYPE zif_abapgit_definitions=>ty_item,
lv_exists TYPE abap_bool, lv_exists TYPE abap_bool,
lt_types TYPE zcl_abapgit_objects=>ty_types_tt. lt_types TYPE zif_abapgit_objects=>ty_types_tt.
FIELD-SYMBOLS: <lv_type> LIKE LINE OF lt_types. FIELD-SYMBOLS: <lv_type> LIKE LINE OF lt_types.

View File

@ -1,12 +1,11 @@
INTERFACE zif_abapgit_object INTERFACE zif_abapgit_object PUBLIC.
PUBLIC .
CONSTANTS: CONSTANTS:
BEGIN OF gc_step_id, BEGIN OF gc_step_id,
early TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `EARLY`, early TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'EARLY',
abap TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `ABAP`, abap TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'ABAP',
ddic TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `DDIC`, ddic TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'DDIC',
late TYPE zif_abapgit_definitions=>ty_deserialization_step VALUE `LATE`, late TYPE zif_abapgit_objects=>ty_deserialization_step VALUE 'LATE',
END OF gc_step_id. END OF gc_step_id.
METHODS serialize METHODS serialize
@ -19,7 +18,7 @@ INTERFACE zif_abapgit_object
IMPORTING IMPORTING
!iv_package TYPE devclass !iv_package TYPE devclass
!io_xml TYPE REF TO zif_abapgit_xml_input !io_xml TYPE REF TO zif_abapgit_xml_input
!iv_step TYPE zif_abapgit_definitions=>ty_deserialization_step !iv_step TYPE zif_abapgit_objects=>ty_deserialization_step
!ii_log TYPE REF TO zif_abapgit_log !ii_log TYPE REF TO zif_abapgit_log
!iv_transport TYPE trkorr !iv_transport TYPE trkorr
RAISING RAISING
@ -78,7 +77,7 @@ INTERFACE zif_abapgit_object
METHODS get_deserialize_steps METHODS get_deserialize_steps
RETURNING RETURNING
VALUE(rt_steps) TYPE zif_abapgit_definitions=>ty_deserialization_step_tt . VALUE(rt_steps) TYPE zif_abapgit_objects=>ty_deserialization_step_tt.
METHODS get_deserialize_order METHODS get_deserialize_order
IMPORTING IMPORTING

View File

@ -1,5 +1,4 @@
INTERFACE zif_abapgit_objects INTERFACE zif_abapgit_objects PUBLIC.
PUBLIC.
TYPES: TYPES:
BEGIN OF ty_serialization, BEGIN OF ty_serialization,
@ -15,9 +14,15 @@ INTERFACE zif_abapgit_objects
END OF ty_deserialization . END OF ty_deserialization .
TYPES: TYPES:
ty_deserialization_tt TYPE STANDARD TABLE OF ty_deserialization WITH DEFAULT KEY . ty_deserialization_tt TYPE STANDARD TABLE OF ty_deserialization WITH DEFAULT KEY .
TYPES:
ty_types_tt TYPE SORTED TABLE OF tadir-object WITH UNIQUE KEY table_line.
TYPES:
ty_deserialization_step TYPE string.
TYPES:
ty_deserialization_step_tt TYPE STANDARD TABLE OF ty_deserialization_step WITH DEFAULT KEY.
TYPES: TYPES:
BEGIN OF ty_step_data, BEGIN OF ty_step_data,
step_id TYPE zif_abapgit_definitions=>ty_deserialization_step, step_id TYPE ty_deserialization_step,
order TYPE i, order TYPE i,
descr TYPE string, descr TYPE string,
syntax_check TYPE abap_bool, syntax_check TYPE abap_bool,

View File

@ -192,7 +192,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION. CLASS zcl_abapgit_repo IMPLEMENTATION.
METHOD bind_listener. METHOD bind_listener.
@ -402,7 +402,7 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
METHOD get_unsupported_objects_local. METHOD get_unsupported_objects_local.
DATA: lt_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt, DATA: lt_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt,
lt_supported_types TYPE zcl_abapgit_objects=>ty_types_tt. lt_supported_types TYPE zif_abapgit_objects=>ty_types_tt.
FIELD-SYMBOLS: <ls_tadir> LIKE LINE OF lt_tadir, FIELD-SYMBOLS: <ls_tadir> LIKE LINE OF lt_tadir,
<ls_object> LIKE LINE OF rt_objects. <ls_object> LIKE LINE OF rt_objects.

View File

@ -422,7 +422,7 @@ CLASS zcl_abapgit_gui_page_sett_info IMPLEMENTATION.
DATA: DATA:
ls_stats TYPE ty_stats, ls_stats TYPE ty_stats,
ls_item TYPE zif_abapgit_definitions=>ty_item, ls_item TYPE zif_abapgit_definitions=>ty_item,
lt_supported_types TYPE zcl_abapgit_objects=>ty_types_tt. lt_supported_types TYPE zif_abapgit_objects=>ty_types_tt.
ls_stats-measure = 'Number of Objects'. ls_stats-measure = 'Number of Objects'.

View File

@ -298,15 +298,15 @@ CLASS zcl_abapgit_gui_page_debuginfo IMPLEMENTATION.
DATA: lv_list TYPE string, DATA: lv_list TYPE string,
li_html TYPE REF TO zif_abapgit_html, li_html TYPE REF TO zif_abapgit_html,
lt_types TYPE zcl_abapgit_objects=>ty_types_tt, lt_types TYPE zif_abapgit_objects=>ty_types_tt,
lv_type LIKE LINE OF lt_types, lv_type LIKE LINE OF lt_types,
lt_obj TYPE STANDARD TABLE OF ko100 WITH DEFAULT KEY, lt_obj TYPE STANDARD TABLE OF ko100 WITH DEFAULT KEY,
lv_class TYPE seoclsname, lv_class TYPE seoclsname,
li_object TYPE REF TO zif_abapgit_object, li_object TYPE REF TO zif_abapgit_object,
ls_item TYPE zif_abapgit_definitions=>ty_item, ls_item TYPE zif_abapgit_definitions=>ty_item,
ls_metadata TYPE zif_abapgit_definitions=>ty_metadata, ls_metadata TYPE zif_abapgit_definitions=>ty_metadata,
lv_step TYPE zif_abapgit_definitions=>ty_deserialization_step, lv_step TYPE zif_abapgit_objects=>ty_deserialization_step,
lt_steps TYPE zif_abapgit_definitions=>ty_deserialization_step_tt. lt_steps TYPE zif_abapgit_objects=>ty_deserialization_step_tt.
FIELD-SYMBOLS: <ls_obj> TYPE ko100. FIELD-SYMBOLS: <ls_obj> TYPE ko100.

View File

@ -268,11 +268,6 @@ INTERFACE zif_abapgit_definitions
prerelase TYPE string, prerelase TYPE string,
prerelase_patch TYPE i, prerelase_patch TYPE i,
END OF ty_version. END OF ty_version.
TYPES:
ty_deserialization_step TYPE string.
TYPES:
ty_deserialization_step_tt TYPE STANDARD TABLE OF ty_deserialization_step
WITH DEFAULT KEY .
TYPES ty_sci_result TYPE c LENGTH 1. TYPES ty_sci_result TYPE c LENGTH 1.
CONSTANTS: CONSTANTS:
BEGIN OF c_sci_result, BEGIN OF c_sci_result,