SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Added Utility method and used it in ENHS (#3658)

Browse Source 
* Update zcx_abapgit_exception.clas.abap

* Added Utility class and adjusted exception raises

* Fix Linter

Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
This commit is contained in:
ed-holland 2020-09-03 09:02:01 +02:00 committed by GitHub
parent a8f5d7a13e
commit cb851f4ab1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 54 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/objects/zcl_abapgit_object_enhs.clas.abap
View File

@ -72,9 +72,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHS IMPLEMENTATION.
li_enh_object->unlock( ).
CATCH cx_enh_root INTO lx_enh_root.
zcx_abapgit_exception=>raise(
iv_text = lx_enh_root->get_text( )
ix_previous = lx_enh_root ).
zcx_abapgit_exception=>raise_with_text( lx_enh_root ).
ENDTRY.
ENDMETHOD.
@ -113,9 +111,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHS IMPLEMENTATION.
devclass = lv_package ).
CATCH cx_enh_root INTO lx_enh_root.
zcx_abapgit_exception=>raise(
iv_text = lx_enh_root->get_text( )
ix_previous = lx_enh_root ).
zcx_abapgit_exception=>raise_with_text( lx_enh_root ).
ENDTRY.
li_enhs = factory( lv_tool ).
@ -202,9 +198,7 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHS IMPLEMENTATION.
li_spot_ref = cl_enh_factory=>get_enhancement_spot( lv_spot_name ).
CATCH cx_enh_root INTO lx_enh_root.
zcx_abapgit_exception=>raise(
iv_text = lx_enh_root->get_text( )
ix_previous = lx_enh_root ).
zcx_abapgit_exception=>raise_with_text( lx_enh_root ).
ENDTRY.
li_enhs = factory( li_spot_ref->get_tool( ) ).

88
src/zcx_abapgit_exception.clas.abap
View File

@ -2,16 +2,17 @@
CLASS zcx_abapgit_exception DEFINITION
PUBLIC
INHERITING FROM cx_static_check
CREATE PUBLIC.
CREATE PUBLIC .
PUBLIC SECTION.
INTERFACES if_t100_message.
DATA msgv1 TYPE symsgv READ-ONLY.
DATA msgv2 TYPE symsgv READ-ONLY.
DATA msgv3 TYPE symsgv READ-ONLY.
DATA msgv4 TYPE symsgv READ-ONLY.
DATA mt_callstack TYPE abap_callstack READ-ONLY.
INTERFACES if_t100_message .
DATA msgv1 TYPE symsgv READ-ONLY .
DATA msgv2 TYPE symsgv READ-ONLY .
DATA msgv3 TYPE symsgv READ-ONLY .
DATA msgv4 TYPE symsgv READ-ONLY .
DATA mt_callstack TYPE abap_callstack READ-ONLY .
"! Raise exception with text
"! @parameter iv_text | Text
@ -22,7 +23,7 @@ CLASS zcx_abapgit_exception DEFINITION
!iv_text TYPE clike
!ix_previous TYPE REF TO cx_root OPTIONAL
RAISING
zcx_abapgit_exception.
zcx_abapgit_exception .
"! Raise exception with T100 message
"! <p>
"! Will default to sy-msg* variables. These need to be set right before calling this method.
@ -43,7 +44,7 @@ CLASS zcx_abapgit_exception DEFINITION
VALUE(iv_msgv3) TYPE symsgv DEFAULT sy-msgv3
VALUE(iv_msgv4) TYPE symsgv DEFAULT sy-msgv4
RAISING
zcx_abapgit_exception.
zcx_abapgit_exception .
METHODS constructor
IMPORTING
!textid LIKE if_t100_message=>t100key OPTIONAL
@ -51,9 +52,17 @@ CLASS zcx_abapgit_exception DEFINITION
!msgv1 TYPE symsgv OPTIONAL
!msgv2 TYPE symsgv OPTIONAL
!msgv3 TYPE symsgv OPTIONAL
!msgv4 TYPE symsgv OPTIONAL.
METHODS get_longtext REDEFINITION.
METHODS get_source_position REDEFINITION.
!msgv4 TYPE symsgv OPTIONAL .
CLASS-METHODS raise_with_text
IMPORTING
!ix_previous TYPE REF TO cx_root
RAISING
zcx_abapgit_exception .
METHODS get_source_position
REDEFINITION .
METHODS if_message~get_longtext
REDEFINITION .
PROTECTED SECTION.
PRIVATE SECTION.
CONSTANTS:
@ -61,12 +70,11 @@ CLASS zcx_abapgit_exception DEFINITION
METHODS:
save_callstack.
ENDCLASS.
CLASS zcx_abapgit_exception IMPLEMENTATION.
CLASS ZCX_ABAPGIT_EXCEPTION IMPLEMENTATION.
METHOD constructor ##ADT_SUPPRESS_GENERATION.
@ -89,7 +97,28 @@ CLASS zcx_abapgit_exception IMPLEMENTATION.
ENDMETHOD.
METHOD get_longtext.
METHOD get_source_position.
FIELD-SYMBOLS: <ls_callstack> TYPE abap_callstack_line.
READ TABLE mt_callstack ASSIGNING <ls_callstack>
INDEX 1.
IF sy-subrc = 0.
program_name = <ls_callstack>-mainprogram.
include_name = <ls_callstack>-include.
source_line = <ls_callstack>-line.
ELSE.
super->get_source_position(
IMPORTING
program_name = program_name
include_name = include_name
source_line = source_line ).
ENDIF.
ENDMETHOD.
METHOD IF_MESSAGE~GET_LONGTEXT.
" You should remember that we have to call ZCL_ABAPGIT_MESSAGE_HELPER
" dynamically, because the compiled abapGit report puts the definition
@ -179,6 +208,13 @@ CLASS zcx_abapgit_exception IMPLEMENTATION.
ENDMETHOD.
METHOD raise_with_text.
raise(
iv_text = ix_previous->get_text( )
ix_previous = ix_previous ).
ENDMETHOD.
METHOD save_callstack.
FIELD-SYMBOLS: <ls_callstack> TYPE abap_callstack_line.
@ -207,26 +243,4 @@ CLASS zcx_abapgit_exception IMPLEMENTATION.
ENDLOOP.
ENDMETHOD.
METHOD get_source_position.
FIELD-SYMBOLS: <ls_callstack> TYPE abap_callstack_line.
READ TABLE mt_callstack ASSIGNING <ls_callstack>
INDEX 1.
IF sy-subrc = 0.
program_name = <ls_callstack>-mainprogram.
include_name = <ls_callstack>-include.
source_line = <ls_callstack>-line.
ELSE.
super->get_source_position(
IMPORTING
program_name = program_name
include_name = include_name
source_line = source_line ).
ENDIF.
ENDMETHOD.
ENDCLASS.