SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Filter code inspection/syntax check (#4946)

Browse Source 
* Filter code inspection/syntax check

In case of generated maintenance screens, the code inspection/syntax check include findings in SAP code (`LSVIM*` includes). This change removes those findings.

* Update zcl_abapgit_code_inspector.clas.abap
This commit is contained in:
Marc Bernard 2021-09-12 01:12:53 -04:00 committed by GitHub
parent ab701df97e
commit cd5d43977a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/zcl_abapgit_code_inspector.clas.abap
View File

@ -42,6 +42,7 @@ CLASS zcl_abapgit_code_inspector DEFINITION
DATA mv_success TYPE abap_bool . DATA mv_success TYPE abap_bool .
TYPES: ty_run_mode TYPE c LENGTH 1. TYPES: ty_run_mode TYPE c LENGTH 1.
CONSTANTS: CONSTANTS:
BEGIN OF co_run_mode, BEGIN OF co_run_mode,
run_with_popup TYPE ty_run_mode VALUE 'P', run_with_popup TYPE ty_run_mode VALUE 'P',
@ -55,7 +56,6 @@ CLASS zcl_abapgit_code_inspector DEFINITION
DATA mv_name TYPE sci_objs . DATA mv_name TYPE sci_objs .
DATA mv_run_mode TYPE c LENGTH 1 . DATA mv_run_mode TYPE c LENGTH 1 .
METHODS create_objectset METHODS create_objectset
RETURNING RETURNING
VALUE(ro_set) TYPE REF TO cl_ci_objectset . VALUE(ro_set) TYPE REF TO cl_ci_objectset .
@ -68,21 +68,23 @@ CLASS zcl_abapgit_code_inspector DEFINITION
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS create_inspection METHODS create_inspection
IMPORTING IMPORTING
io_set TYPE REF TO cl_ci_objectset !io_set TYPE REF TO cl_ci_objectset
io_variant TYPE REF TO cl_ci_checkvariant !io_variant TYPE REF TO cl_ci_checkvariant
RETURNING RETURNING
VALUE(ro_inspection) TYPE REF TO cl_ci_inspection VALUE(ro_inspection) TYPE REF TO cl_ci_inspection
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS decide_run_mode METHODS decide_run_mode
RETURNING RETURNING
VALUE(rv_run_mode) TYPE ty_run_mode. VALUE(rv_run_mode) TYPE ty_run_mode .
METHODS filter_inspection
CHANGING
!ct_list TYPE scit_alvlist .
ENDCLASS. ENDCLASS.
CLASS ZCL_ABAPGIT_CODE_INSPECTOR IMPLEMENTATION. CLASS zcl_abapgit_code_inspector IMPLEMENTATION.
METHOD cleanup. METHOD cleanup.
@ -259,6 +261,14 @@ CLASS ZCL_ABAPGIT_CODE_INSPECTOR IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD filter_inspection.
" Remove findings in LSVIM* includes which are part of generated maintenance screens
DELETE ct_list WHERE sobjtype = 'PROG' AND sobjname CP 'LSVIM*'.
ENDMETHOD.
METHOD run_inspection. METHOD run_inspection.
io_inspection->run( io_inspection->run(
@ -274,6 +284,8 @@ CLASS ZCL_ABAPGIT_CODE_INSPECTOR IMPLEMENTATION.
io_inspection->plain_list( IMPORTING p_list = rt_list ). io_inspection->plain_list( IMPORTING p_list = rt_list ).
filter_inspection( CHANGING ct_list = rt_list ).
SORT rt_list BY objtype objname test code sobjtype sobjname line col. SORT rt_list BY objtype objname test code sobjtype sobjname line col.
DELETE ADJACENT DUPLICATES FROM rt_list. DELETE ADJACENT DUPLICATES FROM rt_list.