SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

SSFO: fix method FX_IDS

Browse Source 
Before this commit is applied the FIX_IDS methods was errorneous
and lead to subsequent dump. This commit fixes the algorithm to
replace IDs and IDREFs
This commit is contained in:
Christian Guenter 2018-10-18 11:50:30 +02:00 committed by Lars Hvam
parent f405ff9e86
commit cdf3be54c1
1 changed files with 37 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
src/objects/zcl_abapgit_object_ssfo.clas.abap
View File

@ -192,16 +192,28 @@ CLASS zcl_abapgit_object_ssfo IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD fix_ids. METHOD fix_ids.
* makes sure ID and IDREF values are the same values for each serialization run
* the standard code has a counter that keeps increasing values
DATA: lv_name TYPE string, " makes sure ID and IDREF values are the same values for each serialization run
li_idref TYPE REF TO if_ixml_node, " the standard code has a counter that keeps increasing values.
li_node TYPE REF TO if_ixml_node, "
li_attr TYPE REF TO if_ixml_named_node_map, " It is important that IDs and IDREFs which are the same before the fix
li_iterator TYPE REF TO if_ixml_node_iterator, " are also the same after the fix.
lt_idref TYPE STANDARD TABLE OF string WITH DEFAULT KEY.
TYPES:
BEGIN OF ty_id_mapping,
old TYPE string,
new TYPE string,
END OF ty_id_mapping,
tty_id_mapping TYPE HASHED TABLE OF ty_id_mapping
WITH UNIQUE KEY old.
DATA: lv_name TYPE string,
li_idref TYPE REF TO if_ixml_node,
li_node TYPE REF TO if_ixml_node,
li_attr TYPE REF TO if_ixml_named_node_map,
li_iterator TYPE REF TO if_ixml_node_iterator,
lt_id_mapping TYPE tty_id_mapping,
ls_id_mapping LIKE LINE OF lt_id_mapping.
li_iterator = ii_xml_doc->create_iterator( ). li_iterator = ii_xml_doc->create_iterator( ).
li_node = li_iterator->get_next( ). li_node = li_iterator->get_next( ).
@ -210,8 +222,17 @@ CLASS zcl_abapgit_object_ssfo IMPLEMENTATION.
IF lv_name = 'NODE' OR lv_name = 'WINDOW'. IF lv_name = 'NODE' OR lv_name = 'WINDOW'.
li_idref = li_node->get_attributes( )->get_named_item( 'IDREF' ). li_idref = li_node->get_attributes( )->get_named_item( 'IDREF' ).
IF li_idref IS BOUND. IF li_idref IS BOUND.
APPEND li_idref->get_value( ) TO lt_idref.
li_idref->set_value( |{ sy-tabix }| ). ls_id_mapping-old = li_idref->get_value( ).
READ TABLE lt_id_mapping WITH KEY old = ls_id_mapping-old
INTO ls_id_mapping.
IF sy-subrc <> 0.
lv_name = lines( lt_id_mapping ) + 1.
ls_id_mapping-new = condense( lv_name ).
INSERT ls_id_mapping INTO TABLE lt_id_mapping.
ENDIF.
li_idref->set_value( |{ ls_id_mapping-new }| ).
ENDIF. ENDIF.
ENDIF. ENDIF.
li_node = li_iterator->get_next( ). li_node = li_iterator->get_next( ).
@ -224,14 +245,17 @@ CLASS zcl_abapgit_object_ssfo IMPLEMENTATION.
IF lv_name = 'NODE' OR lv_name = 'WINDOW'. IF lv_name = 'NODE' OR lv_name = 'WINDOW'.
li_idref = li_node->get_attributes( )->get_named_item( 'ID' ). li_idref = li_node->get_attributes( )->get_named_item( 'ID' ).
IF li_idref IS BOUND. IF li_idref IS BOUND.
lv_name = li_idref->get_value( ).
READ TABLE lt_idref WITH KEY table_line = lv_name TRANSPORTING NO FIELDS. ls_id_mapping-old = li_idref->get_value( ).
READ TABLE lt_id_mapping WITH KEY old = ls_id_mapping-old
INTO ls_id_mapping.
IF sy-subrc = 0. IF sy-subrc = 0.
li_idref->set_value( |{ sy-tabix }| ). li_idref->set_value( |{ ls_id_mapping-new }| ).
ELSE. ELSE.
li_attr = li_node->get_attributes( ). li_attr = li_node->get_attributes( ).
li_attr->remove_named_item( 'ID' ). li_attr->remove_named_item( 'ID' ).
ENDIF. ENDIF.
ENDIF. ENDIF.
ENDIF. ENDIF.
li_node = li_iterator->get_next( ). li_node = li_iterator->get_next( ).