From d006cd065852082a382bbbda4187762dc762c879 Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Tue, 16 Jun 2020 15:57:04 +0200 Subject: [PATCH] Removed default for commit comment (#3513) * Removed default for commit comment Closes https://github.com/larshp/abapGit/issues/3511 * Removed default for commit comment Co-authored-by: Lars Hvam --- src/ui/zcl_abapgit_gui_page_settings.clas.abap | 2 -- src/zcl_abapgit_settings.clas.abap | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/ui/zcl_abapgit_gui_page_settings.clas.abap b/src/ui/zcl_abapgit_gui_page_settings.clas.abap index a3794209c..387ddddd1 100644 --- a/src/ui/zcl_abapgit_gui_page_settings.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_settings.clas.abap @@ -240,8 +240,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SETTINGS IMPLEMENTATION. READ TABLE mt_post_fields ASSIGNING WITH KEY name = 'comment_default'. IF sy-subrc = 0. mo_settings->set_commitmsg_comment_default( -value ). - ELSE. - mo_settings->set_commitmsg_comment_default( zcl_abapgit_settings=>c_commitmsg_comment_default ). ENDIF. READ TABLE mt_post_fields ASSIGNING WITH KEY name = 'body_size'. diff --git a/src/zcl_abapgit_settings.clas.abap b/src/zcl_abapgit_settings.clas.abap index f834b931e..63c1c9184 100644 --- a/src/zcl_abapgit_settings.clas.abap +++ b/src/zcl_abapgit_settings.clas.abap @@ -2,7 +2,6 @@ CLASS zcl_abapgit_settings DEFINITION PUBLIC CREATE PUBLIC. PUBLIC SECTION. CONSTANTS: c_commitmsg_comment_length_dft TYPE i VALUE 50. - CONSTANTS: c_commitmsg_comment_default TYPE string VALUE 'Update $OBJECT'. CONSTANTS: c_commitmsg_body_size_dft TYPE i VALUE 72. CONSTANTS: @@ -316,7 +315,6 @@ CLASS ZCL_ABAPGIT_SETTINGS IMPLEMENTATION. set_adt_jump_enanbled( abap_true ). set_show_default_repo( abap_false ). set_commitmsg_comment_length( c_commitmsg_comment_length_dft ). - set_commitmsg_comment_default( c_commitmsg_comment_default ). set_commitmsg_body_size( c_commitmsg_body_size_dft ). set_default_link_hint_key( ). set_icon_scaling( '' ).