From d31627d6a66f02fc41dc3a94ae7e5c0db88a52d0 Mon Sep 17 00:00:00 2001
From: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Date: Mon, 2 Dec 2024 09:00:46 -0500
Subject: [PATCH 1/2] MSAG: Fix error handling during deletion (#7093)

---
 src/objects/zcl_abapgit_object_msag.clas.abap | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/objects/zcl_abapgit_object_msag.clas.abap b/src/objects/zcl_abapgit_object_msag.clas.abap
index 995788751..a3f58f990 100644
--- a/src/objects/zcl_abapgit_object_msag.clas.abap
+++ b/src/objects/zcl_abapgit_object_msag.clas.abap
@@ -37,13 +37,17 @@ CLASS zcl_abapgit_object_msag DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
         zcx_abapgit_exception .
     METHODS delete_msgid
       IMPORTING
-        !iv_message_id TYPE arbgb .
+        !iv_message_id TYPE arbgb
+      RAISING
+        zcx_abapgit_exception.
     METHODS free_access_permission
       IMPORTING
         !iv_message_id TYPE arbgb .
     METHODS delete_documentation
       IMPORTING
-        !iv_message_id TYPE arbgb .
+        !iv_message_id TYPE arbgb
+      RAISING
+        zcx_abapgit_exception.
 ENDCLASS.
 
 
@@ -61,9 +65,7 @@ CLASS zcl_abapgit_object_msag IMPLEMENTATION.
         element  = iv_message_id
         addition = '   '
       IMPORTING
-        object   = lv_key_s
-      EXCEPTIONS
-        OTHERS   = 0.
+        object   = lv_key_s.
 
     CALL FUNCTION 'DOKU_DELETE_ALL'
       EXPORTING
@@ -80,7 +82,11 @@ CLASS zcl_abapgit_object_msag IMPLEMENTATION.
         no_docu_found                  = 4
         object_is_already_enqueued     = 5
         object_is_enqueued_by_corr     = 6
-        user_break                     = 7.
+        user_break                     = 7
+        OTHERS                         = 8.
+    IF sy-subrc <> 0.
+      zcx_abapgit_exception=>raise( 'Error deleting longtext for message' ).
+    ENDIF.
 
   ENDMETHOD.
 

From 994cbf8f926abc2afcb5ccec88c20ce532c86228 Mon Sep 17 00:00:00 2001
From: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Date: Mon, 2 Dec 2024 09:27:48 -0500
Subject: [PATCH 2/2] Fix error handling in exception viewer (#7095)

---
 .../lib/zcl_abapgit_exception_viewer.clas.abap   | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/ui/lib/zcl_abapgit_exception_viewer.clas.abap b/src/ui/lib/zcl_abapgit_exception_viewer.clas.abap
index 31e1fc8ac..0dc5fa2f2 100644
--- a/src/ui/lib/zcl_abapgit_exception_viewer.clas.abap
+++ b/src/ui/lib/zcl_abapgit_exception_viewer.clas.abap
@@ -146,6 +146,7 @@ CLASS zcl_abapgit_exception_viewer IMPLEMENTATION.
 
   METHOD goto_message.
 
+    DATA: lv_msg TYPE c LENGTH 100.
     DATA: lt_bdcdata TYPE STANDARD TABLE OF bdcdata,
           ls_bdcdata LIKE LINE OF lt_bdcdata.
 
@@ -177,17 +178,18 @@ CLASS zcl_abapgit_exception_viewer IMPLEMENTATION.
     CALL FUNCTION 'ABAP4_CALL_TRANSACTION'
       STARTING NEW TASK 'GIT'
       EXPORTING
-        tcode                   = 'SE91'
-        mode_val                = 'E'
+        tcode                 = 'SE91'
+        mode_val              = 'E'
       TABLES
-        using_tab               = lt_bdcdata
+        using_tab             = lt_bdcdata
       EXCEPTIONS
-        call_transaction_denied = 1
-        tcode_invalid           = 2
-        OTHERS                  = 3.
+        system_failure        = 1 MESSAGE lv_msg
+        communication_failure = 2 MESSAGE lv_msg
+        resource_failure      = 3
+        OTHERS                = 4.
 
     IF sy-subrc <> 0.
-      zcx_abapgit_exception=>raise_t100( ).
+      zcx_abapgit_exception=>raise( lv_msg ).
     ENDIF.
 
   ENDMETHOD.