diff --git a/src/objects/zcl_abapgit_oo_serializer.clas.abap b/src/objects/zcl_abapgit_oo_serializer.clas.abap index e73e61e60..dc8cf9f38 100644 --- a/src/objects/zcl_abapgit_oo_serializer.clas.abap +++ b/src/objects/zcl_abapgit_oo_serializer.clas.abap @@ -1,4 +1,6 @@ -CLASS zcl_abapgit_oo_serializer DEFINITION PUBLIC CREATE PUBLIC. +CLASS zcl_abapgit_oo_serializer DEFINITION + PUBLIC + CREATE PUBLIC . PUBLIC SECTION. @@ -41,34 +43,43 @@ CLASS zcl_abapgit_oo_serializer DEFINITION PUBLIC CREATE PUBLIC. VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt RAISING zcx_abapgit_exception . + PROTECTED SECTION. + PRIVATE SECTION. + + DATA mv_skip_testclass TYPE abap_bool . + METHODS calculate_skip_testclass IMPORTING !it_source TYPE zif_abapgit_definitions=>ty_string_tt RETURNING VALUE(rv_skip_testclass) TYPE abap_bool . - PRIVATE SECTION. - DATA mv_skip_testclass TYPE abap_bool. METHODS serialize_abap_old - IMPORTING is_clskey TYPE seoclskey - RETURNING VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt - RAISING zcx_abapgit_exception. - + IMPORTING + !is_clskey TYPE seoclskey + RETURNING + VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt + RAISING + zcx_abapgit_exception . METHODS serialize_abap_new - IMPORTING is_clskey TYPE seoclskey - RETURNING VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt - RAISING zcx_abapgit_exception - cx_sy_dyn_call_error. + IMPORTING + !is_clskey TYPE seoclskey + RETURNING + VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt + RAISING + zcx_abapgit_exception + cx_sy_dyn_call_error . METHODS remove_signatures - CHANGING ct_source TYPE zif_abapgit_definitions=>ty_string_tt. - + CHANGING + !ct_source TYPE zif_abapgit_definitions=>ty_string_tt . METHODS read_include - IMPORTING is_clskey TYPE seoclskey - iv_type TYPE seop_include_ext_app - RETURNING VALUE(rt_source) TYPE seop_source_string. - - + IMPORTING + !is_clskey TYPE seoclskey + !iv_type TYPE seop_include_ext_app + RETURNING + VALUE(rt_source) TYPE seop_source_string . METHODS reduce - CHANGING ct_source TYPE zif_abapgit_definitions=>ty_string_tt. + CHANGING + !ct_source TYPE zif_abapgit_definitions=>ty_string_tt . ENDCLASS. diff --git a/src/objects/zcl_abapgit_oo_serializer.clas.testclasses.abap b/src/objects/zcl_abapgit_oo_serializer.clas.testclasses.abap index 7944425ba..90b7480af 100644 --- a/src/objects/zcl_abapgit_oo_serializer.clas.testclasses.abap +++ b/src/objects/zcl_abapgit_oo_serializer.clas.testclasses.abap @@ -1,3 +1,6 @@ +CLASS ltcl_oo_serialize DEFINITION DEFERRED. +CLASS zcl_abapgit_oo_serializer DEFINITION LOCAL FRIENDS ltcl_oo_serialize. + CLASS ltcl_oo_serialize DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS. diff --git a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap index f8f17ea74..793d41867 100644 --- a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap @@ -1,81 +1,90 @@ -CLASS zcl_abapgit_gui_chunk_lib DEFINITION PUBLIC FINAL CREATE PUBLIC. +CLASS zcl_abapgit_gui_chunk_lib DEFINITION + PUBLIC + FINAL + CREATE PUBLIC . PUBLIC SECTION. CLASS-METHODS render_error - IMPORTING ix_error TYPE REF TO zcx_abapgit_exception OPTIONAL - iv_error TYPE string OPTIONAL - RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html. - + IMPORTING + !ix_error TYPE REF TO zcx_abapgit_exception OPTIONAL + !iv_error TYPE string OPTIONAL + RETURNING + VALUE(ro_html) TYPE REF TO zcl_abapgit_html . CLASS-METHODS render_repo_top - IMPORTING io_repo TYPE REF TO zcl_abapgit_repo - iv_show_package TYPE abap_bool DEFAULT abap_true - iv_show_branch TYPE abap_bool DEFAULT abap_true - iv_interactive_branch TYPE abap_bool DEFAULT abap_false - iv_branch TYPE string OPTIONAL - io_news TYPE REF TO zcl_abapgit_news OPTIONAL - RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html - RAISING zcx_abapgit_exception. - + IMPORTING + !io_repo TYPE REF TO zcl_abapgit_repo + !iv_show_package TYPE abap_bool DEFAULT abap_true + !iv_show_branch TYPE abap_bool DEFAULT abap_true + !iv_interactive_branch TYPE abap_bool DEFAULT abap_false + !iv_branch TYPE string OPTIONAL + !io_news TYPE REF TO zcl_abapgit_news OPTIONAL + RETURNING + VALUE(ro_html) TYPE REF TO zcl_abapgit_html + RAISING + zcx_abapgit_exception . CLASS-METHODS render_item_state - IMPORTING iv_lstate TYPE char1 - iv_rstate TYPE char1 - RETURNING VALUE(rv_html) TYPE string. - - CLASS-METHODS render_branch_span - IMPORTING iv_branch TYPE string - io_repo TYPE REF TO zcl_abapgit_repo_online - iv_interactive TYPE abap_bool - RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html - RAISING zcx_abapgit_exception. - + IMPORTING + !iv_lstate TYPE char1 + !iv_rstate TYPE char1 + RETURNING + VALUE(rv_html) TYPE string . CLASS-METHODS render_js_error_banner - RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html - RAISING zcx_abapgit_exception. - + RETURNING + VALUE(ro_html) TYPE REF TO zcl_abapgit_html + RAISING + zcx_abapgit_exception . CLASS-METHODS render_news IMPORTING - io_news TYPE REF TO zcl_abapgit_news - RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html - RAISING zcx_abapgit_exception. - + !io_news TYPE REF TO zcl_abapgit_news + RETURNING + VALUE(ro_html) TYPE REF TO zcl_abapgit_html + RAISING + zcx_abapgit_exception . CLASS-METHODS render_hotkey_overview IMPORTING - io_page TYPE REF TO zcl_abapgit_gui_page + !io_page TYPE REF TO zcl_abapgit_gui_page RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html RAISING - zcx_abapgit_exception. - - CLASS-METHODS render_infopanel - IMPORTING - iv_div_id TYPE string - iv_title TYPE string - iv_hide TYPE abap_bool DEFAULT abap_true - iv_hint TYPE string OPTIONAL - iv_scrollable TYPE abap_bool DEFAULT abap_true - io_content TYPE REF TO zcl_abapgit_html - RETURNING - VALUE(ro_html) TYPE REF TO zcl_abapgit_html - RAISING - zcx_abapgit_exception. - + zcx_abapgit_exception . CLASS-METHODS render_commit_popup IMPORTING - iv_content TYPE csequence - iv_id TYPE csequence + !iv_content TYPE csequence + !iv_id TYPE csequence RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html RAISING - zcx_abapgit_exception. - + zcx_abapgit_exception . PROTECTED SECTION. PRIVATE SECTION. + + CLASS-METHODS render_branch_span + IMPORTING + !iv_branch TYPE string + !io_repo TYPE REF TO zcl_abapgit_repo_online + !iv_interactive TYPE abap_bool + RETURNING + VALUE(ro_html) TYPE REF TO zcl_abapgit_html + RAISING + zcx_abapgit_exception . + CLASS-METHODS render_infopanel + IMPORTING + !iv_div_id TYPE string + !iv_title TYPE string + !iv_hide TYPE abap_bool DEFAULT abap_true + !iv_hint TYPE string OPTIONAL + !iv_scrollable TYPE abap_bool DEFAULT abap_true + !io_content TYPE REF TO zcl_abapgit_html + RETURNING + VALUE(ro_html) TYPE REF TO zcl_abapgit_html + RAISING + zcx_abapgit_exception . ENDCLASS. -CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION. +CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. METHOD render_branch_span. diff --git a/src/ui/zcl_abapgit_html_action_utils.clas.abap b/src/ui/zcl_abapgit_html_action_utils.clas.abap index b0b3d6f52..a8f0c9b5f 100644 --- a/src/ui/zcl_abapgit_html_action_utils.clas.abap +++ b/src/ui/zcl_abapgit_html_action_utils.clas.abap @@ -4,9 +4,6 @@ CLASS zcl_abapgit_html_action_utils DEFINITION PUBLIC SECTION. - CLASS-METHODS field_keys_to_upper - CHANGING - !ct_fields TYPE tihttpnvp . CLASS-METHODS parse_fields IMPORTING !iv_string TYPE clike @@ -17,12 +14,6 @@ CLASS zcl_abapgit_html_action_utils DEFINITION !iv_string TYPE clike RETURNING VALUE(rt_fields) TYPE tihttpnvp . - CLASS-METHODS add_field - IMPORTING - !iv_name TYPE string - !ig_field TYPE any - CHANGING - !ct_field TYPE tihttpnvp . CLASS-METHODS get_field IMPORTING !iv_name TYPE string @@ -58,13 +49,13 @@ CLASS zcl_abapgit_html_action_utils DEFINITION CLASS-METHODS file_encode IMPORTING !iv_key TYPE zif_abapgit_persistence=>ty_repo-key - !ig_file TYPE any "assuming ty_file + !ig_file TYPE any "assuming ty_file RETURNING VALUE(rv_string) TYPE string . CLASS-METHODS obj_encode IMPORTING !iv_key TYPE zif_abapgit_persistence=>ty_repo-key - !ig_object TYPE any "assuming ty_item + !ig_object TYPE any "assuming ty_item RETURNING VALUE(rv_string) TYPE string . CLASS-METHODS file_obj_decode @@ -72,8 +63,8 @@ CLASS zcl_abapgit_html_action_utils DEFINITION !iv_string TYPE clike EXPORTING !ev_key TYPE zif_abapgit_persistence=>ty_repo-key - !eg_file TYPE any "assuming ty_file - !eg_object TYPE any "assuming ty_item + !eg_file TYPE any "assuming ty_file + !eg_object TYPE any "assuming ty_item RAISING zcx_abapgit_exception . CLASS-METHODS dbkey_encode @@ -94,16 +85,28 @@ CLASS zcl_abapgit_html_action_utils DEFINITION !ev_seed TYPE string RAISING zcx_abapgit_exception . + PROTECTED SECTION. PRIVATE SECTION. - CLASS-METHODS unescape - IMPORTING iv_string TYPE string - RETURNING VALUE(rv_string) TYPE string. + CLASS-METHODS field_keys_to_upper + CHANGING + !ct_fields TYPE tihttpnvp . + CLASS-METHODS add_field + IMPORTING + !iv_name TYPE string + !ig_field TYPE any + CHANGING + !ct_field TYPE tihttpnvp . + CLASS-METHODS unescape + IMPORTING + !iv_string TYPE string + RETURNING + VALUE(rv_string) TYPE string . ENDCLASS. -CLASS zcl_abapgit_html_action_utils IMPLEMENTATION. +CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. METHOD add_field. diff --git a/src/ui/zcl_abapgit_html_action_utils.clas.testclasses.abap b/src/ui/zcl_abapgit_html_action_utils.clas.testclasses.abap index 6804137d6..8d152702d 100644 --- a/src/ui/zcl_abapgit_html_action_utils.clas.testclasses.abap +++ b/src/ui/zcl_abapgit_html_action_utils.clas.testclasses.abap @@ -4,7 +4,6 @@ CLASS ltcl_html_action_utils DEFINITION FOR TESTING RISK LEVEL HARMLESS PUBLIC SECTION. CLASS-METHODS class_constructor. - METHODS add_field FOR TESTING. METHODS get_field FOR TESTING. METHODS parse_fields_simple_case FOR TESTING. METHODS parse_fields_advanced_case FOR TESTING. @@ -56,31 +55,6 @@ CLASS ltcl_html_action_utils IMPLEMENTATION. ENDMETHOD. - METHOD add_field. - - DATA: lt_fields TYPE tihttpnvp, - lt_answer TYPE tihttpnvp, - ls_field LIKE LINE OF lt_fields. - - ls_field-name = 'NAME'. - ls_field-value = 'TEST'. - APPEND ls_field TO lt_answer. - - ls_field-name = 'VALUE'. - ls_field-value = 'TEST'. - APPEND ls_field TO lt_answer. - - zcl_abapgit_html_action_utils=>add_field( EXPORTING iv_name = 'NAME' ig_field = 'TEST' - CHANGING ct_field = lt_fields ). - zcl_abapgit_html_action_utils=>add_field( EXPORTING iv_name = 'VALUE' ig_field = ls_field - CHANGING ct_field = lt_fields ). - - cl_abap_unit_assert=>assert_equals( - act = lt_fields - exp = lt_answer ). - - ENDMETHOD. - METHOD get_field. DATA: lt_fields TYPE tihttpnvp, diff --git a/src/xml/zcl_abapgit_xml_output.clas.abap b/src/xml/zcl_abapgit_xml_output.clas.abap index 5f3cb6086..86b215dcf 100644 --- a/src/xml/zcl_abapgit_xml_output.clas.abap +++ b/src/xml/zcl_abapgit_xml_output.clas.abap @@ -1,7 +1,7 @@ CLASS zcl_abapgit_xml_output DEFINITION PUBLIC INHERITING FROM zcl_abapgit_xml - CREATE PUBLIC. + CREATE PUBLIC . PUBLIC SECTION. @@ -18,9 +18,6 @@ CLASS zcl_abapgit_xml_output DEFINITION IMPORTING !iv_name TYPE clike !ii_xml TYPE REF TO if_ixml_element . - METHODS build_asx_node - RETURNING - VALUE(ri_element) TYPE REF TO if_ixml_element . METHODS render IMPORTING !iv_normalize TYPE abap_bool DEFAULT abap_true @@ -29,8 +26,12 @@ CLASS zcl_abapgit_xml_output DEFINITION VALUE(rv_xml) TYPE string . PROTECTED SECTION. PRIVATE SECTION. - DATA: mi_raw TYPE REF TO if_ixml_element. + DATA mi_raw TYPE REF TO if_ixml_element . + + METHODS build_asx_node + RETURNING + VALUE(ri_element) TYPE REF TO if_ixml_element . ENDCLASS.