SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Move methods to private (#2416)

Browse Source 
* ZCL_ABAPGIT_GUI_CHUNK_LIB move 2 methods private

* HTML_ACTION_UTILS move two methods private

* move calculate_skip_testclass to private

* move BUILD_ASX_NODE to private
This commit is contained in:
Lars Hvam 2019-02-18 05:27:49 -08:00 committed by GitHub
parent d09b97749f
commit d0a721b2cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 121 additions and 120 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
src/objects/zcl_abapgit_oo_serializer.clas.abap
View File

@ -1,4 +1,6 @@
CLASS zcl_abapgit_oo_serializer DEFINITION PUBLIC CREATE PUBLIC. CLASS zcl_abapgit_oo_serializer DEFINITION
PUBLIC
CREATE PUBLIC .
PUBLIC SECTION. PUBLIC SECTION.
@ -41,34 +43,43 @@ CLASS zcl_abapgit_oo_serializer DEFINITION PUBLIC CREATE PUBLIC.
VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PROTECTED SECTION.
PRIVATE SECTION.
DATA mv_skip_testclass TYPE abap_bool .
METHODS calculate_skip_testclass METHODS calculate_skip_testclass
IMPORTING IMPORTING
!it_source TYPE zif_abapgit_definitions=>ty_string_tt !it_source TYPE zif_abapgit_definitions=>ty_string_tt
RETURNING RETURNING
VALUE(rv_skip_testclass) TYPE abap_bool . VALUE(rv_skip_testclass) TYPE abap_bool .
PRIVATE SECTION.
DATA mv_skip_testclass TYPE abap_bool.
METHODS serialize_abap_old METHODS serialize_abap_old
IMPORTING is_clskey TYPE seoclskey IMPORTING
RETURNING VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt !is_clskey TYPE seoclskey
RAISING zcx_abapgit_exception. RETURNING
VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt
RAISING
zcx_abapgit_exception .
METHODS serialize_abap_new METHODS serialize_abap_new
IMPORTING is_clskey TYPE seoclskey IMPORTING
RETURNING VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt !is_clskey TYPE seoclskey
RAISING zcx_abapgit_exception RETURNING
VALUE(rt_source) TYPE zif_abapgit_definitions=>ty_string_tt
RAISING
zcx_abapgit_exception
cx_sy_dyn_call_error . cx_sy_dyn_call_error .
METHODS remove_signatures METHODS remove_signatures
CHANGING ct_source TYPE zif_abapgit_definitions=>ty_string_tt. CHANGING
!ct_source TYPE zif_abapgit_definitions=>ty_string_tt .
METHODS read_include METHODS read_include
IMPORTING is_clskey TYPE seoclskey IMPORTING
iv_type TYPE seop_include_ext_app !is_clskey TYPE seoclskey
RETURNING VALUE(rt_source) TYPE seop_source_string. !iv_type TYPE seop_include_ext_app
RETURNING
VALUE(rt_source) TYPE seop_source_string .
METHODS reduce METHODS reduce
CHANGING ct_source TYPE zif_abapgit_definitions=>ty_string_tt. CHANGING
!ct_source TYPE zif_abapgit_definitions=>ty_string_tt .
ENDCLASS. ENDCLASS.

3
src/objects/zcl_abapgit_oo_serializer.clas.testclasses.abap
View File

@ -1,3 +1,6 @@
CLASS ltcl_oo_serialize DEFINITION DEFERRED.
CLASS zcl_abapgit_oo_serializer DEFINITION LOCAL FRIENDS ltcl_oo_serialize.
CLASS ltcl_oo_serialize DEFINITION FINAL FOR TESTING CLASS ltcl_oo_serialize DEFINITION FINAL FOR TESTING
DURATION SHORT DURATION SHORT
RISK LEVEL HARMLESS. RISK LEVEL HARMLESS.

111
src/ui/zcl_abapgit_gui_chunk_lib.clas.abap
View File

@ -1,81 +1,90 @@
CLASS zcl_abapgit_gui_chunk_lib DEFINITION PUBLIC FINAL CREATE PUBLIC. CLASS zcl_abapgit_gui_chunk_lib DEFINITION
PUBLIC
FINAL
CREATE PUBLIC .
PUBLIC SECTION. PUBLIC SECTION.
CLASS-METHODS render_error CLASS-METHODS render_error
IMPORTING ix_error TYPE REF TO zcx_abapgit_exception OPTIONAL IMPORTING
iv_error TYPE string OPTIONAL !ix_error TYPE REF TO zcx_abapgit_exception OPTIONAL
RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html. !iv_error TYPE string OPTIONAL
RETURNING
VALUE(ro_html) TYPE REF TO zcl_abapgit_html .
CLASS-METHODS render_repo_top CLASS-METHODS render_repo_top
IMPORTING io_repo TYPE REF TO zcl_abapgit_repo IMPORTING
iv_show_package TYPE abap_bool DEFAULT abap_true !io_repo TYPE REF TO zcl_abapgit_repo
iv_show_branch TYPE abap_bool DEFAULT abap_true !iv_show_package TYPE abap_bool DEFAULT abap_true
iv_interactive_branch TYPE abap_bool DEFAULT abap_false !iv_show_branch TYPE abap_bool DEFAULT abap_true
iv_branch TYPE string OPTIONAL !iv_interactive_branch TYPE abap_bool DEFAULT abap_false
io_news TYPE REF TO zcl_abapgit_news OPTIONAL !iv_branch TYPE string OPTIONAL
RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html !io_news TYPE REF TO zcl_abapgit_news OPTIONAL
RAISING zcx_abapgit_exception. RETURNING
VALUE(ro_html) TYPE REF TO zcl_abapgit_html
RAISING
zcx_abapgit_exception .
CLASS-METHODS render_item_state CLASS-METHODS render_item_state
IMPORTING iv_lstate TYPE char1 IMPORTING
iv_rstate TYPE char1 !iv_lstate TYPE char1
RETURNING VALUE(rv_html) TYPE string. !iv_rstate TYPE char1
RETURNING
CLASS-METHODS render_branch_span VALUE(rv_html) TYPE string .
IMPORTING iv_branch TYPE string
io_repo TYPE REF TO zcl_abapgit_repo_online
iv_interactive TYPE abap_bool
RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html
RAISING zcx_abapgit_exception.
CLASS-METHODS render_js_error_banner CLASS-METHODS render_js_error_banner
RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html RETURNING
RAISING zcx_abapgit_exception. VALUE(ro_html) TYPE REF TO zcl_abapgit_html
RAISING
zcx_abapgit_exception .
CLASS-METHODS render_news CLASS-METHODS render_news
IMPORTING IMPORTING
io_news TYPE REF TO zcl_abapgit_news !io_news TYPE REF TO zcl_abapgit_news
RETURNING VALUE(ro_html) TYPE REF TO zcl_abapgit_html RETURNING
RAISING zcx_abapgit_exception. VALUE(ro_html) TYPE REF TO zcl_abapgit_html
RAISING
zcx_abapgit_exception .
CLASS-METHODS render_hotkey_overview CLASS-METHODS render_hotkey_overview
IMPORTING IMPORTING
io_page TYPE REF TO zcl_abapgit_gui_page !io_page TYPE REF TO zcl_abapgit_gui_page
RETURNING RETURNING
VALUE(ro_html) TYPE REF TO zcl_abapgit_html VALUE(ro_html) TYPE REF TO zcl_abapgit_html
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
CLASS-METHODS render_infopanel
IMPORTING
iv_div_id TYPE string
iv_title TYPE string
iv_hide TYPE abap_bool DEFAULT abap_true
iv_hint TYPE string OPTIONAL
iv_scrollable TYPE abap_bool DEFAULT abap_true
io_content TYPE REF TO zcl_abapgit_html
RETURNING
VALUE(ro_html) TYPE REF TO zcl_abapgit_html
RAISING
zcx_abapgit_exception.
CLASS-METHODS render_commit_popup CLASS-METHODS render_commit_popup
IMPORTING IMPORTING
iv_content TYPE csequence !iv_content TYPE csequence
iv_id TYPE csequence !iv_id TYPE csequence
RETURNING RETURNING
VALUE(ro_html) TYPE REF TO zcl_abapgit_html VALUE(ro_html) TYPE REF TO zcl_abapgit_html
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PROTECTED SECTION. PROTECTED SECTION.
PRIVATE SECTION. PRIVATE SECTION.
CLASS-METHODS render_branch_span
IMPORTING
!iv_branch TYPE string
!io_repo TYPE REF TO zcl_abapgit_repo_online
!iv_interactive TYPE abap_bool
RETURNING
VALUE(ro_html) TYPE REF TO zcl_abapgit_html
RAISING
zcx_abapgit_exception .
CLASS-METHODS render_infopanel
IMPORTING
!iv_div_id TYPE string
!iv_title TYPE string
!iv_hide TYPE abap_bool DEFAULT abap_true
!iv_hint TYPE string OPTIONAL
!iv_scrollable TYPE abap_bool DEFAULT abap_true
!io_content TYPE REF TO zcl_abapgit_html
RETURNING
VALUE(ro_html) TYPE REF TO zcl_abapgit_html
RAISING
zcx_abapgit_exception .
ENDCLASS. ENDCLASS.
CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION. CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION.
METHOD render_branch_span. METHOD render_branch_span.

29
src/ui/zcl_abapgit_html_action_utils.clas.abap
View File

@ -4,9 +4,6 @@ CLASS zcl_abapgit_html_action_utils DEFINITION
PUBLIC SECTION. PUBLIC SECTION.
CLASS-METHODS field_keys_to_upper
CHANGING
!ct_fields TYPE tihttpnvp .
CLASS-METHODS parse_fields CLASS-METHODS parse_fields
IMPORTING IMPORTING
!iv_string TYPE clike !iv_string TYPE clike
@ -17,12 +14,6 @@ CLASS zcl_abapgit_html_action_utils DEFINITION
!iv_string TYPE clike !iv_string TYPE clike
RETURNING RETURNING
VALUE(rt_fields) TYPE tihttpnvp . VALUE(rt_fields) TYPE tihttpnvp .
CLASS-METHODS add_field
IMPORTING
!iv_name TYPE string
!ig_field TYPE any
CHANGING
!ct_field TYPE tihttpnvp .
CLASS-METHODS get_field CLASS-METHODS get_field
IMPORTING IMPORTING
!iv_name TYPE string !iv_name TYPE string
@ -94,16 +85,28 @@ CLASS zcl_abapgit_html_action_utils DEFINITION
!ev_seed TYPE string !ev_seed TYPE string
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PROTECTED SECTION.
PRIVATE SECTION. PRIVATE SECTION.
CLASS-METHODS unescape
IMPORTING iv_string TYPE string
RETURNING VALUE(rv_string) TYPE string.
CLASS-METHODS field_keys_to_upper
CHANGING
!ct_fields TYPE tihttpnvp .
CLASS-METHODS add_field
IMPORTING
!iv_name TYPE string
!ig_field TYPE any
CHANGING
!ct_field TYPE tihttpnvp .
CLASS-METHODS unescape
IMPORTING
!iv_string TYPE string
RETURNING
VALUE(rv_string) TYPE string .
ENDCLASS. ENDCLASS.
CLASS zcl_abapgit_html_action_utils IMPLEMENTATION. CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION.
METHOD add_field. METHOD add_field.

26
src/ui/zcl_abapgit_html_action_utils.clas.testclasses.abap
View File

@ -4,7 +4,6 @@ CLASS ltcl_html_action_utils DEFINITION FOR TESTING RISK LEVEL HARMLESS
PUBLIC SECTION. PUBLIC SECTION.
CLASS-METHODS class_constructor. CLASS-METHODS class_constructor.
METHODS add_field FOR TESTING.
METHODS get_field FOR TESTING. METHODS get_field FOR TESTING.
METHODS parse_fields_simple_case FOR TESTING. METHODS parse_fields_simple_case FOR TESTING.
METHODS parse_fields_advanced_case FOR TESTING. METHODS parse_fields_advanced_case FOR TESTING.
@ -56,31 +55,6 @@ CLASS ltcl_html_action_utils IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD add_field.
DATA: lt_fields TYPE tihttpnvp,
lt_answer TYPE tihttpnvp,
ls_field LIKE LINE OF lt_fields.
ls_field-name = 'NAME'.
ls_field-value = 'TEST'.
APPEND ls_field TO lt_answer.
ls_field-name = 'VALUE'.
ls_field-value = 'TEST'.
APPEND ls_field TO lt_answer.
zcl_abapgit_html_action_utils=>add_field( EXPORTING iv_name = 'NAME' ig_field = 'TEST'
CHANGING ct_field = lt_fields ).
zcl_abapgit_html_action_utils=>add_field( EXPORTING iv_name = 'VALUE' ig_field = ls_field
CHANGING ct_field = lt_fields ).
cl_abap_unit_assert=>assert_equals(
act = lt_fields
exp = lt_answer ).
ENDMETHOD.
METHOD get_field. METHOD get_field.
DATA: lt_fields TYPE tihttpnvp, DATA: lt_fields TYPE tihttpnvp,

9
src/xml/zcl_abapgit_xml_output.clas.abap
View File

@ -18,9 +18,6 @@ CLASS zcl_abapgit_xml_output DEFINITION
IMPORTING IMPORTING
!iv_name TYPE clike !iv_name TYPE clike
!ii_xml TYPE REF TO if_ixml_element . !ii_xml TYPE REF TO if_ixml_element .
METHODS build_asx_node
RETURNING
VALUE(ri_element) TYPE REF TO if_ixml_element .
METHODS render METHODS render
IMPORTING IMPORTING
!iv_normalize TYPE abap_bool DEFAULT abap_true !iv_normalize TYPE abap_bool DEFAULT abap_true
@ -29,8 +26,12 @@ CLASS zcl_abapgit_xml_output DEFINITION
VALUE(rv_xml) TYPE string . VALUE(rv_xml) TYPE string .
PROTECTED SECTION. PROTECTED SECTION.
PRIVATE SECTION. PRIVATE SECTION.
DATA: mi_raw TYPE REF TO if_ixml_element.
DATA mi_raw TYPE REF TO if_ixml_element .
METHODS build_asx_node
RETURNING
VALUE(ri_element) TYPE REF TO if_ixml_element .
ENDCLASS. ENDCLASS.